createsend 3.1.0 → 3.1.1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    createsend (3.1.0)
+    createsend (3.1.1)
       hashie (>= 1.2, < 3)
       httparty (~> 0.10)
       json

data/HISTORY.md

@@ -1,6 +1,10 @@
 # createsend-ruby history
 
-## v3.1.0 - 28 Mar, 2013 (8a91dda)
+## v3.1.1 - 10 Apr, 2013
+
+* Fixed a bug occurring sometimes when refreshing OAuth access tokens, because of a URL encoding issue.
+
+## v3.1.0 - 28 Mar, 2013
 
 * Added `CreateSend::CreateSend.refresh_access_token` to allow easier refreshing of access tokens when using class methods.
 
@@ -21,7 +25,7 @@
 
 * Added `CreateSend::InvalidOAuthToken` and `CreateSend::RevokedOAuthToken` exceptions to make handling of OAuth exceptions in user code easier.
 
-## v3.0.0 - 25 Mar, 2013 (129ad0e)
+## v3.0.0 - 25 Mar, 2013
 
 * Added support for authenticating using OAuth. See the [README](README.md#authenticating) for full usage instructions.
 * Refactored authentication so that it is _always_ done at the instance level. This introduces some breaking changes, which are clearly explained below.
@@ -75,11 +79,11 @@
       sub = CreateSend::Subscriber.add auth, "list id", "dave@example.com", "Dave", [], true
       ```
 
-## v2.5.1 - 4 Feb, 2013   (f0a35ae)
+## v2.5.1 - 4 Feb, 2013
 
 * Updated dependencies in gemspec. Removed cane as a development dependency.
 
-## v2.5.0 - 11 Dec, 2012   (3054885)
+## v2.5.0 - 11 Dec, 2012
 
 * Added support for including from name, from email, and reply to email in drafts, scheduled, and sent campaigns.
 * Added support for campaign text version urls.
@@ -87,7 +91,7 @@
 * Added support for getting account billing details as well as client credits.
 * Made all date fields optional when getting paged results.
 
-## v2.4.0 - 5 Nov, 2012   (4277d8d9)
+## v2.4.0 - 5 Nov, 2012
 
 * Added CreateSend::Campaign#email_client_usage.
 * Added support for ReadsEmailWith field on subscriber objects.
@@ -102,24 +106,24 @@ fields.
 * Added documentation explaining that text_url may now be nil or an empty
 string when creating a campaign.
 
-## v2.3.0 - 10 Oct, 2012   (6639c1f6)
+## v2.3.0 - 10 Oct, 2012
 
 * Added support for creating campaigns from templates.
 * Added support for unsuppressing an email address.
 * Improved documentation and tests for getting active subscribers. Clearly
 documented the data structure for multi option multi select fields.
 
-## v2.2.0 - 17 Sep, 2012   (17409634)
+## v2.2.0 - 17 Sep, 2012
 
 * Added WorldviewURL field to campaign summary response.
 * Added Latitude, Longitude, City, Region, CountryCode, and CountryName fields
 to campaign opens and clicks response.
 
-## v2.1.0 - 30 Aug, 2012   (ee936259)
+## v2.1.0 - 30 Aug, 2012
 
 * Added support for basic / unlimited pricing.
 
-## v2.0.0 - 22 Aug, 2012   (8a5ab6b4)
+## v2.0.0 - 22 Aug, 2012
 
 * Added support for UnsubscribeSetting field when creating, updating and
 getting list details.
@@ -130,27 +134,27 @@ specific email address belongs.
 * Removed deprecated warnings and disallowed calls to be made in a deprecated
 manner.
 
-## v1.1.1 - 24 Jul, 2012   (72934e66)
+## v1.1.1 - 24 Jul, 2012
 
 * Added support for specifying whether subscription-based autoresponders
 should be restarted when adding or updating subscribers.
 
-## v1.1.0 - 11 Jul, 2012   (93e856b6)
+## v1.1.0 - 11 Jul, 2012
 
 * Added support for newly released team management functionality.
 
-## v1.0.4 - 4 May, 2012   (9bce25c1)
+## v1.0.4 - 4 May, 2012
 
 * Added Travis CI support.
 * Added Gemnasium support.
 * Fixes to usage of Shoulda and Hashie libraries.
 
-## v1.0.3 - 3 Dec, 2011   (1ed2b56a)
+## v1.0.3 - 3 Dec, 2011
 
 * Fixes to support Ruby 1.9.* (both the library as well as the rake tasks).
 * Fixed the User-Agent header so that it now uses the correct module VERSION.
 
-## v1.0.2 - 31 Oct, 2011   (83020409)
+## v1.0.2 - 31 Oct, 2011
 
 * Added support for deleting a subscriber.
 * Added support for specifying a 'clear' field when updating or importing
@@ -161,10 +165,10 @@ subscribers.
 * Added support for including more social sharing stats in campaign summary.
 * Added support for unscheduling a campaign.
 
-## v1.0.1 - 25 Oct, 2011   (347b2b95)
+## v1.0.1 - 25 Oct, 2011
 
 * Remove CreateSendOptions and remove usage of yaml config file.
 
-## v1.0.0 - 26 Sep, 2011   (0a078b09)
+## v1.0.0 - 26 Sep, 2011
 
 * Initial release which supports current Campaign Monitor API.

data/README.md

@@ -189,7 +189,7 @@ Error Code:    304
 Error Message: Campaign Subject Required
 ```
 
-### Expected input and output
+## Expected input and output
 The best way of finding out the expected input and output of a particular method in a particular class is to use the unit tests as a reference.
 
 For example, if you wanted to find out how to call the CreateSend::Subscriber.add method, you would look at the file test/subscriber_test.rb

data/lib/createsend/createsend.rb

@@ -77,7 +77,7 @@ module CreateSend
     # Returns a new access token, 'expires in' value, and refresh token.
     def self.refresh_access_token(refresh_token)
       options = {
-        :body => "grant_type=refresh_token&refresh_token=#{refresh_token}" }
+        :body => "grant_type=refresh_token&refresh_token=#{CGI.escape(refresh_token)}" }
       response = HTTParty.post(@@oauth_token_uri, options)
       if response.has_key? 'error' and response.has_key? 'error_description'
         err = "Error refreshing access token: "

data/lib/createsend/version.rb

@@ -1,3 +1,3 @@
 module CreateSend
-  VERSION = "3.1.0" unless defined?(CreateSend::VERSION)
+  VERSION = "3.1.1" unless defined?(CreateSend::VERSION)
 end

data/test/createsend_test.rb

@@ -73,23 +73,23 @@ class CreateSendTest < Test::Unit::TestCase
           Exception, 'Error exchanging code for access token: invalid_grant - Specified code was invalid or expired')
       FakeWeb.last_request.body.should == "grant_type=authorization_code&client_id=8998879&client_secret=iou0q9wud0q9wd0q9wid0q9iwd0q9wid0q9wdqwd&redirect_uri=http%3A%2F%2Fexample.com%2Fauth&code=invalidcode"
     end
-    
+
     should "refresh an access token given a refresh token" do
-      refresh_token = 'tGzv3JOkF0XG5Qx2TlKWIA'
+      refresh_token = 'ASP95S4aR+9KsgfHB0dapTYxNA=='
       options = {
         :body => fixture_file("refresh_oauth_token.json"),
         :content_type => "application/json; charset=utf-8" }
       FakeWeb.register_uri(:post, "https://api.createsend.com/oauth/token", options)
       new_access_token, new_expires_in, new_refresh_token = CreateSend::CreateSend.refresh_access_token refresh_token
 
-      FakeWeb.last_request.body.should == "grant_type=refresh_token&refresh_token=#{refresh_token}"
+      FakeWeb.last_request.body.should == "grant_type=refresh_token&refresh_token=#{CGI.escape(refresh_token)}"
       new_access_token.should == "SlAV32hkKG2e12e"
       new_expires_in.should == 1209600
       new_refresh_token.should == "tGzv3JOkF0XG5Qx2TlKWIA"
     end
 
     should "raise an error when an attempt to refresh an access token fails" do
-      refresh_token = 'invalidrefreshtoken'
+      refresh_token = 'ASP95S4aR+9KsgfHB0dapTYxNA=='
       options = {
         :body => fixture_file("oauth_refresh_token_error.json"),
         :content_type => "application/json; charset=utf-8" }
@@ -97,7 +97,7 @@ class CreateSendTest < Test::Unit::TestCase
       lambda { access_token, expires_in, refresh_token = CreateSend::CreateSend.refresh_access_token(
         refresh_token) }.should raise_error(
           Exception, 'Error refreshing access token: invalid_grant - Specified refresh_token was invalid or expired')
-      FakeWeb.last_request.body.should == "grant_type=refresh_token&refresh_token=#{refresh_token}"
+      FakeWeb.last_request.body.should == "grant_type=refresh_token&refresh_token=#{CGI.escape(refresh_token)}"
     end
 
     should "get a person's api key" do
@@ -117,8 +117,8 @@ class CreateSendTest < Test::Unit::TestCase
 
   context "when an api caller is authenticated using oauth" do
     setup do
-      @access_token = "h9898wu98u9dqjoijnwld"
-      @refresh_token = "tGzv3JOkF0XG5Qx2TlKWIA"
+      @access_token = "ASP95S4aR+9KsgfHB0dapTYxNA=="
+      @refresh_token = "5S4aASP9R+9KsgfHB0dapTYxNA=="
       @auth = {
         :access_token => @access_token,
         :refresh_token => @refresh_token
@@ -133,7 +133,7 @@ class CreateSendTest < Test::Unit::TestCase
       cs = CreateSend::CreateSend.new @auth
       new_access_token, new_expires_in, new_refresh_token = cs.refresh_token
 
-      FakeWeb.last_request.body.should == "grant_type=refresh_token&refresh_token=tGzv3JOkF0XG5Qx2TlKWIA"
+      FakeWeb.last_request.body.should == "grant_type=refresh_token&refresh_token=#{CGI.escape(@auth[:refresh_token])}"
       new_access_token.should == "SlAV32hkKG2e12e"
       new_expires_in.should == 1209600
       new_refresh_token.should == "tGzv3JOkF0XG5Qx2TlKWIA"
@@ -162,7 +162,7 @@ class CreateSendTest < Test::Unit::TestCase
     end
 
     should "raise an error when an attempt to refresh the access token is made but the refresh token is invalid" do
-      refresh_token = 'invalidrefreshtoken'
+      refresh_token = 'ASP95S4aR+9KsgfHB0dapTYxNA=='
       cs = CreateSend::CreateSend.new :access_token => 'any token', :refresh_token => refresh_token
       options = {
         :body => fixture_file("oauth_refresh_token_error.json"),

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: createsend
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-28 00:00:00.000000000 Z
+date: 2013-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -279,9 +279,6 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -935543352703407509
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: