cranium 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 95d417150867a455805bdc4b21372050ee81f8cc
-  data.tar.gz: 6a1ee615b84a1a6eefd83e4590d947e408fb1244
+  metadata.gz: b443b2b93e702139014a95256215bf7a8b22c1cc
+  data.tar.gz: 9c19653223b7958efe0ed35243a5308823c4849a
 SHA512:
-  metadata.gz: 6ee2e4a162601873d76cc96b1d88b02b4e6348019f04a899d68ba6c1723a9d1f678f51314bdc748e30357f7d04d8026330c1d428761c7c65506d46483bc45e3e
-  data.tar.gz: 114072465d737d6d8fd18ea884d7ed3c1f5b26bfc4dbdf3c2da2e6c6fb0994d5922b75502de2c0cbe75bb60042d3a1c90f788258403a580098175e9e7f108c23
+  metadata.gz: 6a722521a2a2b2a1f6843f3d80925f47fedbab6a84571ecc2d20d2fcd8483a410fec3832ff72b8673381f0d54b4b9edd367dda9847540cc744b3734c10509064
+  data.tar.gz: cb0caba449594c18c1d301991263af28d158431cee96e630af0665dd2e0eac7b4e8e26120404694ba6cae1386e297ee4eda40ab09c37adb4d3b5fda5ba4eb8fd

data/cranium.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |spec|
   spec.name = 'cranium'
-  spec.version = '0.3.0'
+  spec.version = '0.3.1'
   spec.authors = ['Emarsys Technologies']
   spec.email = ['smart-insight-dev@emarsys.com']
   spec.description = %q{Provides Extract, Transform and Load functionality for loading data from CSV files to a Greenplum database.}

data/lib/cranium.rb

@@ -14,6 +14,7 @@ module Cranium
   autoload :DSL, 'cranium/dsl'
   autoload :ExternalTable, 'cranium/external_table'
   autoload :Extract, 'cranium/extract'
+  autoload :FileUtils, 'cranium/file_utils'
   autoload :ImportStrategy, 'cranium/import_strategy'
   autoload :Logging, 'cranium/logging'
   autoload :ProgressOutput, 'cranium/progress_output'

data/lib/cranium/data_reader.rb

@@ -1,5 +1,4 @@
 require 'csv'
-require 'cranium/extensions/file'
 
 class Cranium::DataReader
 
@@ -21,7 +20,7 @@ class Cranium::DataReader
   private
 
   def read_input_file(input_file, read_block)
-    Cranium::ProgressOutput.show_progress File.basename(input_file), File.line_count(input_file) do |progress_bar|
+    Cranium::ProgressOutput.show_progress File.basename(input_file), Cranium::FileUtils.line_count(input_file) do |progress_bar|
       line_number = 0
       CSV.foreach input_file, csv_read_options_for(@source) do |row|
         next if 1 == (line_number += 1)

data/lib/cranium/data_transformer.rb

@@ -1,5 +1,4 @@
 require 'csv'
-require 'cranium/extensions/file'
 
 class Cranium::DataTransformer
 
@@ -30,7 +29,7 @@ class Cranium::DataTransformer
   private
 
   def transform_input_file(input_file, transformation_block)
-    Cranium::ProgressOutput.show_progress File.basename(input_file), File.line_count(input_file) do |progress_bar|
+    Cranium::ProgressOutput.show_progress File.basename(input_file), Cranium::FileUtils.line_count(input_file) do |progress_bar|
       line_number = 0
       CSV.foreach input_file, csv_read_options_for(@source) do |row|
         next if 1 == (line_number += 1)

data/lib/cranium/file_utils.rb

@@ -0,0 +1,7 @@
+module Cranium::FileUtils
+
+  def self.line_count(file_path)
+    File.read(file_path).each_line.count
+  end
+
+end

data/spec/cranium/file_utils_spec.rb

@@ -0,0 +1,33 @@
+require_relative '../spec_helper'
+
+describe Cranium::FileUtils do
+
+  describe '#line_count' do
+    let(:number_of_lines) { 3 }
+
+    it 'returns the number of lines the file has' do
+      path = '/tmp/3_lines.txt'
+      create_test_file path, number_of_lines
+
+      expect(described_class.line_count(path)).to eq(number_of_lines)
+      File.delete path
+    end
+
+    it 'handles () characters in path' do
+      path = '/tmp/such_copy_of_a_copy(2).txt'
+      create_test_file path, number_of_lines
+
+      expect { described_class.line_count(path) }.not_to raise_error
+      File.delete path
+    end
+  end
+
+
+
+  def create_test_file(path, number_of_lines)
+    File.open(path, 'w') do |file|
+      number_of_lines.times { |i| file.puts i }
+    end
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cranium
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Emarsys Technologies
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-27 00:00:00.000000000 Z
+date: 2016-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
@@ -213,7 +213,6 @@ files:
 - lib/cranium/dsl/extract_definition.rb
 - lib/cranium/dsl/import_definition.rb
 - lib/cranium/dsl/source_definition.rb
-- lib/cranium/extensions/file.rb
 - lib/cranium/extensions/sequel_greenplum.rb
 - lib/cranium/external_table.rb
 - lib/cranium/extract.rb
@@ -223,6 +222,7 @@ files:
 - lib/cranium/extract/strategy/base.rb
 - lib/cranium/extract/strategy/incremental.rb
 - lib/cranium/extract/strategy/simple.rb
+- lib/cranium/file_utils.rb
 - lib/cranium/import_strategy.rb
 - lib/cranium/import_strategy/base.rb
 - lib/cranium/import_strategy/delete_insert.rb
@@ -265,6 +265,7 @@ files:
 - spec/cranium/dsl_spec.rb
 - spec/cranium/external_table_spec.rb
 - spec/cranium/extract/storage_spec.rb
+- spec/cranium/file_utils_spec.rb
 - spec/cranium/logging_spec.rb
 - spec/cranium/sequel/hash_spec.rb
 - spec/cranium/source_registry_spec.rb
@@ -296,7 +297,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Pure Ruby ETL framework
@@ -350,6 +351,7 @@ test_files:
 - spec/cranium/dsl_spec.rb
 - spec/cranium/external_table_spec.rb
 - spec/cranium/extract/storage_spec.rb
+- spec/cranium/file_utils_spec.rb
 - spec/cranium/logging_spec.rb
 - spec/cranium/sequel/hash_spec.rb
 - spec/cranium/source_registry_spec.rb

data/lib/cranium/extensions/file.rb

@@ -1,7 +0,0 @@
-class File
-
-  def self.line_count(file_path)
-    (`wc -l #{file_path}`.match /^\s*(?<line_count>\d+).*/)["line_count"].to_i
-  end
-
-end