cqm-validators 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: eab81982007411f9a2ad3ed8defc9196514826b7
-  data.tar.gz: f347a12d4b75249da751a807982d2796f022fe4e
+SHA256:
+  metadata.gz: 4c8067796e458fb6576378bcfedadb762e75cfc3222e7b71288a1ac24f706087
+  data.tar.gz: 5ee8cfad30be91371fee0b0ebcd454d5c7bd5993d6ff96b3e565fd148039e5b8
 SHA512:
-  metadata.gz: b1d27039617962694f3a319c15cffa03519d12cf924953f70be84f17e4be010bd0fc6701bf53fc9c3a9701ca2143cbba4417a4f9b8bb788c9d05fa723c7038c5
-  data.tar.gz: 268e8ece14624f63778ed9fc2c27574b97bb9f752b7f01aae7817f3c858ea678b9d48984e8e92cbb23594f2f91d2ee96150fb5cfbab48cf6d5e1464ad4e8e443
+  metadata.gz: 0333e138838bda558b17d0612b5f270d9d549c908531e5e1792433941aaaa913c7d0d7754d09f60ca91df98cd355612418a68cb122a2d9440479d923fbff2989
+  data.tar.gz: 58deb72053f7e7e29e9c2174b21e7b603bbd5fffe954665add5899de6d0438b0b24d40c403b08735358bb10001585731230c4452d8a345295c19fab1bb49308c

data/.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.6
+  TargetRubyVersion: 2.5
   Exclude:
     - bin/*
 Documentation:
@@ -8,6 +8,14 @@ Documentation:
 Lint/RescueException:
   Exclude:
     - 'lib/schematron/java_processor.rb'
+Layout/LineLength:
+  Max: 150
+  Exclude:
+    - 'test/**/*'
+    # TODO: remove exclusions below this line as line length is fixed
+    - 'lib/reported_result_extractor.rb'
+    - 'lib/data_validator.rb'
+    - 'lib/measure_validator.rb'
 Metrics/AbcSize:
   # The ABC size is a calculated magnitude, so this number can be a Fixnum or
   # a Float.
@@ -25,14 +33,6 @@ Metrics/ClassLength:
     - 'test/**/*'
     # TODO: remove exclusions below this line as Class length is fixed
     - 'lib/qrda_qdm_template_validator.rb'
-Metrics/LineLength:
-  Max: 150
-  Exclude:
-    - 'test/**/*'
-    # TODO: remove exclusions below this line as line length is fixed
-    - 'lib/reported_result_extractor.rb'
-    - 'lib/data_validator.rb'
-    - 'lib/measure_validator.rb'
 Metrics/MethodLength:
   CountComments: false  # count full line comments?
   Max: 20
@@ -50,7 +50,9 @@ Metrics/CyclomaticComplexity:
   Max: 10
 Metrics/PerceivedComplexity:
   Max: 10
-Naming/UncommunicativeMethodParamName:
+  Exclude:
+    - 'lib/reported_result_extractor.rb'
+Naming/MethodParameterName:
   Enabled: false
 Style/DateTime:
   Enabled: false

data/.simplecov

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 SimpleCov.start do
   merge_timeout 3600
 end

data/.travis.yml

@@ -2,8 +2,6 @@ language: ruby
 rvm:
   - 2.6
   - 2.5
-  - 2.4
-  - 2.3
 cache:
   - bundler
 sudo: required

data/cqm_validators.gemspec

@@ -22,7 +22,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'nokogiri', '~>1.10.3'
+  spec.required_ruby_version = '>= 2.5.0'
+
+  spec.add_dependency 'nokogiri', '~>1.10'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'byebug'
@@ -30,6 +32,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest-reporters'
   spec.add_development_dependency 'mongoid'
   spec.add_development_dependency 'overcommit'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rubocop', '~> 0.60'
+  spec.add_development_dependency 'rake', '>= 12.3.3'
+  spec.add_development_dependency 'rubocop', '~> 0.93'
 end

data/lib/cqm_validators/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CqmValidators
-  VERSION = '2.0.1'
+  VERSION = '2.0.2'
 end

data/lib/measure_validator.rb

@@ -12,7 +12,7 @@ module CqmValidators
       @errors = []
       @doc = get_document(file)
       @doc.root.add_namespace_definition('cda', 'urn:hl7-org:v3')
-      measure_ids = CQM::Measure.all.map(&:hqmf_id)
+      measure_ids = CQM::Measure.pluck(:hqmf_id)
       doc_measure_ids = @doc.xpath(measure_selector).map(&:value).map(&:upcase)
       # list of all of the set ids in the QRDA
       doc_neutral_ids = @doc.xpath(neutral_measure_selector).map(&:value).map(&:upcase).sort

data/lib/performance_rate_validator.rb

@@ -52,13 +52,13 @@ module CqmValidators
       expected = calculate_performance_rates(reported_result)
       numer_id = population_set.populations.NUMER.hqmf_id
       if expected == 'NA' && reported_result['PR']['nullFlavor'] != 'NA'
-        return build_error("Reported Performance Rate for Numerator #{numer_id} should be NA", '/', data[:file_name])
-      elsif reported_result['PR']['nullFlavor'] == 'NA'
-        return build_error("Reported Performance Rate for Numerator #{numer_id} should not be NA", '/', data[:file_name])
-      elsif reported_result['PR']['value'].split('.', 2).last.size > 6
-        return build_error('Reported Performance Rate SHALL not have a precision greater than .000001 ', '/', data[:file_name])
-      elsif (reported_result['PR']['value'].to_f - expected.round(6)).abs > 0.0000001
-        return build_error("Reported Performance Rate of #{reported_result['PR']['value']} for Numerator #{numer_id} does not match expected"\
+        build_error("Reported Performance Rate for Numerator #{numer_id} should be NA", '/', data[:file_name])
+      elsif expected != 'NA' && reported_result['PR']['nullFlavor'] == 'NA'
+        build_error("Reported Performance Rate for Numerator #{numer_id} should not be NA", '/', data[:file_name])
+      elsif expected != 'NA' && reported_result['PR']['value'].split('.', 2).last.size > 6
+        build_error('Reported Performance Rate SHALL not have a precision greater than .000001 ', '/', data[:file_name])
+      elsif expected != 'NA' && (reported_result['PR']['value'].to_f - expected.round(6)).abs > 0.0000001
+        build_error("Reported Performance Rate of #{reported_result['PR']['value']} for Numerator #{numer_id} does not match expected"\
         " value of #{expected.round(6)}.", '/', data[:file_name])
       end
     end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: cqm-validators
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Laura
 - Michael O'Keefe
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2019-10-25 00:00:00.000000000 Z
+date: 2020-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.3
+        version: '1.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.3
+        version: '1.10'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -113,30 +113,30 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.60'
+        version: '0.93'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.60'
+        version: '0.93'
 description: new cqm validator library
 email:
 - laclark@mitre.org
@@ -216,7 +216,7 @@ homepage: https://github.com/projecttacoma/cqm-validators
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -224,16 +224,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: new cqm validator library
 test_files: []