cpsms 0.1.6 → 0.2.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: f80984c8b224ff0997097e44ea7aa61963e82283
+  data.tar.gz: 4b2a51bf2357919c144918fb035e010f62e6e88c
+SHA512:
+  metadata.gz: 011e544811883eaab3022e3a074bc1f2298e5f186124aa24383da71ea188467901d161c863a0bd563fee18727ad01eb8c82b07af8e73e62bfc1de11d4d74ecb2
+  data.tar.gz: a5006d9315a6414692d4723b6816c57f8e60fde0905ba486f18b3d2b6dc1e2edd5250bbb720a584036f64bb60aba33d1e776a1c4fffab15b0e93a859efe05818

data/.rubocop.yml

@@ -0,0 +1,5 @@
+Style/Documentation:
+  Enabled: false
+
+Metrics/LineLength:
+  Max: 100

data/Gemfile

@@ -1,3 +1,3 @@
-source :rubygems
+source 'https://rubygems.org'
 
 gemspec

data/Gemfile.lock

@@ -1,16 +1,17 @@
 PATH
   remote: .
   specs:
-    cpsms (0.1.5)
-      httparty (~> 0.10.2)
-      libxml-ruby (~> 2.6.0)
+    cpsms (0.2.0)
+      httparty (>= 0.10.2)
+      libxml-ruby (>= 2.6.0)
 
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
-    addressable (2.2.7)
+    addressable (2.3.6)
     ansi (1.4.2)
-    crack (0.3.1)
+    crack (0.4.2)
+      safe_yaml (~> 1.0.0)
     ffi (1.0.11)
     ffi (1.0.11-java)
     guard (0.10.0)
@@ -18,24 +19,25 @@ GEM
       thor (~> 0.14.6)
     guard-minitest (0.4.0)
       guard (~> 0.4)
-    httparty (0.10.2)
-      multi_json (~> 1.0)
+    httparty (0.13.3)
+      json (~> 1.8)
       multi_xml (>= 0.5.2)
-    libxml-ruby (2.6.0)
+    json (1.8.2)
+    libxml-ruby (2.8.0)
     metaclass (0.0.1)
     minitest (2.11.2)
     mocha (0.10.5)
       metaclass (~> 0.0.1)
-    multi_json (1.7.3)
-    multi_xml (0.5.3)
+    multi_xml (0.5.5)
     rake (0.9.2.2)
+    safe_yaml (1.0.4)
     thor (0.14.6)
     turn (0.9.3)
       ansi
-    vcr (2.0.0.rc1)
-    webmock (1.7.10)
-      addressable (~> 2.2, > 2.2.5)
-      crack (>= 0.1.7)
+    vcr (2.9.3)
+    webmock (1.20.4)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
 
 PLATFORMS
   java
@@ -48,5 +50,8 @@ DEPENDENCIES
   mocha (~> 0.10.5)
   rake (~> 0.9.2)
   turn (~> 0.9.3)
-  vcr (~> 2.0.0.rc1)
-  webmock (~> 1.7.10)
+  vcr (~> 2.9.3)
+  webmock (~> 1.20.4)
+
+BUNDLED WITH
+   1.11.2

data/Guardfile

@@ -1,5 +1,5 @@
 guard 'minitest' do
-  watch(%r|^spec/(.*)_spec\.rb|)
-  watch(%r|^lib/(.*)\.rb|)            { |m| "spec/lib/#{m[1]}_spec.rb" }
-  watch(%r|^spec/spec_helper\.rb|)    { "spec" }
+  watch(%r{^spec/(.*)_spec\.rb})
+  watch(%r{^lib/(.*)\.rb})            { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch(%r{^spec/spec_helper\.rb})    { 'spec' }
 end

data/README.md

@@ -1,11 +1,12 @@
+[![Gem Version](https://badge.fury.io/rb/cpsms.svg)](http://badge.fury.io/rb/cpsms)
+[![Build Status](https://circleci.com/gh/dipth/cpsms/tree/master.svg?style=shield)](https://circleci.com/gh/dipth/cpsms/tree/master)
+
 # CPSMS
 
 A wrapper for the cpsms.dk API.
 
 It will allow you to easily send SMS messages through the API from your Ruby applications.
 
-[![Build Status](https://secure.travis-ci.org/dipth/cpsms.png?branch=master)](http://travis-ci.org/dipth/cpsms)
-
 # Prerequisites
 
 To use the API you need to have an account on cpsms.dk

data/Rakefile

@@ -5,4 +5,4 @@ Rake::TestTask.new do |t|
   t.verbose = true
 end
 
-task :default => :test
+task default: :test

data/circle.yml

@@ -0,0 +1,11 @@
+dependencies:
+  override:
+    - rvm-exec 1.9.3 bundle install
+    - rvm-exec 2.1.2 bundle install
+    - rvm-exec 2.2.0 bundle install
+
+test:
+  override:
+    - rvm-exec 1.9.3 bundle exec rake
+    - rvm-exec 2.1.2 bundle exec rake
+    - rvm-exec 2.2.0 bundle exec rake

data/cpsms.gemspec

@@ -1,36 +1,38 @@
-# -*- encoding: utf-8 -*-
-$:.push File.expand_path("../lib", __FILE__)
-require "cpsms/version"
+# encoding: utf-8
+$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
+require 'cpsms/version'
 
 Gem::Specification.new do |s|
-  s.name        = "cpsms"
+  s.name        = 'cpsms'
   s.version     = CPSMS::VERSION
-  s.authors     = ["dipth"]
-  s.email       = ["thomas@dippel.dk"]
-  s.homepage    = "https://github.com/dipth/cpsms"
-  s.summary     = %q{Wrapper for the cpsms.dk API}
-  s.description = %q{Wrapper for the cpsms.dk API}
+  s.authors     = ['dipth']
+  s.email       = ['thomas@dippel.dk']
+  s.homepage    = 'https://github.com/dipth/cpsms'
+  s.summary     = 'Wrapper for the cpsms.dk API'
+  s.description = 'Wrapper for the cpsms.dk API'
 
-  s.rubyforge_project = "cpsms"
+  s.rubyforge_project = 'cpsms'
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
-  s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
+  s.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
+  s.require_paths = ['lib']
 
-  s.add_dependency('httparty',      '~> 0.10.2')
+  s.required_ruby_version = '>= 1.9.3'
+
+  s.add_dependency('httparty', '>= 0.10.2')
 
   case RUBY_PLATFORM
   when 'java'
-    s.add_dependency('libxml-jruby',  '~> 1.0.0')
-    s.add_dependency('jruby-openssl', '~> 0.7.6')
+    s.add_dependency('libxml-jruby',  '>= 1.0.0')
+    s.add_dependency('jruby-openssl', '>= 0.7.6')
   else
-    s.add_dependency('libxml-ruby',   '~> 2.6.0')
+    s.add_dependency('libxml-ruby',   '>= 2.6.0')
   end
 
   s.add_development_dependency('minitest',       '~> 2.11.2')
-  s.add_development_dependency('webmock',        '~> 1.7.10')
-  s.add_development_dependency('vcr',            '~> 2.0.0.rc1')
+  s.add_development_dependency('webmock',        '~> 1.20.4')
+  s.add_development_dependency('vcr',            '~> 2.9.3')
   s.add_development_dependency('turn',           '~> 0.9.3')
   s.add_development_dependency('rake',           '~> 0.9.2')
   s.add_development_dependency('guard-minitest', '~> 0.4.0')

data/lib/cpsms.rb

@@ -1,4 +1,4 @@
-require "httparty"
+require 'httparty'
 Dir[File.dirname(__FILE__) + '/cpsms/*.rb'].each do |file|
   require file
 end

data/lib/cpsms/sms.rb

@@ -2,34 +2,32 @@ module CPSMS
   require 'xml'
 
   class SMS
-
     include HTTParty
 
     base_uri 'https://www.cpsms.dk'
 
     def self.send!(username, password, recipient, message, options = {})
-      body = { :username => username,
-               :password => password,
-               :recipient => recipient,
-               :message => message }
+      body = { username: username,
+               password: password,
+               recipient: recipient,
+               message: message }
 
       body[:from] = options[:from] if options[:from]
       body[:utf8] = 1 if options[:utf8] == true
 
-      parse_response self.post('/sms/', :body => body).body
+      parse_response post('/sms/', body: body).body
     end
 
-  private
-
     def self.parse_response(response)
       xml = XML::Parser.string(response).parse
 
       error = xml.find_first('//error')
-      self.handle_errors(error.content) if error
+      handle_errors(error.content) if error
 
       success = xml.find_first('//succes') # cpsms.dk don't know how to spell
-      self.handle_success(success.content) if success
+      handle_success(success.content) if success
     end
+    private_class_method :parse_response
 
     def self.handle_errors(error)
       case error
@@ -37,6 +35,7 @@ module CPSMS
         raise InvalidCredentialsError
       end
     end
+    private_class_method :handle_errors
 
     def self.handle_success(success)
       case success
@@ -46,7 +45,7 @@ module CPSMS
         true
       end
     end
-
+    private_class_method :handle_success
   end
 
   class InvalidCredentialsError < StandardError; end

data/lib/cpsms/version.rb

@@ -1,3 +1,3 @@
 module CPSMS
-  VERSION = "0.1.6"
+  VERSION = '0.2.0'.freeze
 end

data/spec/lib/cpsms/sms_spec.rb

@@ -2,72 +2,70 @@ require(File.expand_path('./../../../spec_helper', __FILE__))
 require 'mocha'
 
 describe CPSMS::SMS do
-
   let(:username)  { ENV.fetch('CPSMS_USERNAME', 'fake-cpsms-username') }
   let(:password)  { ENV.fetch('CPSMS_PASSWORD', 'fake-cpsms-password') }
   let(:recipient) { ENV.fetch('CPSMS_MOBILE_NUMBER', 'fake-cpsms-mobile-number') }
 
-  describe "default attributes" do
-    it "must include httparty methods" do
+  describe 'default attributes' do
+    it 'must include httparty methods' do
       CPSMS::SMS.must_include HTTParty
     end
 
-    it "must have the base url set to the CPSMS API endpoint" do
+    it 'must have the base url set to the CPSMS API endpoint' do
       CPSMS::SMS.base_uri.must_equal 'https://www.cpsms.dk'
     end
   end
 
-  describe ".send!" do
+  describe '.send!' do
     before do
       VCR.insert_cassette 'sms',
-                          :record => :new_episodes,
-                          :match_requests_on => [:method, :body]
+                          record: :new_episodes,
+                          match_requests_on: [:method, :body]
     end
-    after  { VCR.eject_cassette }
+    after { VCR.eject_cassette }
 
-    it "must have a send! method" do
+    it 'must have a send! method' do
       CPSMS::SMS.must_respond_to :send!
     end
 
-    it "passes on the from option to the API" do
+    it 'passes on the from option to the API' do
       CPSMS::SMS.expects(:parse_response) { nil }
-      CPSMS::SMS.expects(:post).with() do |path, options|
-        options[:body][:from] == "foobar"
-      end.returns( stub(:body) )
-      CPSMS::SMS.send!(username, password, recipient, "test", { :from => "foobar" })
+      CPSMS::SMS.expects(:post).with do |_path, options|
+        options[:body][:from] == 'foobar'
+      end.returns(stub(:body))
+      CPSMS::SMS.send!(username, password, recipient, 'test', from: 'foobar')
     end
 
-    it "passes on the utf8 option to the API" do
+    it 'passes on the utf8 option to the API' do
       CPSMS::SMS.expects(:parse_response) { nil }
-      CPSMS::SMS.expects(:post).with() do |path, options|
+      CPSMS::SMS.expects(:post).with do |_path, options|
         options[:body][:utf8] == 1
-      end.returns( stub(:body) )
-      CPSMS::SMS.send!(username, password, recipient, "test", { :utf8 => true })
+      end.returns(stub(:body))
+      CPSMS::SMS.send!(username, password, recipient, 'test', utf8: true)
     end
 
-    describe "with invalid credentials" do
-      it "raises a CPSMS::InvalidCredentialsError" do
+    describe 'with invalid credentials' do
+      it 'raises a CPSMS::InvalidCredentialsError' do
         proc do
-          CPSMS::SMS.send!("wrong", "wrong", recipient, "test")
+          CPSMS::SMS.send!('wrong', 'wrong', recipient, 'test')
         end.must_raise CPSMS::InvalidCredentialsError
       end
     end
 
-    describe "with valid credentials" do
-      describe "and invalid recipient" do
-        it "raises a CPSMS::InvalidRecipientError" do
+    describe 'with valid credentials' do
+      describe 'and invalid recipient' do
+        it 'raises a CPSMS::InvalidRecipientError' do
           proc do
-            CPSMS::SMS.send!(username, password, 12345678, "test")
+            CPSMS::SMS.send!(username, password, 12_345_678, 'test')
           end.must_raise CPSMS::InvalidRecipientError
         end
       end
 
-      describe "and a valid recipient" do
-        it "returns true" do
-          CPSMS::SMS.send!(username, password, recipient, "test").must_equal true
+      describe 'and a valid recipient' do
+        it 'returns true' do
+          CPSMS::SMS.send!(username, password, recipient, 'test').must_equal true
         end
       end
     end
   end
-
 end

data/spec/spec_helper.rb

@@ -1,26 +1,32 @@
-#we need the actual library file
+# we need the actual library file
 require(File.expand_path('../../lib/cpsms', __FILE__))
 
-#dependencies
+# dependencies
 require 'minitest/autorun'
 require 'webmock/minitest'
 require 'vcr'
 require 'turn'
 
 Turn.config do |c|
- # :outline  - turn's original case/test outline mode [default]
- c.format  = :outline
- # use humanized test names (works only with :outline format)
- c.natural = true
+  # :outline  - turn's original case/test outline mode [default]
+  c.format = :outline
+  # use humanized test names (works only with :outline format)
+  c.natural = true
 end
 
-#VCR config
+# VCR config
 VCR.configure do |c|
   c.cassette_library_dir = 'spec/fixtures/cpsms_cassettes'
-  c.stub_with :webmock
-  c.filter_sensitive_data('username=<USERNAME>')       { "username=#{ ENV.fetch('CPSMS_USERNAME', 'fake-cpsms-username') }" }
-  c.filter_sensitive_data('password=<PASSWORD>')       { "password=#{ ENV.fetch('CPSMS_PASSWORD', 'fake-cpsms-password') }" }
-  c.filter_sensitive_data('recipient=<MOBILE_NUMBER>') { "recipient=#{ ENV.fetch('CPSMS_MOBILE_NUMBER', 'fake-cpsms-mobile-number') }" }
+  c.hook_into :webmock
+  c.filter_sensitive_data('username=<USERNAME>') do
+    "username=#{ENV.fetch('CPSMS_USERNAME', 'fake-cpsms-username')}"
+  end
+  c.filter_sensitive_data('password=<PASSWORD>') do
+    "password=#{ENV.fetch('CPSMS_PASSWORD', 'fake-cpsms-password')}"
+  end
+  c.filter_sensitive_data('recipient=<MOBILE_NUMBER>') do
+    "recipient=#{ENV.fetch('CPSMS_MOBILE_NUMBER', 'fake-cpsms-mobile-number')}"
+  end
 
   # Since HTTParty takes a Hash of body data, we can never be sure that it is
   # sent in the same order. This can cause VCR to not recognise the request and

metadata

@@ -1,158 +1,139 @@
 --- !ruby/object:Gem::Specification
 name: cpsms
 version: !ruby/object:Gem::Version
-  version: 0.1.6
-  prerelease: 
+  version: 0.2.0
 platform: ruby
 authors:
 - dipth
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-23 00:00:00.000000000 Z
+date: 2016-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.10.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.10.2
 - !ruby/object:Gem::Dependency
   name: libxml-ruby
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.6.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.11.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 2.11.2
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.10
+        version: 1.20.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.7.10
+        version: 1.20.4
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0.rc1
+        version: 2.9.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0.rc1
+        version: 2.9.3
 - !ruby/object:Gem::Dependency
   name: turn
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.2
 - !ruby/object:Gem::Dependency
   name: guard-minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: mocha
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.10.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.10.5
 description: Wrapper for the cpsms.dk API
@@ -162,14 +143,15 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rvmrc_example
-- .travis.yml
+- ".gitignore"
+- ".rubocop.yml"
+- ".rvmrc_example"
 - Gemfile
 - Gemfile.lock
 - Guardfile
 - README.md
 - Rakefile
+- circle.yml
 - cpsms.gemspec
 - lib/cpsms.rb
 - lib/cpsms/sms.rb
@@ -179,27 +161,26 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/dipth/cpsms
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: cpsms
-rubygems_version: 1.8.23
+rubygems_version: 2.2.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Wrapper for the cpsms.dk API
 test_files:
 - spec/fixtures/cpsms_cassettes/sms.yml

data/.travis.yml

@@ -1,8 +0,0 @@
-language: ruby
-rvm:
-  - 1.8.7
-  - 1.9.2
-  - 1.9.3
-  - jruby-18mode # JRuby in 1.8 mode
-  - jruby-19mode # JRuby in 1.9 mode
-  - rbx-18mode