coverband 6.1.8 → 6.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '01680ffc24d42fce1b45f90fff31a9d190b029af8a83b0a1405ed81d2785bc10'
-  data.tar.gz: 04daf91b9d7f64849d217075e71ff00d54cac2e64fd1b5c7fdd7e0b27943b56e
+  metadata.gz: 12802541de3827dd777fba9962270fd2f0a6c7b3debb2ef96c4bcca32f02b48d
+  data.tar.gz: 36fa21009ed2ada842ff90ca4a18195c8bfcddc81ad0951c11f613ede11f6606
 SHA512:
-  metadata.gz: 0de107048e072e97c1bded932a59ac9b6be2c6ac94b045118977aae38282a109772b183bed1b7ca99d7867d3fc694f326a53e2e93174bbf372e7f0ba16e8bd13
-  data.tar.gz: 57d8e1921056acb7f13e47b02caeb6207e635984a461c1952aafd0dbf4e445519d99ca8b369b60d11c3121b86da6f5f3d3d2a4e6aaf6d68fd2d3a8aa155d14fb
+  metadata.gz: 03c7e496735cfe705b926b30140b3d704993b0599e470d290fb9ae672a7b204bf5cfa98adfc73d54eb70df1c71e8cbb9d91a5f85862b86d5c2a1ba1d0d3aa704
+  data.tar.gz: 6610a4ec327a69de3bd6878cb256a8f9d605fcf2a4104e6699b6b68acbec3ac9aaaeb957569eaf9ac1e949c58c5a6adbcd75055be464da56a11dde5c873dc4b6

data/README.md

@@ -1,9 +1,9 @@
-<img src="https://raw.github.com/danmayer/coverband/master/docs/assets/logo/heads.svg?sanitize=true" width='300'>
+<img src="https://raw.github.com/danmayer/coverband/main/docs/assets/logo/heads.svg?sanitize=true" width='300'>
 
 # Coverband
 
 [![GithubCI](https://github.com/danmayer/coverband/workflows/CI/badge.svg)](https://github.com/danmayer/coverband/actions)
-[![Coverage Status](https://coveralls.io/repos/github/danmayer/coverband/badge.svg?branch=master)](https://coveralls.io/github/danmayer/coverband?branch=master)
+[![Coverage Status](https://coveralls.io/repos/github/danmayer/coverband/badge.svg?branch=main)](https://coveralls.io/github/danmayer/coverband?branch=main)
 [![Maintainability](https://api.codeclimate.com/v1/badges/1e6682f9540d75f26da7/maintainability)](https://codeclimate.com/github/danmayer/coverband/maintainability)
 [![Discord Shield](https://img.shields.io/discord/609509533999562753)](https://discord.gg/KAH38EV)
 
@@ -57,7 +57,7 @@ gem 'coverband'
 
 With older versions of Coverband, projects would report to redis using rack or sidekiq middleware. After Coverband 4.0, this should no longer be required and could cause performance issues. Reporting to redis is now automatically done within a background thread with no custom code needed.
 
-See [changelog](https://github.com/danmayer/coverband/blob/master/changes.md).
+See [changelog](https://github.com/danmayer/coverband/blob/main/changes.md).
 
 ## Rails
 
@@ -77,10 +77,12 @@ run ActionController::Dispatcher.new
 
 ## Coverband Web UI
 
-![image](https://raw.github.com/danmayer/coverband/master/docs/coverband_web_ui.png)
+![image](https://raw.github.com/danmayer/coverband/main/docs/coverband_web_ui.png)
 
 > You can check it out locally by running the [Coverband Demo App](https://github.com/danmayer/coverband_rails_example).
 
+- View a shared demo at [https://coverband-rails-example.onrender.com/](https://coverband-rails-example.onrender.com/)
+
 - View overall coverage information
 
 - Drill into individual file coverage
@@ -208,7 +210,7 @@ Take Coverband for a spin on the live Heroku deployed [Coverband Demo](https://c
 
 If you need to configure Coverband, this can be done by creating a `config/coverband.rb` file relative to your project root.
 
-- See [lib/coverband/configuration.rb](https://github.com/danmayer/coverband/blob/master/lib/coverband/configuration.rb) for all options
+- See [lib/coverband/configuration.rb](https://github.com/danmayer/coverband/blob/main/lib/coverband/configuration.rb) for all options
 - By default Coverband will try to store data to Redis \* Redis endpoint is looked for in this order: `ENV['COVERBAND_REDIS_URL']`, `ENV['REDIS_URL']`, or `localhost`
 
 Below is an example config file for a Rails 5 app:
@@ -269,7 +271,7 @@ This feature is enabled by default. To stop this feature, disable the feature in
 
 `config.track_views = false`
 
-![image](https://raw.github.com/danmayer/coverband/master/docs/coverband_view_tracker.png)
+![image](https://raw.github.com/danmayer/coverband/main/docs/coverband_view_tracker.png)
 
 ### Hiding settings
 

data/changes.md

@@ -1,3 +1,10 @@
+### 6.2.0
+
+* Fix: Correct `Rack::Static` URL handling in the web reporter by using an empty string URL prefix; thanks @alpaca-tc (#635)
+* Fix: Skip missing files during dead method scans to avoid errors in dynamic or removed-file environments; thanks @doug-hall (#632)
+* Fix: Improve MCP dead method formatting for clearer tool output; thanks @doug-hall (#633)
+* Docs: README updates (including `master` → `main` wording updates); thanks @jjb (#627)
+
 ### 6.1.8
 
 * Feature: Added temporal data to GetFileCoverage tool for MCP by @fabienpiette (#626)

data/lib/coverband/mcp/tools/get_dead_methods.rb

@@ -28,21 +28,21 @@ module Coverband
 
           if file_pattern
             dead_methods = dead_methods.select do |method|
-              File.fnmatch(file_pattern, method[:file_path], File::FNM_PATHNAME)
+              File.fnmatch(file_pattern, method.file_path, File::FNM_PATHNAME)
             end
           end
 
           # Group by file for easier reading
-          grouped = dead_methods.group_by { |m| m[:file_path] }
+          grouped = dead_methods.group_by(&:file_path)
 
           result = grouped.map do |file_path, methods|
             {
               file: file_path,
               dead_methods: methods.map do |m|
                 {
-                  class_name: m[:class_name],
-                  method_name: m[:method_name],
-                  line_number: m[:line_number]
+                  class_name: m.class_name,
+                  method_name: m.name,
+                  line_number: m.first_line_number
                 }
               end
             }

data/lib/coverband/reporters/web.rb

@@ -32,9 +32,9 @@ module Coverband
 
       def init_web
         full_path = Gem::Specification.find_by_name("coverband").full_gem_path
-        @static = Rack::Static.new(self,
-          root: File.expand_path("public", full_path),
-          urls: [/.*\.css/, /.*\.js/, /.*\.gif/, /.*\.png/])
+        @file_server = Rack::Files.new(
+          File.expand_path("public", full_path)
+        )
       end
 
       def check_auth
@@ -85,7 +85,7 @@ module Coverband
           else
             case request_path_info
             when /.*\.(css|js|gif|png)/
-              @static.call(env)
+              @file_server.get(env)
             when %r{/settings}
               [200, coverband_headers, [settings]]
             when %r{/view_tracker_data}

data/lib/coverband/utils/dead_methods.rb

@@ -43,7 +43,11 @@ module Coverband
         # and runtime phases.
         coverage = Coverband.configuration.store.get_coverage_report[Coverband::MERGED_TYPE]
         coverage.flat_map do |file_path, coverage|
+          next [] unless File.exist?(file_path)
+
           scan(file_path: file_path, coverage: coverage["data"])
+        rescue Errno::ENOENT
+          []
         end
       end
 

data/lib/coverband/version.rb

@@ -5,5 +5,5 @@
 # use format "4.2.1.rc.1" ~> 4.2.1.rc to prerelease versions like v4.2.1.rc.2 and v4.2.1.rc.3
 ###
 module Coverband
-  VERSION = "6.1.8"
+  VERSION = "6.2.0"
 end

data/test/coverband/mcp/tools/get_dead_methods_test.rb

@@ -10,6 +10,16 @@ end
 
 if defined?(Coverband::MCP)
   class GetDeadMethodsTest < Minitest::Test
+    def build_dead_method(file_path:, class_name:, method_name:, line_number:)
+      Coverband::Utils::MethodDefinitionScanner::MethodDefinition.new(
+        first_line_number: line_number,
+        last_line_number: line_number,
+        name: method_name,
+        class_name: class_name,
+        file_path: file_path
+      )
+    end
+
     def setup
       super
       Coverband.configure do |config|
@@ -35,24 +45,24 @@ if defined?(Coverband::MCP)
     if defined?(RubyVM::AbstractSyntaxTree)
       test "call returns dead methods when AST support available" do
         mock_dead_methods = [
-          {
+          build_dead_method(
             file_path: "/app/models/user.rb",
             class_name: "User",
             method_name: "unused_method",
             line_number: 10
-          },
-          {
+          ),
+          build_dead_method(
             file_path: "/app/models/user.rb",
             class_name: "User",
             method_name: "another_unused",
             line_number: 15
-          },
-          {
+          ),
+          build_dead_method(
             file_path: "/app/models/order.rb",
             class_name: "Order",
             method_name: "dead_method",
             line_number: 20
-          }
+          )
         ]
 
         Coverband::Utils::DeadMethods.expects(:scan_all).returns(mock_dead_methods)
@@ -83,18 +93,18 @@ if defined?(Coverband::MCP)
 
       test "call filters by file_pattern when provided" do
         mock_dead_methods = [
-          {
+          build_dead_method(
             file_path: "/app/models/user.rb",
             class_name: "User",
             method_name: "unused_method",
             line_number: 10
-          },
-          {
+          ),
+          build_dead_method(
             file_path: "/app/helpers/user_helper.rb",
             class_name: "UserHelper",
             method_name: "dead_helper",
             line_number: 5
-          }
+          )
         ]
 
         Coverband::Utils::DeadMethods.expects(:scan_all).returns(mock_dead_methods)

data/test/coverband/reporters/web_test.rb

@@ -45,6 +45,16 @@ module Coverband
       get "/json?line_coverage=true"
       assert last_response.ok?
     end
+
+    test "renders static files" do
+      get "/application.js"
+      assert last_response.ok?
+    end
+
+    test "renders 404 if static file doesn't exist" do
+      get "/unknown.js"
+      assert last_response.not_found?
+    end
   end
 end
 

data/test/coverband/utils/dead_methods_test.rb

@@ -48,6 +48,26 @@ if defined?(RubyVM::AbstractSyntaxTree)
           assert_equal(6, dead_method.last_line_number)
         end
 
+        def test_scan_all_skips_missing_files
+          missing_file = "./test/fixtures/missing_file.rb"
+          existing_file = "./test/dog.rb"
+          coverage_report = {
+            Coverband::MERGED_TYPE => {
+              missing_file => {"data" => []},
+              existing_file => {"data" => []}
+            }
+          }
+          dead_method = Object.new
+
+          Coverband.configuration.stubs(:store).returns(
+            stub(get_coverage_report: coverage_report)
+          )
+          DeadMethods.expects(:scan).with(file_path: existing_file, coverage: []).returns([dead_method])
+          DeadMethods.expects(:scan).with(file_path: missing_file, coverage: []).never
+
+          assert_equal [dead_method], DeadMethods.scan_all
+        end
+
         def test_output_all
           require_unique_file
           @coverband.report_coverage

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 6.1.8
+  version: 6.2.0
 platform: ruby
 authors:
 - Dan Mayer