coverband 5.0.3 → 5.1.0.rcmailer.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bbff118005d968f8d2158135273f108cbb9b867c9c13d783b5fb8a2220dd5540
-  data.tar.gz: bc7ec947e707d4feaf213a0559f110ae5d11a487ea370f5e9f6a1256c2799701
+  metadata.gz: ec5d51bc8a16c6d59cb6a04ae43ffd0f242677038851c7f44fe0f2720d1686c8
+  data.tar.gz: 608b0442f7993d8e18c686c49037521dbe96325f2f240bb11a542229e3a0bbb8
 SHA512:
-  metadata.gz: af026a80339c3047c62c99c6ec47385288fc7a0fd1d295b646abffdd4b74ea48118f01b2caa2ef997d7dc8775ebc047ce9844189065148f82eaea10fb2bf2978
-  data.tar.gz: a4555a8209507c66efc7ba2432bb5b743cc45331fead66f038df9823a85e8a1bbf9401cd9b47a450cfd184ff399d429e193527df6745ec1770b0b0e08a863141
+  metadata.gz: 9d88524814527a2df8c30d7e15005d3cbab174612fdc841035e46bef0847bd352450357c64a64945e8ed72935c0f288746e1f90773397836ed74fdce5c7f0f83
+  data.tar.gz: d56b0c8f50e6d985b5eecac8051e2516359698c41b70f230d21256b73faab0392097ad5b1ece4cfad685251e5a816fa52db0bdcdbc5fbc71640c94686f6ef141

data/.github/ISSUE_TEMPLATE/bug_report.md

@@ -0,0 +1,38 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Click on '....'
+3. Scroll down to '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Desktop (please complete the following information):**
+ - OS: [e.g. iOS]
+ - Browser [e.g. chrome, safari]
+ - Version [e.g. 22]
+
+**Smartphone (please complete the following information):**
+ - Device: [e.g. iPhone6]
+ - OS: [e.g. iOS8.1]
+ - Browser [e.g. stock browser, safari]
+ - Version [e.g. 22]
+
+**Additional context**
+Add any other context about the problem here.

data/.github/ISSUE_TEMPLATE/feature_request.md

@@ -0,0 +1,20 @@
+---
+name: Feature request
+about: Suggest an idea for this project
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

data/.github/workflows/main.yml

@@ -0,0 +1,30 @@
+name: CI
+# Controls when the action will run.
+on:
+  # Triggers the workflow on push or pull request events but only for the master branch
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+jobs:
+  test:
+    strategy:
+      fail-fast: false
+      matrix:
+        # need to figure out how to use redis on macos github actions
+        # os: [ubuntu, macos]
+        os: [ubuntu]
+        # remove until I sort out CI issues for truffle
+        # truffleruby,
+        # truffleruby-head,
+        ruby: [2.3, 2.4, 2.5, 2.6, 2.7, jruby, jruby-head]
+        redis-version: [5]
+    runs-on: ${{ matrix.os }}-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: supercharge/redis-github-action@1.1.0
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - run: bundle exec rake

data/CONTRIBUTING.md

@@ -0,0 +1 @@
+See our [code of conduct](https://github.com/danmayer/coverband/blob/master/CODE_OF_CONDUCT.md)

data/README.md

@@ -2,7 +2,7 @@
 
 # Coverband
 
-[![Build Status](https://travis-ci.org/danmayer/coverband.svg?branch=master)](https://travis-ci.org/danmayer/coverband)
+[![GithubCI](https://github.com/danmayer/coverband/workflows/CI/badge.svg)](https://github.com/danmayer/coverband/actions)
 [![Coverage Status](https://coveralls.io/repos/github/danmayer/coverband/badge.svg?branch=master)](https://coveralls.io/github/danmayer/coverband?branch=master)
 [![Maintainability](https://api.codeclimate.com/v1/badges/1e6682f9540d75f26da7/maintainability)](https://codeclimate.com/github/danmayer/coverband/maintainability)
 [![Discord Shield](https://img.shields.io/discord/609509533999562753)](https://discord.gg/KAH38EV)
@@ -65,7 +65,7 @@ The Railtie integration means you shouldn't need to do anything else other than
 
 ## Sinatra
 
-For the best coverage you want this loaded as early as possible. We recommend requiring cover band directly in the `config.ru`.  Requiring coverband within an initializer could also work, but you may end up missing some boot up coverage. To start collection require Coverband as early as possible.
+For the best coverage you want this loaded as early as possible. We recommend requiring cover band directly in the `config.ru`. Requiring coverband within an initializer could also work, but you may end up missing some boot up coverage. To start collection require Coverband as early as possible.
 
 ```ruby
 require 'coverband'
@@ -91,7 +91,7 @@ run ActionController::Dispatcher.new
 
   - Clear coverage report
 
-    This will clear the coverage data. This wipes out all collected data. 
+    This will clear the coverage data. This wipes out all collected data.
 
   - Clear individual file coverage
 
@@ -304,6 +304,8 @@ rake coverband:coverage      # report runtime coverband code coverage
 
 Coverband starts on require of the the library which is usually done within the Gemfile. This can be disabled by setting the `COVERBAND_DISABLE_AUTO_START` environment variable. This environment variable can be useful to toggle coverband on and off in certain environments.
 
+**NOTE:** That any value set for `COVERBAND_DISABLE_AUTO_START` is considered true, it does not match the string content but only checks the presence of the ENV variable.
+
 In order to start coverband manually yourself when this flag is enabled, call `Coverband.configure` followed by `Coverband.start`.
 
 ```ruby
@@ -333,7 +335,7 @@ If you currently have require: false, remove the 'coverband' string from the req
 gem 'coverband', require: ['alternative_coverband_patch']
 ```
 
-This conflict happens when a ruby method is patched twice, once using module prepend, and once using method aliasing. See this ruby issue for details. The fix is to apply all patches the same way. Coverband by default will apply its patch using prepend, but you can change that to  method aliasing by adding require: ['alternative_coverband_patch'] to the gem line as shown above.
+This conflict happens when a ruby method is patched twice, once using module prepend, and once using method aliasing. See this ruby issue for details. The fix is to apply all patches the same way. Coverband by default will apply its patch using prepend, but you can change that to method aliasing by adding require: ['alternative_coverband_patch'] to the gem line as shown above.
 
 # Prerequisites
 
@@ -385,7 +387,6 @@ If you submit a change please make sure the tests and benchmarks are passing.
 - **total fail** on front end code, for line for line coverage, because of the precompiled template step basically coverage doesn't work well for `erb`, `slim`, and the like.
   - related it will try to report something, but the line numbers reported for `ERB` files are often off and aren't considered useful. I recommend filtering out .erb using the `config.ignore` option. The default configuration excludes these files
   - **NOTE:** We now have file level coverage for view files, but don't support line level detail
-  - The view file detection doesn't workf or mailers at the moment only for web related views / JSON templates. This is due to how Rails active mailer notifications work.
 - **Coverage does NOT work when used alongside Scout APM Auto Instrumentation**
   - In an environment that uses Scout's `AUTO_INSTRUMENT=true` (usually production or staging) it stops reporting any coverage, it will show one or two files that have been loaded at the start but everything else will show up as having 0% coverage
   - Bug tracked here: https://github.com/scoutapp/scout_apm_ruby/issues/343

data/lib/coverband/collectors/view_tracker.rb

@@ -23,7 +23,7 @@ module Coverband
         @ignore_patterns = Coverband.configuration.ignore
         @store = options.fetch(:store) { Coverband.configuration.store }
         @logger = options.fetch(:logger) { Coverband.configuration.logger }
-        @target = options.fetch(:target) { Dir.glob("#{@project_directory}/app/views/**/*.html.{erb,haml,slim}").reject { |file| file.match(/(_mailer)/) }.freeze }
+        @target = options.fetch(:target) { Dir.glob("#{@project_directory}/app/views/**/*.html.{erb,haml,slim}") }
 
         @roots = options.fetch(:roots) { Coverband.configuration.all_root_patterns }
         @roots = @roots.split(",") if @roots.is_a?(String)

data/lib/coverband/version.rb

@@ -5,5 +5,5 @@
 # use format '4.2.1.rc.1' ~> 4.2.1.rc to prerelease versions like v4.2.1.rc.2 and v4.2.1.rc.3
 ###
 module Coverband
-  VERSION = "5.0.3"
+  VERSION = "5.1.0.rcmailer.1"
 end

data/test/coverband/collectors/view_tracker_test.rb

@@ -42,6 +42,16 @@ class ReporterTest < Minitest::Test
     assert_equal [file_path], tracker.used_views.keys
   end
 
+  test "track partials that include the word _mailer in the path" do
+    Coverband::Collectors::ViewTracker.expects(:supported_version?).returns(true)
+    store = fake_store
+    file_path = "#{File.expand_path(Coverband.configuration.root)}/_mailer/file"
+    tracker = Coverband::Collectors::ViewTracker.new(store: store, roots: "dir")
+    tracker.track_views("name", "start", "finish", "id", identifier: file_path)
+    tracker.report_views_tracked
+    assert_equal [file_path], tracker.used_views.keys
+  end
+
   test "ignore partials that include the folder vendor in the path" do
     Coverband::Collectors::ViewTracker.expects(:supported_version?).returns(true)
     store = fake_store

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 5.0.3
+  version: 5.1.0.rcmailer.1
 platform: ruby
 authors:
 - Dan Mayer
 - Karl Baum
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-10-09 00:00:00.000000000 Z
+date: 2020-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: benchmark-ips
@@ -270,11 +270,14 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/ISSUE_TEMPLATE/bug_report.md"
+- ".github/ISSUE_TEMPLATE/feature_request.md"
+- ".github/workflows/main.yml"
 - ".gitignore"
 - ".jrubyrc"
 - ".standard.yml"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
+- CONTRIBUTING.md
 - Gemfile
 - Gemfile.rails4
 - Gemfile.rails6
@@ -465,7 +468,7 @@ homepage: https://github.com/danmayer/coverband
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -476,12 +479,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Rack middleware to measure production code usage (LOC runtime usage)
 test_files:

data/.travis.yml

@@ -1,48 +0,0 @@
-language: ruby
-rvm:
-  - "2.3"
-  - "2.4"
-  - "2.5"
-  - "2.6.1"
-  - "2.7"
-  - jruby-9.2.6.0
-gemfile:
-  - Gemfile
-  - Gemfile.rails4
-  - Gemfile.rails6
-env:
-  global:
-    # --dev improves JRuby startup time
-    # See https://github.com/jruby/jruby/wiki/Improving-startup-time
-    - JRUBY_OPTS="--dev"
-    - JAVA_OPTS="--add-opens java.base/{java.security.cert=ALL-UNNAMED --add-opens java.base/java.security=ALL-UNNAMED --add-opens java.base/java.util.zip=ALL-UNNAMED"
-
-jobs:
-  exclude:
-    - rvm: "2.3"
-      gemfile: Gemfile.rails6
-    - rvm: "2.4"
-      gemfile: Gemfile.rails6
-    - rvm: "2.7"
-      gemfile: Gemfile.rails4
-    - rvm: jruby-9.2.6.0
-      gemfile: Gemfile.rails4
-
-cache:
-  bundler: true
-  directories:
-    - $HOME/lua51
-services:
-  - redis-server
-script:
-  - sudo ./lua/install.sh
-  - $HOME/lua51/bin/busted lua/test/*
-  - bundle exec standardrb
-  - COVERBAND_HASH_REDIS_STORE=t bundle exec rake
-  - COVERBAND_HASH_REDIS_STORE=t bundle exec rake forked_tests
-  - bundle exec rake
-  - bundle exec rake forked_tests
-  # remove this for now as it is flaky
-  # passes locally on 2.3.5 on travis passes sometimes on 2.4 and always on 2.6.1
-  #- bundle exec rake benchmarks:memory
-  - bundle exec rake benchmarks