coverband 4.2.6 → 4.2.7.rc.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7095ca0ee73eff7b4290c508df1c6c6961ed1283ce2edcca085cf3f05e12bb9d
-  data.tar.gz: e0fc00dc886a0153b3c6887680a86ffee9e13666e5dce3bbe7bc551b249d5734
+  metadata.gz: 68ea5d4222b92fe692d530b929c52d6da5b1c01d710f06bf92d53ea5515e6cba
+  data.tar.gz: 29eb1a2764bd507c7da2376e8566270f581f16ff22d79cb645a5075f59ccdda0
 SHA512:
-  metadata.gz: 4df21534042791528184de6f65548e48ac4a8d06905c815977376b6d3f815eaf121d5117d2e4af4c53b3a46a8122fc32ea3a9c2a1072219d76231f3acf8c530a
-  data.tar.gz: 64f75a91aafb5fd7fa945bde6bbe8b9262f79f90faaa17108743ab480bc3a369a3471225d616144024ca7db0010db219806894ace62dea3cb25941396532a535
+  metadata.gz: '07931a21e9b83879d81936059173ea3c5c64671d2fafddefa7d0cee8aca02b319352a6ea3cf8786322977581a37a52be95775091bab9367265d4d82502ad5fcf'
+  data.tar.gz: 9d77db00ad0f025b620969840747b7c3774d636ea23c0caf47789a06c1e2c72762a5a2aee53c73c4602840504eacd1d47f6261938b652ef7ed055882cf463869

data/README.md

@@ -381,6 +381,22 @@ Note: To debug issues getting Coverband working. I recommend running in developm
 
 If you are trying to debug locally wondering what code is being run during a request. The verbose modes `config.verbose = true` && `Rails.logger.level = :debug`. With true set it will output the number of lines executed per file, to the passed in log.
 
+### Solving: stack level too deep errors
+
+If you start seeing SystemStackError: stack level too deep errors from background jobs after installing Coverband, this means there is another patch for ResqueWorker that conflicts with Coverband's patch in your application. To fix this, change coverband gem line in your Gemfile to the following:
+
+```
+gem 'coverband', require: ['alternative_coverband_patch', 'coverband']
+```
+
+If you currently have require: false, remove the 'coverband' string from the require array above so the gem line becomes like this:
+
+```
+gem 'coverband', require: ['alternative_coverband_patch']
+```
+
+This conflict happens when a ruby method is patched twice, once using module prepend, and once using method aliasing. See this ruby issue for details. The fix is to apply all patches the same way. Coverband by default will apply its patch using prepend, but you can change that to  method aliasing by adding require: ['alternative_coverband_patch'] to the gem line as shown above.
+
 # Prerequisites
 
 - Coverband 3.0.X+ requires Ruby 2.3+

data/lib/alternative_coverband_patch.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+module Coverband
+  COVERBAND_ALTERNATE_PATCH = true
+end

data/lib/coverband/configuration.rb

@@ -40,7 +40,7 @@ module Coverband
     # Heroku when building assets runs code from a dynamic directory
     # /tmp was added to avoid coverage from /tmp/build directories during
     # heroku asset compilation
-    IGNORE_DEFAULTS = %w[vendor/ .erb$ .slim$ /tmp internal:prelude schema.rb]
+    IGNORE_DEFAULTS = %w[vendor/ .erb$ .slim$ /tmp internal:prelude db/schema.rb]
 
     # Add in missing files which were never loaded
     # we need to know what all paths to check for unloaded files

data/lib/coverband/integrations/resque.rb

@@ -22,4 +22,16 @@ module Coverband
   end
 end
 
-Resque::Job.prepend(Coverband::ResqueWorker)
+if defined?(Coverband::COVERBAND_ALTERNATE_PATCH)
+  Resque::Job.class_eval do
+    def perform_with_coverband
+      perform_without_coverband
+    ensure
+      Coverband.report_coverage
+    end
+    alias_method perform_without_coverband perform
+    alias_method perform perform_with_coverband
+  end
+else
+  Resque::Job.prepend(Coverband::ResqueWorker)
+end

data/lib/coverband/version.rb

@@ -5,5 +5,5 @@
 # use format '4.2.1.rc.1' ~> 4.2.1.rc to prerelease versions like v4.2.1.rc.2 and v4.2.1.rc.3
 ###
 module Coverband
-  VERSION = '4.2.6'
+  VERSION = '4.2.7.rc.1'
 end

data/test/coverband/configuration_test.rb

@@ -16,9 +16,9 @@ class BaseTest < Minitest::Test
     end
   end
 
-  test 'ignore works with equal' do
-    coverband = Coverband::Collectors::Coverage.instance.reset_instance
-    expected = ['vendor/', '.erb$', '.slim$', '/tmp', 'internal:prelude', 'schema.rb', 'config/envionments']
+  test "ignore works with equal" do
+    Coverband::Collectors::Coverage.instance.reset_instance
+    expected = ["vendor/", ".erb$", ".slim$", "/tmp", "internal:prelude", "db/schema.rb", "config/envionments"]
     assert_equal expected, Coverband.configuration.ignore
   end
 
@@ -26,15 +26,15 @@ class BaseTest < Minitest::Test
     Coverband.configure do |config|
       config.ignore += ['config/initializers']
     end
-    coverband = Coverband::Collectors::Coverage.instance.reset_instance
-    expected = ['vendor/',
-                '.erb$',
-                '.slim$',
-                '/tmp',
-                'internal:prelude',
-                'schema.rb',
-                'config/envionments',
-                'config/initializers']
+    Coverband::Collectors::Coverage.instance.reset_instance
+    expected = ["vendor/",
+      ".erb$",
+      ".slim$",
+      "/tmp",
+      "internal:prelude",
+      "db/schema.rb",
+      "config/envionments",
+      "config/initializers"]
     assert_equal expected, Coverband.configuration.ignore
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 4.2.6
+  version: 4.2.7.rc.1
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-29 00:00:00.000000000 Z
+date: 2020-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
@@ -271,6 +271,7 @@ files:
 - changes.md
 - config.ru
 - coverband.gemspec
+- lib/alternative_coverband_patch.rb
 - lib/coverband.rb
 - lib/coverband/adapters/base.rb
 - lib/coverband/adapters/file_store.rb
@@ -451,9 +452,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: