coverband 4.2.4 → 4.2.5.rc.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1c094b4a6ef2b76f771cb96aa1fbdc246dc8beea74033ffca4cb466ef96c0a08
-  data.tar.gz: 1162d9244c0e1a1b28c0fa051d7cd53d29b6a4fdfc50c1fadb7d6793229aaf8b
+  metadata.gz: 57a58a71386b69f1d6ccea984e9950649a95a8618e6716149f3a890725cc23ff
+  data.tar.gz: 1b027835c1bf84f630626c32305ac57b7589c79bb785f7486f1a5446aab103fd
 SHA512:
-  metadata.gz: d9eba70b91d87992d1e450490f7fd4545cccb5092bf093c424c51b964cb4b31ad5c8a1d49d1cc774ce6470c6466b7d3b7a7a1df92ecbc4e574a203467f621b55
-  data.tar.gz: 815c462d38f7a27b26f5d209044c53b2e0058c4ea2534db3f6663a267ad0cc435bd6c895128c5ea8f85c0aec61e4e31d9f61c426526b71423e24c941852f74be
+  metadata.gz: 359c975e792a4b640dd35881ff6c413eb1252e9842cf662a458ce8d0e135e1b29e4a1d41166628a4bab5826ea360e3005557be6c6539b521b322127d441a54f3
+  data.tar.gz: e3b6acc540519877792d1779a3ade69e08f3ef7957a4bd9077984ccd89cbfcbb6dfec5076ce2273997992129f34006907b02e48f44dc5cdb9f94d0df88a2dd82

data/.travis.yml

@@ -4,17 +4,18 @@ rvm:
   - "2.4"
   - "2.5"
   - "2.6.1"
+#  - "2.7" #disable until I can detect and exclude rails for on Ruby 2.7
 cache:
   bundler: true
   directories:
-  - $HOME/lua51
+    - $HOME/lua51
 gemfile:
   - Gemfile
   - Gemfile.rails4
 services:
   - redis-server
 script:
-  - sudo ./lua/install.sh 
+  - sudo ./lua/install.sh
   - $HOME/lua51/bin/busted lua/test/*
   - bundle exec rake rubocop
   - COVERBAND_HASH_REDIS_STORE=t bundle exec rake

data/README.md

@@ -206,6 +206,8 @@ config.ignore +=  ['config/application.rb',
                    'lib/tasks/*']
 ```
 
+__Ignoring Custom Gem Locations:__ Note, if you have your gems in a custom location under your app folder you likely want to add them to `config.ignore`. For example, if you have your gems not in a default ignored location of `app/vendor` but have them in `app/gems` you would need to add `gems/*` to your ignore list.
+
 ### View Tracking
 
 Coverband allows an optional feature to track all view files that are used by an application.
@@ -237,6 +239,29 @@ ENV['AWS_ACCESS_KEY_ID']
 ENV['AWS_SECRET_ACCESS_KEY']
 ```
 
+### Fixing Coverage Only Shows Loading Hits
+
+If all your coverage is being counted as loading or eager_loading coverage, and nothing is showing as runtime Coverage the initialization hook failed for some reason. The most likely reason for this issue is manually calling `eager_load!` on some Plugin/Gem. If you or a plugin is altering the Rails initialization process, you can manually flip Coverband to runtime coverage by calling these two lines, in an `after_initialize` block, in `application.rb`.
+
+```ruby
+config.after_initialize do
+  unless Coverband.tasks_to_ignore?
+    Coverband.report_coverage # record the last of the loading coverage
+    Coverband.runtime_coverage! # set all future coverage to runtime
+  end
+end
+```
+
+or if you know you are manually calling eager load anywhere in your initialization process immediately adfter call those two lines. A user reported an issue after calling `ResqueWeb::Engine.eager_load!` for example.
+
+```ruby
+Rails.application.routes.draw do
+  ResqueWeb::Engine.eager_load!
+  Coverband.report_coverage
+  Coverband.runtime_coverage!
+end
+```
+
 ### Avoiding Cache Stampede
 
 If you have many servers and they all hit Redis at the same time you can see spikes in your Redis CPU, and memory. This is do to a concept called [cache stampede](https://en.wikipedia.org/wiki/Cache_stampede). It is better to spread out the reporting across your servers. A simple way to do this is to add a random wiggle on your background reporting. This configuration option allows a wiggle. The right amount of wiggle depends on the numbers of servers you have and how willing you are to have delays in your coverage reporting. I would recommend at least 1 second per server. 

data/lib/coverband/configuration.rb

@@ -54,7 +54,7 @@ module Coverband
       @root = Dir.pwd
       @root_paths = []
       @ignore = IGNORE_DEFAULTS.dup
-      @seach_paths = TRACKED_DEFAULT_PATHS.dup
+      @search_paths = TRACKED_DEFAULT_PATHS.dup
       @additional_files = []
       @verbose = false
       @reporter = 'scov'
@@ -134,14 +134,14 @@ module Coverband
     # Search Paths
     ###
     def tracked_search_paths
-      "#{Coverband.configuration.current_root}/{#{@seach_paths.join(',')}}/**/*.{rb}"
+      "#{Coverband.configuration.current_root}/{#{@search_paths.join(',')}}/**/*.{rb}"
     end
 
     ###
     # Don't allow the to override defaults
     ###
     def search_paths=(path_array)
-      @seach_paths = (@seach_paths + path_array).uniq
+      @search_paths = (@search_paths + path_array).uniq
     end
 
     ###

data/lib/coverband/reporters/web.rb

@@ -32,8 +32,9 @@ module Coverband
 
         return [401, { 'www-authenticate' => 'Basic realm=""' }, ['']] unless check_auth
 
+        request_path_info = (request.path_info == '') ? '/' : request.path_info
         if request.post?
-          case request.path_info
+          case request_path_info
           when %r{\/clear_view_tracking_file}
             clear_view_tracking_file
           when %r{\/clear_view_tracking}
@@ -46,7 +47,7 @@ module Coverband
             [404, { 'Content-Type' => 'text/html' }, ['404 error!']]
           end
         else
-          case request.path_info
+          case request_path_info
           when /.*\.(css|js|gif|png)/
             @static.call(env)
           when %r{\/settings}

data/lib/coverband/version.rb

@@ -5,5 +5,5 @@
 # use format '4.2.1.rc.1' ~> 4.2.1.rc to prerelease versions like v4.2.1.rc.2 and v4.2.1.rc.3
 ###
 module Coverband
-  VERSION = '4.2.4'
+  VERSION = '4.2.5.rc.1'
 end

data/test/coverband/reporters/web_test.rb

@@ -27,6 +27,12 @@ if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.2.0')
         assert_match 'Coverband Admin', last_response.body
       end
 
+      test 'renders index content for empty path' do
+        get ''
+        assert last_response.ok?
+        assert_match 'Coverband Admin', last_response.body
+      end
+
       test 'renders 404' do
         get '/show'
         assert last_response.not_found?

data/test/test_helper.rb

@@ -15,7 +15,7 @@ require 'ostruct'
 require 'json'
 require 'redis'
 require 'resque'
-require 'pry-byebug'
+require 'pry-byebug' unless ENV['CI'] # Ruby 2.3 on CI crashes on pry
 require_relative 'unique_files'
 $VERBOSE = original_verbosity
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 4.2.4
+  version: 4.2.5.rc.1
 platform: ruby
 authors:
 - Dan Mayer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-12-29 00:00:00.000000000 Z
+date: 2020-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
@@ -449,9 +449,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubygems_version: 3.0.3
 signing_key: