coverband 4.2.1.rc1 → 4.2.1.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e20f401f319399c3eb6aab9f562105addeedd4dcea5e3de3db3e5a763e92fe5d
-  data.tar.gz: bc20a849db5868dd73a448269bc9d74e6b58674793807bcdcf36a33cecd8825b
+  metadata.gz: b36c74e7000d8cd20c424fff66e2de35be821c440fbaf54be18b81e2e8de48d1
+  data.tar.gz: b459fd5abde8bdb4cb5283e9512ccc8a25e61d98fd6bb678d16854273f8df1a0
 SHA512:
-  metadata.gz: 5f2303765376cd244a692d1254ef8f7fe57180ee12712d3763921811c7d278fb3ffb2dfa4a1400b86b01809c0acfa8173c7569aeb65be3f860e53dad01dfbc83
-  data.tar.gz: c3456663cc5b9f9ecfce60603234f4aed32ef9f3875cb0ca60ae11e66211f70bb64c6f0b8772b5295c8065d4d8245f107d596cd21140ba7ab146c97ef8353324
+  metadata.gz: 0e906b9c7e280e18b10e5c852199fb379600642c50bb566d678ea17ca2633ced35fc5d184ac93665c5c7eecc80ca0ee49cac161ff0dda06f66cc81b626031722
+  data.tar.gz: f59cb2a359a719837577ba143c60f6ad1e16fe12272c34843d8a0b9c030ab4030afc32343e3d3bbad6804f1f326e47f81cddc7c84e913a14f173c2bb9652c507

data/lib/coverband/configuration.rb

@@ -114,12 +114,10 @@ module Coverband
       @ignore << 'vendor/ruby-*' unless @ignore.include?('vendor/ruby-*')
       add_group('App', root)
       # TODO: rework support for multiple gem paths
-      # currently this supports GEM_HOME (which should be first path)
-      # but various gem managers setup multiple gem paths
-      # gem_paths.each_with_index do |path, index|
-      #   add_group("gems_#{index}", path)
-      # end
-      add_group('Gems', gem_paths.first)
+      # this works but seems hacky and error prone
+      # basically since it is converted to a regex we join all the paths
+      # with a regex 'OR' using '|'
+      add_group('Gems', gem_paths.join('|'))
     end
 
     #

data/lib/coverband/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Coverband
-  VERSION = '4.2.1.rc1'
+  VERSION = '4.2.1.rc2'
 end

data/test/coverband/utils/file_groups_test.rb

@@ -3,16 +3,18 @@
 require File.expand_path('../../test_helper', File.dirname(__FILE__))
 
 describe Coverband::Utils::FileGroups do
-  FAKE_GEM_PATH = 'fake/gem/path'
+  FAKE_GEM_PATH = '/Users/danmayer/.rvm/gems/ruby-2.6.2/gems'
+  SECONDAY_GEM_PATH = '/Users/danmayer/.rvm/rubies/ruby-2.6.2/lib/ruby/gems/2.6.0/gems'
   subject do
     controller_lines = [nil, 2, 2, 0, nil, nil, 0, nil, nil, nil]
     files = [
       Coverband::Utils::SourceFile.new(source_fixture('sample.rb'), [nil, 1, 1, 1, nil, nil, 1, 1, nil, nil]),
       Coverband::Utils::SourceFile.new(source_fixture('app/models/user.rb'), [nil, 1, 1, 1, nil, nil, 1, 0, nil, nil]),
       Coverband::Utils::SourceFile.new(source_fixture('app/controllers/sample_controller.rb'), controller_lines),
-      Coverband::Utils::SourceFile.new("#{FAKE_GEM_PATH}/gem_name.rb", controller_lines)
+      Coverband::Utils::SourceFile.new("#{FAKE_GEM_PATH}/gem_name-1.0.0/gem_name.rb", controller_lines),
+      Coverband::Utils::SourceFile.new("#{SECONDAY_GEM_PATH}/gem_two_name-1.1.1/gem_two.rb", controller_lines)
     ]
-    Coverband.configuration.expects(:gem_paths).at_least_once.returns([FAKE_GEM_PATH])
+    Coverband.configuration.expects(:gem_paths).at_least_once.returns([FAKE_GEM_PATH, SECONDAY_GEM_PATH])
     Coverband.configuration.track_gems = true
     Coverband::Utils::FileGroups.new(files)
   end
@@ -22,7 +24,11 @@ describe Coverband::Utils::FileGroups do
   end
 
   it 'has gem files' do
-    assert_equal "#{FAKE_GEM_PATH}/gem_name.rb", subject.grouped_results['Gems'].first.first.short_name
+    assert_equal "gem_name-1.0.0", subject.grouped_results['Gems'].first.first.gem_name
+  end
+
+  it 'has gem files from secondary gem paths' do
+    assert_equal "gem_two_name-1.1.1", subject.grouped_results['Gems'][1].first.gem_name
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coverband
 version: !ruby/object:Gem::Version
-  version: 4.2.1.rc1
+  version: 4.2.1.rc2
 platform: ruby
 authors:
 - Dan Mayer