courtfinder-client 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 13ada6003ce78ac35d50232679d81dfc90437902
-  data.tar.gz: d0d6b2f1237b1b34e4c6fd6bf548e7b87467b66b
+  metadata.gz: c10363b23a4abddd239820d39fb1f96dbc0080f6
+  data.tar.gz: 08cb9e811c67d11728e4f61d43c1354cdf4b818f
 SHA512:
-  metadata.gz: 5992de9d86d641204284116dc80981308f44db42a7505ac4f5007ddd8a216c3a41b38518fd7712424021ea93639ea87d5722bc024d923f0326e95ed685e435ee
-  data.tar.gz: 496e63fc92b41c5e2733dbfa02b0346192b54684411c424434b961371b79feb779fd4ae7613ea7acec4ed9f69d6cf169f207458473659d90e19f70c2b05a6371
+  metadata.gz: 99c976648f26c260a0a6d4fd326552fea827f0db3c831b6bf14ab433ad5c1ba583793d310084406a71033e89bf2b5f5402ce7309cdf08a3710411fcf85cc3410
+  data.tar.gz: b4f082467c62a7896ea47876857baeb866701d4935cbb9e94479c4541330f9ab039ed5412f1abff19186d6531f1b1b10e26583c19eef96edafd8ef5c814ad4d3

data/README.md

@@ -32,6 +32,14 @@ area of law for the given postcode.
 
 **TODO:** Add support for courts in other areas of law.
 
+## Updating the gem
+
+When you add more features and you feel that a significant change has
+been made, increase the gem version number and publish it to [RubyGems](https://rubygems.org/):
+
+    $ gem build courtfinder-client.gemspec
+    $ gem push courtfinder-client-X.Y.Z.gem
+
 ## Contributing
 
 1. Fork it ( https://github.com/ministryofjustice/courtfinder-client/fork )

data/lib/courtfinder/client.rb

@@ -11,24 +11,21 @@ module Courtfinder
 
       def get postcode
         conn = Faraday.get "#{Courtfinder::SERVER}#{PATH}#{URI.escape(postcode)}"
-        process_address conn.body
+        process conn.body
+      end
+
+      def empty?
+        @json.empty?
       end
 
       private
 
-      def process_address data
-        if data == '[]'
-          data
-        else
-          json = JSON.parse data
-          address_json = json[0]["address"]
-          name_n_street = "#{address_json["address_lines"].join("\n")}"
-          <<-EOS.chomp.gsub('  ', '')
-            #{name_n_street}
-            #{address_json["town"]}
-            #{address_json["county"]}
-            #{address_json["postcode"]}
-          EOS
+      def process data
+        @json = JSON.parse data
+        unwanted_attributes = ['areas_of_law', 'slug', 'dx_number',
+                               'lon', 'lat', 'types', 'number']
+        @json.each do |court|
+          unwanted_attributes.each {|attr| court.delete attr }
         end
       end
     end

data/lib/courtfinder/client/version.rb

@@ -1,5 +1,5 @@
 module Courtfinder
   module Client
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/spec/client_spec.rb

@@ -5,44 +5,91 @@ require 'courtfinder/client'
 describe Courtfinder::Client::HousingPossession do
   before { WebMock.disable_net_connect! }
 
+  let(:result) do
+    [{ "name" => "Cambridge County Court and Family Court",
+       "address" =>
+       { "town" => "Cambridge",
+         "address_lines" =>
+         ["Cambridge County Court and Family Court Hearing Centre",
+          "197 East Road"],
+         "type" => "Postal",
+         "postcode" => "CB1 1BA",
+         "county" => "Cambridgeshire"
+       }
+     }]
+  end
+  let(:client) { Courtfinder::Client::HousingPossession.new }
+
+  def full_url postcode
+    "#{Courtfinder::SERVER}#{Courtfinder::Client::HousingPossession::PATH}#{postcode}"
+  end
+
+  def stub_with postcode
+    stub_request(:get, full_url(postcode))
+      .to_return(:body => fixture('result.json'),
+                 :headers => {:content_type => 'application/json; charset=utf-8'})
+  end
+
+  def blank_result postcode
+    stub_request(:get, full_url(postcode))
+      .to_return(:status => 200,
+                 :body => '[]',
+                 :headers => {})
+  end
+
   describe '.get' do
-    let(:client) { Courtfinder::Client::HousingPossession.new }
-    let(:address) {
-      "Cambridge County Court and Family Court Hearing Centre\n197 East Road\nCambridge\nCambridgeshire\nCB1 1BA"
-    }
-
-    def stub_with postcode
-      stub_request(:get, "#{Courtfinder::SERVER}#{Courtfinder::Client::HousingPossession::PATH}#{postcode}")
-        .to_return(:body => fixture('result.json'),
-                   :headers => {:content_type => 'application/json; charset=utf-8'})
-    end
+    before { stub_with postcode }
 
     context 'when given postcode with no spaces' do
-      postcode = 'sg80lt'
+      let(:postcode) { 'sg80lt' }
 
       it 'should return the court address' do
-        stub_with postcode
-        expect(client.get(postcode)).to eql address
+        expect(client.get(postcode)).to eql result
       end
     end
 
     context 'when given postcode with spaces' do
-      postcode = 'SG8 0LT'
+      let(:postcode) { 'SG8 0LT' }
 
       it 'should return the court address' do
-        stub_with postcode
-        expect(client.get(postcode)).to eql address
+        expect(client.get(postcode)).to eql result
       end
     end
 
     context 'when invalid postcode is provided' do
+      let(:postcode) { 'fake' }
+      before { blank_result postcode }
+
       it 'should return an error' do
-        stub_request(:get, "#{Courtfinder::SERVER}#{Courtfinder::Client::HousingPossession::PATH}fake")
-          .to_return(:status => 200,
-                     :body => '[]',
-                     :headers => {})
+        expect(client.get(postcode)).to eql []
+      end
+    end
+  end
+
+  describe '.empty?' do
+    context 'when there are results returned' do
+      let(:postcode) { 'SG8 0LT' }
+
+      before do
+        stub_with postcode
+        client.get postcode
+      end
+
+      it 'should be false' do
+        expect(client.empty?).to be false
+      end
+    end
+
+    context 'when there are no results returned' do
+      let(:postcode) { 'fake' }
+
+      before do
+        blank_result postcode
+        client.get postcode
+      end
 
-        expect(client.get('fake')).to eql '[]'
+      it 'should be true' do
+        expect(client.empty?).to be true
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: courtfinder-client
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Aleksandar Simić
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-01 00:00:00.000000000 Z
+date: 2014-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler