counter_culture 3.11.3 → 3.11.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 75ac99d8d45f3e16859bb04854958dac048a449aa4afe94f12885cefe3a94787
-  data.tar.gz: e90d1b87ea3e2d919434dbeea2263fa5556044dc273cab21a6a67b423519c012
+  metadata.gz: 4978dfaab9ec73c8b3215c2d2f811093cc00cdf7daccfe877749f301a09ae11a
+  data.tar.gz: e2e1322882fdeab8c7239c7cf16e4019b5450d3f435c478ad1d9e2d33cf5a251
 SHA512:
-  metadata.gz: dc1196535a528c5f87e39aca06d5e1a3e014f469c8aa3e8f01c56f75a59489c4db25dc9b67168b162ddf9ac24e45c55fe887c10176e76786dea5ffe72603f10b
-  data.tar.gz: a949a3856773028e954e00c8ce5ba89ac0e999230c47af3d1b0e312fdef827cbbf0dc71ed91406c6b2b77ba4d194b108f21df8b904f0e09592d2b5ef2a0e25d9
+  metadata.gz: a60b46c8b713dbbb7f2969c9b6885e9975a1c5723eb3566a04b011380eafb077c3051386586cff7c77b5ba171888ef577aa5d1dd6be4a4d97ea8e1db1fdca91d
+  data.tar.gz: 51feccb08cf927e8fc6f1d41f39f91269411db70d96d3b44d57ddf35c67130790c1340cb27aff0e0f4701934b40bc17485345667d1bffcbfb145eb4a5d98bea6

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 3.11.4 (November 5, 2025)
+
+Bugfixes:
+  - Fix counter cache not using the correct type with multiple STI models in the association chain (#421)
+
 ## 3.11.3 (October 22, 2025)
 
 Bugfixes:

data/lib/counter_culture/counter.rb

@@ -240,11 +240,11 @@ module CounterCulture
       Array.wrap(primary_key).map { |pk| value.try(pk&.to_sym) }.compact.presence
     end
 
-    # gets the reflect object on the given relation
+    # gets the reflect object on the given relation and the model that defines this reflect
     #
     # relation: a symbol or array of symbols; specifies the relation
     #   that has the counter cache column
-    def relation_reflect(relation)
+    def relation_reflect_and_model(relation)
       relation = relation.is_a?(Enumerable) ? relation.dup : [relation]
 
       # go from one relation to the next until we hit the last reflect object
@@ -262,7 +262,16 @@ module CounterCulture
         end
       end
 
-      return reflect
+      return [reflect, klass]
+    end
+
+
+    # gets the reflect object on the given relation
+    #
+    # relation: a symbol or array of symbols; specifies the relation
+    #   that has the counter cache column
+    def relation_reflect(relation)
+      relation_reflect_and_model(relation).first
     end
 
     # gets the class of the given relation

data/lib/counter_culture/reconciler.rb

@@ -59,7 +59,7 @@ module CounterCulture
     class Reconciliation
       attr_reader :counter, :options, :relation_class
 
-      delegate :model, :relation, :full_primary_key, :relation_reflect, :polymorphic?, :to => :counter
+      delegate :model, :relation, :full_primary_key, :relation_reflect_and_model, :relation_reflect, :polymorphic?, :to => :counter
       delegate *CounterCulture::Counter::CONFIG_OPTIONS, :to => :counter
 
       def initialize(counter, changes_holder, options, relation_class)
@@ -257,11 +257,11 @@ module CounterCulture
         # store joins in an array so that we can later apply column-specific
         # conditions
         join_clauses = reverse_relation.each_with_index.map do |cur_relation, index|
-          reflect = relation_reflect(cur_relation)
+          reflect, model = relation_reflect_and_model(cur_relation)
 
-          target_table = quote_table_name(reflect.active_record.table_name)
+          target_table = quote_table_name(model.table_name)
           target_table_alias = parameterize(target_table)
-          if relation_class.table_name == reflect.active_record.table_name
+          if relation_class.table_name == model.table_name
             # join with alias to avoid ambiguous table name in
             # self-referential models
             target_table_alias += "_#{target_table_alias}"
@@ -299,8 +299,8 @@ module CounterCulture
 
           # adds 'type' condition to JOIN clause if the current model is a
           # child in a Single Table Inheritance
-          if reflect.active_record.column_names.include?('type') &&
-              !model.descends_from_active_record?
+          if model.column_names.include?('type') &&
+             !model.descends_from_active_record?
             joins_sql += " AND #{target_table_alias}.type IN ('#{model.name}')"
           end
           if polymorphic?

data/lib/counter_culture/version.rb

@@ -1,3 +1,3 @@
 module CounterCulture
-  VERSION = '3.11.3'.freeze
+  VERSION = '3.11.4'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 3.11.3
+  version: 3.11.4
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-10-23 00:00:00.000000000 Z
+date: 2025-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord