counter_culture 3.11.2 → 3.11.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c568fc84225757b834a008eb60dbadfe5dea148078c855fe76a2b5711b0c5b1e
-  data.tar.gz: 3abc94f197b60fb6778eadb98ad402e6b961155c492970111b85bbf1bd171237
+  metadata.gz: 75ac99d8d45f3e16859bb04854958dac048a449aa4afe94f12885cefe3a94787
+  data.tar.gz: e90d1b87ea3e2d919434dbeea2263fa5556044dc273cab21a6a67b423519c012
 SHA512:
-  metadata.gz: adfd25e90ca300e1d6bc19296b343a8fbd9a272076e48591dddc513ffa4173dff10ef2d26cec6bd08bdfbc372ccf1b94e97cee7d7827205523efe0278d1bffea
-  data.tar.gz: 733126919913da347057de9c81cbbdf7b4b45e9ea1bbbecad12586a06432801e37b1c8833078cc93ce11fdc0ad3b201c5484822dcebc708f970d2106c022d35b
+  metadata.gz: dc1196535a528c5f87e39aca06d5e1a3e014f469c8aa3e8f01c56f75a59489c4db25dc9b67168b162ddf9ac24e45c55fe887c10176e76786dea5ffe72603f10b
+  data.tar.gz: a949a3856773028e954e00c8ce5ba89ac0e999230c47af3d1b0e312fdef827cbbf0dc71ed91406c6b2b77ba4d194b108f21df8b904f0e09592d2b5ef2a0e25d9

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 3.11.3 (October 22, 2025)
+
+Bugfixes:
+  - Fix in-memory counter updates for conditional counters when condition changes (#420)
+
 ## 3.11.2 (July 10, 2025)
 
 Bugfixes:

data/lib/counter_culture/counter.rb

@@ -150,7 +150,27 @@ module CounterCulture
           execute_now_or_after_commit(obj) do
             conditions = primary_key_conditions(primary_key, id_to_change)
             klass.where(conditions).update_all updates.join(', ')
-            unless options[:was]
+            # Determine if we should update the in-memory counter on the associated object.
+            # When updating the old counter (was: true), we need to carefully consider two scenarios:
+            # 1) The belongs_to relation changed (e.g., moving a child from parent A to parent B):
+            #    In this case, obj.association now points to parent B, but we're decrementing parent A's
+            #    counter. We should NOT update the in-memory counter because it would incorrectly
+            #    modify parent B's cached value.
+            # 2) A conditional counter's condition changed (e.g., condition: true → false):
+            #    In this case, obj.association still points to the same parent, but the counter column
+            #    name changed (e.g., from 'conditional_count' to nil). We SHOULD update the in-memory
+            #    counter so the parent object reflects the decremented value without requiring a reload.
+            # We distinguish these cases by comparing foreign keys: if the current and previous foreign
+            # keys are identical, we're in scenario 2 and should update the in-memory counter.
+            should_update_counter = if options[:was]
+              current_fk = foreign_key_value(obj, relation, false)
+              previous_fk = foreign_key_value(obj, relation, true)
+              current_fk == previous_fk && current_fk.present?
+            else
+              true
+            end
+
+            if should_update_counter
               assign_to_associated_object(obj, relation, change_counter_column, operator, delta_magnitude)
             end
           end

data/lib/counter_culture/version.rb

@@ -1,3 +1,3 @@
 module CounterCulture
-  VERSION = '3.11.2'.freeze
+  VERSION = '3.11.3'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 3.11.2
+  version: 3.11.3
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-07-10 00:00:00.000000000 Z
+date: 2025-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord