counter_culture 3.10.0 → 3.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78d568cfdb319852f7cbfa1f09b3b17d7a583f0a56afcba26ffc6db937906c0f
-  data.tar.gz: 220516dcbbe2966749fd1c74a6720e9bb82565bba0b41f053fc94c9948db4b73
+  metadata.gz: 157dbe49de1382e3c20686dbb3b22327af960831612683cb08b59db7ccf8dd8e
+  data.tar.gz: 88db04f7a2d879c9b25255f627d13f823f7bf487cf42fb5efc7d9c764d890b59
 SHA512:
-  metadata.gz: 5fb91dc191fad8487358613ac76eae7887113b7191ced1b59acde6a84963c2813787c1036a07490f4579e423bb9cedcf3ba324b6d2f4e1cac903cf5721949445
-  data.tar.gz: c86cf4baee69aceec50718877ab0fd9ff6064bd460d4f0fff8615eb0836cc5c3d74e44178fbd87976a7eab18a106a5f25e09179a85380a93472cbf1e715f14ce
+  metadata.gz: f0ddda7335aa711ca57fa20e36e4b0a3a12086263281994093749407662b2b0c5ab32851ce14c3f3b44b960a11a758b2f4462fe88c93b5f8b65bde4a05eaa2b0
+  data.tar.gz: 020d0e8e5084419a67c14a102d77ba76d1b445fb980fa3e441e009114f0a4e6074d47e11689aadc16edf5efdee2b4f3b2e7db15787cb0a57de125a31faecd4eb

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 3.10.1 (April 30, 2025)
+
+Bigfixes:
+  - Fix issue when using `delegate` instead of `has_many :through` (#411)
+
 ## 3.10.0 (April 15, 2025)
 
 New features:

data/lib/counter_culture/counter.rb

@@ -370,15 +370,31 @@ module CounterCulture
     def assign_to_associated_object(obj, relation, change_counter_column, operator, delta_magnitude)
       association_name = relation_reflect(relation).name
 
-      return unless obj.respond_to?(association_name)
+      association_object = association_object_for_assign(obj, association_name)
+      return if association_object.blank?
 
-      if obj.association(association_name).loaded? && (association_object = obj.public_send(association_name)).present?
-        association_object.assign_attributes(
-          change_counter_column =>
-            association_object_new_counter(association_object, change_counter_column, operator, delta_magnitude)
-        )
-        association_object_clear_change(association_object, change_counter_column)
+      association_object.assign_attributes(
+        change_counter_column =>
+          association_object_new_counter(association_object, change_counter_column, operator, delta_magnitude)
+      )
+      association_object_clear_change(association_object, change_counter_column)
+    end
+
+    def association_object_for_assign(obj, association_name)
+      if obj.class.reflect_on_all_associations.
+          find { |assoc| assoc.name.to_sym == association_name.to_sym }.
+          blank?
+        # This means that this isn't defined as an association; either it
+        # doesn't exist at all, or it uses delegate. In either case, we can't
+        # update the count this way.
+        return
+      end
+      if !obj.association(association_name).loaded?
+        # If the association isn't loaded, no need to update the count
+        return
       end
+
+      obj.public_send(association_name)
     end
 
     def association_object_clear_change(association_object, change_counter_column)

data/lib/counter_culture/version.rb

@@ -1,3 +1,3 @@
 module CounterCulture
-  VERSION = '3.10.0'.freeze
+  VERSION = '3.10.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 3.10.0
+  version: 3.10.1
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-15 00:00:00.000000000 Z
+date: 2025-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord