counter_culture 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c8bc293e01a8e0b0f05d3d183092552f8136e76f7d08145aa354e0dc7c2693ba
-  data.tar.gz: 905edad7a81274176e100eaa58b5ee798d985c97f4c6543dee7b6fe81fd57675
+  metadata.gz: df98e13e157dd1e7dc6bda49e350d020017ce7d28be3eec26f09bba70d1cbae8
+  data.tar.gz: c8d0ae6f11a94a1a5d3e0ebac55ac2572805036b89f59f685e09cf672e3d9a05
 SHA512:
-  metadata.gz: 723cc217870d0640c81f94c692604b260dfa1c45b747693807bbd8f5ceb5557c01398bbe4f9313a844a430b685eee25c9910a2360ffddd124c4d8c759ce72689
-  data.tar.gz: bdcf5cef68f33898f535a976a642fa1b4f1397a496f23e2519c35076935b5fe431e58b7a810ee243ef89596ada2f40dd522642233e46f50b395626d32142f727
+  metadata.gz: e896531ea63cdac8870cd6c977312080c2ae2600a9419fdf8f496eb1df37c008c53c42f420088c804cfa1c6dcac4fa3d8a4eb13a0ac76774cea6bde79940af1a
+  data.tar.gz: e8a1d63b0e95d30fef050f20a8a25e7bc864f1753010272068bdd7f5cc9ac7f4805bb583b4f0df01951d4b6c9e41a5d7061162c1f6d52800d4ba27259ecefece

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 ## 2.3.0 (January 28, 2020)
 
+Improvements:
+  - Allow specifying `start` and `finish` options to `counter_culture_fix_counts` (#279)
+
+## 2.3.0 (January 28, 2020)
+
 Improvements:
   - Allow using scopes in `column_names` (#272)
 

data/README.md

@@ -309,7 +309,26 @@ Product.counter_culture_fix_counts touch: true
 If you have specified a custom timestamps column, pass its name as the value for the `touch` option:
 
 ```ruby
-Product.counter_culture_fix_counts touch: category_count_changed
+Product.counter_culture_fix_counts touch: 'category_count_changed'
+```
+
+
+#### Parallelizing fix counter cache in multiple workers
+
+The options start and finish are especially useful if you want multiple workers dealing with the same processing queue. You can make worker 1 handle all the records between id 1 and 9999 and worker 2 handle from 10000 and beyond by setting the :start and :finish option on each worker.
+
+```ruby
+Product.counter_culture_fix_counts start: 10_000
+# will fix counts for all counter caches defined on Product from record 10000 and onwards.
+
+Product.counter_culture_fix_counts finish: 10_000
+# let's process until 10000 records.
+
+Product.counter_culture_fix_counts start: 1000, finish: 2000
+# In worker 1, lets process from 1000 to 2000
+
+Product.counter_culture_fix_counts start: 2001, finish: 3000
+# In worker 2, lets process from 2001 to 3000
 ```
 
 #### Handling dynamic column names

data/lib/counter_culture/extensions.rb

@@ -81,7 +81,9 @@ module CounterCulture
           next if options[:exclude] && options[:exclude].include?(counter.relation)
           next if options[:only] && !options[:only].include?(counter.relation)
 
-          reconciler = CounterCulture::Reconciler.new(counter, options.slice(:skip_unsupported, :batch_size, :touch, :where, :verbose))
+          reconciler_options = %i(batch_size finish skip_unsupported start touch verbose where)
+
+          reconciler = CounterCulture::Reconciler.new(counter, options.slice(*reconciler_options))
           reconciler.reconcile!
           reconciler.changes
         end.compact

data/lib/counter_culture/reconciler.rb

@@ -102,10 +102,12 @@ module CounterCulture
           # iterate in batches; otherwise we might run out of memory when there's a lot of
           # instances and we try to load all their counts at once
           batch_size = options.fetch(:batch_size, CounterCulture.config.batch_size)
+          start_index = options[:start]
+          finish_index = options[:finish]
 
-          counts_query = counts_query.where(options[:where])
+          counts_query = counts_query.where(options[:where]).group(full_primary_key(relation_class))
 
-          counts_query.group(full_primary_key(relation_class)).find_in_batches(batch_size: batch_size) do |records|
+          counts_query.find_in_batches(batch_size: batch_size, start: start_index, finish: finish_index) do |records|
             # now iterate over all the models and see whether their counts are right
             update_count_for_batch(column_name, records)
           end

data/lib/counter_culture/version.rb

@@ -1,3 +1,3 @@
 module CounterCulture
-  VERSION = '2.3.0'.freeze
+  VERSION = '2.4.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-02-03 00:00:00.000000000 Z
+date: 2020-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: after_commit_action