counter_culture 2.2.0 → 2.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b5637cebe0df178e1b1f77843a82f82a08405eb9c82aa82ac30af0dd82c88c91
-  data.tar.gz: e125436305f7181c9e4aba3d4459b6f83b0f57c41512c20f804d42b9c1f99a79
+  metadata.gz: ed37e7ce1d391b9fc468d8a1638b78e6afb46bc764dd7fff6935d00e41dbf18b
+  data.tar.gz: 1a7d6b777a4065e214ebab7a25d271c4755eca109ca2907f71363450f329ff03
 SHA512:
-  metadata.gz: 4fca0f938a9dd9afc261ba9af247c5e9ba5773e16ec3219274cde22d5c02268555e29a39a8d4bc4e403d05b2dba53aa868e119f804dc3f53a644d17b3aee448d
-  data.tar.gz: 9de907bfc4baa6746f1072845c66a0ebb6f0c00009a7818ba1b4422a7bf0cd0fbea72544097b85ff3ed1ff262d24e06e5b8c1a95e5237ba97d364394353d78c9
+  metadata.gz: '092c9686853ad23dea228cdd32ecef385efeeb3a43f55778372faaf052359512eaf82c7d2f68b1898d419f6911646e2024fde2d75706cefb339b7e98a3c125ce'
+  data.tar.gz: cad2c4b3c7546d0a2098f3d738631712aaf80d26cf6244c7b27c53c3358fca7130e4e52c756e29c7b331549875cc063a7b28f1bc810f8556d73bb58ab4fd6cec

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 2.2.1 (April 17, 2019)
+
+Improvements:
+  - Improve logging when `verbose` is set (#256)
+
 ## 2.2.0 (April 9, 2019)
 
 Improvements:

data/README.md

@@ -7,7 +7,13 @@ Turbo-charged counter caches for your Rails app. Huge improvements over the Rail
 * Supports dynamic column names, making it possible to split up the counter cache for different types of objects
 * Can keep a running count, or a running total
 
-Tested against Ruby 2.2.10, 2.3.7, 2.4.4 and 2.5.1 and against the latest patch releases of Rails 3.2, 4.0, 4.1, 4.2, 5.0, 5.1 and 5.2.
+Tested against Ruby 2.3.8, 2.4.6, 2.5.5 and 2.6.2 and against the latest patch releases of Rails 4.2, 5.0, 5.1 and 5.2.
+
+Please note that -- unlike Rails' built-in counter-caches -- counter_culture does not currently change the behavior of the `.size` method on ActiveRecord associations. If you want to avoid a database query and read the cached value, please use the attribute name containing the counter cache directly.
+```
+product.categories.size  # => will lead to a SELECT COUNT(*) query
+product.categories_count # => will use counter cache without query
+```
 
 ## Installation
 

data/VERSION

@@ -1 +1 @@
-2.2.0
+2.2.1

data/counter_culture.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: counter_culture 2.2.0 ruby lib
+# stub: counter_culture 2.2.1 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "counter_culture".freeze
-  s.version = "2.2.0"
+  s.version = "2.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Magnus von Koeller".freeze]
-  s.date = "2019-04-09"
+  s.date = "2019-04-17"
   s.description = "counter_culture provides turbo-charged counter caches that are kept up-to-date not just on create and destroy, that support multiple levels of indirection through relationships, allow dynamic column names and that avoid deadlocks by updating in the after_commit callback.".freeze
   s.email = "magnus@vonkoeller.de".freeze
   s.extra_rdoc_files = [
@@ -123,7 +123,7 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/magnusvk/counter_culture".freeze
   s.licenses = ["MIT".freeze]
   s.required_ruby_version = Gem::Requirement.new(">= 2.3.0".freeze)
-  s.rubygems_version = "3.0.3".freeze
+  s.rubygems_version = "2.7.6.2".freeze
   s.summary = "Turbo-charged counter caches for your Rails app.".freeze
 
   if s.respond_to? :specification_version then

data/lib/counter_culture/reconciler.rb

@@ -67,7 +67,7 @@ module CounterCulture
       end
 
       def perform
-        log "Performing reconciling of #{counter.model}##{counter.relation.to_sentence}.\n"
+        log "Performing reconciling of #{counter.model}##{counter.relation.to_sentence}."
         # if we're provided a custom set of column names with conditions, use them; just use the
         # column name otherwise
         # which class does this relation ultimately point to? that's where we have to start
@@ -105,14 +105,14 @@ module CounterCulture
             update_count_for_batch(column_name, records)
           end
         end
-        log "\n"
-        log "Finished reconciling of #{counter.model}##{counter.relation.to_sentence}.\n"
+        log_without_newline "\n"
+        log "Finished reconciling of #{counter.model}##{counter.relation.to_sentence}."
       end
 
       private
 
       def update_count_for_batch(column_name, records)
-        log "."
+        log_without_newline "."
 
         ActiveRecord::Base.transaction do
           records.each do |record|
@@ -145,6 +145,12 @@ module CounterCulture
         Rails.logger.info(message)
       end
 
+      def log_without_newline(message)
+        return unless log?
+
+        Rails.logger << message if Rails.logger.info?
+      end
+
       def log?
         options[:verbose] && Rails.logger
       end

data/spec/counter_culture_spec.rb

@@ -1367,13 +1367,17 @@ describe "CounterCulture" do
     SimpleDependent.delete_all
     SimpleMain.delete_all
 
-    main = SimpleMain.create
-    3.times { main.simple_dependents.create }
+    2.times do
+      main = SimpleMain.create
+      3.times { main.simple_dependents.create }
+    end
 
-    SimpleDependent.counter_culture_fix_counts :batch_size => A_BATCH, verbose: true
+    SimpleDependent.counter_culture_fix_counts :batch_size => 1, verbose: true
 
     expect(io.string).to include(
       "Performing reconciling of SimpleDependent#simple_main.")
+    expect(io.string).to include(
+      "..")
     expect(io.string).to include(
       "Finished reconciling of SimpleDependent#simple_main.")
     Rails.logger = logger

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-09 00:00:00.000000000 Z
+date: 2019-04-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: after_commit_action
@@ -336,7 +336,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: Turbo-charged counter caches for your Rails app.