counter_culture 0.1.17 → 0.1.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3bf55ab884e9f76030002f56bc3602e3e604d3da
-  data.tar.gz: e4d81c1554c982ad4990dbecdb26e98996d4d665
+  metadata.gz: 4b1b627a0c744806fbe1214b439f057d504c4056
+  data.tar.gz: 18a273ab383bdad289298b3a6542ffe891ed07ec
 SHA512:
-  metadata.gz: c573939173201d15d2709230b4000401d032cdd684fae5175e6a21e1730461efa7968505757c6147fc13a72a9fc9ff148ea877043f6e5172e20651f9a5273394
-  data.tar.gz: 0c047ebfc7d0b00b5a0b508d7a37c6ca78588544fa412e48c4418a4df47c6d0dd7c71ab97d062876a1674cc1c4b5ab00990263419d3e8e1cdf4d6b326e245aea
+  metadata.gz: d11550bdb3d9d65e30522ff0a00262dd7259dc725fb0a719c881fdf3d7d3044f335470bb631aa74259e6efaaa824aee6ea00403020ef346f66a8e4e7080ae241
+  data.tar.gz: b8b1a6a4fc8fbd43e82cdff9e2811cb6ca4eb4425fd70cb5bbba1f9eb2c506389bd53c8319311deff0940d1525166e35eab5a49670bb76833d6864762e7f2130

data/README.md

@@ -13,7 +13,7 @@ Turbo-charged counter caches for your Rails app. Huge improvements over the Rail
 Add counter_culture to your Gemfile:
 
 ```ruby
-gem 'counter_culture', '~> 0.1.7'
+gem 'counter_culture', '~> 0.1.17'
 ```
 
 Then run ```bundle update ```

data/VERSION

@@ -1 +1 @@
-0.1.17
+0.1.18

data/counter_culture.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "counter_culture"
-  s.version = "0.1.17"
+  s.version = "0.1.18"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Magnus von Koeller"]
-  s.date = "2013-10-08"
+  s.date = "2013-10-16"
   s.description = "counter_culture provides turbo-charged counter caches that are kept up-to-date not just on create and destroy, that support multiple levels of indirection through relationships, allow dynamic column names and that avoid deadlocks by updating in the after_commit callback."
   s.email = "magnus@vonkoeller.de"
   s.extra_rdoc_files = [

data/lib/counter_culture.rb

@@ -101,7 +101,7 @@ module CounterCulture
             # lives in
             reverse_relation.each do |cur_relation|
               reflect = relation_reflect(cur_relation)
-              counts_query = counts_query.joins("JOIN #{reflect.active_record.table_name} ON #{reflect.table_name}.id = #{reflect.active_record.table_name}.#{reflect.foreign_key}")
+              counts_query = counts_query.joins("LEFT JOIN #{reflect.active_record.table_name} ON #{reflect.table_name}.id = #{reflect.active_record.table_name}.#{reflect.foreign_key}")
             end
 
             # iterate in batches; otherwise we might run out of memory when there's a lot of

data/spec/counter_culture_spec.rb

@@ -1065,6 +1065,24 @@ describe "CounterCulture" do
     SimpleMain.find_each { |main| main.simple_dependents_count.should == 3 }
   end
 
+  it "should correctly fix the counter caches when no dependent record exists for some of main records" do
+    # first, clean up
+    SimpleDependent.delete_all
+    SimpleMain.delete_all
+
+    1000.times do |i|
+      main = SimpleMain.create
+      (main.id % 4).times { main.simple_dependents.create }
+    end
+
+    SimpleMain.find_each { |main| main.simple_dependents_count.should == main.id % 4 }
+
+    SimpleMain.order('random()').limit(50).update_all simple_dependents_count: 1
+    SimpleDependent.counter_culture_fix_counts :batch_size => 100
+
+    SimpleMain.find_each { |main| main.simple_dependents_count.should == main.id % 4 }
+  end
+
   it "should correctly sum up flaot values" do
     user = User.create
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 0.1.17
+  version: 0.1.18
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-08 00:00:00.000000000 Z
+date: 2013-10-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails