counter_culture 0.1.14 → 0.1.15

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 35e696be357c398d2c9bcb23bde8ea01203ddbf8
+  data.tar.gz: 9d11a323ccdcd5e09f18e086e5cd948b0fd7bd36
+SHA512:
+  metadata.gz: d87125c4933ac012ac93e5084079c86b85d1ad2420e04245ecb414f3cd4bb56d9e37b38404270b77061028b067545c0ec15cbf5dbb05ea9ed45942890eabdafe
+  data.tar.gz: a72a586a7ddd60204413200b3897b64bd9ec263dcfe5a0ddd4be525aa68404775e59a3a747724757682f29caf00e3bc304233b9c143b9fc5073f4e288a8e650d

data/.ruby-gemset

@@ -0,0 +1 @@
+counter_culture

data/.ruby-version

@@ -0,0 +1 @@
+2.0.0-p247

data/CHANGELOG.md

@@ -0,0 +1,11 @@
+## 0.1.15 (October 5, 2013)
+
+Features:
+  - Added a simple migration generator to simplify adding counter cache columns
+
+Improvements:
+  - delta_column now supports float values
+
+Bugfixes:
+
+  - Prevent running out of memory when running counter_culture_fix_counts in large tables

data/Gemfile

@@ -1,4 +1,4 @@
-source "http://rubygems.org"
+source "https://rubygems.org"
 # Add dependencies required to use your gem here.
 # Example:
 #   gem "activesupport", ">= 2.3.5"
@@ -9,15 +9,17 @@ group :development, :test do
   gem "rails", '>= 3.1.0'
   gem "rspec", "~> 2.10.0"
   gem "after_commit_action"
+  gem "awesome_print"
 end
 
 group :development do
   gem "rdoc", "~> 3.12"
-  gem "bundler", "~> 1.2.0.pre"
+  gem "bundler", ">= 1.2.0"
   gem "jeweler", "~> 1.8.3"
 end
 
 group :test do
   gem "sqlite3"
   gem "rspec-extra-formatters"
+  gem "database_cleaner", ">= 1.1.1"
 end

data/Gemfile.lock

@@ -1,80 +1,102 @@
 GEM
-  remote: http://rubygems.org/
+  remote: https://rubygems.org/
   specs:
-    actionmailer (3.2.10)
-      actionpack (= 3.2.10)
-      mail (~> 2.4.4)
-    actionpack (3.2.10)
-      activemodel (= 3.2.10)
-      activesupport (= 3.2.10)
-      builder (~> 3.0.0)
+    actionmailer (4.0.0)
+      actionpack (= 4.0.0)
+      mail (~> 2.5.3)
+    actionpack (4.0.0)
+      activesupport (= 4.0.0)
+      builder (~> 3.1.0)
       erubis (~> 2.7.0)
-      journey (~> 1.0.4)
-      rack (~> 1.4.0)
-      rack-cache (~> 1.2)
-      rack-test (~> 0.6.1)
-      sprockets (~> 2.2.1)
-    activemodel (3.2.10)
-      activesupport (= 3.2.10)
-      builder (~> 3.0.0)
-    activerecord (3.2.10)
-      activemodel (= 3.2.10)
-      activesupport (= 3.2.10)
-      arel (~> 3.0.2)
-      tzinfo (~> 0.3.29)
-    activeresource (3.2.10)
-      activemodel (= 3.2.10)
-      activesupport (= 3.2.10)
-    activesupport (3.2.10)
-      i18n (~> 0.6)
-      multi_json (~> 1.0)
+      rack (~> 1.5.2)
+      rack-test (~> 0.6.2)
+    activemodel (4.0.0)
+      activesupport (= 4.0.0)
+      builder (~> 3.1.0)
+    activerecord (4.0.0)
+      activemodel (= 4.0.0)
+      activerecord-deprecated_finders (~> 1.0.2)
+      activesupport (= 4.0.0)
+      arel (~> 4.0.0)
+    activerecord-deprecated_finders (1.0.3)
+    activesupport (4.0.0)
+      i18n (~> 0.6, >= 0.6.4)
+      minitest (~> 4.2)
+      multi_json (~> 1.3)
+      thread_safe (~> 0.1)
+      tzinfo (~> 0.3.37)
+    addressable (2.3.5)
     after_commit_action (0.1.3)
       activerecord (>= 3.0.0)
-    arel (3.0.2)
-    builder (3.0.4)
+    arel (4.0.0)
+    atomic (1.1.14)
+    awesome_print (1.2.0)
+    builder (3.1.4)
+    database_cleaner (1.1.1)
     diff-lcs (1.1.3)
     erubis (2.7.0)
-    git (1.2.5)
-    hike (1.2.1)
-    i18n (0.6.1)
-    jeweler (1.8.4)
+    faraday (0.8.8)
+      multipart-post (~> 1.2.0)
+    git (1.2.6)
+    github_api (0.10.1)
+      addressable
+      faraday (~> 0.8.1)
+      hashie (>= 1.2)
+      multi_json (~> 1.4)
+      nokogiri (~> 1.5.2)
+      oauth2
+    hashie (2.0.5)
+    highline (1.6.19)
+    hike (1.2.3)
+    httpauth (0.2.0)
+    i18n (0.6.5)
+    jeweler (1.8.7)
+      builder
       bundler (~> 1.0)
       git (>= 1.2.5)
+      github_api (= 0.10.1)
+      highline (>= 1.6.15)
+      nokogiri (= 1.5.10)
       rake
       rdoc
-    journey (1.0.4)
-    json (1.7.6)
-    mail (2.4.4)
-      i18n (>= 0.4.0)
+    json (1.8.0)
+    jwt (0.1.8)
+      multi_json (>= 1.5)
+    mail (2.5.4)
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
-    mime-types (1.19)
-    multi_json (1.5.0)
+    mime-types (1.25)
+    minitest (4.7.5)
+    multi_json (1.8.1)
+    multi_xml (0.5.5)
+    multipart-post (1.2.0)
+    nokogiri (1.5.10)
+    oauth2 (0.9.2)
+      faraday (~> 0.8)
+      httpauth (~> 0.2)
+      jwt (~> 0.1.4)
+      multi_json (~> 1.0)
+      multi_xml (~> 0.5)
+      rack (~> 1.2)
     polyglot (0.3.3)
-    rack (1.4.3)
-    rack-cache (1.2)
-      rack (>= 0.4)
-    rack-ssl (1.3.2)
-      rack
+    rack (1.5.2)
     rack-test (0.6.2)
       rack (>= 1.0)
-    rails (3.2.10)
-      actionmailer (= 3.2.10)
-      actionpack (= 3.2.10)
-      activerecord (= 3.2.10)
-      activeresource (= 3.2.10)
-      activesupport (= 3.2.10)
-      bundler (~> 1.0)
-      railties (= 3.2.10)
-    railties (3.2.10)
-      actionpack (= 3.2.10)
-      activesupport (= 3.2.10)
-      rack-ssl (~> 1.3.2)
+    rails (4.0.0)
+      actionmailer (= 4.0.0)
+      actionpack (= 4.0.0)
+      activerecord (= 4.0.0)
+      activesupport (= 4.0.0)
+      bundler (>= 1.3.0, < 2.0)
+      railties (= 4.0.0)
+      sprockets-rails (~> 2.0.0)
+    railties (4.0.0)
+      actionpack (= 4.0.0)
+      activesupport (= 4.0.0)
       rake (>= 0.8.7)
-      rdoc (~> 3.4)
-      thor (>= 0.14.6, < 2.0)
-    rake (10.0.3)
-    rdoc (3.12)
+      thor (>= 0.18.1, < 2.0)
+    rake (10.1.0)
+    rdoc (3.12.2)
       json (~> 1.4)
     rspec (2.10.0)
       rspec-core (~> 2.10.0)
@@ -85,25 +107,33 @@ GEM
       diff-lcs (~> 1.1.3)
     rspec-extra-formatters (1.0.0)
     rspec-mocks (2.10.1)
-    sprockets (2.2.2)
+    sprockets (2.10.0)
       hike (~> 1.2)
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sqlite3 (1.3.6)
-    thor (0.16.0)
-    tilt (1.3.3)
-    treetop (1.4.12)
+    sprockets-rails (2.0.0)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      sprockets (~> 2.8)
+    sqlite3 (1.3.8)
+    thor (0.18.1)
+    thread_safe (0.1.3)
+      atomic
+    tilt (1.4.1)
+    treetop (1.4.15)
       polyglot
       polyglot (>= 0.3.1)
-    tzinfo (0.3.35)
+    tzinfo (0.3.37)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   after_commit_action
-  bundler (~> 1.2.0.pre)
+  awesome_print
+  bundler (>= 1.2.0)
+  database_cleaner (>= 1.1.1)
   jeweler (~> 1.8.3)
   rails (>= 3.1.0)
   rdoc (~> 3.12)

data/README.md

@@ -20,13 +20,19 @@ Then run ```bundle update ```
 
 ## Database Schema
 
-You will need to manually create the necessary columns for all counter caches. Use code like the following in your migration:
+You must create the necessary columns for all counter caches. You can use counter_culture's generator to create a skeleton migration:
+
+```
+rails generate counter_culture Category products_count
+```
+
+Which will generate a migration with code like the following:
 ```ruby
 add_column :categories, :products_count, :integer, :null => false, :default => 0
 ```
-It is important to make the column ```NOT NULL``` and set a default of zero for this gem to work correctly.
+Note that the column must be ```NOT NULL``` and have a default of zero for this gem to work correctly.
 
-If you are adding counter caches to existing data, you must [manually populate their values](#manually-populating-counter-cache-values).
+If you are adding counter caches to existing data, you must add code to [manually populate their values](#manually-populating-counter-cache-values) to the generated migration.
 
 ## Usage
 
@@ -143,6 +149,8 @@ end
 Now, the ```Category``` model will keep the counter cache in ```product_weight_ounces``` up-to-date.
 The value in the counter cache will be the sum of the ```weight_ounces``` values in each of the associated Product records.
 
+The ```:delta_column``` option supports all numeric column types, not just ```:integer```. Specifically, ```:float``` is supported and tested.
+
 ### Dynamically over-writing affected foreign keys
 
 ```ruby
@@ -220,7 +228,13 @@ Manually populating counter caches with dynamicall over-written foreign keys (``
 
 #### Polymorphic associations
 
-counter_culture currently does *not* support polymorphic associations. Check [this issue](https://github.com/bestvendor/counter_culture/issues/4) for progress and alternatives.
+counter_culture currently does *not* support polymorphic associations. Check [this issue](https://github.com/magnusvk/counter_culture/issues/4) for progress and alternatives.
+
+## A note on testing
+
+counter_culture will not update counters in your automated tests *if* you use transactional fixtures. That's because transactional fixtures roll back all your database transactions and they are never committed. But counter_culture will only update its counters in the ```after_commit``` callback, which in this case will never run.
+
+counter_culture itself has extensive automated tests so there should not be a need to test counter caches in your own tests. I therefore recommend removing any checks of counter caches as that will avoid this issue. If that is not an option for you, you will have to turn off transactional fixtures and use something like [database_cleaner](https://github.com/bmabey/database_cleaner) instead to clean your database between tests.
 
 ## Contributing to counter_culture
  
@@ -234,4 +248,4 @@ counter_culture currently does *not* support polymorphic associations. Check [th
 
 ## Copyright
 
-Copyright (c) 2012 BestVendor. See LICENSE.txt for further details.
+Copyright (c) 2012-2013 BestVendor, Magnus von Koeller. See LICENSE.txt for further details.

data/VERSION

@@ -1 +1 @@
-0.1.14
+0.1.15

data/counter_culture.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "counter_culture"
-  s.version = "0.1.14"
+  s.version = "0.1.15"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Magnus von Koeller"]
-  s.date = "2013-08-13"
+  s.date = "2013-10-05"
   s.description = "counter_culture provides turbo-charged counter caches that are kept up-to-date not just on create and destroy, that support multiple levels of indirection through relationships, allow dynamic column names and that avoid deadlocks by updating in the after_commit callback."
   s.email = "magnus@vonkoeller.de"
   s.extra_rdoc_files = [
@@ -19,7 +19,9 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
     ".rspec",
-    ".rvmrc",
+    ".ruby-gemset",
+    ".ruby-version",
+    "CHANGELOG.md",
     "Gemfile",
     "Gemfile.lock",
     "LICENSE.txt",
@@ -29,6 +31,8 @@ Gem::Specification.new do |s|
     "circle.yml",
     "counter_culture.gemspec",
     "lib/counter_culture.rb",
+    "lib/generators/counter_culture_generator.rb",
+    "lib/generators/templates/counter_culture_migration.rb.erb",
     "spec/counter_culture_spec.rb",
     "spec/models/category.rb",
     "spec/models/company.rb",
@@ -36,6 +40,8 @@ Gem::Specification.new do |s|
     "spec/models/industry.rb",
     "spec/models/product.rb",
     "spec/models/review.rb",
+    "spec/models/simple_dependent.rb",
+    "spec/models/simple_main.rb",
     "spec/models/user.rb",
     "spec/rails_app/.gitignore",
     "spec/rails_app/Gemfile",
@@ -91,26 +97,28 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/bestvendor/counter_culture"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.25"
+  s.rubygems_version = "2.0.7"
   s.summary = "Turbo-charged counter caches for your Rails app."
 
   if s.respond_to? :specification_version then
-    s.specification_version = 3
+    s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
       s.add_development_dependency(%q<rails>, [">= 3.1.0"])
       s.add_development_dependency(%q<rspec>, ["~> 2.10.0"])
       s.add_development_dependency(%q<after_commit_action>, [">= 0"])
+      s.add_development_dependency(%q<awesome_print>, [">= 0"])
       s.add_development_dependency(%q<rdoc>, ["~> 3.12"])
-      s.add_development_dependency(%q<bundler>, ["~> 1.2.0.pre"])
+      s.add_development_dependency(%q<bundler>, [">= 1.2.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.8.3"])
       s.add_runtime_dependency(%q<after_commit_action>, ["~> 0.1.3"])
     else
       s.add_dependency(%q<rails>, [">= 3.1.0"])
       s.add_dependency(%q<rspec>, ["~> 2.10.0"])
       s.add_dependency(%q<after_commit_action>, [">= 0"])
+      s.add_dependency(%q<awesome_print>, [">= 0"])
       s.add_dependency(%q<rdoc>, ["~> 3.12"])
-      s.add_dependency(%q<bundler>, ["~> 1.2.0.pre"])
+      s.add_dependency(%q<bundler>, [">= 1.2.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.8.3"])
       s.add_dependency(%q<after_commit_action>, ["~> 0.1.3"])
     end
@@ -118,8 +126,9 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<rails>, [">= 3.1.0"])
     s.add_dependency(%q<rspec>, ["~> 2.10.0"])
     s.add_dependency(%q<after_commit_action>, [">= 0"])
+    s.add_dependency(%q<awesome_print>, [">= 0"])
     s.add_dependency(%q<rdoc>, ["~> 3.12"])
-    s.add_dependency(%q<bundler>, ["~> 1.2.0.pre"])
+    s.add_dependency(%q<bundler>, [">= 1.2.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.8.3"])
     s.add_dependency(%q<after_commit_action>, ["~> 0.1.3"])
   end

data/lib/counter_culture.rb

@@ -75,10 +75,11 @@ module CounterCulture
           klass = relation_klass(hash[:relation])
 
           # we are only interested in the id and the count of related objects (that's this class itself)
-          query = hash[:delta_column] \
-            ? klass.select("#{klass.table_name}.id, SUM(COALESCE(#{self.table_name}.#{hash[:delta_column]},0)) AS count") \
-            : klass.select("#{klass.table_name}.id, COUNT(#{self.table_name}.id                              ) AS count")
-          query = query.group("#{klass.table_name}.id")
+          if hash[:delta_column]
+            query = klass.select("#{klass.table_name}.id, SUM(COALESCE(#{self.table_name}.#{hash[:delta_column]},0)) AS count")
+          else
+            query = klass.select("#{klass.table_name}.id, COUNT(#{self.table_name}.id                              ) AS count")
+          end
           # respect the deleted_at column if it exists
           query = query.where("#{self.table_name}.deleted_at IS NULL") if self.column_names.include?('deleted_at')
 
@@ -88,7 +89,7 @@ module CounterCulture
           # iterate over all the possible counter cache column names
           column_names.each do |where, column_name|
             # if there are additional conditions, add them here
-            counts = query.where(where)
+            counts_query = query.where(where)
 
             # we need to work our way back from the end-point of the relation to this class itself;
             # make a list of arrays pointing to the second-to-last, third-to-last, etc.
@@ -99,27 +100,36 @@ module CounterCulture
             # lives in
             reverse_relation.each do |cur_relation|
               reflect = relation_reflect(cur_relation)
-              counts = counts.joins("JOIN #{reflect.active_record.table_name} ON #{reflect.table_name}.id = #{reflect.active_record.table_name}.#{reflect.foreign_key}")
+              counts_query = counts_query.joins("JOIN #{reflect.active_record.table_name} ON #{reflect.table_name}.id = #{reflect.active_record.table_name}.#{reflect.foreign_key}")
             end
-            # and then we collect the counts in an id => count hash
-            counts = counts.inject({}){|memo, model| memo[model.id] = model.count.to_i; memo}
-
-            # now that we know what the correct counts are, we need to iterate over all instances
-            # and check whether the count is correct; if not, we correct it
-            klass.find_each do |model|
-              if model.read_attribute(column_name) != counts[model.id].to_i
-                # keep track of what we fixed, e.g. for a notification email
-                fixed<< {
-                  :entity => klass.name,
-                  :id => model.id,
-                  :what => column_name,
-                  :wrong => model.send(column_name),
-                  :right => counts[model.id]
-                }
-                # use update_all because it's faster and because a fixed counter-cache shouldn't
-                # update the timestamp
-                klass.where(:id => model.id).update_all(column_name => counts[model.id].to_i)
+
+            # iterate in batches; otherwise we might run out of memory when there's a lot of
+            # instances and we try to load all their counts at once
+            start = 0
+            batch_size = options[:batch_size] || 1000
+            while (records = klass.reorder(full_primary_key(klass) + " ASC").offset(start).limit(batch_size)).any?
+              # collect the counts for this batch in an id => count hash; this saves time relative
+              # to running one query per record
+              counts = counts_query.reorder(full_primary_key(klass) + " ASC").offset(start).limit(batch_size).group(full_primary_key(klass)).inject({}){|memo, model| memo[model.id] = model.count.to_i; memo}
+
+              # now iterate over all the models and see whether their counts are right
+              records.each do |model|
+                if model.read_attribute(column_name) != counts[model.id].to_i
+                  # keep track of what we fixed, e.g. for a notification email
+                  fixed<< {
+                    :entity => klass.name,
+                    :id => model.id,
+                    :what => column_name,
+                    :wrong => model.send(column_name),
+                    :right => counts[model.id]
+                  }
+                  # use update_all because it's faster and because a fixed counter-cache shouldn't
+                  # update the timestamp
+                  klass.where(:id => model.id).update_all(column_name => counts[model.id].to_i)
+                end
               end
+
+              start += batch_size
             end
           end
         end
@@ -128,6 +138,11 @@ module CounterCulture
       end
 
       private
+      # the string to pass to order() in order to sort by primary key
+      def full_primary_key(klass)
+        "#{klass.quoted_table_name}.#{klass.quoted_primary_key}"
+      end
+
       # gets the reflect object on the given relation
       #
       # relation: a symbol or array of symbols; specifies the relation
@@ -254,7 +269,7 @@ module CounterCulture
       if id_to_change && options[:counter_column]
         delta_magnitude = if options[:delta_column]
                             delta_attr_name = options[:was] ? "#{options[:delta_column]}_was" : options[:delta_column]
-                            self.send(delta_attr_name).to_i
+                            self.send(delta_attr_name) || 0
                           else
                             1
                           end

data/lib/generators/counter_culture_generator.rb

@@ -0,0 +1,31 @@
+require 'rails/generators/active_record'
+
+class CounterCultureGenerator < ActiveRecord::Generators::Base
+
+  desc "Create a migration that adds counter-cache columns to a model"
+
+  argument :counter_cache_columns, :required => true, :type => :array, 
+    :desc => "The names of the counter cache columns to add",
+    :banner => "counter_cache_one counter_cache_two counter_cache_three ..."
+
+  source_root File.expand_path("../templates", __FILE__)
+
+  def generate_migration
+    migration_template "counter_culture_migration.rb.erb", "db/migrate/#{migration_file_name}"
+  end
+
+  protected
+
+  def migration_name
+    "add_#{counter_cache_columns.join("_")}_to_#{name.underscore.pluralize}"
+  end
+
+  def migration_file_name
+    "#{migration_name}.rb"
+  end
+
+  def migration_class_name
+    migration_name.camelize
+  end
+
+end

data/lib/generators/templates/counter_culture_migration.rb.erb

@@ -0,0 +1,15 @@
+class <%= migration_class_name %> < ActiveRecord::Migration
+
+  def self.up
+<% counter_cache_columns.each do |column| %>
+    add_column :<%= table_name %>, :<%= column %>, :integer, :null => false, :default => 0
+<% end %>
+  end
+
+  def self.down
+<% counter_cache_columns.each do |column| %>
+    remove_column :<%= table_name %>, :<%= column %>
+<% end %>
+  end
+
+end

data/spec/counter_culture_spec.rb

@@ -7,8 +7,17 @@ require 'models/review'
 require 'models/user'
 require 'models/category'
 require 'models/has_string_id'
+require 'models/simple_main'
+require 'models/simple_dependent'
+
+require 'database_cleaner'
+DatabaseCleaner.strategy = :deletion
 
 describe "CounterCulture" do
+  before(:each) do
+    DatabaseCleaner.clean
+  end
+
   it "increments counter cache on create" do
     user = User.create
     product = Product.create
@@ -950,7 +959,7 @@ describe "CounterCulture" do
   end
 
   it "should fix a string counter cache correctly" do
-    string_id = HasStringId.create({:id => "bbb"}, :without_protection => true)
+    string_id = HasStringId.create({:id => "bbb"})
 
     user = User.create :has_string_id_id => string_id.id
 
@@ -1000,8 +1009,8 @@ describe "CounterCulture" do
   end
 
   it "should work correctly with string keys" do
-    string_id = HasStringId.create({:id => "1"}, :without_protection => true)
-    string_id2 = HasStringId.create({:id => "abc"}, :without_protection => true)
+    string_id = HasStringId.create(id: "1")
+    string_id2 = HasStringId.create(id: "abc")
 
     user = User.create :has_string_id_id => string_id.id
 
@@ -1037,6 +1046,58 @@ describe "CounterCulture" do
   it "should raise a good error message when calling fix_counts with no caches defined" do
     expect { Category.counter_culture_fix_counts }.to raise_error "No counter cache defined on Category"
   end
+
+  it "should correctly fix the counter caches with thousands of records" do
+    # first, clean up
+    SimpleDependent.delete_all
+    SimpleMain.delete_all
+    
+    10000.times do |i|
+      main = SimpleMain.create
+      3.times { main.simple_dependents.create }
+    end
+
+    SimpleMain.find_each { |main| main.simple_dependents_count.should == 3 }
+
+    SimpleMain.order('random()').limit(50).update_all simple_dependents_count: 1
+    SimpleDependent.counter_culture_fix_counts
+
+    SimpleMain.find_each { |main| main.simple_dependents_count.should == 3 }
+  end
+
+  it "should correctly sum up flaot values" do
+    user = User.create
+
+    r1 = Review.create :user_id => user.id, :value => 3.4
+
+    user.reload
+    user.review_value_sum.round(1).should == 3.4
+
+    r2 = Review.create :user_id => user.id, :value => 7.2
+
+    user.reload
+    user.review_value_sum.round(1).should == 10.6
+
+    r3 = Review.create :user_id => user.id, :value => 5
+
+    user.reload
+    user.review_value_sum.round(1).should == 15.6
+
+    r2.destroy
+
+    user.reload
+    user.review_value_sum.round(1).should == 8.4
+
+    r3.destroy
+
+    user.reload
+    user.review_value_sum.round(1).should == 3.4
+
+    r1.destroy
+
+    user.reload
+    user.review_value_sum.round(1).should == 0
+  end
   
   describe "#previous_model" do
     let(:user){User.create :name => "John Smith", :manages_company_id => 1}

data/spec/models/has_string_id.rb

@@ -1,4 +1,4 @@
 class HasStringId < ActiveRecord::Base
-  set_primary_key :id
+  self.primary_key = :id
   has_many :users
 end

data/spec/models/review.rb

@@ -7,6 +7,7 @@ class Review < ActiveRecord::Base
   counter_culture :user
   counter_culture :user, :column_name => Proc.new { |model| model.review_type ? "#{model.review_type}_count" : nil }, :column_names => {"reviews.review_type = 'using'" => 'using_count', "reviews.review_type = 'tried'" => 'tried_count'}
   counter_culture :user, :column_name => 'review_approvals_count', :delta_column => 'approvals'
+  counter_culture :user, :column_name => 'review_value_sum', :delta_column => 'value'
   counter_culture [:user, :manages_company]
   counter_culture [:user, :manages_company], :column_name => 'review_approvals_count', :delta_column => 'approvals'
   counter_culture [:user, :manages_company, :industry]

data/spec/models/simple_dependent.rb

@@ -0,0 +1,5 @@
+class SimpleDependent < ActiveRecord::Base
+  belongs_to :simple_main
+
+  counter_culture :simple_main
+end

data/spec/models/simple_main.rb

@@ -0,0 +1,3 @@
+class SimpleMain < ActiveRecord::Base
+  has_many :simple_dependents
+end

data/spec/schema.rb

@@ -45,6 +45,7 @@ ActiveRecord::Schema.define(:version => 20120522160158) do
     t.integer  "user_id"
     t.integer  "product_id"
     t.integer  "approvals"
+    t.float    "value"
   end
 
   create_table "users", :force => true do |t|
@@ -56,6 +57,7 @@ ActiveRecord::Schema.define(:version => 20120522160158) do
     t.integer  "tried_count",         :default => 0, :null => false
     t.integer  "review_approvals_count",      :default => 0, :null => false
     t.string   "has_string_id_id"
+    t.float    "review_value_sum",    :default => 0.0, :null => false
   end
 
   create_table "categories", :force => true do |t|
@@ -70,4 +72,12 @@ ActiveRecord::Schema.define(:version => 20120522160158) do
   end
   add_index "has_string_ids", :id, :unique => true
 
+  create_table "simple_mains", :force => true do |t|
+    t.integer "simple_dependents_count", :null => false, :default => 0
+  end
+  
+  create_table "simple_dependents", :force => true do |t|
+    t.integer "simple_main_id"
+  end
+
 end

metadata

@@ -1,36 +1,32 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 0.1.14
-  prerelease: 
+  version: 0.1.15
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-13 00:00:00.000000000 Z
+date: 2013-10-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -46,23 +41,34 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: after_commit_action
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: awesome_print
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -70,7 +76,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -78,23 +83,20 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.2.0.pre
+        version: 1.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - '>='
       - !ruby/object:Gem::Version
-        version: 1.2.0.pre
+        version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -102,7 +104,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -110,7 +111,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: after_commit_action
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -118,7 +118,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -136,7 +135,9 @@ extra_rdoc_files:
 files:
 - .document
 - .rspec
-- .rvmrc
+- .ruby-gemset
+- .ruby-version
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -146,6 +147,8 @@ files:
 - circle.yml
 - counter_culture.gemspec
 - lib/counter_culture.rb
+- lib/generators/counter_culture_generator.rb
+- lib/generators/templates/counter_culture_migration.rb.erb
 - spec/counter_culture_spec.rb
 - spec/models/category.rb
 - spec/models/company.rb
@@ -153,6 +156,8 @@ files:
 - spec/models/industry.rb
 - spec/models/product.rb
 - spec/models/review.rb
+- spec/models/simple_dependent.rb
+- spec/models/simple_main.rb
 - spec/models/user.rb
 - spec/rails_app/.gitignore
 - spec/rails_app/Gemfile
@@ -207,29 +212,25 @@ files:
 homepage: http://github.com/bestvendor/counter_culture
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1126156113488497245
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.7
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Turbo-charged counter caches for your Rails app.
 test_files: []

data/.rvmrc

@@ -1 +0,0 @@
-rvm 1.9.3@counter_culture