counter_culture 3.10.0 → 3.10.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 78d568cfdb319852f7cbfa1f09b3b17d7a583f0a56afcba26ffc6db937906c0f
-  data.tar.gz: 220516dcbbe2966749fd1c74a6720e9bb82565bba0b41f053fc94c9948db4b73
+  metadata.gz: dc2af460731ae5d0d71c452bff1969ede450961b0383de35624015058e73bbce
+  data.tar.gz: fe4cd5de448b52f11b2b5d9409202ad115bb6e87d5008ed83eb3708fbd177745
 SHA512:
-  metadata.gz: 5fb91dc191fad8487358613ac76eae7887113b7191ced1b59acde6a84963c2813787c1036a07490f4579e423bb9cedcf3ba324b6d2f4e1cac903cf5721949445
-  data.tar.gz: c86cf4baee69aceec50718877ab0fd9ff6064bd460d4f0fff8615eb0836cc5c3d74e44178fbd87976a7eab18a106a5f25e09179a85380a93472cbf1e715f14ce
+  metadata.gz: 360b2c83a7e377c2a9974cfbd812d5df0f0d3921c93aabf5b4c0426e5f7aab156fe1cd7350607be17694b243f6cc823000b8eb2bb342fb65401ce9071dcc688e
+  data.tar.gz: 39a199f34ca2275c4804ab1f03a0dac80105675ef43dc473f3d9d4c479b57eb7088d32a36a67a47df00ae26e1d81d3454cf0de465209d357c181cca66de18d1c

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 3.10.2 (June 24, 2025)
+
+Bugfixes:
+  - Fix incorrect in-memory counter updates on `belongs_to` association (#415)
+
+## 3.10.1 (April 30, 2025)
+
+Bugfixes:
+  - Fix issue when using `delegate` instead of `has_many :through` (#411)
+
 ## 3.10.0 (April 15, 2025)
 
 New features:

data/lib/counter_culture/counter.rb

@@ -138,7 +138,9 @@ module CounterCulture
         unless Thread.current[:aggregate_counter_updates]
           execute_now_or_after_commit(obj) do
             klass.where(primary_key => id_to_change).update_all updates.join(', ')
-            assign_to_associated_object(obj, relation, change_counter_column, operator, delta_magnitude)
+            unless options[:was]
+              assign_to_associated_object(obj, relation, change_counter_column, operator, delta_magnitude)
+            end
           end
         end
       end
@@ -370,15 +372,31 @@ module CounterCulture
     def assign_to_associated_object(obj, relation, change_counter_column, operator, delta_magnitude)
       association_name = relation_reflect(relation).name
 
-      return unless obj.respond_to?(association_name)
+      association_object = association_object_for_assign(obj, association_name)
+      return if association_object.blank?
 
-      if obj.association(association_name).loaded? && (association_object = obj.public_send(association_name)).present?
-        association_object.assign_attributes(
-          change_counter_column =>
-            association_object_new_counter(association_object, change_counter_column, operator, delta_magnitude)
-        )
-        association_object_clear_change(association_object, change_counter_column)
+      association_object.assign_attributes(
+        change_counter_column =>
+          association_object_new_counter(association_object, change_counter_column, operator, delta_magnitude)
+      )
+      association_object_clear_change(association_object, change_counter_column)
+    end
+
+    def association_object_for_assign(obj, association_name)
+      if obj.class.reflect_on_all_associations.
+          find { |assoc| assoc.name.to_sym == association_name.to_sym }.
+          blank?
+        # This means that this isn't defined as an association; either it
+        # doesn't exist at all, or it uses delegate. In either case, we can't
+        # update the count this way.
+        return
+      end
+      if !obj.association(association_name).loaded?
+        # If the association isn't loaded, no need to update the count
+        return
       end
+
+      obj.public_send(association_name)
     end
 
     def association_object_clear_change(association_object, change_counter_column)

data/lib/counter_culture/version.rb

@@ -1,3 +1,3 @@
 module CounterCulture
-  VERSION = '3.10.0'.freeze
+  VERSION = '3.10.2'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 3.10.0
+  version: 3.10.2
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-15 00:00:00.000000000 Z
+date: 2025-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord