counter_culture 0.1.32 → 0.1.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c76907944f824031e31fcc691b102507788efae1
-  data.tar.gz: 284f75c98c1fdc54a9184abdeb4bef21966eb87f
+  metadata.gz: 5355b1fef2ee6bc80493e05f067a467e2aee9655
+  data.tar.gz: d17dc9165689f705528785d33a4f9b42c35f1314
 SHA512:
-  metadata.gz: 43598278f71d3711c3c767c89bdf766b2c9388ed32f81900b7f934d705df7ba5f7c53e4cde6fe2401528fda002036133a6123cd27e0ffbed6f8846f2801e89ab
-  data.tar.gz: 1f42db9e571e7939c139ca6e8d591e9a8430e8512cb831942edb6e0612637f4b23ca027b9320f017ac9531d8702a183554878e028b00de24d8c4701d32a2007d
+  metadata.gz: 18becb6b285ee801e83659721a214444c5a5e3c52cee77d310432a1e52b68a0de4373afe0c4f5854c469c6d431cf03b4ee2f510c4aa5190fe076ab1b2f2b7039
+  data.tar.gz: 09015b5df2ef84c6fb5c42e6316f6016e654586cf4b860be199384bb03db370ff0cdf4c5e1c0d1f01b51fcf8405f135ab5324d8bf4ca04b161a9a585c920b1de

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.1.33 (April 2, 2015)
+
+Bugfixes:
+  - Fixes an issue with STI classes and inheritance
+
 ## 0.1.32 (March 16, 2015)
 
 Improvements:

data/VERSION

@@ -1 +1 @@
-0.1.32
+0.1.33

data/counter_culture.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: counter_culture 0.1.32 ruby lib
+# stub: counter_culture 0.1.33 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "counter_culture"
-  s.version = "0.1.32"
+  s.version = "0.1.33"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Magnus von Koeller"]
-  s.date = "2015-03-17"
+  s.date = "2015-04-02"
   s.description = "counter_culture provides turbo-charged counter caches that are kept up-to-date not just on create and destroy, that support multiple levels of indirection through relationships, allow dynamic column names and that avoid deadlocks by updating in the after_commit callback."
   s.email = "magnus@vonkoeller.de"
   s.extra_rdoc_files = [
@@ -52,6 +52,7 @@ Gem::Specification.new do |s|
     "spec/models/review.rb",
     "spec/models/simple_dependent.rb",
     "spec/models/simple_main.rb",
+    "spec/models/simple_review.rb",
     "spec/models/subcateg.rb",
     "spec/models/twitter_review.rb",
     "spec/models/user.rb",
@@ -108,7 +109,7 @@ Gem::Specification.new do |s|
   ]
   s.homepage = "http://github.com/bestvendor/counter_culture"
   s.licenses = ["MIT"]
-  s.rubygems_version = "2.4.3"
+  s.rubygems_version = "2.2.2"
   s.summary = "Turbo-charged counter caches for your Rails app."
 
   if s.respond_to? :specification_version then

data/lib/counter_culture.rb

@@ -13,7 +13,13 @@ module CounterCulture
 
     module ClassMethods
       # this holds all configuration data
-      attr_reader :after_commit_counter_cache
+      def after_commit_counter_cache
+        config = @after_commit_counter_cache || []
+        if superclass.respond_to?(:after_commit_counter_cache) && superclass.after_commit_counter_cache
+          config = superclass.after_commit_counter_cache + config
+        end
+        config
+      end
 
       # called to configure counter caches
       def counter_culture(relation, options = {})

data/spec/counter_culture_spec.rb

@@ -4,6 +4,7 @@ require 'models/company'
 require 'models/industry'
 require 'models/product'
 require 'models/review'
+require 'models/simple_review'
 require 'models/twitter_review'
 require 'models/user'
 require 'models/category'
@@ -936,7 +937,7 @@ describe "CounterCulture" do
     company.save!
     product.save!
 
-    TwitterReview.counter_culture_fix_counts
+    TwitterReview.counter_culture_fix_counts :skip_unsupported => true
 
     company.reload
     product.reload
@@ -945,6 +946,21 @@ describe "CounterCulture" do
     product.twitter_reviews_count.should == 1
   end
 
+  it "handles an inherited STI counter cache correctly" do
+    company = Company.create
+    user = User.create :manages_company_id => company.id
+    product = Product.create
+    SimpleReview.create :user_id => user.id, :product_id => product.id
+    product.reload
+    product.reviews_count.should == 1
+    product.simple_reviews_count.should == 1
+
+    Review.create :user_id => user.id, :product_id => product.id
+    product.reload
+    product.reviews_count.should == 2
+    product.simple_reviews_count.should == 1
+  end
+
   it "should fix a second-level counter cache correctly" do
     company = Company.create
     user = User.create :manages_company_id => company.id

data/spec/models/simple_review.rb

@@ -0,0 +1,3 @@
+class SimpleReview < Review
+  counter_culture :product
+end

data/spec/schema.rb

@@ -41,8 +41,9 @@ ActiveRecord::Schema.define(:version => 20120522160158) do
 
   create_table "products", :force => true do |t|
     t.string   "name"
-    t.integer  "reviews_count",       :default => 0, :null => false
-    t.integer  "rexiews_count",       :default => 0, :null => false
+    t.integer  "reviews_count",               :default => 0, :null => false
+    t.integer  "simple_reviews_count",        :default => 0, :null => false
+    t.integer  "rexiews_count",               :default => 0, :null => false
     t.integer  "twitter_reviews_count",       :default => 0, :null => false
     t.integer  "category_id"
     t.datetime "created_at"

data/spec/spec_helper.rb

@@ -19,4 +19,6 @@ ActiveRecord::Base.logger.level = 1
 
 RSpec.configure do |config|
   config.fail_fast = true
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: counter_culture
 version: !ruby/object:Gem::Version
-  version: 0.1.32
+  version: 0.1.33
 platform: ruby
 authors:
 - Magnus von Koeller
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-17 00:00:00.000000000 Z
+date: 2015-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: after_commit_action
@@ -194,6 +194,7 @@ files:
 - spec/models/review.rb
 - spec/models/simple_dependent.rb
 - spec/models/simple_main.rb
+- spec/models/simple_review.rb
 - spec/models/subcateg.rb
 - spec/models/twitter_review.rb
 - spec/models/user.rb
@@ -267,7 +268,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Turbo-charged counter caches for your Rails app.