couchbase 1.3.4 → 1.3.5

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    MzUyYTFlYjFlYTg1MWQ3Y2E2YWViNmRjZTc3MTZmNzZjMDBkZThiZg==
-  data.tar.gz: !binary |-
-    ZGM2ZDgwNGI5NTE0YWZkODJkZTlmOWFlMWU3NWIzMzY4MTExNmE1YQ==
+SHA1:
+  metadata.gz: 997ac87419c7305101ce2f9c13e90c90ba7ad648
+  data.tar.gz: b59ac0259606d777c9025701da72ec9f72d0d8b4
 SHA512:
-  metadata.gz: !binary |-
-    YzFjNmM4ZDFkMGIyZDk0YzQ0ZGIzZDY0OGVlNGZhNjEwNDIyY2M0NDdlYTZj
-    MTIwZTRlMGQ1MWEzNzc0OTNlZTU1YjUzNjY5OTNlZTZjNDYxNTVkYzc1ZDBk
-    MzJiZWQ1M2Y2MmZiNDc3YzU1MGRiNWRlOTQ3ZTVmMDI3OTQ4OTk=
-  data.tar.gz: !binary |-
-    NDdkMTRhYjEyMDcxMmQ0MzY4ODM4Mjk1ZDY2NDZiZWM0YmYwNzQ4NzEyMjY2
-    OGQ0NzdmYTM4ZTQzNzczYjkxNWFlZTQ4NjIwZDdmMGUxYTRiYTE2OGVkNWFk
-    YWUzMjRlZGQ4NTUxY2NkNzFkYTBjODlhYzY3YWFiYTkwODY4ZWU=
+  metadata.gz: a09a68fc64b558e17f1d0fc51e26f08f9a101b845da4240b4dd46e282c74e253062ba73325311d89d487a8b517a75186192fb338dd23072475969fcf8a17ee48
+  data.tar.gz: 23e9e3e6cf81fdb10ca726506e5f15a257aab9da39fb8fe39cc8361eaf64ead695b58740bcfd6605c85a4175c0294dbf5a8d2153cf8aa13317241566415ce3d7

data/README.markdown

@@ -9,10 +9,10 @@ are related libraries available:
 ## SUPPORT
 
 If you find an issue, please file it in our [JIRA][1]. Also you are
-always welcome on the `#libcouchbase` channel at [freenode.net IRC servers][2].
+always welcome on the `#libcouchbase` channel at [freenode.net IRC
+servers][2]. Checkout [library overview][overview] and [API
+documentation][api].
 
-Documentation: [http://docs.couchbase.com/couchbase-sdk-ruby-1.3/](http://docs.couchbase.com/couchbase-sdk-ruby-1.3/)
-API Documentation: [http://www.couchbase.com/autodocs/](http://www.couchbase.com/autodocs/)
 
 ## INSTALL
 
@@ -95,6 +95,9 @@ Now install the couchbase gem itself
 
     $ gem install couchbase
 
+The library verified with all major ruby versions: 1.8.7, 1.9.3, 2.0,
+2.1.
+
 ## USAGE
 
 First, you need to load the library:
@@ -635,6 +638,8 @@ task and you will find all artifacts in `pkg/` directory:
     pkg/couchbase-1.3.4-x86-mingw32.gem
 
 
+[api]: http://www.couchbase.com/autodocs/couchbase-ruby-client-1.3.4/index.html
+[overview]: http://docs.couchbase.com/couchbase-sdk-ruby-1.3/index.html
 [1]: http://couchbase.com/issues/browse/RCBC
 [2]: http://freenode.net/irc_servers.shtml
 [3]: http://www.couchbase.com/develop/c/current

data/RELEASE_NOTES.markdown

@@ -3,6 +3,24 @@
 This document is a list of user visible feature changes and important
 bugfixes. Do not forget to update this doc in every important patch.
 
+## 1.3.5 (2014-02-05)
+
+* [major] RCBC-159, RCBC-152 Honor the :environment constructor argument
+
+* [major] Allow inheritance from `Couchbase::Bucket`. It wasn't
+  possible to create a view with subclass of the `Couchbase::Bucket`.
+
+* [major] Ensure that an exception raised early will not prevent the
+  finalizer from being called in the underlying client being constructed.
+  One example situation where this could occur:
+
+        class Couchbase::Bucket
+          def initialize(*args)
+            raise "something wrong"
+            super
+          end
+        end
+
 ## 1.3.4 (2014-01-08)
 
 * [major] Build 64-bit versions of the extensions for Windows

data/ext/couchbase_ext/arithmetic.c

@@ -136,10 +136,9 @@ cb_bucket_arithmetic(int sign, int argc, VALUE *argv, VALUE self)
  * provided at the protocol level. This simplifies what would otherwise be a
  * two-stage get and set operation.
  *
- * @note that server values stored and transmitted as unsigned numbers,
- *   therefore if you try to store negative number and then increment or
- *   decrement it will cause overflow. (see "Integer overflow" example
- *   below)
+ * @note that server treats values as unsigned numbers, therefore if
+ * you try to store negative number and then increment or decrement it
+ * will cause overflow. (see "Integer overflow" example below)
  *
  * @overload incr(key, delta = 1, options = {})
  *   @param key [String, Symbol] Key used to reference the value.
@@ -194,6 +193,16 @@ cb_bucket_arithmetic(int sign, int argc, VALUE *argv, VALUE self)
  *     c.set("foo", -100)
  *     c.get("foo")           #=> -100
  *     c.incr("foo")          #=> 18446744073709551517
+ *     # but it might look like working
+ *     c.set("foo", -2)
+ *     c.get("foo")           #=> -2
+ *     c.incr("foo", 2)       #=> 0
+ *     # on server:
+ *     #    // UINT64_MAX is 18446744073709551615
+ *     #    uint64_t num = atoll("-2");
+ *     #    // num is 18446744073709551614
+ *     #    num += 2
+ *     #    // num is 0
  *
  *   @example Asynchronous invocation
  *     c.run do

data/ext/couchbase_ext/bucket.c

@@ -69,7 +69,9 @@ cb_bucket_free(void *ptr)
             lcb_destroy(bucket->handle);
             lcb_destroy_io_ops(bucket->io);
         }
-        st_free_table(bucket->object_space);
+        if (bucket->object_space) {
+            st_free_table(bucket->object_space);
+        }
         xfree(bucket);
     }
 }
@@ -242,6 +244,7 @@ do_scan_connection_options(struct cb_bucket_st *bucket, int argc, VALUE *argv)
             if (arg != Qundef) {
                 cb_bucket_transcoder_set(bucket->self, arg);
             }
+            arg = rb_hash_aref(opts, cb_sym_environment);
             if (arg != Qnil) {
                 if (arg == cb_sym_production || arg == cb_sym_development) {
                     bucket->environment = arg;

data/ext/couchbase_ext/http.c

@@ -206,7 +206,7 @@ cb_http_request_init(int argc, VALUE *argv, VALUE self)
     if (NIL_P(on_body) && rb_block_given_p()) {
         on_body = rb_block_proc();
     }
-    if (CLASS_OF(bucket) != cb_cBucket) {
+    if (!RTEST(rb_obj_is_kind_of(bucket, cb_cBucket))) {
         rb_raise(rb_eTypeError, "wrong argument type (expected Couchbase::Bucket)");
     }
     memset(&request->cmd, 0, sizeof(lcb_http_cmd_t));

data/ext/couchbase_ext/result.c

@@ -62,7 +62,7 @@ cb_result_inspect(VALUE self)
     }
 
     attr = rb_attr_get(self, cb_id_iv_value);
-    if (RTEST(attr) && rb_obj_is_kind_of(attr, cb_cBucket)) {
+    if (RTEST(attr) && RTEST(rb_obj_is_kind_of(attr, cb_cBucket))) {
         rb_str_buf_cat2(str, " bucket="); /* value also accessible using alias #bucket */
         rb_str_append(str, rb_inspect(attr));
     }

data/ext/couchbase_ext/timer.c

@@ -169,7 +169,7 @@ cb_timer_init(int argc, VALUE *argv, VALUE self)
     rb_need_block();
     rb_scan_args(argc, argv, "21&", &bucket, &timeout, &opts, &cb);
 
-    if (CLASS_OF(bucket) != cb_cBucket) {
+    if (!RTEST(rb_obj_is_kind_of(bucket, cb_cBucket))) {
         rb_raise(rb_eTypeError, "wrong argument type (expected Couchbase::Bucket)");
     }
     tm->self = self;

data/lib/couchbase/version.rb

@@ -17,5 +17,5 @@
 
 # Couchbase ruby client
 module Couchbase
-  VERSION = "1.3.4"
+  VERSION = "1.3.5"
 end

data/test/test_bucket.rb

@@ -247,4 +247,30 @@ class TestBucket < MiniTest::Test
     GC.start # make sure it won't touch handle in finalizer
   end
 
+  def test_it_accepts_environment_option
+    with_mock do |mock|
+      connection = Couchbase.new(:hostname => mock.host,
+                                 :port => mock.port,
+                                 :environment => :development)
+      assert_equal :development, connection.environment
+    end
+  end
+
+  def test_it_defaults_to_production_environment
+    with_mock do |mock|
+      connection = Couchbase.new(:hostname => mock.host,
+                                 :port => mock.port)
+      assert_equal :production, connection.environment
+    end
+  end
+
+  def test_it_uses_default_environment_if_unknown_was_specified
+    with_mock do |mock|
+      connection = Couchbase.new(:hostname => mock.host,
+                                 :port => mock.port,
+                                 :environment => :foobar)
+      assert_equal :production, connection.environment
+    end
+  end
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: couchbase
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.3.5
 platform: ruby
 authors:
 - Couchbase
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-08 00:00:00.000000000 Z
+date: 2014-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yaji
@@ -17,7 +17,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.3'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.3.2
   type: :runtime
@@ -27,7 +27,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.3'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.3.2
 - !ruby/object:Gem::Dependency
@@ -51,7 +51,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.0
   type: :runtime
@@ -61,21 +61,21 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -85,7 +85,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '5.0'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 5.0.4
   type: :development
@@ -95,7 +95,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '5.0'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 5.0.4
 - !ruby/object:Gem::Dependency
@@ -105,7 +105,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.7.5
   type: :development
@@ -115,7 +115,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.7.5
 - !ruby/object:Gem::Dependency
@@ -125,7 +125,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.5'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.5.2
   type: :development
@@ -135,7 +135,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.5'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 0.5.2
 - !ruby/object:Gem::Dependency
@@ -145,7 +145,7 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.1'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.0
   type: :development
@@ -155,35 +155,35 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '1.1'
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: active_support
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: eventmachine
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: The official client library for use with Couchbase Server.
@@ -293,17 +293,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.1
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Couchbase ruby driver