couch_potato 1.1.0 → 1.1.1

data/CHANGES.md

@@ -1,5 +1,9 @@
 ## Changes
 
+### 1.1.1
+
+* fixes properties were leaked to sibling classes (Alexander Lang)
+
 ### 1.1.0
 
 * adds conflict handling for Database#save/destroy (Alexander Lang)

data/lib/couch_potato/persistence/properties.rb

@@ -21,6 +21,11 @@ module CouchPotato
           @list << property
         end
 
+        # XXX
+        def inspect
+          list.map(&:name).inspect
+        end
+
         def inherited_properties
           superclazz = @clazz.superclass
           properties = []
@@ -38,6 +43,7 @@ module CouchPotato
           def self.properties
             @properties ||= {}
             @properties[name] ||= PropertyList.new(self)
+            @properties[name]
           end
         end
       end

data/lib/couch_potato/persistence/simple_property.rb

@@ -43,11 +43,12 @@ module CouchPotato
       private
 
       def accessors_module_for(clazz)
-        unless clazz.const_defined?('AccessorMethods')
-          accessors_module = clazz.const_set('AccessorMethods', Module.new)
+        module_name = "#{clazz.name.to_s.gsub('::', '__')}AccessorMethods"
+        unless clazz.const_defined?(module_name)
+          accessors_module = clazz.const_set(module_name, Module.new)
           clazz.send(:include, accessors_module)
         end
-        clazz.const_get('AccessorMethods')
+        clazz.const_get(module_name)
       end
 
       def define_accessors(base, name, options)

data/lib/couch_potato/version.rb

@@ -1,3 +1,3 @@
 module CouchPotato
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

data/spec/property_spec.rb

@@ -26,11 +26,27 @@ class CuckooClock < Watch
   property :cuckoo
 end
 
+class SportsWatch < Watch
+  property :bpm
+end
+
 describe 'properties' do
   before(:all) do
     recreate_db
   end
 
+  context 'inheritance' do
+    it 'has access to superclass properties' do
+      expect(CuckooClock.new.cuckoo).to be_nil
+    end
+
+    it "does not have access to properties of 'sibling classes'" do
+      expect {
+        CuckooClock.new.bpm
+      }.to raise_error(NoMethodError)
+    end
+  end
+
   it "should allow me to overwrite read accessor and call super" do
     Watch.new(:overwritten_read => 1).overwritten_read.should == '1'
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: couch_potato
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-01 00:00:00.000000000 Z
+date: 2013-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json