cot 0.5.2 → 0.5.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NzRhMGE4M2I0NmZlYjUyMTRkMjdlMzQ2MzNkNjUzNGM0Y2M5MjI1MA==
+    MmQ0MWNjZWVjMTJkNDI3ZGJmNWFhNTFjZTkxZTc4NWE2MDRjMjRmNw==
   data.tar.gz: !binary |-
-    OWFhMTM2MmI3NjQ1ZTE3OTFhMDMwZTA2YzY3NDVhNDJkN2QwOWYyZg==
+    MzgzYmFlYjM3NjEzNzYxM2UxYTI1ZmRmYzk0NzIzZmVkMjEwZDAyYQ==
 SHA512:
   metadata.gz: !binary |-
-    MWM5ZTA2OTJjMWFmY2IxOTA5MTE1NmNlNGY4OTdmM2U5Y2Q0NmJhYzdiNmEw
-    OWFjNDAwNGZjZDViMDNhZTk0YjY5N2IxMjVkMThlMGEwYmNmMzRlYTU1MzUz
-    YTI2MTQ0ODNkMjA4MzY2OGZmMGYxZGQ2ZDIxYzVmYjQxOWVmMmU=
+    NjA1OWJmYWFmYzQ2OWNhNzdjZWUxMThhMmRlMDcxMWQ1OWI2MTYyOTY3ZjZi
+    Njc1ZTc5ZWQ2OWFlYzc5NjhjZDEwOGNmM2FkM2I2NmU3NjBlYTBlMGViOGEz
+    MWEyMGQwZWZhZmVjMGJhY2NkMDg0YTM4OGE2NDY1ZmIwMTZhNWY=
   data.tar.gz: !binary |-
-    ZWQ2MTJlNzFiMzNmNTkyMmI3NDRjZDg2NmEzMTY0M2RlYWZiMGYwZjBkYmE5
-    NDgwMTYzMDI0NTBmYmY3OGUwMzE5Nzc2Y2Q4OTc1NGIxM2Q3ODZkNDg2YmRl
-    ODE0ZTBlNjk3NGVhOTQ4ZWZjMzY2ZGZlZGQzNDNhM2NmOGU0ZmE=
+    NjA1ZTYxYzIxOTg2ZmQwOTM0ZTVlZDQ5YzFjMTkxZWMxODk2YTdiZmQ5ZmIx
+    N2E2NGU2ZmUxNzMwMjFjMTA3NDEyYjc5N2Y2ODVkNzlmMWQwMjgzYWRlZjMy
+    MjA3ZjNmNDY0Y2YyN2MzYzA3MzkwNzQ4M2ViMmJjYzA4OTE0YjM=

data/.travis.yml

@@ -1,7 +1,7 @@
 language: ruby
 rvm:
 - 2.1.5
-#- 2.0.0
+- 2.0.0
 - 2.2.0
 script:
   - bundle exec rake

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    cot (0.5.2)
+    cot (0.5.3)
       activemodel
 
 GEM

data/Rakefile

@@ -17,6 +17,7 @@ task test: :spec
 require 'mutant'
 desc 'Run mutation tests using mutant'
 task :mutant do
+  ENV['SKIP_COVERAGE'] = 'true'
   result = Mutant::CLI.run(%w( -Ilib -rcot --use rspec Cot* ))
   fail unless result == Mutant::CLI::EXIT_SUCCESS
 end

data/lib/cot/collection.rb

@@ -11,6 +11,9 @@ module Cot
     def initialize(*params)
       parse_params(params)
 
+      if self.class.klass.nil?
+        fail 'Collected class not set, please either pass a class to initialize or call collected_class'
+      end
       # If you pass in different types of things here we can't be friends
       initialize_objects(@objects) unless @objects.first.instance_of? self.class.klass
 

data/lib/cot/version.rb

@@ -1,3 +1,3 @@
 module Cot
-  VERSION = '0.5.2'
+  VERSION = '0.5.3'
 end

data/spec/lib/cot/collection_spec.rb

@@ -4,8 +4,14 @@ class FakeDouble < Cot::Frame
   property :foo
   property :fooy
 end
+class ExampleCollection < Cot::Collection
+end
 
 describe Cot::Collection do
+  after :each do
+    ExampleCollection.klass = nil
+  end
+
   let(:obj1) { FakeDouble.new id: 1, foo: :bar }
   let(:obj2) { FakeDouble.new id: 2, foo: :bar }
   subject(:collection) { Cot::Collection.new FakeDouble, [obj1, obj2] }
@@ -73,29 +79,29 @@ describe Cot::Collection do
     context 'when passing a class' do
       context 'with options' do
         it 'takes an optional sub_key option to pull the object out of the payload' do
-          coll = Cot::Collection.new FakeDouble,
-                                     [{ inner: { fooy: :bar } }, { inner: { asdf: :fdas } }],
-                                     sub_key: :inner
+          coll = ExampleCollection.new FakeDouble,
+                                       [{ inner: { fooy: :bar } }, { inner: { asdf: :fdas } }],
+                                       sub_key: :inner
           expect(coll.first).to be_kind_of FakeDouble
           expect(coll.first.fooy).to eq :bar
         end
 
         it 'takes options as strings and symbols' do
-          coll = Cot::Collection.new FakeDouble,
-                                     [{ inner: { fooy: :bar } }, { inner: { asdf: :fdas } }],
-                                     'sub_key' => :inner
+          coll = ExampleCollection.new FakeDouble,
+                                       [{ inner: { fooy: :bar } }, { inner: { asdf: :fdas } }],
+                                       'sub_key' => :inner
           expect(coll.first).to be_kind_of FakeDouble
           expect(coll.first.fooy).to eq :bar
         end
 
         it 'takes an optional default_attributes option to add set attributes in every object.' do
-          coll = Cot::Collection.new FakeDouble, [{ fooy: :bar }, { asdf: :fdas }], default_attributes: { foo: :baz }
+          coll = ExampleCollection.new FakeDouble, [{ fooy: :bar }, { asdf: :fdas }], default_attributes: { foo: :baz }
           expect(coll).to all be_kind_of FakeDouble
           expect(coll.map(&:foo).uniq).to eq [:baz]
         end
 
         it 'supports a legacy optional sub_key parameter to pull the object out of the payload' do
-          coll = Cot::Collection.new FakeDouble, [{ inner: { fooy: :bar } }, { inner: { asdf: :fdas } }], :inner
+          coll = ExampleCollection.new FakeDouble, [{ inner: { fooy: :bar } }, { inner: { asdf: :fdas } }], :inner
           expect(coll.first).to be_kind_of FakeDouble
           expect(coll.first.fooy).to eq :bar
         end
@@ -103,22 +109,22 @@ describe Cot::Collection do
 
       context 'without options' do
         it 'does not process the objects if they are already the correct class' do
-          coll = Cot::Collection.new [FakeDouble.new(fooy: :bar), FakeDouble.new(asdf: :fdas)]
+          coll = ExampleCollection.new FakeDouble, [FakeDouble.new(fooy: :bar), FakeDouble.new(asdf: :fdas)]
           expect(coll.first).to be_kind_of FakeDouble
         end
 
         it 'does not set the subkey if none is provided' do
-          coll = Cot::Collection.new [FakeDouble.new(fooy: :bar), FakeDouble.new(asdf: :fdas)]
+          coll = ExampleCollection.new FakeDouble, [FakeDouble.new(fooy: :bar), FakeDouble.new(asdf: :fdas)]
           expect(coll.instance_variable_get :@options).to_not have_key :sub_key
         end
 
         it 'can accept empty hashes' do
-          coll = Cot::Collection.new FakeDouble, [{}]
+          coll = ExampleCollection.new FakeDouble, [{}]
           expect(coll.first).to be_kind_of FakeDouble
         end
 
         it 'creates new instances of the passed klass if the objects are not already the class' do
-          coll = Cot::Collection.new FakeDouble, [{ fooy: :bar }, { asdf: :fdas }]
+          coll = ExampleCollection.new FakeDouble, [{ fooy: :bar }, { asdf: :fdas }]
           expect(coll.first).to be_kind_of FakeDouble
         end
       end
@@ -169,28 +175,34 @@ describe Cot::Collection do
 
       context 'without options' do
         it 'does not process the objects if they are already the correct class' do
-          coll = Cot::Collection.new [FakeDouble.new(fooy: :bar), FakeDouble.new(asdf: :fdas)]
+          coll = MyCollection.new [FakeDouble.new(fooy: :bar), FakeDouble.new(asdf: :fdas)]
           expect(coll.first).to be_kind_of FakeDouble
         end
 
         it 'creates new instances of the passed klass if the objects are not already the class' do
-          coll = Cot::Collection.new [{ fooy: :bar }, { asdf: :fdas }]
+          coll = MyCollection.new [{ fooy: :bar }, { asdf: :fdas }]
           expect(coll.first).to be_kind_of FakeDouble
         end
       end
     end
+
+    it 'fails if no klass is set' do
+      class BadCollection < Cot::Collection; end
+      error = 'Collected class not set, please either pass a class to initialize or call collected_class'
+      expect { BadCollection.new }.to raise_error error
+    end
   end
 
   context 'update members' do
     it 'updates members' do
-      coll = Cot::Collection.new FakeDouble, [{ fooy: :bar }]
+      coll = ExampleCollection.new FakeDouble, [{ fooy: :bar }]
       expect(coll.length).to eq 1
       coll.update_members [{ id: 123, foo: :bar }]
       expect(coll.first.id).to eq 123
     end
 
     it 'removes members that are not in the payload' do
-      coll = Cot::Collection.new FakeDouble, [{ fooy: :bar }, { asdf: :fdas }]
+      coll = ExampleCollection.new FakeDouble, [{ fooy: :bar }, { asdf: :fdas }]
       expect(coll.length).to eq 2
       coll.update_members [{ id: 123, foo: :bar }]
       expect(coll.first.id).to eq 123
@@ -200,13 +212,13 @@ describe Cot::Collection do
 
   context 'changed?' do
     it 'returns true if one of the objects has changed' do
-      coll = Cot::Collection.new FakeDouble, [{ fooy: :bar }]
+      coll = ExampleCollection.new FakeDouble, [{ fooy: :bar }]
       coll.first.fooy = 'baz'
       expect(coll.changed?).to be true
     end
 
     it 'return false if none of the objects have changed' do
-      coll = Cot::Collection.new FakeDouble, [{ fooy: :bar }]
+      coll = ExampleCollection.new FakeDouble, [{ fooy: :bar }]
       expect(coll.changed?).to be false
     end
   end

data/spec/spec_helper.rb

@@ -2,8 +2,7 @@ require 'simplecov'
 
 ENV['RAILS_ENV'] ||= 'test'
 
-require 'simplecov'
-SimpleCov.start
+SimpleCov.start unless ENV['SKIP_COVERAGE']
 
 require 'cot'
 require 'rspec'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cot
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - Joseph Henrich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-01 00:00:00.000000000 Z
+date: 2015-04-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel