corundum 0.0.29 → 0.0.30

data/lib/corundum/gemcutter.rb

@@ -10,6 +10,7 @@ module Corundum
     setting(:build_finished_path)
     setting(:gem_name)
     setting(:package_dir)
+    setting(:qa_rejections)
 
     def default_configuration(toolkit, build)
       super
@@ -18,6 +19,7 @@ module Corundum
       self.build_finished_path = toolkit.finished_files.build
       self.gem_name = toolkit.gemspec.full_name
       self.package_dir = build.package_dir
+      self.qa_rejections = toolkit.qa_rejections
     end
 
     def resolve_configuration
@@ -75,14 +77,18 @@ module Corundum
 
         task :reinstall => [:uninstall, :install]
 
-        task :dependencies_available => :is_unpushed do
+        task :dependencies_available do
+          require 'corundum/qa-report'
           checker = Gem::SpecFetcher.new
+          report = QA::Report.new("Gem dependencies")
+          qa_rejections << report
           gemspec.runtime_dependencies.each do |dep|
             fulfilling = checker.find_matching(dep,true,false,false)
             if fulfilling.empty?
-              fail "Dependency #{dep} is unfulfilled remotely"
+              report.add("missing", File::basename(gemspec.loaded_from), nil, dep)
+              report.fail "Dependency unfulfilled remotely"
             else
-              puts "Remotely fulfilled: #{dep}" if verbose
+              report.add("fulfilled", File::basename(gemspec.loaded_from), nil, dep)
             end
           end
         end
@@ -106,7 +112,8 @@ module Corundum
         task :push => build_finished_path
       end
       task :release => in_namespace(:push)
-      task :preflight => in_namespace(:dependencies_available, :is_unpushed)
+      task :preflight => in_namespace(:is_unpushed)
+      task :qa => in_namespace(:dependencies_available)
     end
   end
 end

data/lib/corundum/qa-report.rb

@@ -0,0 +1,111 @@
+module Corundum
+  module QA
+    #Adopted gratefully from Xavier Shay's Cane
+    class ReportFormatter
+      def initialize(reports)
+        @reports = reports
+      end
+      attr_reader :reports
+
+      def to_s
+        return "" if reports.empty?
+
+        widths = column_widths(reports)
+
+        reports.map do |report|
+          report.to_s(widths)
+        end.join("\n") + "\n\n" + totals + "\n\n"
+      end
+
+      protected
+
+      def max_width(name, &block)
+        reports.map(&:rejects).flatten.map do |reject|
+          yield(reject).to_s.length
+        end.max
+      end
+
+      def column_widths(reports)
+        Hash[[:file_and_line, :label, :value].map do |name|
+          [name, max_width(name, &name)]
+        end]
+      end
+
+      def totals
+        "Total QA report items: #{reports.inject(0){|sum, report| sum + report.length}}"
+        "Total QA failing reports: #{reports.inject(0){|sum, report| sum + (report.passed ? 0 : 1)}}"
+      end
+    end
+
+    class Rejection
+      def initialize(label, file, line = nil, value = nil)
+        @file, @line, @label, @value = file, line, label, value
+      end
+      attr_reader :file, :line, :label, :value
+
+      def file_and_line
+        @file_and_line ||=
+          begin
+            if line.nil?
+              file
+            else
+              [file, line].join(":")
+            end
+          end
+      end
+
+      def to_s(column_widths=nil)
+        column_widths ||= {}
+        [:file_and_line, :label, :value].map do |name|
+          if column_widths.has_key?(name)
+            self.send(name).to_s.ljust(column_widths[name])
+          else
+            self.send(name).to_s
+          end
+        end.join('  ')
+      end
+    end
+
+    class Report
+      def initialize(name)
+        @name = name
+        @rejects = []
+        @passed = true
+        @summary = ""
+      end
+      attr_reader :name, :rejects
+      attr_accessor :summary, :passed
+
+      def <<(reject)
+        @rejects << reject
+      end
+
+      def add(*args)
+        self << Rejection.new(*args)
+      end
+
+      def fail(summary)
+        @passed = false
+        @summary = summary
+      end
+
+      def length
+        @rejects.length
+      end
+      alias count length
+
+      def empty?
+        @rejects.empty?
+      end
+
+      def to_s(widths=nil)
+        (passed ? "Ok" : "FAIL") +
+        ": #{name} (#{length})\n" +
+          (summary.empty? ? "" : (summary + "\n")) +
+          rejects.map do |reject|
+          "  " + reject.to_s(widths) + "\n"
+          end.join("")
+      end
+    end
+  end
+end

data/lib/corundum/simplecov.rb

@@ -117,6 +117,7 @@ module Corundum
           need_coverage = @code_files.find_all(&coverage_filter)
 
           report = QA::Report.new("Stragglers")
+          qa_rejections << report
           (covered_files - need_coverage).each do |file|
             report.add("Not in gemspec", file)
           end

metadata

@@ -2,7 +2,7 @@
 name: corundum
 version: !ruby/object:Gem::Version
   prerelease: 
-  version: 0.0.29
+  version: 0.0.30
 platform: ruby
 authors:
 - Judson Lester
@@ -321,6 +321,7 @@ files:
 - lib/corundum.rb
 - lib/corundum/configuration-store.rb
 - lib/corundum/core.rb
+- lib/corundum/qa-report.rb
 - lib/corundum/browser-task.rb
 - lib/corundum/github-pages.rb
 - lib/corundum/rspec.rb
@@ -414,7 +415,7 @@ licenses:
 post_install_message: 
 rdoc_options:
 - --title
-- corundum-0.0.29 RDoc
+- corundum-0.0.30 RDoc
 require_paths:
 - lib/
 required_ruby_version: !ruby/object:Gem::Requirement
@@ -423,7 +424,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       segments:
       - 0
-      hash: -574444653
+      hash: -251699523
       version: '0'
   none: false
 required_rubygems_version: !ruby/object:Gem::Requirement