cornell_ldap 1.0.0 → 1.1.0

data/VERSION

@@ -1 +1 @@
-1.0.0
+1.1.0

data/cornell_ldap.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{cornell_ldap}
-  s.version = "1.0.0"
+  s.version = "1.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Ari Epstein"]

data/lib/cornell_ldap.rb

@@ -40,7 +40,7 @@ module CornellLdap
 
     # Returns has representation of on campus address for person if one is
     # reported.
-    # See CornellLdap::Record#make_address_attributes for more information.
+    # See CornellLdap::Record#address_attributes for more information.
     def campus_address
       unless @campus_address.nil?
         return @campus_address
@@ -52,24 +52,24 @@ module CornellLdap
     end
 
     # Returns local area (Ithaca area) address for person if one is reported
-    # See CornellLdap::Record#make_address_attributes for more information.
+    # See CornellLdap::Record#address_attributes for more information.
     def local_address
       unless @local_address.nil?
         return @local_address
       end
       @local_address = false unless attribute_present?('cornelledulocaladdress') &&
-        @local_address = Record.make_address_attributes(cornelledulocaladdress)
+        @local_address = Record.address_attributes(cornelledulocaladdress)
       return local_address
     end
 
     # Returns home address for person if one is reported
-    # See CornellLdap::Record#make_address_attributes for more information.
+    # See CornellLdap::Record#address_attributes for more information.
     def home_address
       unless @home_address.nil?
         return @home_address
       end
       @home_address = false unless attribute_present?('homePostalAddress') &&
-        @home_address = Record.make_address_attributes(homePostalAddress)
+        @home_address = Record.address_attributes(homePostalAddress)
       return home_address
     end
 

data/spec/cornell_ldap_spec.rb

@@ -59,6 +59,18 @@ describe "CornellLdap" do
     end
   end
 
+  it "should call address_attributes to return local address" do
+    person = mock_person
+    CornellLdap::Record.should_receive(:address_attributes).once.with(person.cornelledulocaladdress)
+    person.local_address
+  end
+
+  it "should call address_attributes to return home address" do
+    person = mock_person
+    CornellLdap::Record.should_receive(:address_attributes).once.with(person.homePostalAddress)
+    person.home_address
+  end
+
   def mock_person
     person = CornellLdap::Record.new
     person.attributes={

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: cornell_ldap
 version: !ruby/object:Gem::Version 
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors: 
 - Ari Epstein