coradoc 2.0.3 → 2.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7f2699bddcd303d5c58e2f3e6a7d4c4341a8f06dc06df44785a97aa48ad7e055
-  data.tar.gz: 8e696cec10f047229d67806d5d93d21bcd02465ef57da243295f13906ccfc91d
+  metadata.gz: 69f496efd91c2d85e4e057be629f8ee00492c40497661c0af940be65f148e092
+  data.tar.gz: a2668ca45e7d23bf613d966c36b4c5da70311be0dcdbc0fba4d988844f49b65f
 SHA512:
-  metadata.gz: 8b313846dc7365da7c399117c33119c28009df2009d478345157839c29e9bf30a152fb0000ab56c7202ea7cb784e661ba2a3b61bfa7a40f7616440182994f718
-  data.tar.gz: 42118e1947a3c609110786b7f906412080a79e518b02e101a4cc19d696e790849d93cdc049334829837a44a18308a34a03e3d6caf8fac83628a8119c1d35cfcc
+  metadata.gz: '04584b5faee36ac872400d4d17458221931de4f733aae75839dc40f282d4f863948c9105eb80fefb84f6945639c76c55ccf62fd93d8fd442268f36698950625d'
+  data.tar.gz: 00c91cfd40f731c1fffab6ae507d326140e5c7830a8d10bf6a5bb75857ba0b69a552fc4a27d8bd3abb95d4a16159a516df62232bc538fd79fe55a7023e95af0b

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-05-07 12:19:03 UTC using RuboCop version 1.75.8.
+# on 2026-05-08 04:52:25 UTC using RuboCop version 1.75.8.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -154,7 +154,7 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   Max: 556
 
-# Offense count: 181
+# Offense count: 179
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/CyclomaticComplexity:
   Max: 32
@@ -175,7 +175,7 @@ Metrics/ParameterLists:
   Max: 7
   MaxOptionalParameters: 4
 
-# Offense count: 123
+# Offense count: 122
 # Configuration parameters: AllowedMethods, AllowedPatterns.
 Metrics/PerceivedComplexity:
   Max: 27
@@ -238,6 +238,12 @@ Naming/VariableName:
   Exclude:
     - 'coradoc-markdown/lib/coradoc/markdown.rb'
 
+# Offense count: 12
+# This cop supports unsafe autocorrection (--autocorrect-all).
+RSpec/BeEq:
+  Exclude:
+    - 'coradoc-adoc/spec/coradoc/asciidoc/model/element_classification_spec.rb'
+
 # Offense count: 1
 RSpec/BeforeAfterAll:
   Exclude:
@@ -246,11 +252,19 @@ RSpec/BeforeAfterAll:
     - '**/spec/support/**/*.rb'
     - 'spec/benchmark/performance_spec.rb'
 
-# Offense count: 19
+# Offense count: 20
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
   Enabled: false
 
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: SkipBlocks, EnforcedStyle, OnlyStaticConstants.
+# SupportedStyles: described_class, explicit
+RSpec/DescribedClass:
+  Exclude:
+    - 'coradoc-adoc/spec/coradoc/asciidoc/model/base_spec.rb'
+
 # Offense count: 485
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
@@ -302,7 +316,7 @@ RSpec/MessageSpies:
 RSpec/MultipleDescribes:
   Enabled: false
 
-# Offense count: 613
+# Offense count: 619
 RSpec/MultipleExpectations:
   Max: 12
 
@@ -381,7 +395,7 @@ Style/ClassVars:
     - 'coradoc-adoc/lib/coradoc/asciidoc/serializer/element_registry.rb'
     - 'coradoc-html/lib/coradoc/html/input/converters.rb'
 
-# Offense count: 291
+# Offense count: 292
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false

data/coradoc-adoc/lib/coradoc/asciidoc/model/attached.rb

@@ -17,6 +17,9 @@ module Coradoc
       # @see Coradoc::AsciiDoc::Model::Block::Core
       #
       class Attached < Base
+        def block_level?
+          true
+        end
       end
     end
   end

data/coradoc-adoc/lib/coradoc/asciidoc/model/base.rb

@@ -35,6 +35,16 @@ module Coradoc
 
         attribute :id, :string
 
+        # Element classification for spacing and serialization decisions.
+        # Subclasses override these to declare their level.
+        def block_level?
+          false
+        end
+
+        def inline?
+          false
+        end
+
         # Generate a warning message whenever this method is called.
         def simplify_block_content(content)
           warn '[DEPRECATION] #simplify_block_content is called inside a Lutaml Model.  This is still a WIP.'

data/coradoc-adoc/lib/coradoc/asciidoc/model/comment_block.rb

@@ -21,6 +21,10 @@ module Coradoc
       # @see Coradoc::AsciiDoc::Model::CommentLine Single-line comments
       #
       class CommentBlock < Base
+        def block_level?
+          true
+        end
+
         attribute :text, :string
         attribute :line_break, :string, default: -> { "\n" }
       end

data/coradoc-adoc/lib/coradoc/asciidoc/model/image/block_image.rb

@@ -5,6 +5,10 @@ module Coradoc
     module Model
       module Image
         class BlockImage < Coradoc::AsciiDoc::Model::Image::Core
+          def block_level?
+            true
+          end
+
           # Autoload nested AttributeList class
           autoload :AttributeList, 'coradoc/asciidoc/model/image/block_image/attribute_list'
 

data/coradoc-adoc/lib/coradoc/asciidoc/model/image/inline_image.rb

@@ -5,6 +5,10 @@ module Coradoc
     module Model
       module Image
         class InlineImage < Coradoc::AsciiDoc::Model::Image::Core
+          def inline?
+            true
+          end
+
           attribute :colons, :string, default: -> { ':' }
         end
       end

data/coradoc-adoc/lib/coradoc/asciidoc/model/inline/base.rb

@@ -5,6 +5,9 @@ module Coradoc
     module Model
       module Inline
         class Base < Coradoc::AsciiDoc::Model::Base
+          def inline?
+            true
+          end
         end
       end
     end

data/coradoc-adoc/lib/coradoc/asciidoc/model/inline/hard_line_break.rb

@@ -14,6 +14,9 @@ module Coradoc
         #   break.to_adoc # => " +"
         #
         class HardLineBreak < Base
+          def inline?
+            :hardbreak
+          end
         end
       end
     end

data/coradoc-adoc/lib/coradoc/asciidoc/model/list/core.rb

@@ -29,6 +29,10 @@ module Coradoc
         class Core < Nestable
           include Coradoc::AsciiDoc::Model::Anchorable
 
+          def block_level?
+            true
+          end
+
           attribute :id, :string
           attribute :prefix, :string
           # attribute :anchor, Inline::Anchor, default: -> {

data/coradoc-adoc/lib/coradoc/asciidoc/model/list/item.rb

@@ -65,23 +65,6 @@ module Coradoc
                     initialize_empty: true
 
           attribute :nested, Coradoc::AsciiDoc::Model::List::Nestable
-
-          HARDBREAK_MARKERS = %i[hardbreak init].freeze
-          STRIP_UNICODE_BEGIN_MARKERS = (HARDBREAK_MARKERS.dup + [false]).freeze
-          STRIP_UNICODE_END_MARKERS = [:hardbreak, :end, false].freeze
-
-          def inline?(elem)
-            case elem
-            when Inline::HardLineBreak
-              :hardbreak
-            when ->(i) { i.class.name.to_s.include? '::Inline::' }
-              true
-            when String, TextElement, Image::InlineImage
-              true
-            else
-              false
-            end
-          end
         end
       end
     end

data/coradoc-adoc/lib/coradoc/asciidoc/model/section.rb

@@ -39,6 +39,10 @@ module Coradoc
       class Section < Base
         include Coradoc::AsciiDoc::Model::Anchorable
 
+        def block_level?
+          true
+        end
+
         attribute :id, :string
         attribute :content, :string
         attribute :title, Coradoc::AsciiDoc::Model::Title

data/coradoc-adoc/lib/coradoc/asciidoc/model/table.rb

@@ -26,6 +26,10 @@ module Coradoc
       class Table < Base
         include Coradoc::AsciiDoc::Model::Anchorable
 
+        def block_level?
+          true
+        end
+
         attribute :id, :string
         attribute :title, :string
         attribute :rows, Coradoc::AsciiDoc::Model::TableRow, collection: true

data/coradoc-adoc/lib/coradoc/asciidoc/model/text_element.rb

@@ -4,6 +4,10 @@ module Coradoc
   module AsciiDoc
     module Model
       class TextElement < Base
+        def inline?
+          true
+        end
+
         attribute :id, :string
         attribute :content,
                   Lutaml::Model::Serializable,

data/coradoc-adoc/lib/coradoc/asciidoc/serializer/serializers/base.rb

@@ -120,17 +120,6 @@ module Coradoc
             end
           end
 
-          # Helper to check if element is block-level
-          # @param element [Object] Element to check
-          # @return [Boolean] True if block-level
-          def block_level_element?(element)
-            element.is_a?(Coradoc::AsciiDoc::Model::Block::Core) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Section) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Paragraph) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::List) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Table)
-          end
-
           # Helper to add spacing between elements
           # @param elements [Array] Elements to space
           # @param options [Hash] Spacing options

data/coradoc-adoc/lib/coradoc/asciidoc/serializer/serializers/list/item.rb

@@ -94,16 +94,10 @@ module Coradoc
             private
 
             def inline?(elem)
-              case elem
-              when Coradoc::AsciiDoc::Model::Inline::HardLineBreak
-                :hardbreak
-              when ->(i) { i.class.name.to_s.include?('::Inline::') }
-                true
-              when String, Coradoc::AsciiDoc::Model::TextElement, Coradoc::AsciiDoc::Model::Image::InlineImage
-                true
-              else
-                false
-              end
+              return true if elem.is_a?(String)
+              return false unless elem.is_a?(Coradoc::AsciiDoc::Model::Base)
+
+              elem.inline?
             end
 
             def gen_anchor(inline: false)

data/coradoc-adoc/lib/coradoc/asciidoc/serializer/spacing_strategy.rb

@@ -47,19 +47,11 @@ module Coradoc
             end
           end
 
-          # Check if element is block-level
-          # @param element [Object] Element to check
-          # @return [Boolean] True if block-level
           def block_level?(element)
             return false if element.nil?
+            return true if element.is_a?(String)
 
-            element.is_a?(Coradoc::AsciiDoc::Model::Block::Core) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Section) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Paragraph) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::List) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Table) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::CommentBlock) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Admonition)
+            element.block_level?
           end
 
           # Check if element is inline-level
@@ -67,15 +59,9 @@ module Coradoc
           # @return [Boolean] True if inline-level
           def inline_level?(element)
             return false if element.nil?
+            return true if element.is_a?(String)
 
-            element.is_a?(String) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::TextElement) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Inline::Bold) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Inline::Italic) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Inline::Monospace) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Inline::Highlight) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Inline::Superscript) ||
-              element.is_a?(Coradoc::AsciiDoc::Model::Inline::Subscript)
+            element.inline?
           end
         end
       end

data/coradoc-adoc/spec/coradoc/asciidoc/model/base_spec.rb

@@ -33,10 +33,24 @@ RSpec.describe Coradoc::AsciiDoc::Model::Base do
   end
 
   describe '#to_adoc' do
-    it 'is defined on Base' do
+    it 'serializes via ElementRegistry' do
       instance = test_class.new(name: 'test')
 
-      expect(instance).to respond_to(:to_adoc)
+      expect(instance).to be_a(described_class)
+    end
+  end
+
+  describe 'element classification' do
+    it 'defaults block_level? to false' do
+      instance = test_class.new
+
+      expect(instance.block_level?).to be(false)
+    end
+
+    it 'defaults inline? to false' do
+      instance = test_class.new
+
+      expect(instance.inline?).to be(false)
     end
   end
 

data/coradoc-adoc/spec/coradoc/asciidoc/model/element_classification_spec.rb

@@ -0,0 +1,146 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe 'Element classification' do
+  describe 'block_level?' do
+    it 'Section is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Section.new.block_level?).to be(true)
+    end
+
+    it 'Paragraph is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Paragraph.new.block_level?).to be(true)
+    end
+
+    it 'Admonition is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Admonition.new.block_level?).to be(true)
+    end
+
+    it 'CommentBlock is block-level' do
+      expect(Coradoc::AsciiDoc::Model::CommentBlock.new.block_level?).to be(true)
+    end
+
+    it 'Table is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Table.new.block_level?).to be(true)
+    end
+
+    it 'Block::Core is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Block::Core.new.block_level?).to be(true)
+    end
+
+    it 'Block::Listing is block-level (inherits from Core)' do
+      expect(Coradoc::AsciiDoc::Model::Block::Listing.new.block_level?).to be(true)
+    end
+
+    it 'Block::Quote is block-level (inherits from Core)' do
+      expect(Coradoc::AsciiDoc::Model::Block::Quote.new.block_level?).to be(true)
+    end
+
+    it 'List::Ordered is block-level' do
+      expect(Coradoc::AsciiDoc::Model::List::Ordered.new.block_level?).to be(true)
+    end
+
+    it 'List::Unordered is block-level' do
+      expect(Coradoc::AsciiDoc::Model::List::Unordered.new.block_level?).to be(true)
+    end
+
+    it 'BlockImage is block-level' do
+      expect(Coradoc::AsciiDoc::Model::Image::BlockImage.new.block_level?).to be(true)
+    end
+  end
+
+  describe 'inline?' do
+    it 'Inline::Bold is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Bold.new.inline?).to be(true)
+    end
+
+    it 'Inline::Italic is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Italic.new.inline?).to be(true)
+    end
+
+    it 'Inline::Monospace is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Monospace.new.inline?).to be(true)
+    end
+
+    it 'Inline::Highlight is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Highlight.new.inline?).to be(true)
+    end
+
+    it 'Inline::Superscript is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Superscript.new.inline?).to be(true)
+    end
+
+    it 'Inline::Subscript is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Subscript.new.inline?).to be(true)
+    end
+
+    it 'Inline::Link is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Link.new.inline?).to be(true)
+    end
+
+    it 'Inline::Anchor is inline' do
+      expect(Coradoc::AsciiDoc::Model::Inline::Anchor.new.inline?).to be(true)
+    end
+
+    it 'TextElement is inline' do
+      expect(Coradoc::AsciiDoc::Model::TextElement.new.inline?).to be(true)
+    end
+
+    it 'InlineImage is inline' do
+      expect(Coradoc::AsciiDoc::Model::Image::InlineImage.new.inline?).to be(true)
+    end
+
+    it 'HardLineBreak returns :hardbreak' do
+      expect(Coradoc::AsciiDoc::Model::Inline::HardLineBreak.new.inline?).to eq(:hardbreak)
+    end
+  end
+
+  describe 'non-block, non-inline elements' do
+    it 'Title is neither block nor inline' do
+      title = Coradoc::AsciiDoc::Model::Title.new
+      expect(title.block_level?).to be(false)
+      expect(title.inline?).to be(false)
+    end
+
+    it 'List::Item is neither block nor inline' do
+      item = Coradoc::AsciiDoc::Model::List::Item.new
+      expect(item.block_level?).to be(false)
+      expect(item.inline?).to be(false)
+    end
+
+    it 'AttributeList is neither block nor inline' do
+      attrs = Coradoc::AsciiDoc::Model::AttributeList.new
+      expect(attrs.block_level?).to be(false)
+      expect(attrs.inline?).to be(false)
+    end
+  end
+
+  describe 'SpacingStrategy integration' do
+    let(:strategy) { Coradoc::AsciiDoc::Serializer::SpacingStrategy }
+
+    it 'uses polymorphic block_level? for spacing' do
+      para = Coradoc::AsciiDoc::Model::Paragraph.new
+      section = Coradoc::AsciiDoc::Model::Section.new
+
+      expect(strategy.block_level?(para)).to be(true)
+      expect(strategy.block_level?(section)).to be(true)
+    end
+
+    it 'uses polymorphic inline? for spacing' do
+      bold = Coradoc::AsciiDoc::Model::Inline::Bold.new
+      text = Coradoc::AsciiDoc::Model::TextElement.new
+
+      expect(strategy.inline_level?(bold)).to be(true)
+      expect(strategy.inline_level?(text)).to be(true)
+    end
+
+    it 'returns false for nil' do
+      expect(strategy.block_level?(nil)).to be(false)
+      expect(strategy.inline_level?(nil)).to be(false)
+    end
+
+    it 'treats strings as inline' do
+      expect(strategy.inline_level?('text')).to be(true)
+    end
+  end
+end

data/lib/coradoc/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Coradoc
-  VERSION = '2.0.3'
+  VERSION = '2.0.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: coradoc
 version: !ruby/object:Gem::Version
-  version: 2.0.3
+  version: 2.0.4
 platform: ruby
 authors:
 - Ribose Inc.
@@ -300,6 +300,7 @@ files:
 - coradoc-adoc/spec/coradoc/asciidoc/model/break_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/document_attributes_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/document_spec.rb
+- coradoc-adoc/spec/coradoc/asciidoc/model/element_classification_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/header_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/image_spec.rb
 - coradoc-adoc/spec/coradoc/asciidoc/model/inline/extended_spec.rb