cool.io 1.9.1 → 1.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d38b3958d9ad5505fb4a53ded526d2ab347d46200a567a9aa0681cc5ca487cc
-  data.tar.gz: 42cb1b75db2c409dfc48756b8df29663675e31a104d03c37bbbfce9344592d6d
+  metadata.gz: 5cdd11354b2fc68835f7380b7f529a5c41c29280dd489287eb99fbc605978f18
+  data.tar.gz: 51e173aadc18fdd12915648b7ac58553ab0b22c13be146e2273d507135cefe58
 SHA512:
-  metadata.gz: 6e3358de317e34735ca0f264c75f93d34d38325482c02eabf4d1289b3c44ef6557918bd59078a34c809322d69d05299ccb58f89db630c4054dc0162de8ab49b6
-  data.tar.gz: 775568343fe8788adbc43757a6f06ef5474e1d19477571317f29e21ff3da777d8567a6401377c6eb854e9f0c4060d97da7c84dafa56dc1e772f636417365d338
+  metadata.gz: 4449d8f0cec3c081e3ff3625351d66e1eb19ec4cdc23d547a4c2862d0b3a25e8a71bf43eb803559b3758ed284bd3f4a4f5e6008b04e490530604c6cc6551a9eb
+  data.tar.gz: 7607bab107f686eb8f1a16bc013f0a78815238fc1063de51d75b3e6299f00384583bd311de2841ea1d5bd43e4b72eaad5b43f3f22face9bd327ca9c0629f1a0f

data/ext/cool.io/loop.c

@@ -113,6 +113,12 @@ void Coolio_Loop_process_event(VALUE watcher, int revents)
   /* The Global VM lock isn't held right now, but hopefully
    * we can still do this safely */
   watcher_data = Coolio_Watcher_ptr(watcher);
+
+  if (watcher_data->enabled == 0) {
+    /* Ignore event because watcher was already detached. */
+    return;
+  }
+
   loop_data = Coolio_Loop_ptr(watcher_data->loop);
 
   /*  Well, what better place to explain how this all works than

data/ext/cool.io/watcher.h

@@ -33,6 +33,10 @@
   if(watcher_data->loop == Qnil) \
     rb_raise(rb_eRuntimeError, "not attached to a loop"); \
   \
+  if (watcher_data->enabled == 0) { \
+    /* Ignore because watcher was already detached. */ \
+    return Qnil; \
+  } \
   loop_data = Coolio_Loop_ptr(watcher_data->loop); \
   \
   ev_##watcher_type##_stop(loop_data->ev_loop, &watcher_data->event_types.ev_##watcher_type); \

data/lib/cool.io/version.rb

@@ -1,5 +1,5 @@
 module Coolio
-  VERSION = "1.9.1"
+  VERSION = "1.9.2"
   
   def self.version
     VERSION

data/spec/detach_race_condition_spec.rb

@@ -0,0 +1,50 @@
+require 'spec_helper'
+
+describe Cool.io::Loop do
+  class Victim < Cool.io::IOWatcher
+    def initialize(io)
+      super
+      @io = io
+    end
+
+    def on_readable
+      begin
+        @io.read_nonblock(1024)
+      rescue IO::WaitReadable, EOFError
+      end
+    end
+  end
+
+  # https://github.com/socketry/cool.io/issues/87
+  it "does not raise TypeError when a watcher is detached while an event is pending" do
+    loop = Cool.io::Loop.default
+
+    iterations = 200
+
+    expect {
+      iterations.times do
+        r_victim, w_victim = IO.pipe
+        victim_watcher = Victim.new(r_victim)
+        victim_watcher.attach(loop)
+
+        t1 = Thread.new do
+          sleep 0.01
+          w_victim.write("dummy\n")
+        end
+
+        t2 = Thread.new do
+          sleep 0.01
+          victim_watcher.detach
+        end
+
+        loop.run_once
+
+        t1.join
+        t2.join
+
+        r_victim.close
+        w_victim.close
+      end
+    }.not_to raise_error
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cool.io
 version: !ruby/object:Gem::Version
-  version: 1.9.1
+  version: 1.9.2
 platform: ruby
 authors:
 - Tony Arcieri
@@ -140,6 +140,7 @@ files:
 - libev_ruby_gil.diff
 - libev_win_select.diff
 - spec/async_watcher_spec.rb
+- spec/detach_race_condition_spec.rb
 - spec/dns_spec.rb
 - spec/iobuffer_spec.rb
 - spec/spec_helper.rb
@@ -168,11 +169,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.0.dev
+rubygems_version: 4.0.3
 specification_version: 4
 summary: A cool framework for doing high performance I/O in Ruby
 test_files:
 - spec/async_watcher_spec.rb
+- spec/detach_race_condition_spec.rb
 - spec/dns_spec.rb
 - spec/iobuffer_spec.rb
 - spec/spec_helper.rb