cookstyle 7.31.9 → 7.32.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 77ad4617e8e89f4b34622dfc962e39037e28c5d9779cbc3198a64c7155b426ed
-  data.tar.gz: cf9fdce4231a1b0c55e8166628affc51abe3eb188ba5a8d75c08cd57f0d49470
+  metadata.gz: e2f55c6b537df4ecc7cbab6b05962b36bfdd2be1de9c9aa2a4a75169ca6c1e03
+  data.tar.gz: e2266d2ad7aca19c04cabe83df4f471b0226f85ec472d63bde5cf0232b327ed7
 SHA512:
-  metadata.gz: db4d6bf2c6a01d8bbd4c49f3ed8a13cf23b70d664f15c515536ae64e509af4d2caa6151825161d9dc554d19088527465b009e37ff13fbac1a04829308fb90684
-  data.tar.gz: 192f218ee77783b63d7712a0c51837c2a50ebffef4cf1f12112cfcd0008599e9bdf25fb6250f7f4f2c2206f15ae856ef62a6ee2183abb8cb86ad959823df98f6
+  metadata.gz: 44ca2ad6f132101f59e22c8c3b92e417a63836b37f916176cec3bdebd2bdd3547ec2ea7377b1f6f59a82a33f6e722964755583812a378ed8c4ca178a2475a96c
+  data.tar.gz: 93286dc94bd04076ab103582a3b18bce4d0ff814876aa39283d96e279ad08febdc17da6d6267f7d93c8f01f92c4e7102ff90124b6162474020545c7b8cc6a7c4

data/config/cookstyle.yml

@@ -8,6 +8,7 @@ AllCops:
   Include:
     - '**/.delivery/project.toml'      # required by Chef/Deprecations/Delivery
     - '**/.delivery/config.json'       # required by Chef/Deprecations/Delivery
+    - '**/.foodcritic'
   Exclude:
     - '**/files/**/*'
     - '**/vendor/**/*'
@@ -1222,6 +1223,14 @@ Chef/Deprecations/FoodcriticTesting:
     - '**/Rakefile'
     - '**/Gemfile'
 
+Chef/Deprecations/FoodcriticFile:
+  Description: The Foodcritic cookbook linter has been deprecated and should no longer be used for validating cookbooks
+  StyleGuide: 'chef_deprecations_foodcriticfile'
+  Enabled: true
+  VersionAdded: '7.32.0'
+  Include:
+    - '**/.foodcritic'
+
 Chef/Deprecations/DeprecatedYumRepositoryActions:
   Description: With the release of Chef Infra Client 12.14 and the yum cookbook 3.0 several actions in the yum_repository resource actions were renamed. The `add` action became `create` and `delete` became `remove` to better match other resources in Chef Infra Client.
   StyleGuide: 'chef_deprecations_deprecatedyumrepositoryactions'

data/lib/cookstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Cookstyle
-  VERSION = "7.31.9" # rubocop: disable Style/StringLiterals
+  VERSION = "7.32.0" # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '1.25.1'
 end

data/lib/rubocop/cop/chef/correctness/invalid_platform_helper.rb

@@ -25,12 +25,12 @@ module RuboCop
         #
         #   #### incorrect
         #   platform?('darwin')
-        #   platform?('rhel)
+        #   platform?('rhel')
         #   platform?('sles')
         #
         #   #### correct
         #   platform?('mac_os_x')
-        #   platform?('redhat)
+        #   platform?('redhat')
         #   platform?('suse')
         #
         class InvalidPlatformHelper < Base

data/lib/rubocop/cop/chef/deprecation/chefdk_generators.rb

@@ -27,14 +27,14 @@ module RuboCop
         #   ChefDK::CLI
         #   ChefDK::Generator::TemplateHelper
         #   module ChefDK
-        #     ...
+        #     # some additional code
         #   end
         #
         #   #### correct
         #   ChefCLI::CLI
         #   ChefCLI::Generator::TemplateHelper
         #   module ChefCLI
-        #     ...
+        #     # some additional code
         #   end
         #
         class ChefDKGenerators < Base

data/lib/rubocop/cop/chef/deprecation/foodcritic_file.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+#
+# Copyright:: 2022, Chef Software Inc.
+# Author:: Tim Smith (<tsmith84@gmail.com>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module Deprecations
+        # The Foodcritic cookbook linter has been deprecated and should no longer be used for validating cookbooks. Do not include the `.foodcritic` config file used by Foodcritic in your cookbooks.
+        #
+        class FoodcriticFile < Base
+          include RangeHelp
+
+          MSG = 'Do not include the `.foodcritic` config file for the deprecated Foodcritic cookbook linter.'
+
+          def on_new_investigation
+            return unless processed_source.path.end_with?('.foodcritic')
+
+            # Using range similar to RuboCop::Cop::Naming::Filename (file_name.rb)
+            range = source_range(processed_source.buffer, 1, 0)
+
+            add_offense(range, severity: :warning)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/resource_uses_updated_method.rb

@@ -30,7 +30,7 @@ module RuboCop
         #
         #   #### correct
         #   action :foo do
-        #     converge_by('resource did something) do
+        #     converge_by('resource did something') do
         #       # code that causes the resource to converge
         #     end
         #

data/lib/rubocop/cop/chef/deprecation/use_automatic_resource_name.rb

@@ -28,7 +28,8 @@ module RuboCop
         #     class MyCookbookService < Chef::Resource
         #       use_automatic_resource_name
         #       provides :mycookbook_service
-        #       ...
+        #
+        #       # some additional code
         #     end
         #   end
         #

data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb

@@ -33,6 +33,8 @@ module RuboCop
         #
         #   # check to see if we're on RHEL 7 on a RHEL 7.6 node where node['platform_version] is 7.6.1810
         #   if node['platform_version'].to_i == 7
+        #     # some code
+        #   end
         #
         class SimplifyPlatformMajorVersionCheck < Base
           extend AutoCorrector

data/lib/rubocop/cop/inspec/deprecation/attribute_default.rb

@@ -19,7 +19,7 @@ module RuboCop
   module Cop
     module InSpec
       module Deprecations
-        # The InSpec inputs `default` option has been replaced with the `value` option.
+        # The Chef InSpec inputs `default` option has been replaced with the `value` option.
         #
         # @example
         #

data/lib/rubocop/cop/inspec/deprecation/attribute_helper.rb

@@ -19,7 +19,7 @@ module RuboCop
   module Cop
     module InSpec
       module Deprecations
-        # InSpec attributes have been renamed to inputs. Use the `input` method not the deprecation `attribute` method to access these values.
+        # Chef InSpec attributes have been renamed to inputs. Use the `input` method not the deprecation `attribute` method to access these values.
         #
         # @example
         #

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 7.31.9
+  version: 7.32.0
 platform: ruby
 authors:
 - Thom May
@@ -124,6 +124,7 @@ files:
 - lib/rubocop/cop/chef/deprecation/erl_call.rb
 - lib/rubocop/cop/chef/deprecation/execute_path_property.rb
 - lib/rubocop/cop/chef/deprecation/execute_relative_creates_without_cwd.rb
+- lib/rubocop/cop/chef/deprecation/foodcritic_file.rb
 - lib/rubocop/cop/chef/deprecation/foodcritic_testing.rb
 - lib/rubocop/cop/chef/deprecation/hwrp_without_provides.rb
 - lib/rubocop/cop/chef/deprecation/hwrp_without_unified_mode_true.rb