cookstyle 6.19.5 → 6.19.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47388999a2aa49c2d130f1a553e2d17efec6090b4207e39557fc78acb8c4e5a8
-  data.tar.gz: c622b97ecf8c86b337c7bc63ff444c4b305a6a249cc40c598ea800a1ba9cae67
+  metadata.gz: f26b00de7e92bb6cd6e16e2c323c66504b95a098512d78929dda659128c0f828
+  data.tar.gz: ae852bc01e5b7d9e2bab25ef88778650c46a0c0fb463286bc68dc8400892c215
 SHA512:
-  metadata.gz: 4b1f192f83d65beb1360ff7df9648176bbc54398b39eb7e8791f0342f5152e5361bae374514fcb60134cb6348101c78047ab53d57efcfad3cccfa60e03de2234
-  data.tar.gz: db704725caa2dbfa226e6693bee8ced4adeaaf45d531c5665ff3c602cb7d9b3392676917d814f44b5bb4e7fb015c3c52ce94e812b6ef017fd117210d0ff35252
+  metadata.gz: 69f6664c011cd99a25a1a2695c156190eea02c952e3dfcef41de670de003d3ccfb3a927c9967c3f1ea887294a0acdbd11280b61b410382dc20231fa408abf6a8
+  data.tar.gz: 1a0a759425be48591153c51e14d06324a3edc240eae193e99110870f62785405043f5847c5ee112157288c11c529614ed920fa17d3b281392d8798d8679723c2

data/Gemfile

@@ -17,8 +17,12 @@ group :docs do
 end
 
 group :profiling do
-  gem 'stackprof'
   gem 'memory_profiler'
+  gem 'stackprof'
+end
+
+group :rubocop_gems do
+  gem 'rubocop-performance'
 end
 
 group :development do

data/lib/cookstyle/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 module Cookstyle
-  VERSION = "6.19.5" # rubocop: disable Style/StringLiterals
+  VERSION = "6.19.11" # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '0.92.0'
 end

data/lib/rubocop/cop/chef/correctness/chef_application_fatal.rb

@@ -33,6 +33,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Use raise to force Chef Infra Client to fail instead of using Chef::Application.fatal'
+          RESTRICT_ON_SEND = [:fatal!].freeze
 
           def_node_matcher :application_fatal?, <<-PATTERN
             (send

data/lib/rubocop/cop/chef/correctness/incorrect_library_injection.rb

@@ -37,6 +37,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Libraries should be injected into the Chef::DSL::Recipe class and not Chef::Recipe or Chef::Provider classes directly.'
+          RESTRICT_ON_SEND = [:send, :include].freeze
 
           def_node_search :correct_injection?, <<-PATTERN
             {(send

data/lib/rubocop/cop/chef/correctness/invalid_platform_values_in_case.rb

@@ -35,6 +35,7 @@ module RuboCop
           include ::RuboCop::Chef::PlatformHelpers
 
           MSG = 'Use valid platform values in case statements.'
+          RESTRICT_ON_SEND = [:[]].freeze
 
           def_node_matcher :node_platform?, <<-PATTERN
             (send (send nil? :node) :[] (str "platform") )

data/lib/rubocop/cop/chef/correctness/invalid_version_metadata.rb

@@ -32,6 +32,7 @@ module RuboCop
         #
         class InvalidVersionMetadata < Base
           MSG = 'Cookbook metadata.rb version field should follow X.Y.Z version format.'
+          RESTRICT_ON_SEND = [:version].freeze
 
           def_node_matcher :version?, '(send nil? :version $str ...)'
 

data/lib/rubocop/cop/chef/correctness/node_normal.rb

@@ -39,6 +39,7 @@ module RuboCop
         #
         class NodeNormal < Base
           MSG = 'Do not use node.normal. Replace with default/override/force_default/force_override attribute levels.'
+          RESTRICT_ON_SEND = [:normal].freeze
 
           def_node_matcher :node_normal?, <<-PATTERN
             (send (send _ :node) :normal)

data/lib/rubocop/cop/chef/correctness/node_normal_unless.rb

@@ -39,6 +39,7 @@ module RuboCop
         #
         class NodeNormalUnless < Base
           MSG = 'Do not use node.normal_unless. Replace with default/override/force_default/force_override attribute levels.'
+          RESTRICT_ON_SEND = [:normal_unless].freeze
 
           def_node_matcher :node_normal_unless?, <<-PATTERN
             (send (send _ :node) :normal_unless)

data/lib/rubocop/cop/chef/correctness/node_save.rb

@@ -30,6 +30,7 @@ module RuboCop
         #
         class CookbookUsesNodeSave < Base
           MSG = "Don't use node.save to save partial node data to the Chef Infra Server mid-run unless it's absolutely necessary. Node.save can result in failed Chef Infra runs appearing in search and increases load on the Chef Infra Server."
+          RESTRICT_ON_SEND = [:save].freeze
 
           def_node_matcher :node_save?, <<-PATTERN
             (send (send nil? :node) :save)

data/lib/rubocop/cop/chef/deprecation/chef_shellout.rb

@@ -41,7 +41,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "Don't use deprecated Chef::ShellOut which was removed in Chef Infra Client 13. Use Mixlib::ShellOut instead, which behaves identically."
-          # RESTRICT_ON_SEND = [:new, :require, :include].freeze
+          RESTRICT_ON_SEND = [:new, :require, :include].freeze
 
           def_node_matcher :include_shellout?, <<-PATTERN
           (send nil? :include

data/lib/rubocop/cop/chef/deprecation/chef_windows_platform_helper.rb

@@ -33,6 +33,7 @@ module RuboCop
         class ChefWindowsPlatformHelper < Base
           extend AutoCorrector
           MSG = "Use `platform?('windows')` instead of the legacy `Chef::Platform.windows?` helper."
+          RESTRICT_ON_SEND = [:windows?].freeze
 
           def_node_matcher :chef_platform_windows?, <<-PATTERN
             (send

data/lib/rubocop/cop/chef/deprecation/deprecated_chefspec_platform.rb

@@ -32,8 +32,6 @@ module RuboCop
 
           MSG = "Use currently supported platforms in ChefSpec listed at https://github.com/chefspec/fauxhai/blob/master/PLATFORMS.md. Fauxhai / ChefSpec will perform fuzzy matching on platform version so it's always best to be less specific ie. 10 instead of 10.3"
 
-          Gem::Dependency.new('', ['~> 1.4.5', '>= 1.4.6']).match?('', '1.4.6')
-
           DEPRECATED_MAPPING = {
             'amazon' => {
               '2017.12' => '2',

data/lib/rubocop/cop/chef/deprecation/deprecated_platform_methods.rb

@@ -44,6 +44,7 @@ module RuboCop
 
         class DeprecatedPlatformMethods < Base
           MSG = 'Use provider_for_action or provides instead of the deprecated Chef::Platform methods in resources, which were removed in Chef Infra Client 13.'
+          RESTRICT_ON_SEND = [:provider_for_resource, :find_provider, :find_provider_for_node, :set].freeze
 
           def_node_matcher :platform_method?, <<-PATTERN
             (send (const (const nil? :Chef) :Platform) {:provider_for_resource :find_provider :find_provider_for_node :set} ... )

data/lib/rubocop/cop/chef/deprecation/legacy_notify_syntax.rb

@@ -78,7 +78,7 @@ module RuboCop
                                 else
                                   "\"#{type.source}[\#{#{name.source}}]\""
                                 end
-                new_val = "#{notify_type} #{action.source}, #{service_value}".dup
+                new_val = +"#{notify_type} #{action.source}, #{service_value}"
                 new_val << ", #{timing.first.source}" unless timing.empty?
                 corrector.replace(node, new_val)
               end

data/lib/rubocop/cop/chef/deprecation/node_deep_fetch.rb

@@ -37,6 +37,8 @@ module RuboCop
         class NodeDeepFetch < Base
           extend RuboCop::Cop::AutoCorrector
 
+          RESTRICT_ON_SEND = [:deep_fetch, :deep_fetch!].freeze
+
           def_node_matcher :node_deep_fetch?, <<-PATTERN
             (send (send _ :node) ${:deep_fetch :deep_fetch!} _)
           PATTERN

data/lib/rubocop/cop/chef/deprecation/node_methods_not_attributes.rb

@@ -41,9 +41,29 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Use node attributes to access Ohai data instead of node methods, which were deprecated in Chef Infra Client 13.'
+          RESTRICT_ON_SEND = %i(
+            current_user
+            domain
+            fqdn
+            hostname
+            ip6address
+            ipaddress
+            macaddress
+            machinename
+            ohai_time
+            os
+            os_version
+            platform
+            platform_build
+            platform_family
+            platform_version
+            root_group
+            shard_seed
+            uptime
+            uptime_seconds).freeze
 
           def_node_matcher :node_ohai_methods?, <<-PATTERN
-            (send (send nil? :node) #non_nested_ohai_attribute?)
+            (send (send nil? :node) _)
           PATTERN
 
           def on_send(node)
@@ -53,31 +73,6 @@ module RuboCop
               end
             end
           end
-
-          private
-
-          def non_nested_ohai_attribute?(attribute)
-            %i(
-              current_user
-              domain
-              fqdn
-              hostname
-              ip6address
-              ipaddress
-              macaddress
-              machinename
-              ohai_time
-              os
-              os_version
-              platform
-              platform_build
-              platform_family
-              platform_version
-              root_group
-              shard_seed
-              uptime
-              uptime_seconds).include?(attribute)
-          end
         end
       end
     end

data/lib/rubocop/cop/chef/deprecation/node_set.rb

@@ -34,6 +34,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Do not use node.set. Replace with node.normal to keep identical behavior.'
+          RESTRICT_ON_SEND = [:set].freeze
 
           def_node_matcher :node_set?, <<-PATTERN
             (send (send _ :node) $:set)

data/lib/rubocop/cop/chef/deprecation/node_set_unless.rb

@@ -34,6 +34,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Do not use node.set_unless. Replace with node.normal_unless to keep identical behavior.'
+          RESTRICT_ON_SEND = [:set_unless].freeze
 
           def_node_matcher :node_set_unless?, <<-PATTERN
             (send (send _ :node) $:set_unless)

data/lib/rubocop/cop/chef/deprecation/node_set_without_level.rb

@@ -36,6 +36,7 @@ module RuboCop
         #
         class NodeSetWithoutLevel < Base
           MSG = 'When setting a node attribute in Chef Infra Client 11 and later you must specify the precedence level.'
+          RESTRICT_ON_SEND = [:[]=, :<<].freeze
 
           def on_op_asgn(node)
             # make sure it was a += or -=

data/lib/rubocop/cop/chef/deprecation/partial_search_class_usage.rb

@@ -49,6 +49,7 @@ module RuboCop
         #
         class PartialSearchClassUsage < Base
           MSG = 'Legacy Chef::PartialSearch class usage should be updated to use the search helper instead with the filter_result key.'
+          RESTRICT_ON_SEND = [:new].freeze
 
           def_node_matcher :partial_search_class?, <<-PATTERN
             (send (const (const ... :Chef) :PartialSearch) :new)

data/lib/rubocop/cop/chef/deprecation/powershell_cookbook_helpers.rb

@@ -36,6 +36,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "Use node['powershell']['version'] or the new powershell_version helper available in Chef Infra Client 15.8+ instead of the deprecated PowerShell cookbook helpers."
+          RESTRICT_ON_SEND = [:powershell_version?].freeze
 
           def_node_matcher :ps_cb_helper?, <<-PATTERN
           (send

data/lib/rubocop/cop/chef/deprecation/resource_overrides_provides_method.rb

@@ -34,12 +34,12 @@ module RuboCop
         class ResourceOverridesProvidesMethod < Base
           MSG = "Don't override the provides? method in a resource provider. Use provides :SOME_PROVIDER_NAME instead. This will cause failures in Chef Infra Client 13 and later."
 
-          def_node_search :provides, '(send nil? :provides ...)'
+          def_node_search :calls_provides?, '(send nil? :provides ...)'
 
           def on_def(node)
             return unless node.method_name == :provides?
 
-            add_offense(node, message: MSG, severity: :warning) if provides(processed_source.ast).count == 0
+            add_offense(node, message: MSG, severity: :warning) unless calls_provides?(processed_source.ast)
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/windows_version_helpers.rb

@@ -42,6 +42,7 @@ module RuboCop
           minimum_target_chef_version '14.0'
 
           MSG = "Use node['platform_version'] and node['kernel'] data introduced in Chef Infra Client 14 instead of the deprecated Windows::VersionHelper helpers from the Windows cookbook."
+          RESTRICT_ON_SEND = [:nt_version, :server_version?, :core_version?, :workstation_version?].freeze
 
           def_node_matcher :windows_helper?, <<-PATTERN
             (send ( const ( const {nil? cbase} :Windows ) :VersionHelper ) $_ )

data/lib/rubocop/cop/chef/modernize/compile_time_resources.rb

@@ -35,6 +35,7 @@ module RuboCop
         #
         class ResourceForcingCompileTime < Base
           MSG = "Set 'compile_time true' in resources when available instead of forcing resources to run at compile time by setting an action on the block."
+          RESTRICT_ON_SEND = [:run_action].freeze
 
           def_node_matcher :compile_time_resource?, <<-PATTERN
             (send (block (send nil? {:build_essential :chef_gem :hostname :ohai_hint} (...)) (args) (...)) $:run_action (sym ...))

data/lib/rubocop/cop/chef/modernize/conditional_using_test.rb

@@ -36,7 +36,7 @@ module RuboCop
           RESTRICT_ON_SEND = [:not_if, :only_if].freeze
 
           def_node_matcher :resource_conditional?, <<~PATTERN
-          (send nil? {:not_if :only_if} $str )
+            (send nil? {:not_if :only_if} $str )
           PATTERN
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/databag_helpers.rb

@@ -35,6 +35,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'Use the `data_bag_item` helper instead of `Chef::DataBagItem.load` or `Chef::EncryptedDataBagItem.load`.'
+          RESTRICT_ON_SEND = [:load].freeze
 
           def_node_matcher :data_bag_class_load?, <<-PATTERN
           (send

data/lib/rubocop/cop/chef/modernize/node_init_package.rb

@@ -43,6 +43,7 @@ module RuboCop
           extend RuboCop::Cop::AutoCorrector
 
           MSG = "Use node['init_package'] to check for systemd instead of reading the contents of '/proc/1/comm'"
+          RESTRICT_ON_SEND = [:open, :read, :exist?, :==, :not_if, :only_if].freeze
 
           def_node_matcher :file_reads_proc_1_comm?, <<-PATTERN
             (send (const {(cbase) nil?} {:File :IO}) {:open :read} (str "/proc/1/comm"))
@@ -62,7 +63,7 @@ module RuboCop
           PATTERN
 
           def_node_matcher :file_systemd_conditional?, <<~PATTERN
-          (send nil? {:not_if :only_if} $(str "test -f /bin/systemctl && /bin/systemctl"))
+            (send nil? {:not_if :only_if} $(str "test -f /bin/systemctl && /bin/systemctl"))
           PATTERN
 
           def on_send(node)

data/lib/rubocop/cop/chef/modernize/node_roles_include.rb

@@ -33,6 +33,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "Use `node.role?('foo')` to check if a node includes a role instead of `node['roles'].include?('foo')`."
+          RESTRICT_ON_SEND = [:include?].freeze
 
           def_node_matcher :node_role_include?, <<-PATTERN
           (send

data/lib/rubocop/cop/chef/modernize/respond_to_metadata.rb

@@ -69,7 +69,7 @@ module RuboCop
           end
 
           def_node_matcher :if_respond_to?, <<~PATTERN
-          (if (send nil? :respond_to? _ ) ... )
+            (if (send nil? :respond_to? _ ) ... )
           PATTERN
         end
       end

data/lib/rubocop/cop/chef/modernize/respond_to_provides.rb

@@ -45,16 +45,16 @@ module RuboCop
           end
 
           def_node_matcher :if_respond_to_provides?, <<~PATTERN
-          (if
-            {
-            (send nil? :respond_to?
-              (sym :provides))
+            (if
+              {
+              (send nil? :respond_to?
+                (sym :provides))
 
-            (:defined?
-              (send nil? :provides))
-            }
-            (send nil? :provides
-              (sym _)) ... )
+              (:defined?
+                (send nil? :provides))
+              }
+              (send nil? :provides
+                (sym _)) ... )
           PATTERN
         end
       end

data/lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb

@@ -43,7 +43,7 @@ module RuboCop
           end
 
           def_node_matcher :if_respond_to_resource_name?, <<~PATTERN
-          (if (send nil? :respond_to? ( :sym :resource_name ) ) ... )
+            (if (send nil? :respond_to? ( :sym :resource_name ) ) ... )
           PATTERN
         end
       end

data/lib/rubocop/cop/chef/modernize/shell_out_helper.rb

@@ -37,6 +37,7 @@ module RuboCop
           minimum_target_chef_version '12.11'
 
           MSG = "Use the built-in `shell_out` helper available in Chef Infra Client 12.11+ instead of calling `Mixlib::ShellOut.new('foo').run_command`."
+          RESTRICT_ON_SEND = [:run_command].freeze
 
           def_node_matcher :mixlib_shellout_run_cmd?, <<-PATTERN
           (send

data/lib/rubocop/cop/chef/redundant/double_compile_time.rb

@@ -37,6 +37,7 @@ module RuboCop
           extend RuboCop::Cop::AutoCorrector
 
           MSG = "If a resource includes the `compile_time` property there's no need to also use `.run_action(:some_action)` on the resource block."
+          RESTRICT_ON_SEND = [:run_action].freeze
 
           def_node_matcher :compile_time_and_run_action?, <<-PATTERN
           (send

data/lib/rubocop/cop/chef/redundant/name_property_and_required.rb

@@ -61,6 +61,7 @@ module RuboCop
         #
         class NamePropertyIsRequired < Base
           MSG = 'Resource properties marked as name properties should not also be required properties'
+          RESTRICT_ON_SEND = [:property, :attribute].freeze
 
           # match on a property or attribute that has any name and any type and a hash that
           # contains name_property: true and required: true. These are wrapped in <> which means

data/lib/rubocop/cop/chef/redundant/ohai_attribute_to_string.rb

@@ -46,6 +46,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "This Ohai node attribute is already a string and doesn't need to be converted"
+          RESTRICT_ON_SEND = [:to_s].freeze
 
           def_node_matcher :attribute_to_s?, <<-PATTERN
             (send (send (send nil? :node) :[] $(str {"platform" "platform_family" "platform_version" "fqdn" "hostname" "os" "name"}) ) :to_s )

data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb

@@ -36,6 +36,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = 'There is no need to validate the input of properties in resources using a regex value that will always pass.'
+          RESTRICT_ON_SEND = [:property, :attribute].freeze
 
           def_node_matcher :property_with_regex_splat?, <<-PATTERN
             (send nil? {:property :attribute} (sym _) ... (hash <$(pair (sym :regex) (regexp (str ".*") (regopt))) ...>))

data/lib/rubocop/cop/chef/style/attribute_keys.rb

@@ -45,6 +45,7 @@ module RuboCop
           include RuboCop::Cop::ConfigurableEnforcedStyle
 
           MSG = 'Use %s to access node attributes'
+          RESTRICT_ON_SEND = [:[]].freeze
 
           def_node_matcher :node_attribute_access?, <<-PATTERN
             (send (send _ :node) :[] _)

data/lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb

@@ -38,6 +38,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "Use node['platform_version'].to_i instead of node['platform_version'].split('.').first or node['platform_version'].split('.')[0]"
+          RESTRICT_ON_SEND = [:split].freeze
 
           def_node_matcher :platform_version_check?, <<-PATTERN
             (send (send (send nil? :node) :[] (str "platform_version") ) :split (str ".") )

data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb

@@ -39,6 +39,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values."
+          RESTRICT_ON_SEND = [:==, :!=, :eql?, :include?].freeze
 
           # sorted list of all the os values that match 1:1 with a platform_family
           UNNECESSARY_OS_VALUES = %w(aix darwin dragonflybsd freebsd netbsd openbsd solaris2 windows).freeze

data/lib/rubocop/cop/chef/style/use_platform_helpers.rb

@@ -42,6 +42,7 @@ module RuboCop
           extend AutoCorrector
 
           MSG = "Use platform? and platform_family? helpers to check a node's platform"
+          RESTRICT_ON_SEND = [:==, :!=, :eql?, :include?].freeze
 
           def_node_matcher :platform_equals?, <<-PATTERN
             (send (send (send nil? :node) :[] $(str {"platform" "platform_family"}) ) ${:== :!=} $str )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 6.19.5
+  version: 6.19.11
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-09-28 00:00:00.000000000 Z
+date: 2020-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop