cookstyle 5.5.7 → 5.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0322e55fbe3e8ec36d29d1cc23fccb0bb23c4025d46bcd629d476adb7bf40eba
-  data.tar.gz: 5962352d31f41fbb630963a0ae68d096afda0d6daae6b5f49fd426794e287232
+  metadata.gz: b1802f69a48b5c25b599199ac6e97ebd036bc1c92a6e33653700ddcd48565f6e
+  data.tar.gz: 12ce2bf3e7d4b3e2cf254bfe9fad557eb7c077ae52c2572f9262fca194048d90
 SHA512:
-  metadata.gz: 8bd4f43082807bea03e36e319a9c71cbe49f92f250b4a8e14fc8dd99b2aeaaa687e3802a4abfc575556d691f8d888b94a23231cc7c89d8ffd669baf28ae3b243
-  data.tar.gz: 27dc56eb8c75ada36578b55a36c19d9ff1d8dfd96c0e95190581ffc5a80030918b475cd9d156219fa1559acd2d1f3d178351c009793030f0d2d70f9afa89e8d0
+  metadata.gz: bd1ab13eecd20c9bf2777d46da546f880a3f94cf2d0411a36ebdc7e5117974bf534489619e87cfc0eeafb26ae14d406c82f497b022054464ef440fb4068c69c3
+  data.tar.gz: 1cb23f278d044fc0acd6b818a94664e0c078aeeba78a639a9ade4fbadb5065addf62454fa78d31beed80209d11ecc9a54af3182223a233439b19a15210c1c63d

data/config/cookstyle.yml

@@ -63,6 +63,14 @@ ChefStyle/FileMode:
   Exclude:
     - '**/metadata.rb'
 
+ChefStyle/UsePlatformHelpers:
+  Description: Use platform? and platform_family? helpers for checking node platform in resources and recipes
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+    - '**/libraries/*'
+
 ###############################
 # ChefCorrectness: Avoiding potential problems
 ###############################
@@ -274,6 +282,13 @@ ChefDeprecations/LongDescriptionMetadata:
   Include:
     - '**/metadata.rb'
 
+ChefDeprecations/RecipeMetadata:
+  Description: The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the README.md file instead.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Include:
+    - '**/metadata.rb'
+
 ChefDeprecations/CookbookDependsOnCompatResource:
   Description: Don't depend on the deprecated compat_resource cookbook made obsolete by Chef 12.19+
   Enabled: true
@@ -390,6 +405,13 @@ ChefDeprecations/IncludingYumDNFCompatRecipe:
   Exclude:
     - '**/metadata.rb'
 
+ChefDeprecations/WindowsTaskChangeAction:
+  Description: The :change action in the windows_task resource was removed when windows_task was added to Chef Infra Client 13+. The default action of :create should can now be used to create an update tasks.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
 ###############################
 # ChefModernize: Cleaning up legacy code and using new built-in resources
 ###############################
@@ -568,6 +590,69 @@ ChefModernize/ShellOutToChocolatey:
   Exclude:
     - '**/metadata.rb'
 
+ChefModernize/CronManageResource:
+  Description: The cron_manage resource was renamed to cron_access in the 6.1 release of the cron cookbook and later shipped in Chef Infra Client 14.4. The new resource name should be used.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
+ChefModernize/UsesZypperRepo:
+  Description: The zypper_repo resource was renamed zypper_repository when it was added to Chef Infra Client 13.3.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
+ChefModernize/DependsOnZypperCookbook:
+  Description: Don't include the zypper cookbook as the zypper_repository resource is built into Chef Infra Client 13.3+
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
+ChefModernize/ExecuteTzUtil:
+  Description: Use the timezone resource included in Chef Infra Client 14.6+ instead of shelling out to tzutil
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
+ChefModernize/OpensslRsaKeyResource:
+  Description: The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef Infra Client 14.0. The new resource name should be used.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
+ChefModernize/OpensslX509Resource:
+  Description: The openssl_x509 resource was renamed to openssl_x509_certificate. The new resource name should be used.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
+ChefModernize/OsxConfigProfileResource:
+  Description: The osx_config_profile resource was renamed to osx_profile. The new resource name should be used.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
+ChefModernize/SysctlParamResource:
+  Description: The sysctl_param resource was renamed to sysctl when it was added to Chef Infra Client 14.0. The new resource name should be used.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
+ChefModernize/MacOsXUserdefaults:
+  Description: The mac_os_x_userdefaults resource was renamed to macos_userdefaults when it was added to Chef Infra Client 14.0. The new resource name should be used.
+  Enabled: true
+  VersionAdded: '5.6.0'
+  Exclude:
+    - '**/metadata.rb'
+
 ###############################
 # Migrating to new patterns
 ###############################

data/lib/cookstyle/version.rb

@@ -1,4 +1,4 @@
 module Cookstyle
-  VERSION = "5.5.7".freeze # rubocop: disable Style/StringLiterals
+  VERSION = "5.6.2".freeze # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '0.72.0'.freeze
 end

data/lib/rubocop/cop/chef/deprecation/recipe_metadata.rb

@@ -0,0 +1,47 @@
+#
+# Copyright:: 2019, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      module ChefDeprecations
+        # The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented
+        # in the README.md file instead.
+        #
+        # @example
+        #
+        #   # bad
+        #   recipe 'openldap::default', 'Install and configure OpenLDAP'
+        #
+        #
+        class RecipeMetadata < Cop
+          MSG = 'The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the README.md file instead.'.freeze
+
+          def on_send(node)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :recipe
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.remove(node.loc.expression)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb

@@ -0,0 +1,82 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefDeprecations
+        # The :change action in the windows_task resource was removed when windows_task was added to Chef Infra Client 13+
+        # The default action of :create should can now be used to create an update tasks.
+        #
+        # @example
+        #
+        #   # bad
+        #   windows_task 'chef ad-join leave start time' do
+        #     task_name 'chef ad-join leave'
+        #     start_day '06/09/2016'
+        #     start_time '01:00'
+        #     action [:change, :create]
+        #   end
+        #
+        #   # good
+        #   windows_task 'chef ad-join leave start time' do
+        #     task_name 'chef ad-join leave'
+        #     start_day '06/09/2016'
+        #     start_time '01:00'
+        #     action :create
+        #   end
+        #
+        class WindowsTaskChangeAction < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'The :change action in the windows_task resource was removed when windows_task was added to Chef Infra Client 13+. The default action of :create should can now be used to create an update tasks.'.freeze
+
+          def on_block(node)
+            match_property_in_resource?(:windows_task, 'action', node) do |action_node|
+              action_values = action_node.arguments.first
+
+              if action_values.sym_type? # there's only a single action given
+                check_action(action_values)
+              else # it was an array of actions
+                action_values.node_parts.each { |action| check_action(action) }
+              end
+            end
+          end
+
+          def autocorrect(node)
+            if node.parent.send_type? # :change was the only action
+              lambda do |corrector|
+                corrector.replace(node.loc.expression, ':create')
+              end
+            # chances are it's [:create, :change] since that's all that makes sense, but double check that theory
+            elsif node.parent.child_nodes.count == 2 &&
+                  node.parent.child_nodes.map(&:value).sort == [:change, :create]
+              lambda do |corrector|
+                corrector.replace(node.parent.loc.expression, ':create')
+              end
+            end
+          end
+
+          private
+
+          def check_action(ast_obj)
+            add_offense(ast_obj, location: :expression, message: MSG, severity: :refactor) if ast_obj.value == :change
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/cron_manage_resource.rb

@@ -0,0 +1,49 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # The cron_manage resource was renamed to cron_access in the 6.1 release of the cron
+        # cookbook, and later shipped in Chef Infra Client 14.4. The new resource name should
+        # be used.
+        #
+        #   # bad
+        #   cron_manage 'mike'
+        #
+        #   # good
+        #   cron_access 'mike'
+        #
+        class CronManageResource < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'The cron_manage resource was renamed to cron_access in the 6.1 release of the cron cookbook and later shipped in Chef Infra Client 14.4. The new resource name should be used.'.freeze
+
+          def on_send(node)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :cron_manage
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, node.source.gsub(/^cron_manage/, 'cron_access'))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb

@@ -0,0 +1,51 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # Don't depend the zypper cookbook as the zypper_repository resource is built into
+        # Chef Infra Client 13.3
+        #
+        # @example
+        #
+        #   # bad
+        #   depends 'zypper'
+        #
+        class DependsOnZypperCookbook < Cop
+          MSG = "Don't include the zypper cookbook as the zypper_repository resource is built into Chef Infra Client 13.3+".freeze
+
+          def_node_matcher :zypper_depends?, <<-PATTERN
+            (send nil? :depends (str "zypper"))
+          PATTERN
+
+          def on_send(node)
+            zypper_depends?(node) do
+              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.remove(node.loc.expression)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/execute_tzutil.rb

@@ -0,0 +1,74 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # Instead of using the execute or powershell_script resources to to run the `tzutil` command, use
+        # Chef Infra Client's built-in timezone resource which is available in Chef Infra Client 14.6 and later.
+        #
+        #   # bad
+        #   execute 'set tz' do
+        #     command 'tzutil.exe /s UTC'
+        #   end
+        #
+        #   execute 'tzutil /s UTC'
+        #
+        #   powershell_script 'set windows timezone' do
+        #     code "tzutil.exe /s UTC"
+        #     not_if { shell_out('tzutil.exe /g').stdout.include?('UTC') }
+        #   end
+        #
+        #   # good
+        #   timezone 'UTC'
+        #
+        class ExecuteTzUtil < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'Use the timezone resource included in Chef Infra Client 14.6+ instead of shelling out to tzutil'.freeze
+
+          def_node_matcher :execute_resource?, <<-PATTERN
+            (send nil? :execute $str)
+          PATTERN
+
+          def on_send(node)
+            execute_resource?(node) do
+              add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.arguments.first.value.match?(/^tzutil/i)
+            end
+          end
+
+          def on_block(node)
+            match_property_in_resource?(:execute, 'command', node) do |code_property|
+              add_offense(node, location: :expression, message: MSG, severity: :refactor) if calls_tzutil?(code_property)
+            end
+
+            match_property_in_resource?(:powershell_script, 'code', node) do |code_property|
+              add_offense(node, location: :expression, message: MSG, severity: :refactor) if calls_tzutil?(code_property)
+            end
+          end
+
+          private
+
+          def calls_tzutil?(ast_obj)
+            property_data = method_arg_ast_to_string(ast_obj)
+            return true if property_data && property_data.match?(/^tzutil/i)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/macos_user_defaults.rb

@@ -0,0 +1,56 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # The mac_os_x_userdefaults resource was renamed to macos_userdefaults when it was added to Chef Infra Client
+        # 14.0. The new resource name should be used.
+        #
+        #   # bad
+        #   mac_os_x_userdefaults 'full keyboard access to all controls' do
+        #     domain 'AppleKeyboardUIMode'
+        #     global true
+        #     value '2'
+        #   end
+        #
+        #   # good
+        #   macos_userdefaults 'full keyboard access to all controls' do
+        #     domain 'AppleKeyboardUIMode'
+        #     global true
+        #     value '2'
+        #   end
+        #
+        class MacOsXUserdefaults < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'The mac_os_x_userdefaults resource was renamed to macos_userdefaults when it was added to Chef Infra Client 14.0. The new resource name should be used.'.freeze
+
+          def on_send(node)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :mac_os_x_userdefaults
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, node.source.gsub(/^mac_os_x_userdefaults/, 'macos_userdefaults'))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb

@@ -0,0 +1,52 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef
+        # Infra Client 14.0. The new resource name should be used.
+        #
+        #   # bad
+        #   openssl_rsa_key '/etc/httpd/ssl/server.key' do
+        #     key_length 2048
+        #   end
+        #
+        #   # good
+        #   openssl_rsa_private_key '/etc/httpd/ssl/server.key' do
+        #     key_length 2048
+        #   end
+        #
+        class OpensslRsaKeyResource < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'The openssl_rsa_key resource was renamed to openssl_rsa_private_key in Chef Infra Client 14.0. The new resource name should be used.'.freeze
+
+          def on_send(node)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :openssl_rsa_key
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, node.source.gsub(/^openssl_rsa_key/, 'openssl_rsa_private_key'))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb

@@ -0,0 +1,58 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # The openssl_x509 resource was renamed to openssl_x509_certificate.
+        # The new resource name should be used.
+        #
+        #   # bad
+        #   openssl_x509 '/etc/httpd/ssl/mycert.pem' do
+        #     common_name 'www.f00bar.com'
+        #     org 'Foo Bar'
+        #     org_unit 'Lab'
+        #     country 'US'
+        #   end
+        #
+        #   # good
+        #   openssl_x509_certificate '/etc/httpd/ssl/mycert.pem' do
+        #     common_name 'www.f00bar.com'
+        #     org 'Foo Bar'
+        #     org_unit 'Lab'
+        #     country 'US'
+        #   end
+        #
+        class OpensslX509Resource < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'The openssl_x509 resource was renamed to openssl_x509_certificate. The new resource name should be used.'.freeze
+
+          def on_send(node)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :openssl_x509
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, node.source.gsub(/^openssl_x509/, 'openssl_x509_certificate'))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb

@@ -0,0 +1,52 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # The osx_config_profile resource was renamed to osx_profile.
+        # The new resource name should be used.
+        #
+        #   # bad
+        #   osx_config_profile 'Install screensaver profile' do
+        #     profile 'screensaver/com.company.screensaver.mobileconfig'
+        #   end
+        #
+        #   # good
+        #   osx_profile 'Install screensaver profile' do
+        #     profile 'screensaver/com.company.screensaver.mobileconfig'
+        #   end
+        #
+        class OsxConfigProfileResource < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'The osx_config_profile resource was renamed to osx_profile. The new resource name should be used.'.freeze
+
+          def on_send(node)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :osx_config_profile
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, node.source.gsub(/^osx_config_profile/, 'osx_profile'))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/systctl_param_resource.rb

@@ -0,0 +1,52 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # The sysctl_param resource was renamed to sysctl when it was added to Chef Infra Client
+        # 14.0. The new resource name should be used.
+        #
+        #   # bad
+        #   sysctl_param 'fs.aio-max-nr' do
+        #     value '1048576'
+        #   end
+        #
+        #   # good
+        #   sysctl 'fs.aio-max-nr' do
+        #     value '1048576'
+        #   end
+        #
+        class SysctlParamResource < Cop
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'The sysctl_param resource was renamed to sysctl when it was added to Chef Infra Client 14.0. The new resource name should be used.'.freeze
+
+          def on_send(node)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :sysctl_param
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, node.source.gsub(/^sysctl_param/, 'sysctl'))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/modernize/zypper_repo.rb

@@ -0,0 +1,57 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # The zypper_repo resource was renamed zypper_repository when it was added to Chef Infra Client 13.3.
+        #
+        # @example
+        #
+        #   # bad
+        #   zypper_repo 'apache' do
+        #     baseurl 'http://download.opensuse.org/repositories/Apache'
+        #     path '/openSUSE_Leap_42.2'
+        #     type 'rpm-md'
+        #     priority '100'
+        #   end
+        #
+        #   # good
+        #   zypper_repository 'apache' do
+        #     baseurl 'http://download.opensuse.org/repositories/Apache'
+        #     path '/openSUSE_Leap_42.2'
+        #     type 'rpm-md'
+        #     priority '100'
+        #   end
+        #
+        class UsesZypperRepo < Cop
+          MSG = 'The zypper_repo resource was renamed zypper_repository when it was added to Chef Infra Client 13.3.'.freeze
+
+          def on_send(node)
+            add_offense(node, location: :expression, message: MSG, severity: :refactor) if node.method_name == :zypper_repo
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, node.source.gsub(/^zypper_repo/, 'zypper_repository'))
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/style/use_platform_helpers.rb

@@ -0,0 +1,59 @@
+#
+# Copyright:: 2019, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefStyle
+        # Use the platform?() and platform_family?() helpers instead of node['platform] == 'foo'
+        # and node['platform_family'] == 'bar'. These helpers are easier to read and can accept multiple
+        # platform arguments, which greatly simplifies complex platform logic.
+        #
+        # @example
+        #
+        #   # bad
+        #   node['platform'] == 'ubuntu'
+        #
+        #   # good
+        #   platform?('ubuntu')
+        #
+        class UsePlatformHelpers < Cop
+          MSG = 'Use platform? and platform_family? helpers for checking node platform'.freeze
+
+          def_node_matcher :platform_check?, <<-PATTERN
+            ( send (send (send nil? :node) :[] $(str {"platform" "platform_family"}) ) :== $str )
+          PATTERN
+
+          def on_send(node)
+            platform_check?(node) do |type, plat|
+              # set these so we can use them in the auto_correct method
+              @type = type
+              @plat = plat
+
+              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              corrector.replace(node.loc.expression, "#{@type.value}?('#{@plat.value}')")
+            end
+          end
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 5.5.7
+  version: 5.6.2
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-06 00:00:00.000000000 Z
+date: 2019-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -113,11 +113,13 @@ files:
 - lib/rubocop/cop/chef/deprecation/node_set.rb
 - lib/rubocop/cop/chef/deprecation/node_set_unless.rb
 - lib/rubocop/cop/chef/deprecation/provides_metadata.rb
+- lib/rubocop/cop/chef/deprecation/recipe_metadata.rb
 - lib/rubocop/cop/chef/deprecation/replaces_metadata.rb
 - lib/rubocop/cop/chef/deprecation/require_recipe.rb
 - lib/rubocop/cop/chef/deprecation/suggests_metadata.rb
 - lib/rubocop/cop/chef/deprecation/use_inline_resources.rb
 - lib/rubocop/cop/chef/deprecation/user_supports_property.rb
+- lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb
 - lib/rubocop/cop/chef/deprecation/xml_ruby_recipe.rb
 - lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb
 - lib/rubocop/cop/chef/effortless/data_bags.rb
@@ -126,11 +128,18 @@ files:
 - lib/rubocop/cop/chef/modernize/berksfile_source.rb
 - lib/rubocop/cop/chef/modernize/build_essential.rb
 - lib/rubocop/cop/chef/modernize/chef_14_resources.rb
+- lib/rubocop/cop/chef/modernize/cron_manage_resource.rb
 - lib/rubocop/cop/chef/modernize/defines_chefspec_matchers.rb
+- lib/rubocop/cop/chef/modernize/depends_zypper_cookbook.rb
 - lib/rubocop/cop/chef/modernize/execute_apt_update.rb
+- lib/rubocop/cop/chef/modernize/execute_tzutil.rb
 - lib/rubocop/cop/chef/modernize/includes_mixin_shellout.rb
 - lib/rubocop/cop/chef/modernize/libarchive_file.rb
+- lib/rubocop/cop/chef/modernize/macos_user_defaults.rb
 - lib/rubocop/cop/chef/modernize/minitest_handler_usage.rb
+- lib/rubocop/cop/chef/modernize/openssl_rsa_key_resource.rb
+- lib/rubocop/cop/chef/modernize/openssl_x509_resource.rb
+- lib/rubocop/cop/chef/modernize/osx_config_profile_resource.rb
 - lib/rubocop/cop/chef/modernize/powershell_expand_archive.rb
 - lib/rubocop/cop/chef/modernize/powershell_install_package.rb
 - lib/rubocop/cop/chef/modernize/powershell_install_windowsfeature.rb
@@ -142,15 +151,18 @@ files:
 - lib/rubocop/cop/chef/modernize/respond_to_resource_name.rb
 - lib/rubocop/cop/chef/modernize/seven_zip_archive.rb
 - lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb
+- lib/rubocop/cop/chef/modernize/systctl_param_resource.rb
 - lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb
 - lib/rubocop/cop/chef/modernize/windows_default_recipe.rb
 - lib/rubocop/cop/chef/modernize/windows_version_helper.rb
 - lib/rubocop/cop/chef/modernize/windows_zipfile.rb
+- lib/rubocop/cop/chef/modernize/zypper_repo.rb
 - lib/rubocop/cop/chef/style/attribute_keys.rb
 - lib/rubocop/cop/chef/style/comment_sentence_spacing.rb
 - lib/rubocop/cop/chef/style/comments_copyright_format.rb
 - lib/rubocop/cop/chef/style/comments_format.rb
 - lib/rubocop/cop/chef/style/file_mode.rb
+- lib/rubocop/cop/chef/style/use_platform_helpers.rb
 homepage: https://github.com/chef/cookstyle
 licenses:
 - Apache-2.0