cookstyle 5.20.0 → 5.21.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c8af7267fe94ef01b9da1d3b84c221101cdb7e8976217cbca2bd8f43c475858
-  data.tar.gz: 3f6196cac78246fc8b36a013f4bbb335470824f3ef23974869596087c8082925
+  metadata.gz: 415ddd30149c8277cf255cd81ceb26835eb969da515e97e748372dc72ba40840
+  data.tar.gz: cf2a3e2be30fff68aabef795aecdb6e489a2ede68f09f21cd3c781c35979846c
 SHA512:
-  metadata.gz: ef274262f9b3e41204d9ee5153c9c4022958659b69a6a4d781848a523d6bb37336101fafe5c30ece1d072118b13422803bfa629ba97605c75bd9588c8ef21e36
-  data.tar.gz: 6fbff49a1400321bee3bec46011d0b3193d8460a702c9749a84e11c9992c5642e75b2e3857ab1c84461c23a31b0e5b4c4dcd186e9ea4a0cc588974fd3e28d4b7
+  metadata.gz: 911b2afb60dbf89849e4a3e349ef784d7e2b29a25ed00a9eca07222a4fd002fd7486d9d1e2baac4c94cf486c8423ba53f2d0bd83d85cfa2ba668daf05056cb11
+  data.tar.gz: 8f81cdfd43904b11c7651d29dc4f26e5bd930af8d68c2be477cf3c59f9f5d5a37a0f20c5b41640054d5c2ec817d4a4c87ea17be6cda9a486a5c1ffd4f4dbfeb1

data/config/cookstyle.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.3
   TargetChefVersion: ~
   Exclude:
     - '**/files/**/*'
@@ -127,6 +127,11 @@ ChefStyle/ChefWhaaat:
   Enabled: false
   VersionAdded: '5.20.0'
 
+ChefStyle/UnnecessaryOSCheck:
+  Description: Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic.
+  Enabled: false
+  VersionAdded: '5.21.0'
+
 ###############################
 # ChefCorrectness: Avoiding potential problems
 ###############################
@@ -1101,6 +1106,15 @@ ChefModernize/ExecuteSysctl:
     - '**/attributes/*.rb'
     - '**/Berksfile'
 
+ChefModernize/SimplifyAptPpaSetup:
+  Description: The apt_repository resource allows setting up PPAs without using the full URL to ppa.launchpad.net.
+  Enabled: true
+  VersionAdded: '5.21.0'
+  Exclude:
+    - '**/metadata.rb'
+    - '**/attributes/*.rb'
+    - '**/Berksfile'
+
 ###############################
 # ChefRedundantCode: Cleanup unnecessary code in your cookbooks regardless of Chef Infra Client release
 ###############################
@@ -1247,6 +1261,22 @@ ChefRedundantCode/GroupingMetadata:
   Include:
     - '**/metadata.rb'
 
+ChefRedundantCode/StringPropertyWithNilDefault:
+  Description: 'Properties have a nil value by default so there is no need to set the default value to nil.'
+  Enabled: true
+  VersionAdded: '5.21.0'
+  Include:
+    - '**/resources/*.rb'
+    - '**/libraries/*.rb'
+
+ChefRedundantCode/PropertySplatRegex:
+  Description: 'There is no need to validate the input of properties in resources using a regex value that will always pass.'
+  Enabled: true
+  VersionAdded: '5.21.0'
+  Include:
+    - '**/resources/*.rb'
+    - '**/libraries/*.rb'
+
 ###############################
 # Migrating to new patterns
 ###############################
@@ -1444,8 +1474,6 @@ Style/MethodDefParentheses:
   Enabled: true
 Naming/MethodName:
   Enabled: true
-Style/ModuleFunction:
-  Enabled: true
 Style/MultilineBlockChain:
   Enabled: true
 Layout/MultilineBlockLayout:
@@ -1625,6 +1653,7 @@ Layout/ConditionPosition:
 Lint/Debugger:
   Enabled: true
 Layout/DefEndAlignment:
+  AutoCorrect: true
   Enabled: true
 Lint/DeprecatedClassMethods:
   Enabled: true
@@ -1642,6 +1671,7 @@ Lint/EmptyInterpolation:
   Enabled: true
 Layout/EndAlignment:
   Enabled: true
+  AutoCorrect: true
 Lint/EndInMethod:
   Enabled: true
 Lint/EnsureReturn:
@@ -1958,3 +1988,8 @@ Style/IfUnlessModifier:
 # in general cookbooks shouldn't include a gemfile, but if they do they can do with it as they wish
 Bundler/OrderedGems:
   Enabled: false
+
+# extend self and module_function are not the same. module_function makes all the methods private
+# and this rule will break any library that worked with extend self.
+Style/ModuleFunction:
+  Enabled: false

data/lib/cookstyle.rb

@@ -38,6 +38,7 @@ module Cookstyle
 end
 
 require_relative 'rubocop/chef'
+require_relative 'rubocop/chef/autocorrect_helpers'
 require_relative 'rubocop/chef/cookbook_helpers'
 require_relative 'rubocop/chef/platform_helpers'
 require_relative 'rubocop/chef/cookbook_only'

data/lib/cookstyle/version.rb

@@ -1,4 +1,4 @@
 module Cookstyle
-  VERSION = "5.20.0".freeze # rubocop: disable Style/StringLiterals
+  VERSION = "5.21.9".freeze # rubocop: disable Style/StringLiterals
   RUBOCOP_VERSION = '0.75.1'.freeze
 end

data/lib/rubocop/chef/autocorrect_helpers.rb

@@ -0,0 +1,32 @@
+#
+# Copyright:: Copyright 2020, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Chef
+    # Helpers for use in autocorrection
+    module AutocorrectHelpers
+      # if the node has a heredoc as an argument you'll only get the start of the heredoc and removing
+      # the node will result in broken ruby. This way we match the node and the entire heredoc for removal
+      def expression_including_heredocs(node)
+        if node.arguments.last.respond_to?(:heredoc?) && node.arguments.last.heredoc?
+          node.loc.expression.join(node.arguments.last.loc.heredoc_end)
+        else
+          node.loc.expression
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/deprecation/windows_task_change_action.rb

@@ -73,7 +73,9 @@ module RuboCop
           private
 
           def check_action(ast_obj)
-            add_offense(ast_obj, location: :expression, message: MSG, severity: :refactor) if ast_obj.value == :change
+            if ast_obj.respond_to?(:value) && ast_obj.value == :change
+              add_offense(ast_obj, location: :expression, message: MSG, severity: :refactor)
+            end
           end
         end
       end

data/lib/rubocop/cop/chef/deprecation/yum_dnf_compat_recipe.rb

@@ -37,6 +37,7 @@ module RuboCop
 
           def on_send(node)
             yum_dnf_compat_recipe_usage?(node) do
+              node = node.parent if node.parent&.conditional? && node.parent&.single_line?
               add_offense(node, location: :expression, message: MSG, severity: :refactor)
             end
           end

data/lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb

@@ -0,0 +1,67 @@
+#
+# Copyright:: 2020, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+module RuboCop
+  module Cop
+    module Chef
+      module ChefModernize
+        # The apt_repository resource allows setting up PPAs without using the full URL to ppa.launchpad.net, which should be used to simplify the resource code in your cookbooks.
+        #
+        # @example
+        #
+        #  # bad
+        #    apt_repository 'atom-ppa' do
+        #      uri 'http://ppa.launchpad.net/webupd8team/atom/ubuntu'
+        #      components ['main']
+        #      keyserver 'keyserver.ubuntu.com'
+        #      key 'C2518248EEA14886'
+        #    end
+        #
+        #  # good
+        #    apt_repository 'atom-ppa' do
+        #      uri 'ppa:webupd8team/atom'
+        #      components ['main']
+        #      keyserver 'keyserver.ubuntu.com'
+        #      key 'C2518248EEA14886'
+        #    end
+        #
+        class SimplifyAptPpaSetup < Cop
+          include RangeHelp
+          include RuboCop::Chef::CookbookHelpers
+
+          MSG = 'The apt_repository resource allows setting up PPAs without using the full URL to ppa.launchpad.net.'.freeze
+
+          def on_block(node)
+            match_property_in_resource?(:apt_repository, 'uri', node) do |uri|
+              if %r{http(s)*://ppa.launchpad.net/(.*)/ubuntu$}.match?(uri.arguments&.first&.str_content)
+                add_offense(uri, location: :expression, message: MSG, severity: :refactor)
+              end
+            end
+          end
+
+          def autocorrect(node)
+            if (replacement_val = %r{http(s)*://ppa.launchpad.net/(.*)/ubuntu}.match(node.source)[2])
+              lambda do |corrector|
+                corrector.replace(node.loc.expression, "uri 'ppa:#{replacement_val}'")
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/redundant/attribute_metadata.rb

@@ -34,6 +34,7 @@ module RuboCop
         #
         class AttributeMetadata < Cop
           include RangeHelp
+          include RuboCop::Chef::AutocorrectHelpers
 
           MSG = 'The attribute metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
@@ -43,7 +44,7 @@ module RuboCop
 
           def autocorrect(node)
             lambda do |corrector|
-              corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :right))
+              corrector.remove(range_with_surrounding_space(range: expression_including_heredocs(node), side: :left))
             end
           end
         end

data/lib/rubocop/cop/chef/redundant/grouping_metadata.rb

@@ -29,6 +29,7 @@ module RuboCop
         #
         class GroupingMetadata < Cop
           include RangeHelp
+          include RuboCop::Chef::AutocorrectHelpers
 
           MSG = 'The grouping metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
@@ -38,7 +39,7 @@ module RuboCop
 
           def autocorrect(node)
             lambda do |corrector|
-              corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
+              corrector.remove(range_with_surrounding_space(range: expression_including_heredocs(node), side: :left))
             end
           end
         end

data/lib/rubocop/cop/chef/redundant/long_description_metadata.rb

@@ -28,6 +28,7 @@ module RuboCop
         #
         class LongDescriptionMetadata < Cop
           include RangeHelp
+          include RuboCop::Chef::AutocorrectHelpers
 
           MSG = 'The long_description metadata.rb method is not used and is unnecessary in cookbooks.'.freeze
 
@@ -37,12 +38,7 @@ module RuboCop
 
           def autocorrect(node)
             lambda do |corrector|
-              if node.arguments.first.respond_to?(:heredoc?) && node.arguments.first.heredoc?
-                total_range = range_with_surrounding_space(range: node.loc.expression.join(node.arguments.first.loc.heredoc_end), side: :left)
-                corrector.remove(total_range)
-              else
-                corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
-              end
+              corrector.remove(range_with_surrounding_space(range: expression_including_heredocs(node), side: :left))
             end
           end
         end

data/lib/rubocop/cop/chef/redundant/property_splat_regex.rb

@@ -0,0 +1,58 @@
+#
+# Copyright:: Copyright 2020, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefRedundantCode
+        # When a property has a type of String it can accept any string. There is no need to also validate string inputs against a regex that accept all values.
+        #
+        # @example
+        #
+        #   # bad
+        #   property :config_file, String, regex: /.*/
+        #   attribute :config_file, String, regex: /.*/
+        #
+        #   # good
+        #   property :config_file, String
+        #   attribute :config_file, String
+        #
+        class PropertySplatRegex < Cop
+          include RangeHelp
+
+          MSG = 'There is no need to validate the input of properties in resources using a regex value that will always pass.'.freeze
+
+          def_node_matcher :property_with_regex_splat?, <<-PATTERN
+            (send nil? {:property :attribute} (sym _) ... (hash <$(pair (sym :regex) (regexp (str ".*") (regopt))) ...>))
+          PATTERN
+
+          def on_send(node)
+            property_with_regex_splat?(node) do |splat|
+              add_offense(splat, location: :expression, message: MSG, severity: :refactor)
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              range = range_with_surrounding_comma(range_with_surrounding_space(range: node.loc.expression, side: :left), :left)
+              corrector.remove(range)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/redundant/recipe_metadata.rb

@@ -29,6 +29,7 @@ module RuboCop
         #
         class RecipeMetadata < Cop
           include RangeHelp
+          include RuboCop::Chef::AutocorrectHelpers
 
           MSG = "The recipe metadata.rb method is not used and is unnecessary in cookbooks. Recipes should be documented in the cookbook's README.md file instead.".freeze
 
@@ -38,7 +39,7 @@ module RuboCop
 
           def autocorrect(node)
             lambda do |corrector|
-              corrector.remove(range_with_surrounding_space(range: node.loc.expression, side: :left))
+              corrector.remove(range_with_surrounding_space(range: expression_including_heredocs(node), side: :left))
             end
           end
         end

data/lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb

@@ -0,0 +1,65 @@
+#
+# Copyright:: Copyright 2019-2020, Chef Software Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefRedundantCode
+        # Properties have a nil value by default so there is no need to set the default value to nil.
+        #
+        # @example
+        #
+        #   # bad
+        #   property :config_file, String, default: nil
+        #   property :config_file, [String, NilClass], default: nil
+        #
+        #   # good
+        #   property :config_file, String
+        #   property :config_file, [String, NilClass]
+        #
+        class StringPropertyWithNilDefault < Cop
+          include RangeHelp
+
+          MSG = 'Properties have a nil value by default so there is no need to set the default value to nil.'.freeze
+
+          def_node_matcher :string_property_with_nil_default?, <<-PATTERN
+            (send nil? :property (sym _)
+            {(const nil? :String) #string_and_nil_like?}
+            (hash <$(pair (sym :default) (nil)) ...>))
+          PATTERN
+
+          # An array of types that includes String & either NilClass or nil
+          def_node_matcher :string_and_nil_like?, <<-PATTERN
+            (array <(const nil? :String) {(const nil? :NilClass) (nil)}>)
+          PATTERN
+
+          def on_send(node)
+            string_property_with_nil_default?(node) do |nil_default|
+              add_offense(nil_default, location: :expression, message: MSG, severity: :refactor)
+            end
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              range = range_with_surrounding_comma(range_with_surrounding_space(range: node.loc.expression, side: :left), :left)
+              corrector.remove(range)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/sharing/invalid_license_string.rb

@@ -439,6 +439,7 @@ module RuboCop
           COMMON_TYPOS = {
             "all_rights": 'all rights reserved',
             "apache 2.0": 'Apache-2.0',
+            "apache v2": 'Apache-2.0',
             "apache v2.0": 'Apache-2.0',
             "apache license version 2.0": 'Apache-2.0',
             "apache2": 'Apache-2.0',

data/lib/rubocop/cop/chef/style/unnecessary_os_check.rb

@@ -0,0 +1,113 @@
+#
+# Copyright:: 2020, Chef Software, Inc.
+# Author:: Tim Smith (<tsmith@chef.io>)
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+module RuboCop
+  module Cop
+    module Chef
+      module ChefStyle
+        # Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values. These helpers are easier to read and can accept multiple platform arguments, which greatly simplifies complex platform logic.
+        #
+        # @example
+        #
+        #   # bad
+        #   node['os'] == 'darwin'
+        #   node['os'] == 'windows'
+        #   node['os'].eql?('aix')
+        #   %w(netbsd openbsd freebsd).include?(node['os'])
+        #
+        #   # good
+        #   platform_family?('mac_os_x')
+        #   platform_family?('windows')
+        #   platform_family?('aix')
+        #   platform_family?('netbsd', 'openbsd', 'freebsd)
+        #
+        class UnnecessaryOSCheck < Cop
+          MSG = "Use the platform_family?() helpers instead of node['os] == 'foo' for platform_families that match 1:1 with OS values.".freeze
+
+          # sorted list of all the os values that match 1:1 with a platform_family
+          UNNECESSARY_OS_VALUES = %w(aix darwin dragonflybsd freebsd netbsd openbsd solaris2 windows).freeze
+
+          def_node_matcher :os_equals?, <<-PATTERN
+            (send (send (send nil? :node) :[] (str "os") ) ${:== :!=} $str )
+          PATTERN
+
+          def_node_matcher :os_eql?, <<-PATTERN
+          (send (send (send nil? :node) :[] (str "os") ) :eql? $str )
+          PATTERN
+
+          def_node_matcher :os_include?, <<-PATTERN
+            (send $(array ...) :include? (send (send nil? :node) :[] (str "os")))
+          PATTERN
+
+          def on_send(node)
+            os_equals?(node) do |_operator, val|
+              if UNNECESSARY_OS_VALUES.include?(val.value)
+                add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              end
+            end
+
+            os_eql?(node) do |val|
+              if UNNECESSARY_OS_VALUES.include?(val.value)
+                add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              end
+            end
+
+            os_include?(node) do |val|
+              array_of_plats = array_from_ast(val)
+              # see if all the values in the .include? usage are in our list of 1:1 platform family to os values
+              if (UNNECESSARY_OS_VALUES & array_of_plats) == array_of_plats
+                add_offense(node, location: :expression, message: MSG, severity: :refactor)
+              end
+            end
+          end
+
+          # return the passed value unless the value is darwin and then return mac_os_x
+          def sanitized_platform(plat)
+            plat == 'darwin' ? 'mac_os_x' : plat
+          end
+
+          # given an ast array spit out a ruby array
+          def array_from_ast(ast)
+            vals = []
+            ast.each_child_node { |x| vals << x.value }
+            vals.sort
+          end
+
+          def autocorrect(node)
+            lambda do |corrector|
+              os_equals?(node) do |operator, plat|
+                corrected_string = operator == :!= ? '!' : ''
+                corrected_string << "platform_family?('#{sanitized_platform(plat.value)}')"
+                corrector.replace(node.loc.expression, corrected_string)
+              end
+
+              os_include?(node) do |plats|
+                platforms = plats.values.map { |x| x.str_type? ? "'#{sanitized_platform(x.value)}'" : x.source }
+                corrected_string = "platform_family?(#{platforms.join(', ')})"
+                corrector.replace(node.loc.expression, corrected_string)
+              end
+
+              os_eql?(node) do |plat|
+                corrected_string = "platform_family?('#{sanitized_platform(plat.value)}')"
+                corrector.replace(node.loc.expression, corrected_string)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/chef/style/use_platform_helpers.rb

@@ -28,6 +28,7 @@ module RuboCop
         #   node['platform'] != 'ubuntu'
         #   node['platform_family'] != 'debian'
         #   %w(rhel suse).include?(node['platform_family'])
+        #   node['platform'].eql?('ubuntu')
         #
         #   # good
         #   platform?('ubuntu')
@@ -47,6 +48,10 @@ module RuboCop
             (send $(array ...) :include? (send (send nil? :node) :[] $(str {"platform" "platform_family"})))
           PATTERN
 
+          def_node_matcher :platform_eql?, <<-PATTERN
+          (send (send (send nil? :node) :[] $(str {"platform" "platform_family"}) ) :eql? $str )
+          PATTERN
+
           def on_send(node)
             platform_equals?(node) do
               add_offense(node, location: :expression, message: MSG, severity: :refactor)
@@ -55,6 +60,10 @@ module RuboCop
             platform_include?(node) do
               add_offense(node, location: :expression, message: MSG, severity: :refactor)
             end
+
+            platform_eql?(node) do
+              add_offense(node, location: :expression, message: MSG, severity: :refactor)
+            end
           end
 
           def autocorrect(node)
@@ -70,6 +79,11 @@ module RuboCop
                 corrected_string = "#{type.value}?(#{platforms.join(', ')})"
                 corrector.replace(node.loc.expression, corrected_string)
               end
+
+              platform_eql?(node) do |type, plat|
+                corrected_string = "#{type.value}?('#{plat.value}')"
+                corrector.replace(node.loc.expression, corrected_string)
+              end
             end
           end
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookstyle
 version: !ruby/object:Gem::Version
-  version: 5.20.0
+  version: 5.21.9
 platform: ruby
 authors:
 - Thom May
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-23 00:00:00.000000000 Z
+date: 2020-02-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -45,6 +45,7 @@ files:
 - lib/cookstyle.rb
 - lib/cookstyle/version.rb
 - lib/rubocop/chef.rb
+- lib/rubocop/chef/autocorrect_helpers.rb
 - lib/rubocop/chef/cookbook_helpers.rb
 - lib/rubocop/chef/cookbook_only.rb
 - lib/rubocop/chef/platform_helpers.rb
@@ -167,6 +168,7 @@ files:
 - lib/rubocop/cop/chef/modernize/sc_windows_resource.rb
 - lib/rubocop/cop/chef/modernize/seven_zip_archive.rb
 - lib/rubocop/cop/chef/modernize/shellouts_to_chocolatey.rb
+- lib/rubocop/cop/chef/modernize/simplify_apt_ppa_setup.rb
 - lib/rubocop/cop/chef/modernize/systctl_param_resource.rb
 - lib/rubocop/cop/chef/modernize/unnecessary_mixlib_shellout_require.rb
 - lib/rubocop/cop/chef/modernize/whyrun_supported_true.rb
@@ -183,12 +185,14 @@ files:
 - lib/rubocop/cop/chef/redundant/grouping_metadata.rb
 - lib/rubocop/cop/chef/redundant/long_description_metadata.rb
 - lib/rubocop/cop/chef/redundant/name_property_and_required.rb
+- lib/rubocop/cop/chef/redundant/property_splat_regex.rb
 - lib/rubocop/cop/chef/redundant/property_with_default_and_required.rb
 - lib/rubocop/cop/chef/redundant/provides_metadata.rb
 - lib/rubocop/cop/chef/redundant/recipe_metadata.rb
 - lib/rubocop/cop/chef/redundant/replaces_metadata.rb
 - lib/rubocop/cop/chef/redundant/resource_with_nothing_action.rb
 - lib/rubocop/cop/chef/redundant/sensitive_property_in_resource.rb
+- lib/rubocop/cop/chef/redundant/string_property_with_nil_default.rb
 - lib/rubocop/cop/chef/redundant/suggests_metadata.rb
 - lib/rubocop/cop/chef/redundant/unnecessary_desired_state.rb
 - lib/rubocop/cop/chef/redundant/unnecessary_name_property.rb
@@ -207,6 +211,7 @@ files:
 - lib/rubocop/cop/chef/style/overly_complex_supports_depends_metadata.rb
 - lib/rubocop/cop/chef/style/simplify_platform_major_version_check.rb
 - lib/rubocop/cop/chef/style/true_false_resource_properties.rb
+- lib/rubocop/cop/chef/style/unnecessary_os_check.rb
 - lib/rubocop/cop/chef/style/unnecessary_platform_case_statement.rb
 - lib/rubocop/cop/chef/style/use_platform_helpers.rb
 - lib/rubocop/cop/target_chef_version.rb