cookbook-omnifetch 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3c87b779ed374b94c79ed6d60c92d4acdacca050
-  data.tar.gz: c5f55d263dd9c5ccc81b96be560664d6d4ac882a
+  metadata.gz: 64e4ca89bc3c10a6c4bf4e224bb39f5657d1cd12
+  data.tar.gz: c16cfaa9e0b3c9eb655faa3d12a293b6ec166931
 SHA512:
-  metadata.gz: 948bbab575f6693876e197978b3866b9489dc24c64b3860b94fee60cb5187d96fc3101559067aa163d0b44911aa90c10bc20f1a33de6d14e626cd41198337519
-  data.tar.gz: 1ad1cac27d2b6a6c84f01c8155a7dcf11f14f5af56c45dd842c50e6e86ff35369e501f81a9914646c07bfa60e9c47cb463506ce5d1b4ef5c23bc885bde277d5c
+  metadata.gz: 8e3354f49b0ed00fd5ab23f6de8dd8994419bb8e15c1d32b5dc85f960c46c1d20af45b8f2ca4cbb0e96a812a57e9a8bc04bba1907a319c13e9a6a323eda673be
+  data.tar.gz: f7841d6c9081275526ba60ece1fd3f349b24d812d9c2bba66110a3c1da6800d0e35e2da1a304f7601e4fda6849e9f78f49c8a127f3c3fcaf4f33dc1f919db3dd

data/lib/cookbook-omnifetch.rb

@@ -8,6 +8,7 @@ require "cookbook-omnifetch/path"
 require "cookbook-omnifetch/artifactserver"
 require "cookbook-omnifetch/artifactory"
 require "cookbook-omnifetch/chef_server"
+require "cookbook-omnifetch/chef_server_artifact"
 
 module CookbookOmnifetch
 
@@ -107,6 +108,22 @@ module CookbookOmnifetch
     integration.storage_path
   end
 
+  # Returns the number of threads that will be used when downloading cookbooks
+  # from a Chef Server. The default is 1.
+  #
+  # NOTE: This should only be changed if the `http_client` passed in to a
+  # ChefServerLocation or ChefServerArtifactLocation is thread-safe. In
+  # particular, the `Chef::ServerAPI` class is NOT THREAD SAFE. Chef Client uses
+  # thread-local storage to create one instance of `Chef::ServerAPI` per-thread
+  # when used in threaded code.
+  #
+  # When a properly thread-safe HTTP client is used, this can be configured to
+  # a larger value to reduce the time needed to download cookbooks from a Chef
+  # Server.
+  def self.chef_server_download_concurrency
+    integration.chef_server_download_concurrency
+  end
+
   # Returns true or false if the given path contains a Chef Cookbook
   #
   # @param [#to_s] path

data/lib/cookbook-omnifetch/chef_server.rb

@@ -1,35 +1,7 @@
 require "cookbook-omnifetch/base"
+require "cookbook-omnifetch/metadata_based_installer"
 
 module CookbookOmnifetch
-  class CookbookMetadata
-
-    FILE_TYPES = [
-      :resources,
-      :providers,
-      :recipes,
-      :definitions,
-      :libraries,
-      :attributes,
-      :files,
-      :templates,
-      :root_files,
-    ].freeze
-
-    def initialize(metadata)
-      @metadata = metadata
-    end
-
-    def files(&block)
-      FILE_TYPES.each do |type|
-        next unless @metadata.has_key?(type.to_s)
-
-        @metadata[type.to_s].each do |file|
-          yield file["url"], file["path"]
-        end
-      end
-    end
-  end
-
   class ChefServerLocation < BaseLocation
 
     attr_reader :cookbook_version
@@ -42,27 +14,20 @@ module CookbookOmnifetch
       @uri ||= options[:chef_server]
     end
 
-    def repo_host
-      @host ||= URI.parse(uri).host
-    end
-
     def cookbook_name
       dependency.name
     end
 
-    def install
-      FileUtils.mkdir_p(staging_root) unless staging_root.exist?
-      md = http_client.get("/cookbooks/#{cookbook_name}/#{cookbook_version}")
-      CookbookMetadata.new(md).files do |url, path|
-        stage = staging_path.join(path)
-        FileUtils.mkdir_p(File.dirname(stage))
+    def url_path
+      "/cookbooks/#{cookbook_name}/#{cookbook_version}"
+    end
 
-        http_client.streaming_request(url) do |tempfile|
-          tempfile.close
-          FileUtils.mv(tempfile.path, stage)
-        end
-      end
-      FileUtils.mv(staging_path, install_path)
+    def installer
+      MetadataBasedInstaller.new(http_client: http_client, url_path: url_path, install_path: install_path)
+    end
+
+    def install
+      installer.install
     end
 
     # Determine if this revision is installed.
@@ -92,22 +57,5 @@ module CookbookOmnifetch
       "#{dependency.name}-#{cookbook_version}"
     end
 
-    # The path where tarballs are downloaded to and unzipped.  On certain platforms
-    # you have a better chance of getting an atomic move if your temporary working
-    # directory is on the same device/volume as the  destination.  To support this,
-    # we use a staging directory located under the cache path under the rather mild
-    # assumption that everything under the cache path is going to be on one device.
-    #
-    # Do not create anything under this directory that isn't randomly named and
-    # remember to release your files once you are done.
-    #
-    # @return [Pathname]
-    def staging_root
-      Pathname.new(CookbookOmnifetch.cache_path).join(".cache_tmp", "artifactserver")
-    end
-
-    def staging_path
-      staging_root.join(cache_key)
-    end
   end
 end

data/lib/cookbook-omnifetch/chef_server_artifact.rb

@@ -0,0 +1,72 @@
+require "cookbook-omnifetch/base"
+require "cookbook-omnifetch/metadata_based_installer"
+
+module CookbookOmnifetch
+  # This location allows fetching from the `cookbook_artifacts/` API where Chef
+  # Server stores cookbooks for policyfile use when they're uploaded via `chef push`.
+  #
+  # End users likely won't have much use for this; it's intended to facilitate
+  # included policies when including a policy stored on a chef server and
+  # cookbooks cannot be installed from the original source based on the
+  # information in the included policy.
+  class ChefServerArtifactLocation < BaseLocation
+
+    attr_reader :cookbook_identifier
+    attr_reader :uri
+
+    def initialize(dependency, options = {})
+      super
+      @cookbook_identifier = options[:identifier]
+      @http_client = options[:http_client]
+      @uri ||= options[:chef_server_artifact]
+    end
+
+    def repo_host
+      @host ||= URI.parse(uri).host
+    end
+
+    def cookbook_name
+      dependency.name
+    end
+
+    def url_path
+      "/cookbook_artifacts/#{cookbook_name}/#{cookbook_identifier}"
+    end
+
+    def installer
+      MetadataBasedInstaller.new(http_client: http_client, url_path: url_path, install_path: install_path)
+    end
+
+    def install
+      installer.install
+    end
+
+    # Determine if this revision is installed.
+    #
+    # @return [Boolean]
+    def installed?
+      install_path.exist?
+    end
+
+    def http_client
+      @http_client
+    end
+
+    # The path where this cookbook would live in the store, if it were
+    # installed.
+    #
+    # @return [Pathname, nil]
+    def install_path
+      @install_path ||= CookbookOmnifetch.storage_path.join(cache_key)
+    end
+
+    def lock_data
+      { "chef_server" => uri, "server_identifier" => cookbook_identifier }
+    end
+
+    def cache_key
+      "#{dependency.name}-#{cookbook_identifier}"
+    end
+
+  end
+end

data/lib/cookbook-omnifetch/integration.rb

@@ -35,10 +35,15 @@ module CookbookOmnifetch
     configurable :shell_out_class
     configurable :cached_cookbook_class
 
+    # Number of threads to use when downloading from a Chef Server. See
+    # commentary in cookbook_omnifetch.rb
+    configurable :chef_server_download_concurrency
+
     def initialize
       self.class.configurables.each do |configurable|
         instance_variable_set("@#{configurable}".to_sym, NullValue.new)
       end
+      @chef_server_download_concurrency = 1
     end
 
   end

data/lib/cookbook-omnifetch/metadata_based_installer.rb

@@ -0,0 +1,94 @@
+require "cookbook-omnifetch/threaded_job_queue"
+
+module CookbookOmnifetch
+
+  class MetadataBasedInstaller
+    class CookbookMetadata
+
+      FILE_TYPES = [
+        :resources,
+        :providers,
+        :recipes,
+        :definitions,
+        :libraries,
+        :attributes,
+        :files,
+        :templates,
+        :root_files,
+      ].freeze
+
+      def initialize(metadata)
+        @metadata = metadata
+      end
+
+      def files(&block)
+        FILE_TYPES.each do |type|
+          next unless @metadata.has_key?(type.to_s)
+
+          @metadata[type.to_s].each do |file|
+            yield file["url"], file["path"]
+          end
+        end
+      end
+    end
+
+    attr_reader :http_client
+    attr_reader :url_path
+    attr_reader :install_path
+    attr_reader :slug
+
+    def initialize(http_client:, url_path:, install_path:)
+      @http_client = http_client
+      @url_path = url_path
+      @install_path = install_path
+      @slug = Kernel.rand(1_000_000_000).to_s
+    end
+
+    def install
+      FileUtils.rm_rf(staging_path) # ensure we have a clean dir, just in case
+      FileUtils.mkdir_p(staging_root) unless staging_root.exist?
+      md = http_client.get(url_path)
+
+      queue = ThreadedJobQueue.new
+
+      CookbookMetadata.new(md).files do |url, path|
+        stage = staging_path.join(path)
+        FileUtils.mkdir_p(File.dirname(stage))
+
+        queue << lambda do |_lock|
+          http_client.streaming_request(url) do |tempfile|
+            tempfile.close
+            FileUtils.mv(tempfile.path, stage)
+          end
+        end
+      end
+
+      queue.process(CookbookOmnifetch.chef_server_download_concurrency)
+
+      FileUtils.mv(staging_path, install_path)
+    end
+
+    # The path where files are downloaded to.  On certain platforms you have a
+    # better chance of getting an atomic move if your temporary working
+    # directory is on the same device/volume as the  destination.  To support
+    # this, we use a staging directory located under the cache path under the
+    # rather mild assumption that everything under the cache path is going to
+    # be on one device.
+    #
+    # @return [Pathname]
+    def staging_root
+      Pathname.new(CookbookOmnifetch.cache_path).join(".cache_tmp", "metadata-installer")
+    end
+
+    def staging_path
+      staging_root.join(staging_cache_key)
+    end
+
+    # Convert the URL to a safe name for a file and append our random slug.
+    # This helps us avoid colliding in the case that there are multiple
+    # processes installing the same cookbook at the same time.
+    def staging_cache_key
+      "#{url_path.gsub(/[^[:alnum:]]/, "_")}_#{slug}"
+    end
+  end
+end

data/lib/cookbook-omnifetch/threaded_job_queue.rb

@@ -0,0 +1,46 @@
+# Copyright:: Copyright 2014-2016, Chef Software Inc.
+# License:: Apache License, Version 2.0
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+module CookbookOmnifetch
+
+  # This class is copied from the Chef codebase:
+  # https://github.com/chef/chef/blob/7f0b5150c32994b4ad593505172c5834a984b087/lib/chef/util/threaded_job_queue.rb
+  #
+  # We do not re-use the code from Chef because we do not want to introduce a
+  # dependency on Chef in this library.
+  class ThreadedJobQueue
+    def initialize
+      @queue = Queue.new
+      @lock = Mutex.new
+    end
+
+    def <<(job)
+      @queue << job
+    end
+
+    def process(concurrency = 10)
+      workers = (1..concurrency).map do
+        Thread.new do
+          loop do
+            fn = @queue.pop
+            fn.arity == 1 ? fn.call(@lock) : fn.call
+          end
+        end
+      end
+      workers.each { |worker| self << Thread.method(:exit) }
+      workers.each { |worker| worker.join }
+    end
+  end
+end

data/lib/cookbook-omnifetch/version.rb

@@ -1,3 +1,3 @@
 module CookbookOmnifetch
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/spec/unit/chef_server_artifact_spec.rb

@@ -0,0 +1,74 @@
+require "spec_helper"
+require "cookbook-omnifetch/chef_server.rb"
+
+RSpec.describe CookbookOmnifetch::ChefServerArtifactLocation do
+
+  let(:http_client) { double("Http Client") }
+
+  let(:test_root) { "/some/fake/path" }
+
+  let(:storage_path) { File.join(test_root, "storage") }
+
+  let(:dependency) { double("Dependency", name: cookbook_name) }
+
+  let(:cookbook_name) { "example" }
+
+  let(:cookbook_identifier) { "467dc855408ce8b74f991c5dc2fd72a6aa369b60" }
+
+  let(:url) { "https://chef.example.com/organizations/example" }
+
+  let(:options) { { chef_server_artifact: url, identifier: cookbook_identifier, http_client: http_client } }
+
+  let(:expected_cache_key) { "example-467dc855408ce8b74f991c5dc2fd72a6aa369b60" }
+
+  subject(:chef_server_artifact_location) { described_class.new(dependency, options) }
+
+  before do
+    allow(CookbookOmnifetch).to receive(:storage_path).and_return(Pathname.new(storage_path))
+  end
+
+  it "has a URI" do
+    expect(chef_server_artifact_location.uri).to eq(url)
+  end
+
+  it "has an HTTP client" do
+    expect(chef_server_artifact_location.http_client).to eq(http_client)
+  end
+
+  it "has a metadata_based_installer" do
+    installer = chef_server_artifact_location.installer
+    expect(installer).to be_a(CookbookOmnifetch::MetadataBasedInstaller)
+    expect(installer.http_client).to eq(http_client)
+    expect(installer.url_path).to eq("/cookbook_artifacts/example/467dc855408ce8b74f991c5dc2fd72a6aa369b60")
+    expect(installer.install_path.to_s).to eq(File.join(storage_path, expected_cache_key))
+  end
+
+  it "has a cache key containing the site URI and version" do
+    expect(chef_server_artifact_location.cache_key).to eq(expected_cache_key)
+  end
+
+  it "has an identifier" do
+    expect(chef_server_artifact_location.cookbook_identifier).to eq(cookbook_identifier)
+  end
+
+  it "provides lock data as a Hash" do
+    expected_data = {
+      "chef_server" => url,
+      "server_identifier" => cookbook_identifier,
+    }
+    expect(chef_server_artifact_location.lock_data).to eq(expected_data)
+  end
+
+  describe "when installing" do
+
+    let(:installer) { instance_double("CookbookOmnifetch::MetadataBasedInstaller") }
+
+    it "delegates to the MetadataBasedInstaller" do
+      allow(chef_server_artifact_location).to receive(:installer).and_return(installer)
+      expect(installer).to receive(:install)
+      chef_server_artifact_location.install
+    end
+
+  end
+
+end

data/spec/unit/chef_server_spec.rb

@@ -1,98 +1,72 @@
 require "spec_helper"
 require "cookbook-omnifetch/chef_server.rb"
 
-module CookbookOmnifetch
-  METADATA = {
-    "recipes" => [
-      { "name" => "default.rb", "path" => "recipes/default.rb", "checksum" => "a6be794cdd2eb44d38fdf17f792a0d0d", "specificity" => "default", "url" => "https://example.com/recipes/default.rb" },
-    ],
-    "root_files" => [
-      { "name" => "metadata.rb", "path" => "metadata.rb", "checksum" => "5b346119e5e41ab99500608decac8dca", "specificity" => "default", "url" => "https://example.com/metadata.rb" },
-    ],
-  }
-
-  describe CookbookMetadata do
-    let(:cb_metadata) { CookbookMetadata.new(METADATA) }
-
-    it "yields a set of paths and urls" do
-      expect { |b| cb_metadata.files(&b) }.to yield_successive_args(["https://example.com/recipes/default.rb", "recipes/default.rb"], ["https://example.com/metadata.rb", "metadata.rb"])
-    end
-  end
-
-  describe ChefServerLocation do
+RSpec.describe CookbookOmnifetch::ChefServerLocation do
 
-    let(:http_client) { double("Http Client") }
+  let(:http_client) { double("Http Client") }
 
-    let(:cb_metadata) { CookbookMetadata.new(METADATA) }
+  let(:test_root) { "/some/fake/path" }
 
-    let(:test_root) { Dir.mktmpdir(nil) }
+  let(:storage_path) { File.join(test_root, "storage") }
 
-    let(:storage_path) { File.join(test_root, "storage") }
+  let(:dependency) { double("Dependency", name: cookbook_name) }
 
-    let(:cache_path) { File.join(test_root, "cache") }
+  let(:cookbook_name) { "example" }
 
-    let(:constraint) { double("Constraint") }
+  let(:cookbook_version) { "0.5.0" }
 
-    let(:dependency) { double("Dependency", name: cookbook_name, constraint: constraint) }
+  let(:url) { "https://chef.example.com/organizations/example" }
 
-    let(:cookbook_name) { "example" }
-    let(:cookbook_version) { "0.5.0" }
+  let(:options) { { chef_server: url, version: cookbook_version, http_client: http_client } }
 
-    let(:url) { "https://chef.example.com/organizations/example" }
+  subject(:chef_server_location) { described_class.new(dependency, options) }
 
-    let(:cookbook_fixture_path) { fixtures_path.join("cookbooks/example_cookbook") }
+  before do
+    allow(CookbookOmnifetch).to receive(:storage_path).and_return(Pathname.new(storage_path))
+  end
 
-    let(:remote_path) { File.join(test_root, "remote") }
-    let(:options) { { chef_server: url, version: cookbook_version, http_client: http_client } }
+  it "has a URI" do
+    expect(chef_server_location.uri).to eq(url)
+  end
 
-    let(:cookbook_files) { %w{. .. metadata.rb recipes} }
-    subject(:chef_server_location) { described_class.new(dependency, options) }
+  it "has an HTTP client" do
+    expect(chef_server_location.http_client).to eq(http_client)
+  end
 
-    before do
-      allow(CookbookOmnifetch).to receive(:storage_path).and_return(Pathname.new(storage_path))
-      allow(CookbookOmnifetch).to receive(:cache_path).and_return(cache_path)
-      allow_any_instance_of(File).to receive(:close).and_return(true)
-      FileUtils.cp_r(cookbook_fixture_path, remote_path)
-      FileUtils.mkdir_p(storage_path)
-    end
+  it "has a metadata_based_installer" do
+    installer = chef_server_location.installer
+    expect(installer).to be_a(CookbookOmnifetch::MetadataBasedInstaller)
+    expect(installer.http_client).to eq(http_client)
+    expect(installer.url_path).to eq("/cookbooks/example/0.5.0")
+    expect(installer.install_path.to_s).to eq(File.join(storage_path, "example-0.5.0"))
+  end
 
-    after do
-      FileUtils.rm_r(test_root)
-    end
+  it "has a cache key containing the site URI and version" do
+    expect(chef_server_location.cache_key).to eq("example-0.5.0")
+  end
 
-    it "has a URI" do
-      expect(chef_server_location.uri).to eq(url)
-    end
+  it "has an exact version" do
+    expect(chef_server_location.cookbook_version).to eq("0.5.0")
+  end
 
-    it "has a cache key containing the site URI and version" do
-      expect(chef_server_location.cache_key).to eq("example-0.5.0")
-    end
+  it "provides lock data as a Hash" do
+    expected_data = {
+      "chef_server" => url,
+      "version" => "0.5.0",
+    }
+    expect(chef_server_location.lock_data).to eq(expected_data)
+  end
 
-    it "has an exact version" do
-      expect(chef_server_location.cookbook_version).to eq("0.5.0")
-    end
+  describe "when installing" do
 
-    it "installs the cookbook to the desired install path" do
-      expect(http_client).to receive(:get).with("/cookbooks/example/0.5.0").and_return(METADATA)
-      expect(http_client).to receive(:streaming_request).twice do |url, &block|
-        path = url.split("/", 4)[3]
-        path = File.join(remote_path, path)
-        block.call(File.open(path))
-      end
+    let(:installer) { instance_double("CookbookOmnifetch::MetadataBasedInstaller") }
 
+    it "delegates to the MetadataBasedInstaller" do
+      allow(chef_server_location).to receive(:installer).and_return(installer)
+      expect(installer).to receive(:install)
       chef_server_location.install
-
-      expect(Dir).to exist(chef_server_location.install_path)
-      expect(Dir.entries(chef_server_location.install_path)).to match_array(cookbook_files)
-    end
-
-    it "provides lock data as a Hash" do
-      expected_data = {
-        "chef_server" => url,
-        "version" => "0.5.0",
-      }
-      expect(chef_server_location.lock_data).to eq(expected_data)
     end
 
   end
+
 end

data/spec/unit/metadata_based_installer_spec.rb

@@ -0,0 +1,137 @@
+require "spec_helper"
+require "cookbook-omnifetch/metadata_based_installer.rb"
+
+RSpec.shared_context "sample_metadata" do
+
+  let(:raw_metadata) do
+    {
+      "recipes" => [
+        { "name" => "default.rb", "path" => "recipes/default.rb", "checksum" => "a6be794cdd2eb44d38fdf17f792a0d0d", "specificity" => "default", "url" => "https://example.com/recipes/default.rb" },
+      ],
+      "root_files" => [
+        { "name" => "metadata.rb", "path" => "metadata.rb", "checksum" => "5b346119e5e41ab99500608decac8dca", "specificity" => "default", "url" => "https://example.com/metadata.rb" },
+      ],
+    }
+
+  end
+end
+
+RSpec.describe CookbookOmnifetch::MetadataBasedInstaller::CookbookMetadata do
+
+  include_context "sample_metadata"
+
+  subject(:cb_metadata) { described_class.new(raw_metadata) }
+
+  it "yields a set of paths and urls" do
+    expect { |b| cb_metadata.files(&b) }.to yield_successive_args(["https://example.com/recipes/default.rb", "recipes/default.rb"], ["https://example.com/metadata.rb", "metadata.rb"])
+  end
+end
+
+RSpec.describe CookbookOmnifetch::MetadataBasedInstaller do
+
+  include_context "sample_metadata"
+
+  let(:url_path) { "/cookbooks/example/0.5.0" }
+
+  let(:http_client) do
+    double("Http Client")
+  end
+
+  let(:recipe_url) do
+    raw_metadata["recipes"][0]["url"]
+  end
+
+  let(:recipe_path) do
+    raw_metadata["recipes"][0]["path"]
+  end
+
+  let(:recipe_filehandle) do
+    File.open(File.join(remote_path, recipe_path))
+  end
+
+  let(:root_file_url) do
+    raw_metadata["root_files"][0]["url"]
+  end
+
+  let(:root_file_path) do
+    raw_metadata["root_files"][0]["path"]
+  end
+
+  let(:root_file_filehandle) do
+    File.open(File.join(remote_path, root_file_path))
+  end
+
+  let(:cookbook_fixture_path) { fixtures_path.join("cookbooks/example_cookbook") }
+
+  let(:test_root) { Dir.mktmpdir(nil) }
+
+  let(:cache_path) { File.join(test_root, "cache") }
+
+  let(:remote_path) { File.join(test_root, "remote") }
+
+  let(:install_path) { File.join(test_root, "install_path") }
+
+  let(:cookbook_files) { %w{metadata.rb recipes recipes/default.rb} }
+
+  let(:expected_installed_files) do
+    cookbook_files.map do |file|
+      File.join(install_path, file)
+    end
+  end
+
+  subject(:installer) do
+    described_class.new(http_client: http_client,
+                        url_path: url_path,
+                        install_path: install_path)
+  end
+
+  before do
+    FileUtils.cp_r(cookbook_fixture_path, remote_path)
+
+    allow(CookbookOmnifetch).to receive(:cache_path).and_return(cache_path)
+  end
+
+  after do
+    FileUtils.rm_r(test_root)
+  end
+
+  it "stages the download to a randomized location" do
+    Kernel.srand(0)
+    expected_path = Pathname.new(cache_path).join(".cache_tmp/metadata-installer/_cookbooks_example_0_5_0_209652396")
+
+    expect(installer.staging_path).to eq(expected_path)
+
+    next_installer = described_class.new(http_client: http_client,
+                                         url_path: url_path,
+                                         install_path: install_path)
+
+    next_expected_path = Pathname.new(cache_path).join(".cache_tmp/metadata-installer/_cookbooks_example_0_5_0_398764591")
+    expect(next_installer.staging_path).to eq(next_expected_path)
+  end
+
+  describe "installing the cookbook" do
+
+    before do
+      expect(http_client).to receive(:get).
+        with(url_path).
+        and_return(raw_metadata)
+      expect(http_client).to receive(:streaming_request).
+        with(recipe_url).
+        and_yield(recipe_filehandle)
+      expect(http_client).to receive(:streaming_request).
+        with(root_file_url).
+        and_yield(root_file_filehandle)
+    end
+
+    it "installs the cookbook to the desired install path" do
+      expect(Dir).to_not exist(install_path)
+
+      installer.install
+
+      expect(Dir).to exist(install_path)
+      expect(Dir.glob("#{install_path}/**/*")).to match_array(expected_installed_files)
+    end
+
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: cookbook-omnifetch
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Jamie Winsor
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-17 00:00:00.000000000 Z
+date: 2017-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mixlib-archive
@@ -82,11 +82,14 @@ files:
 - lib/cookbook-omnifetch/artifactserver.rb
 - lib/cookbook-omnifetch/base.rb
 - lib/cookbook-omnifetch/chef_server.rb
+- lib/cookbook-omnifetch/chef_server_artifact.rb
 - lib/cookbook-omnifetch/exceptions.rb
 - lib/cookbook-omnifetch/git.rb
 - lib/cookbook-omnifetch/github.rb
 - lib/cookbook-omnifetch/integration.rb
+- lib/cookbook-omnifetch/metadata_based_installer.rb
 - lib/cookbook-omnifetch/path.rb
+- lib/cookbook-omnifetch/threaded_job_queue.rb
 - lib/cookbook-omnifetch/version.rb
 - spec/fixtures/cookbooks/example_cookbook-0.5.0/README.md
 - spec/fixtures/cookbooks/example_cookbook-0.5.0/metadata.rb
@@ -102,9 +105,11 @@ files:
 - spec/unit/artifactory_spec.rb
 - spec/unit/artifactserver_spec.rb
 - spec/unit/base_spec.rb
+- spec/unit/chef_server_artifact_spec.rb
 - spec/unit/chef_server_spec.rb
 - spec/unit/exceptions_spec.rb
 - spec/unit/git_spec.rb
+- spec/unit/metadata_based_installer_spec.rb
 - spec/unit/path_spec.rb
 homepage: http://www.getchef.com/
 licenses:
@@ -126,7 +131,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Library code to fetch Chef cookbooks from a variety of sources to a local
@@ -146,7 +151,9 @@ test_files:
 - spec/unit/artifactory_spec.rb
 - spec/unit/artifactserver_spec.rb
 - spec/unit/base_spec.rb
+- spec/unit/chef_server_artifact_spec.rb
 - spec/unit/chef_server_spec.rb
 - spec/unit/exceptions_spec.rb
 - spec/unit/git_spec.rb
+- spec/unit/metadata_based_installer_spec.rb
 - spec/unit/path_spec.rb