convolver 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 4c3bcf13a230b62ed29260b84490f720af3408cc
-  data.tar.gz: 3d00b5f4ece4078525b5d57fbe536d3dfcc6020e
+SHA256:
+  metadata.gz: 9c83dcadafabcbb8a971258601e61697a35d73afc28e7341bbe9d6f5fee887e3
+  data.tar.gz: dfc6018d6b2ae5a9ea7570036874f036961e9925c18e41116b481b4604f0cc56
 SHA512:
-  metadata.gz: 113c51e9233dabd6d94490b1906e31787f0fc9e7826bacf8b999c2c63e2722381baf417c616519735456f286c781e2597547b9851e77addd8267ec87c38947c2
-  data.tar.gz: 2495231401448636a915562cf6ad09ba4351094a4af290b0d0a84ee5a7a313e57e1e2d8e07b70746b7ee60b1780ba6ed9e4e8c8c19518fa785d4c01e589b8258
+  metadata.gz: 41b62c830ba924ddc25abcf92363fcf474477d806e4040d7c694496ed1eda15d3929e4bfeea2597b7ee372baa28c44991d69c9941cfa7db753070ca8bac7b90c
+  data.tar.gz: 0fd4024a1a4eb0c1b0a6059e6f606508e048dc4a6e56d5499e0c5b94d85669ba17831472a0c3167e1361b8b25ec299d665cab3a4bc38162c363c756dddb60ecc

data/.github/workflows/ci.yml

@@ -0,0 +1,40 @@
+name: CI
+
+on:
+  pull_request:
+
+permissions:
+  contents: read
+
+jobs:
+  test:
+    name: Ruby ${{ matrix.ruby }}
+    runs-on: ubuntu-latest
+    timeout-minutes: 10
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - '3.3'
+          - '3.4'
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+
+      - name: Install FFTW
+        run: sudo apt-get update && sudo apt-get install --yes libfftw3-dev
+
+      - name: Set up Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler: latest
+          bundler-cache: true
+
+      - name: Compile extension and run specs
+        run: bundle exec rake compile test
+
+      - name: Run RuboCop
+        run: bundle exec rubocop

data/.rubocop.yml

@@ -0,0 +1,16 @@
+plugins:
+  - rubocop-rake
+  - rubocop-rspec
+
+AllCops:
+  NewCops: enable
+
+Style/GlobalVars:
+  Exclude:
+    - ext/convolver/extconf.rb
+
+RSpec/ExampleLength:
+  Max: 30
+
+RSpec/MultipleExpectations:
+  Max: 7

data/Gemfile

@@ -1,4 +1,15 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in convolver.gemspec
 gemspec
+
+gem 'rake', '>= 1.9.1'
+gem 'rake-compiler', '>= 0.8.3'
+gem 'rspec', '>= 2.13.0'
+gem 'rubocop', '~> 1.85'
+gem 'rubocop-rake', '~> 0.7'
+gem 'rubocop-rspec', '~> 3.9'
+gem 'simplecov', '>= 0.22'
+gem 'yard', '>= 0.8.7.2'

data/README.md

@@ -1,9 +1,8 @@
 # Convolver
 
 [![Gem Version](https://badge.fury.io/rb/convolver.png)](http://badge.fury.io/rb/convolver)
-[![Build Status](https://travis-ci.org/neilslater/convolver.png?branch=master)](http://travis-ci.org/neilslater/convolver)
+[![Build Status](https://api.travis-ci.com/neilslater/convolver.png?branch=master)](https://travis-ci.com/github/neilslater/convolver)
 [![Coverage Status](https://coveralls.io/repos/neilslater/convolver/badge.png?branch=master)](https://coveralls.io/r/neilslater/convolver?branch=master)
-[![Inline docs](http://inch-ci.org/github/neilslater/convolver.png?branch=master)](http://inch-ci.org/github/neilslater/convolver)
 [![Code Climate](https://codeclimate.com/github/neilslater/convolver.png)](https://codeclimate.com/github/neilslater/convolver)
 
 Calculates discrete convolution between two multi-dimensional arrays of floats.
@@ -16,6 +15,27 @@ See http://en.wikipedia.org/wiki/Convolution
 Before you install *convolver*, you should install the FFTW3 library on your system.
 See http://www.fftw.org/ for details.
 
+On macOS with Homebrew, the `fftw3` Ruby gem needs to be told where Homebrew
+installed the headers and libraries:
+
+    brew install fftw
+    bundle config set --local build.fftw3 "--with-fftw3-dir=$(brew --prefix fftw)"
+    bundle install
+
+The local Bundler setting is written to `.bundle/config`, which is intentionally
+not committed because the Homebrew prefix depends on the machine.
+
+### Known warning with Ruby 3.4
+
+The first use of `NArray` may emit this warning:
+
+    warning: undefining the allocator of T_DATA class NArray
+
+This comes from the legacy native allocation API used by `narray` 0.6.1.2. Ruby
+disables the inherited allocator when the first native NArray object is created.
+The warning does not affect convolver's results; removing it properly requires a
+fix in `narray` or a future migration to a maintained NArray implementation.
+
 ### Installing the gem
 
 Add this line to your application's Gemfile:

data/Rakefile

@@ -1,20 +1,22 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 require 'rake/extensiontask'
 
-desc "Convolver unit tests"
+desc 'Convolver unit tests'
 RSpec::Core::RakeTask.new(:test) do |t|
-  t.pattern = "spec/*_spec.rb"
+  t.pattern = 'spec/*_spec.rb'
   t.verbose = true
 end
 
 gemspec = Gem::Specification.load('convolver.gemspec')
 Rake::ExtensionTask.new do |ext|
   ext.name = 'convolver'
-  ext.source_pattern = "*.{c,h}"
+  ext.source_pattern = '*.{c,h}'
   ext.ext_dir = 'ext/convolver'
   ext.lib_dir = 'lib/convolver'
   ext.gem_spec = gemspec
 end
 
-task :default => [:compile, :test]
+task default: %i[compile test]

data/convolver.gemspec

@@ -1,31 +1,27 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+require 'English'
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'convolver/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "convolver"
+  spec.name          = 'convolver'
   spec.version       = Convolver::VERSION
-  spec.authors       = ["Neil Slater"]
-  spec.email         = ["slobo777@gmail.com"]
-  spec.description   = %q{Convolution for NArray}
-  spec.summary       = %q{Convolution for NArray}
-  spec.homepage      = "http://github.com/neilslater/convolver"
-  spec.license       = "MIT"
-
-  spec.add_dependency "narray", ">= 0.6.0.8"
-  spec.add_dependency "fftw3", ">= 0.3"
+  spec.authors       = ['Neil Slater']
+  spec.email         = ['slobo777@gmail.com']
+  spec.description   = 'Convolution for NArray'
+  spec.summary       = 'Convolution for NArray'
+  spec.homepage      = 'http://github.com/neilslater/convolver'
+  spec.license       = 'MIT'
+  spec.required_ruby_version = '>= 3.2'
 
-  spec.add_development_dependency "yard", ">= 0.8.7.2"
-  spec.add_development_dependency "bundler", ">= 1.3"
-  spec.add_development_dependency "rspec", ">= 2.13.0"
-  spec.add_development_dependency "rake", ">= 1.9.1"
-  spec.add_development_dependency "rake-compiler", ">= 0.8.3"
-  spec.add_development_dependency "coveralls", ">= 0.6.7"
+  spec.add_dependency 'fftw3', '>= 0.3'
+  spec.add_dependency 'narray', '>= 0.6.0.8'
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.extensions    = spec.files.grep(%r{/extconf\.rb$})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
+  spec.metadata['rubygems_mfa_required'] = 'true'
 end

data/ext/convolver/convolve_raw.c

@@ -76,13 +76,16 @@ void convolve_raw(
 
   // Main convolve loop
   for ( i = 0; i < out_size; i++ ) {
+#if CONVOLVER_USE_SSE
     __m128 simd_x, simd_y, simd_t;
-    float t = 0.0;
     float v[4];
     simd_t = _mm_setzero_ps();
+#endif
+    float t = 0.0;
 
     offset += out_co_incr[ corner_dec( out_rank, out_shape, out_q ) ];
 
+#if CONVOLVER_USE_SSE
     // Use SIMD for all the aligned values in groups of 4
     for ( j = 0; j < kernel_aligned; j +=4 ) {
       simd_x = _mm_load_ps( kernel_ptr + j );
@@ -93,13 +96,24 @@ void convolve_raw(
       simd_t = _mm_add_ps( simd_x, simd_t );
     }
     _mm_store_ps( v, simd_t );
+#else
+    // SSE is unavailable on architectures such as Apple Silicon.
+    // Use the same calculation without x86-specific intrinsics.
+    for ( j = 0; j < kernel_aligned; j++ ) {
+      t += in_ptr[ offset + kernel_co_incr_cache[j] ] * kernel_ptr[j];
+    }
+#endif
 
     // Complete any remaining 1,2 or 3 items one at a time
     for ( j = kernel_aligned; j < kernel_size; j++ ) {
       t += in_ptr[ offset + kernel_co_incr_cache[j] ] * kernel_ptr[ j ];
     }
 
+#if CONVOLVER_USE_SSE
     out_ptr[i] = v[0] + v[1] + v[2] + v[3] + t;
+#else
+    out_ptr[i] = t;
+#endif
   }
 
   xfree( kernel_co_incr_cache );

data/ext/convolver/convolve_raw.h

@@ -9,7 +9,12 @@
 #define CONVOLVE_RAW_H
 
 #include <ruby.h>
+#if defined(__SSE__)
 #include <xmmintrin.h>
+#define CONVOLVER_USE_SSE 1
+#else
+#define CONVOLVER_USE_SSE 0
+#endif
 #include "narray_shared.h"
 
 #define LARGEST_RANK 16

data/ext/convolver/convolver.c

@@ -3,7 +3,6 @@
 #include <ruby.h>
 #include "narray.h"
 #include <stdio.h>
-#include <xmmintrin.h>
 
 #include "narray_shared.h"
 #include "convolve_raw.h"

data/ext/convolver/extconf.rb

@@ -1,31 +1,37 @@
+# frozen_string_literal: true
+
 # ext/convolver/extconf.rb
-require "mkmf"
-require "rubygems"
+require 'mkmf'
+require 'rubygems'
 
 # Following code stolen shamelessly from fftw3 gem:
-narray_dir = File.dirname(Gem.find_files("narray.h").first) rescue $sitearchdir
+narray_dir = begin
+  File.dirname(Gem.find_files('narray.h').first)
+rescue StandardError
+  $sitearchdir
+end
 if /cygwin|mingw/ =~ RUBY_PLATFORM
   dir_config('narray', narray_dir, "#{narray_dir}/src")
 else
   dir_config('narray', narray_dir, narray_dir)
 end
 
-if ( ! ( have_header("narray.h") && have_header("narray_config.h") ) ) then
-   print <<-EOS
+unless have_header('narray.h') && have_header('narray_config.h')
+  print <<-ERROR_MESSAGE
    ** configure error **
    Header narray.h or narray_config.h is not found. If you have these files in
    /narraydir/include, try the following:
 
    % ruby extconf.rb --with-narray-include=/narraydir/include
 
-EOS
-   exit(-1)
+  ERROR_MESSAGE
+  exit(-1)
 end
 
 # This also stolen from fftw3 gem (and not confirmed for Windows platforms - please let me know if it works!)
 if /cygwin|mingw/ =~ RUBY_PLATFORM
-   have_library("narray") || raise("ERROR: narray library is not found")
+  have_library('narray') || raise('ERROR: narray library is not found')
 end
 
 $CFLAGS << ' -O3 -funroll-loops'
-create_makefile( 'convolver/convolver' )
+create_makefile('convolver/convolver')

data/lib/convolver/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Convolver
-  VERSION = "0.3.2"
+  VERSION = '0.4.0'
 end

data/lib/convolver.rb

@@ -1,8 +1,11 @@
+# frozen_string_literal: true
+
 require 'narray'
-require "convolver/convolver"
-require "convolver/version"
+require 'convolver/convolver'
+require 'convolver/version'
 require 'fftw3'
 
+# Convolution operations for NArray values.
 module Convolver
   # Chooses and calls likely fastest method from #convolve_basic and #convolve_fftw3.
   # The two parameters must have the same rank. The output has same rank, its size in each
@@ -13,25 +16,19 @@ module Convolver
   # @param [NArray] signal must be same size or larger than kernel in each dimension
   # @param [NArray] kernel must be same size or smaller than signal in each dimension
   # @return [NArray] result of convolving signal with kernel
-  def self.convolve signal, kernel
+  def self.convolve(signal, kernel)
     # For small signals or kernels, just go straight to basic
-    if signal.size < 1000 || kernel.size < 100
-      return convolve_basic( signal, kernel )
-    end
+    return convolve_basic(signal, kernel) if signal.size < 1000 || kernel.size < 100
 
     # If predicted time is less than a millisecond, just do a basic convolve
-    basic_time_predicted = predict_convolve_basic_time( signal, kernel )
-    if basic_time_predicted < 0.1
-      return convolve_basic( signal, kernel )
-    end
+    basic_time_predicted = predict_convolve_basic_time(signal, kernel)
+    return convolve_basic(signal, kernel) if basic_time_predicted < 0.1
 
     # Factor of two to allow for large uncertainty in predictions for FFTW3
-    fft_time_predicted = predict_convolve_fft_time( signal, kernel )
-    if fft_time_predicted < 2 * basic_time_predicted
-      return convolve_fftw3( signal, kernel )
-    end
+    fft_time_predicted = predict_convolve_fft_time(signal, kernel)
+    return convolve_fftw3(signal, kernel) if fft_time_predicted < 2 * basic_time_predicted
 
-    convolve_basic( signal, kernel )
+    convolve_basic(signal, kernel)
   end
 
   # Uses FFTW3 library to calculate convolution of an array of floats representing a signal,
@@ -41,21 +38,12 @@ module Convolver
   # @param [NArray] signal must be same size or larger than kernel in each dimension
   # @param [NArray] kernel must be same size or smaller than signal in each dimension
   # @return [NArray] result of convolving signal with kernel
-  def self.convolve_fftw3 signal, kernel
-    combined_shape, shift_by, ranges = fft_offsets( signal.shape, kernel.shape )
-
-    mod_a = NArray.sfloat(*combined_shape)
-    mod_a[*shift_by] = signal
-
-    mod_b = NArray.sfloat(*combined_shape)
-
-    Convolver.fit_kernel_backwards( mod_b, kernel )
-
-    afreqs = FFTW3.fft(mod_a)
-    bfreqs = FFTW3.fft(mod_b)
-    cfreqs = afreqs * bfreqs
+  def self.convolve_fftw3(signal, kernel)
+    combined_shape, shift_by, ranges = fft_offsets(signal.shape, kernel.shape)
+    mod_a, mod_b = fft_inputs(signal, kernel, combined_shape, shift_by)
+    cfreqs = FFTW3.fft(mod_a) * FFTW3.fft(mod_b)
 
-    (FFTW3.ifft( cfreqs ).real * (1.0/mod_a.size))[*ranges]
+    (FFTW3.ifft(cfreqs).real * (1.0 / mod_a.size))[*ranges]
   end
 
   # A rough estimate of time that #convolve_fftw3 will take, based on complexity
@@ -64,8 +52,8 @@ module Convolver
   # @param [NArray] signal must be same size or larger than kernel in each dimension
   # @param [NArray] kernel must be same size or smaller than signal in each dimension
   # @return [Float] rough estimate of time for convolution compared to baseline
-  def self.predict_convolve_fft_time signal, kernel
-    16 * 4.55e-08 * result_shape(signal.shape,kernel.shape).inject(1) { |t,x| t * x * Math.log(x) }
+  def self.predict_convolve_fft_time(signal, kernel)
+    16 * 4.55e-08 * result_shape(signal.shape, kernel.shape).inject(1) { |t, x| t * x * Math.log(x) }
   end
 
   # A rough estimate of time that #convolve will take, based on complexity
@@ -74,19 +62,17 @@ module Convolver
   # @param [NArray] signal must be same size or larger than kernel in each dimension
   # @param [NArray] kernel must be same size or smaller than signal in each dimension
   # @return [Float] rough estimate of time for convolution compared to baseline
-  def self.predict_convolve_basic_time signal, kernel
-    outputs = shape_to_size( result_shape( signal.shape, kernel.shape ) )
-    4.54e-12 * (outputs * shape_to_size( signal.shape ) * shape_to_size( kernel.shape ))
+  def self.predict_convolve_basic_time(signal, kernel)
+    outputs = shape_to_size(result_shape(signal.shape, kernel.shape))
+    4.54e-12 * (outputs * shape_to_size(signal.shape) * shape_to_size(kernel.shape))
   end
 
-  private
-
-  def self.shape_to_size shape
-    shape.inject(1) { |t,x| t * x }
+  def self.shape_to_size(shape)
+    shape.inject(1) { |t, x| t * x }
   end
 
-  def self.result_shape signal_shape, kernel_shape
-    result_shape = [  ]
+  def self.result_shape(signal_shape, kernel_shape)
+    result_shape = []
     signal_shape.each_with_index do |signal_size, i|
       kernel_size = kernel_shape[i]
       result_shape[i] = signal_size - kernel_size + 1
@@ -94,19 +80,21 @@ module Convolver
     result_shape
   end
 
-  def self.fft_offsets signal_shape, kernel_shape
-    combined_shape = []
-    shift_by = []
-    ranges = []
-    signal_shape.each_with_index do |signal_size, i|
-      kernel_size = kernel_shape[i]
+  def self.fft_offsets(signal_shape, kernel_shape)
+    signal_shape.zip(kernel_shape).map { |sizes| fft_offset(*sizes) }.transpose
+  end
 
-      combined_shape[i] = signal_size + kernel_size - 1
-      output_size = signal_size - kernel_size + 1
-      output_offset = kernel_size - 1
-      shift_by[i] = kernel_size / 2
-      ranges[i] = (output_offset...(output_offset + output_size))
-    end
-    [ combined_shape, shift_by, ranges ]
+  def self.fft_inputs(signal, kernel, combined_shape, shift_by)
+    signal_input = NArray.sfloat(*combined_shape)
+    signal_input[*shift_by] = signal
+    kernel_input = NArray.sfloat(*combined_shape)
+    fit_kernel_backwards(kernel_input, kernel)
+    [signal_input, kernel_input]
+  end
+
+  def self.fft_offset(signal_size, kernel_size)
+    output_offset = kernel_size - 1
+    output_size = signal_size - kernel_size + 1
+    [signal_size + kernel_size - 1, kernel_size / 2, output_offset...(output_offset + output_size)]
   end
 end

data/spec/convolver_basic_spec.rb

@@ -0,0 +1,89 @@
+# frozen_string_literal: true
+
+require 'helpers'
+
+describe Convolver do
+  describe '#convolve_basic' do
+    it 'works like the example in the README' do
+      a = NArray[0.3, 0.4, 0.5]
+      b = NArray[1.3, -0.5]
+      c = described_class.convolve_basic(a, b)
+      expect(c).to be_narray_like NArray[0.19, 0.27]
+    end
+
+    it 'calculates a 2D convolution' do
+      a = NArray[[0.3, 0.4, 0.5], [0.6, 0.8, 0.2], [0.9, 1.0, 0.1]]
+      b = NArray[[1.2, -0.5], [0.5, -1.3]]
+      c = described_class.convolve_basic(a, b)
+      expect(c).to be_narray_like NArray[[-0.58, 0.37], [-0.53, 1.23]]
+    end
+
+    it 'calculates a 2D convolution with rectangular arrays' do
+      a = NArray[ [0.3, 0.4, 0.5, 0.3, 0.4], [0.6, 0.8, 0.2, 0.8, 0.2],
+                  [0.9, 1.0, 0.1, 0.9, 1.0], [0.5, 0.9, 0.3, 0.2, 0.8], [0.7, 0.1, 0.3, 0.0, 0.1],
+                  [0.4, 0.5, 0.6, 0.7, 0.8], [0.5, 0.4, 0.3, 0.2, 0.1] ]
+      b = NArray[[1.2, -0.5, 0.2], [1.8, 0.5, -1.3]]
+      c = described_class.convolve_basic(a, b)
+      expect(c).to be_narray_like NArray[ [1.48, 0.79, 1.03], [2.35, 1.7, -0.79], [1.56, 2.84, -0.53],
+                                          [1.13, 1.3, 0.83], [1.04, 0.26, 0.77], [1.06, 1.05, 1.04] ]
+    end
+
+    it 'calculates a 3D convolution' do
+      # 5x4x3
+      a = NArray[
+        [[1.0, 0.6, 1.1, 0.2, 0.9], [1.0, 0.7, 0.8, 1.0, 1.0], [0.2, 0.6, 0.1, 0.2, 0.5],
+         [0.5, 0.9, 0.2, 0.1, 0.6]],
+        [[0.4, 0.9, 0.4, 0.0, 0.6], [0.2, 1.1, 0.2, 0.4, 0.1], [0.4, 0.2, 0.5, 0.8, 0.7],
+         [0.1, 0.9, 0.7, 0.1, 0.3]],
+        [[0.8, 0.6, 1.0, 0.1, 0.4], [0.3, 0.8, 0.6, 0.7, 1.1], [0.9, 1.0, 0.3, 0.4, 0.6],
+         [0.2, 0.5, 0.4, 0.7, 0.2]]
+      ]
+
+      # 3x3x3
+      b = NArray[
+        [[-0.9, 1.2, 0.8], [0.9, 0.1, -0.5], [1.1, 0.1, -1.1]],
+        [[-0.2, -1.0, 1.4], [-1.4, 0.0, 1.3], [0.3, 1.0, -0.5]],
+        [[0.6, 0.0, 0.7],   [-0.7, 1.1, 1.2], [1.3, 0.7, 0.0]]
+      ]
+
+      # Should be 3x2x1
+      c = described_class.convolve_basic(a, b)
+      expect(c).to be_narray_like NArray[[[5.51, 3.04, 4.3], [3.04, 6.31, 3.87]]]
+    end
+
+    it 'calculates a 4D convolution' do
+      # 3x4x5x3
+      a = NArray[
+        [[[0.5, 0.4, 0.9], [0.1, 0.9, 0.8], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
+         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
+         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
+         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
+         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]]],
+        [[[0.5, 0.4, 0.9], [0.1, 0.9, 0.8], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
+         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
+         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
+         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
+         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]]],
+        [[[0.5, 0.4, 0.9], [0.1, 0.9, 0.8], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
+         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
+         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]],
+         [[0.0, 0.4, 0.0], [0.2, 0.3, 0.8], [0.6, 0.3, 0.2], [0.7, 0.4, 0.3]],
+         [[0.3, 0.3, 0.1], [0.6, 0.9, 0.4], [0.4, 0.0, 0.1], [0.8, 0.3, 0.4]]] ]
+
+      # 2x3x3x2
+      b = NArray[ [
+        [[1.1, 0.6], [1.2, 0.6], [0.8, 0.1]], [[-0.4, 0.8], [0.5, 0.4], [1.2, 0.2]],
+        [[0.8, 0.2], [0.5, 0.0], [1.4, 1.3]]
+      ],
+                  [[[1.1, 0.6], [1.2, 0.6], [0.8, 0.1]], [[-0.4, 0.8], [0.5, 0.4], [1.2, 0.2]],
+                   [[0.8, 0.2], [0.5, 0.0], [1.4, 1.3]]] ]
+
+      # Should be 2x2x3x2
+      c = described_class.convolve_basic(a, b)
+      expect(c).to be_narray_like NArray[
+        [[[8.5, 8.2], [11.34, 9.68]], [[7.68, 6.56], [11.24, 7.16]], [[9.14, 6.54], [12.44, 9.2]]],
+        [[[8.5, 8.2], [11.34, 9.68]], [[7.68, 6.56], [11.24, 7.16]], [[9.14, 6.54], [12.44, 9.2]]]
+      ]
+    end
+  end
+end