controller_setter_pattern 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 36ee901377eb976f73cfc39346aa635c7063af71
-  data.tar.gz: 7740bd3b21ee8af6e282fb182ac75cdb33026c5c
+  metadata.gz: 56f77be87b831737dd8d2dde96ac059a77c224b2
+  data.tar.gz: cded750410e8995f62f6885c12d086dd1036800f
 SHA512:
-  metadata.gz: 1fff224ca7116cf0773456103b329f60d4186a3c1ea176f35cd84f5ba8b048b5ba14104e302c17f4970ec4685e931ca0b0a82cec52e4220cd5a53f2996365420
-  data.tar.gz: 1fdbb3904400d9b320a4b10ad7918cf1bdb50d5b78c2b6531bb8cd895b518dd5f5c60630ec9b06bdbd41447883a86be49b5ae9b455a004776e79523ac2bc76dd
+  metadata.gz: eccec7b8481594659362b55b4cf91ee1778d998bb88334041d366bdab9e2e753d9637ea4c58b0fe74677fb17d9c91025b74e3da519a7d57789916484179133d1
+  data.tar.gz: adfa269ee3f7bde2a8bdd351cd26cb0393a390abfc3e833a2e4312a37e322834e3a50ebb787c5eb64d64b130a918de7c70f05153a50baa6d2c27b74490a9b749

data/.gitignore

@@ -1,3 +1,3 @@
 .project
 Gemfile.lock
-log/*
+*.gem

data/.travis.yml

@@ -0,0 +1,9 @@
+language: ruby
+rvm:
+  - 2.2.2
+gemfile:
+  - Gemfile
+addons:
+  code_climate:
+    repo_token: c1f8ba0adfcc8f55bfa8940710b9899fdfed0581fdc6d9537a34a5e42ed8dfe7
+script: "bundle exec rake spec"

data/Gemfile

@@ -2,4 +2,6 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem 'rails', '~> 4.2.1'
+gem 'rails', '~> 4.2.1'
+
+gem 'codeclimate-test-reporter', '~> 0.4.7', group: :test

data/README.md

@@ -1,4 +1,11 @@
 # controller_setter_pattern
+
+[![Build Status](https://travis-ci.org/Casara/controller_setter_pattern.svg)](https://travis-ci.org/Casara/controller_setter_pattern)
+[![Code Climate](https://codeclimate.com/github/Casara/controller_setter_pattern.svg)](https://codeclimate.com/github/Casara/controller_setter_pattern)
+[![Test Coverage](https://codeclimate.com/github/Casara/controller_setter_pattern/badges/coverage.svg)](https://codeclimate.com/github/Casara/controller_setter_pattern/coverage)
+[![Gem Version](https://badge.fury.io/rb/controller_setter_pattern.svg)](http://badge.fury.io/rb/controller_setter_pattern)
+[![Dependency Status](https://gemnasium.com/Casara/controller_setter_pattern.svg)](https://gemnasium.com/Casara/controller_setter_pattern)
+
 Pattern for assign instance variables in controllers for use in views, etc.
 
 ## Instalation
@@ -43,7 +50,7 @@ class ArticlesController < ApplicationController
       render :new
     end
   end
-  
+
   # PATCH/PUT /articles/:id
   def update
     if @article.update(article_params)
@@ -52,7 +59,7 @@ class ArticlesController < ApplicationController
       render :edit
     end
   end
-  
+
   # DELETE /articles/:id
   def destroy
     @article.destroy
@@ -162,6 +169,7 @@ set :ebook, model: Book
 ```
 
 **Specify the parameters key to use to fetch the object:**
+
 ```ruby
 set :ebook, model: Book, finder_params: :isbn
 # @ebook = Book.find_by_isbn(params[:isbn])
@@ -175,4 +183,4 @@ set :ebook, model: Book, finder_params: [:author, :title]
 ```ruby
 set :user, scope: :active, finder_params: :email
 # @user = User.active.find_by_email(params[:email])
-```
+```

data/coverage/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

data/lib/controller_setter_pattern/action_controller.rb

@@ -4,64 +4,68 @@ module ControllerSetterPattern
 
     module ClassMethods
       def set(*names)
-        options = names.extract_options!
+        callback_options = names.extract_options!
 
-        model = options.delete(:model)
-        model = model.to_s.camelize.constantize unless model.nil?
+        (options ||= {})[:model] = callback_options.delete(:model)
+        options[:model] ||= options[:model].to_s.camelize.constantize unless options[:model].nil?
 
-        finder_params = normalize_finder_params(options.delete(:finder_params) || [])
-        finder_method = 'find' + (finder_params.empty? ? '' : '_by_' + finder_params.join('_and_'))
+        options[:finder_params] = _normalize_finder_params(callback_options.delete(:finder_params) || [])
+        options[:finder_method] = 'find' + (options[:finder_params].empty? ? '' : '_by_' + options[:finder_params].join('_and_'))
 
-        ancestor = options.delete(:ancestor)
-        scope = options.delete(:scope)
+        options[:ancestor] = callback_options.delete(:ancestor)
+        options[:scope] = callback_options.delete(:scope)
 
-        names.each do |variable|
-          before_action options do |controller|
-            if !ancestor.nil?
-              if controller.instance_variable_defined?("@#{ancestor}")
-                resource = controller.instance_variable_get("@#{ancestor}")
-                model_class = resource.class
-              else
-                model_class = ancestor.to_s.camelize.constantize
-                resource = model_class.find(params["#{model_class.name.underscore}_id".to_sym])
-              end
-              reflection_name = (model || variable).to_s.underscore.pluralize.to_sym
-              resource = resource.send(reflection_name) if resource.respond_to?(reflection_name)
-            elsif !model.nil? && model.descends_from_active_record?
-              model_class = model
-            elsif
-              model_class = variable.to_s.camelize.constantize
-            end
-
-            resource ||= model_class
-
-            unless scope.nil?
-              scope = [scope] unless scope.is_a?(Array)
-              scope.each { |s| resource = resource.send(s) }
-            end
-
-            if finder_params.empty?
-              values_for_find = controller.params["#{variable}_id".to_sym] || controller.params[:id]
-            else
-              defaults = finder_params.inject({}) { |h, v| h.merge(v.to_s => nil) }
-              values_for_find = defaults.merge(controller.params.permit(finder_params)).values
-            end
-
-            resource = resource.send(finder_method, *values_for_find)
-
-            var_name = "@#{variable}".to_sym
-            controller.instance_variable_set(var_name, resource)
-          end
-        end
+        _insert_setters(names, options, callback_options)
       end
 
       private
-        def normalize_finder_params(finder_params)
+        def _normalize_finder_params(finder_params)
           finder_params = [finder_params] unless finder_params.is_a?(Array)
           finder_params = finder_params.compact.uniq
           finder_params.clear if finder_params.one? && finder_params.join.eql?('id')
           finder_params
         end
+
+        def _insert_setters(setters, options, callback_options)
+          setters.each do |setter|
+            before_action callback_options do |controller|
+              resource = _get_resource(setter, options[:model], options[:ancestor])
+              Array(options[:scope]).each { |s| resource = resource.send(s) } unless options[:scope].nil?
+              values_for_find = _get_values_for_finder_params(setter, options[:finder_params])
+              resource = resource.send(options[:finder_method], *values_for_find)
+              controller.instance_variable_set("@#{setter}".to_sym, resource)
+            end
+          end
+        end
     end
+
+    private
+      def _get_resource(setter, model, ancestor)
+        if !ancestor.nil?
+          _get_ancestor_resource(setter, model, ancestor)
+        else
+          (!model.nil? && model.descends_from_active_record?) ? model : setter.to_s.camelize.constantize
+        end
+      end
+
+      def _get_ancestor_resource(setter, model, ancestor)
+        if instance_variable_defined?("@#{ancestor}")
+          resource = instance_variable_get("@#{ancestor}")
+        else
+          model_class = ancestor.to_s.camelize.constantize
+          resource = model_class.find(params["#{model_class.name.underscore}_id".to_sym])
+        end
+        reflection_name = (model || setter).to_s.underscore.pluralize.to_sym
+        resource = resource.send(reflection_name) if resource.respond_to?(reflection_name)
+      end
+
+      def _get_values_for_finder_params(setter, finder_params)
+        if finder_params.empty?
+          values_for_find = params["#{setter}_id".to_sym] || params[:id]
+        else
+          defaults = finder_params.inject({}) { |h, v| h.merge(v.to_s => nil) }
+          values_for_find = defaults.merge(params.permit(finder_params)).values
+        end
+      end
   end
 end

data/lib/controller_setter_pattern/version.rb

@@ -1,6 +1,6 @@
 module ControllerSetterPattern #:nodoc:
   MAJOR = 0
   MINOR = 1
-  PATCH = 0
+  PATCH = 1
   VERSION = "#{MAJOR}.#{MINOR}.#{PATCH}"
 end

data/log/.gitignore

@@ -0,0 +1,2 @@
+*
+!.gitignore

data/spec/controller_setter_pattern_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-require 'rspec/rails'
 
 describe ControllerSetterPattern do
   it 'is a model' do
@@ -39,10 +38,14 @@ describe AccountController, type: :controller do
     end
 
     it 'finds an instance with scope' do
-      user.active!
       get :profile, username: user.username
       should be_a(User)
     end
+
+    it 'finds the instance with scopes' do
+      get :admin_profile, username: user.username
+      expect(assigns(:admin_account)).to be_a(User)
+    end
   end
 end
 

data/spec/factories.rb

@@ -3,6 +3,14 @@ FactoryGirl.define do
     name     { Faker::Name.name }
     username { Faker::Internet.user_name(name) }
     email    { Faker::Internet.safe_email(username) }
+    admin    false
+
+    after(:create) do |user, evaluator|
+      if evaluator.id == 1
+        user.admin = true
+        user.active!
+      end
+    end
   end
 
   factory :customer do

data/spec/spec_helper.rb

@@ -1,3 +1,4 @@
+require 'action_controller/railtie'
 require 'action_controller'
 require 'active_model'
 require 'active_record'
@@ -5,14 +6,26 @@ require 'database_cleaner'
 require 'logger'
 require 'faker'
 require 'factory_girl_rails'
+require 'rspec/rails'
+require 'rails'
+require 'codeclimate-test-reporter'
+
+formatters = [SimpleCov::Formatter::HTMLFormatter]
+formatters << CodeClimate::TestReporter::Formatter if ENV['CODECLIMATE_REPO_TOKEN']
+SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[*formatters]
+SimpleCov.start
+
 require 'controller_setter_pattern'
 
 module Rails
-  class App
+  class App < Rails::Application
     def env_config; {} end
+
     def routes
       @routes ||= ActionDispatch::Routing::RouteSet.new
     end
+
+    config.root = File.expand_path('../../', __FILE__)
   end
 
   def self.application

data/spec/support/controllers.rb

@@ -13,6 +13,7 @@ end
 class AccountController < ActionController::Base
   set :account, model: User, finder_params: :email, only: :resend_password
   set :account, model: User, scope: :active, finder_params: :username, only: :profile
+  set :admin_account, model: User, scope: [:active, :administrator], finder_params: :username, only: :admin_profile
 
   def resend_password
     render text: "An email containing the new password was sent to your inbox (#{@account.email})."
@@ -21,6 +22,10 @@ class AccountController < ActionController::Base
   def profile
     render json: @account
   end
+
+  def admin_profile
+    render json: @admin_account
+  end
 end
 
 class OrdersController < ActionController::Base

data/spec/support/models.rb

@@ -14,6 +14,8 @@ class User < ActiveRecord::Base
   validates_uniqueness_of :username, case_sensitive: false
 
   before_save { |record| record.status = 'pending' if record.passive? }
+
+  scope :administrator, -> { where(admin: true) }
 end
 
 class Customer < ActiveRecord::Base

data/spec/support/routes.rb

@@ -3,6 +3,7 @@ Rails.application.routes.draw do
 
   get 'resend_password/:email' => 'account#resend_password'
   get 'profile/:username' => 'account#profile'
+  get 'admin/profile/:username' => 'account#admin_profile', as: :admin_profile
 
   get 'customers/:customer_id/orders/:id' => 'orders#show'
   get 'customers/:customer_id/orders/:id/edit' => 'orders#edit', as: :edit

data/spec/support/schema.rb

@@ -6,6 +6,7 @@ ActiveRecord::Schema.define do
     t.string :name
     t.string :username, unique: true
     t.string :email, unique: true
+    t.boolean :admin, default: false
     t.timestamps null: false
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: controller_setter_pattern
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Rodrigo Casara
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-04 00:00:00.000000000 Z
+date: 2015-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -146,14 +146,17 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - controller_setter_pattern.gemspec
+- coverage/.gitignore
 - lib/controller_setter_pattern.rb
 - lib/controller_setter_pattern/action_controller.rb
 - lib/controller_setter_pattern/version.rb
+- log/.gitignore
 - spec/controller_setter_pattern_spec.rb
 - spec/factories.rb
 - spec/spec_helper.rb