contribution-checker 1.2.1 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f6ecd5538f10ca9621b4fa836289523aa63976ed
-  data.tar.gz: 3f8256f68c44955712b5c88941619a224ffcb9ec
+  metadata.gz: 93c623a0b2a62aac8d53ba2a929540f84cffdd0e
+  data.tar.gz: 02e8cd90d4bb28a23d3fb0289cb708429fa5b504
 SHA512:
-  metadata.gz: dc84b1ef6e9a2d17882402647b9957ee68608c76385e6c775b893b731528f4bbfe53f2610a4c68992f7a5532031f9cc2159e5c77507d36f0a39dd35b81d6d104
-  data.tar.gz: e9b884acb90e6e1c4bf6a54b3f3012fd5efe1e7809ad90662394ac7a792b725832d906fa57b69ff8d652dc2b114a32268432732d9bc91b873923b7486dc759f3
+  metadata.gz: a7c2919aaa0c9e35d7b939aaa40e429f2ee4cb0033983b45bf373be81d0ba9ce4d1b059db661076b9c7921fddb3046d0fa2625bd31e1bdfff6b8ca1cb4ebdc15
+  data.tar.gz: efe0ad40370c02026581f69199b17f0363a67704a2a33204a8890c45e2055aa348296ba37b044288b3eb7aaedbbc8da235e9e7f6d561afebc416d627373a705a

data/README.md

@@ -15,11 +15,12 @@ checker.check
 => {
   :contribution => true,
   :and_criteria => {
+    :commit_email_is_not_generic => true,
     :commit_in_valid_branch      => true,
     :commit_in_last_year         => true,
     :repo_not_a_fork             => true,
     :commit_email_linked_to_user => true,
-    :commit_email                => "example@example.com",
+    :commit_email                => "me@foo.com",
     :default_branch              => "master"
   },
   :or_criteria => {

data/contribution-checker.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["jdennes@gmail.com"]
   spec.summary       = %q{Check whether a commit is counted as a contribution.}
   spec.description   = %q{Check whether a GitHub commit is counted as a contribution for a specific GitHub user.}
-  spec.homepage      = ""
+  spec.homepage      = "https://github.com/jdennes/contribution-checker"
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")

data/lib/contribution-checker/checker.rb

@@ -33,11 +33,12 @@ module ContributionChecker
     # {
     #   :contribution => true,
     #   :and_criteria => {
+    #     :commit_email_is_not_generic => true,
     #     :commit_in_valid_branch      => true,
     #     :commit_in_last_year         => true,
     #     :repo_not_a_fork             => true,
     #     :commit_email_linked_to_user => true,
-    #     :commit_email                => "example@example.com",
+    #     :commit_email                => "me@foo.com",
     #     :default_branch              => "master"
     #   },
     #   :or_criteria => {
@@ -62,6 +63,7 @@ module ContributionChecker
       @repo = @client.repository @nwo
       @user = @client.user
 
+      @commit_email_is_not_generic = commit_email_is_not_generic?
       @commit_in_valid_branch = commit_in_valid_branch?
       @commit_in_last_year = commit_in_last_year?
       @repo_not_a_fork = !repository_is_fork?
@@ -75,6 +77,7 @@ module ContributionChecker
       {
         :contribution => and_criteria_met? && or_criteria_met?,
         :and_criteria => {
+          :commit_email_is_not_generic => @commit_email_is_not_generic,
           :commit_in_valid_branch      => @commit_in_valid_branch,
           :commit_in_last_year         => @commit_in_last_year,
           :repo_not_a_fork             => @repo_not_a_fork,
@@ -108,6 +111,18 @@ module ContributionChecker
       end
     end
 
+    # Checks that the commit was not authored using a non-generic email.
+    # For example, this will return false when the commit was authored using
+    # emails like me@example.com, me@localhost, me@fake.org, etc.
+    #
+    # @return [Boolean]
+    def commit_email_is_not_generic?
+      @commit[:commit][:author][:email] !~ Regexp.union(
+        /[@.](example|test|fake|none)\.?(com|net|org)?\z/i,
+        /[@.]local\.?(host)?\z/i,
+      )
+    end
+
     # Checks whether the commit is in a valid branch. A valid branch is defined
     # as either the default branch of the repository, or the gh-pages branch.
     #
@@ -254,6 +269,7 @@ module ContributionChecker
     #
     # @return [Boolean]
     def and_criteria_met?
+      @commit_email_is_not_generic &&
       @commit_in_valid_branch &&
       @commit_in_last_year &&
       @repo_not_a_fork &&

data/lib/contribution-checker/version.rb

@@ -1,3 +1,3 @@
 module ContributionChecker
-  VERSION = "1.2.1"
+  VERSION = "1.3.0"
 end

data/spec/contribution-checker/checker_spec.rb

@@ -63,6 +63,51 @@ describe ContributionChecker::Checker do
       end
     end
 
+    context "when a commit is authored using a generic email address" do
+      let(:checker) { checker = ContributionChecker::Checker.new \
+        :access_token => "token",
+        :commit_url   => "https://github.com/jdennes/contribution-checker/commit/731e83d4abf1bd67ac6ab68d18387693482e47cf"
+      }
+
+      before do
+        stub_get("/repos/jdennes/contribution-checker/commits/731e83d4abf1bd67ac6ab68d18387693482e47cf").
+          to_return(json_response("commit_with_generic_email.json"))
+        stub_get("/repos/jdennes/contribution-checker").
+          to_return(json_response("repo.json"))
+        stub_get("/user").
+          to_return(json_response("user.json"))
+        stub_get("/repos/jdennes/contribution-checker/compare/master...731e83d4abf1bd67ac6ab68d18387693482e47cf").
+          to_return(json_response("default_compare.json"))
+        stub_get("/user/emails").
+          to_return(json_response("emails.json"))
+        stub_get("/user/starred/jdennes/contribution-checker").
+          to_return(:status => 404)
+        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&state=all").
+          to_return(json_response("issues_and_prs.json"))
+        end
+
+      it "returns the check result" do
+        result = checker.check
+        expect(result).to be_a(Hash)
+
+        expect(result[:contribution]).to eq(false)
+
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(false)
+        expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
+        expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
+        expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
+        expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
+        expect(result[:and_criteria][:commit_email]).to eq("another@example.com")
+        expect(result[:and_criteria][:default_branch]).to eq("master")
+
+        expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
+        expect(result[:or_criteria][:user_can_push_to_repo]).to eq(true)
+        expect(result[:or_criteria][:user_is_repo_org_member]).to eq(false)
+        expect(result[:or_criteria][:user_has_fork_of_repo]).to eq(false)
+        expect(result[:or_criteria][:user_has_opened_issue_or_pr_in_repo]).to eq(true)
+      end
+    end
+
     context "when a commit is in the default branch and is successfully checked" do
       let(:checker) { checker = ContributionChecker::Checker.new \
         :access_token => "token",
@@ -92,11 +137,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(true)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
@@ -138,11 +184,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(true)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
@@ -184,11 +231,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(true)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
@@ -230,11 +278,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(false)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(false)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
@@ -277,11 +326,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(true)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
@@ -323,11 +373,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(true)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
@@ -369,11 +420,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(true)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
@@ -419,11 +471,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(true)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)
@@ -469,11 +522,12 @@ describe ContributionChecker::Checker do
 
         expect(result[:contribution]).to eq(true)
 
+        expect(result[:and_criteria][:commit_email_is_not_generic]).to eq(true)
         expect(result[:and_criteria][:commit_in_valid_branch]).to eq(true)
         expect(result[:and_criteria][:commit_in_last_year]).to eq(true)
         expect(result[:and_criteria][:repo_not_a_fork]).to eq(true)
         expect(result[:and_criteria][:commit_email_linked_to_user]).to eq(true)
-        expect(result[:and_criteria][:commit_email]).to eq("example@example.com")
+        expect(result[:and_criteria][:commit_email]).to eq("me@foo.com")
         expect(result[:and_criteria][:default_branch]).to eq("master")
 
         expect(result[:or_criteria][:user_has_starred_repo]).to eq(false)

data/spec/fixtures/commit.json

@@ -3,12 +3,12 @@
   "commit": {
     "author": {
       "name": "James Dennes",
-      "email": "example@example.com",
+      "email": "me@foo.com",
       "date": "2014-06-08T10:25:34Z"
     },
     "committer": {
       "name": "James Dennes",
-      "email": "example@example.com",
+      "email": "me@foo.com",
       "date": "2014-06-08T10:25:34Z"
     },
     "message": "Version 0.0.2",

data/spec/fixtures/commit_with_generic_email.json

@@ -0,0 +1,89 @@
+{
+  "sha": "731e83d4abf1bd67ac6ab68d18387693482e47cf",
+  "commit": {
+    "author": {
+      "name": "James Dennes",
+      "email": "another@example.com",
+      "date": "2014-06-08T10:25:34Z"
+    },
+    "committer": {
+      "name": "James Dennes",
+      "email": "another@example.com",
+      "date": "2014-06-08T10:25:34Z"
+    },
+    "message": "Version 0.0.2",
+    "tree": {
+      "sha": "30d937ac96b77183e8df7f319acc1e4387516981",
+      "url": "https://api.github.com/repos/jdennes/contribution-checker/git/trees/30d937ac96b77183e8df7f319acc1e4387516981"
+    },
+    "url": "https://api.github.com/repos/jdennes/contribution-checker/git/commits/731e83d4abf1bd67ac6ab68d18387693482e47cf",
+    "comment_count": 0
+  },
+  "url": "https://api.github.com/repos/jdennes/contribution-checker/commits/731e83d4abf1bd67ac6ab68d18387693482e47cf",
+  "html_url": "https://github.com/jdennes/contribution-checker/commit/731e83d4abf1bd67ac6ab68d18387693482e47cf",
+  "comments_url": "https://api.github.com/repos/jdennes/contribution-checker/commits/731e83d4abf1bd67ac6ab68d18387693482e47cf/comments",
+  "author": {
+    "login": "jdennes",
+    "id": 65057,
+    "avatar_url": "https://avatars.githubusercontent.com/u/65057?",
+    "gravatar_id": "55fd031da91ef9af6e6ed88b101416a1",
+    "url": "https://api.github.com/users/jdennes",
+    "html_url": "https://github.com/jdennes",
+    "followers_url": "https://api.github.com/users/jdennes/followers",
+    "following_url": "https://api.github.com/users/jdennes/following{/other_user}",
+    "gists_url": "https://api.github.com/users/jdennes/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/jdennes/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/jdennes/subscriptions",
+    "organizations_url": "https://api.github.com/users/jdennes/orgs",
+    "repos_url": "https://api.github.com/users/jdennes/repos",
+    "events_url": "https://api.github.com/users/jdennes/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/jdennes/received_events",
+    "type": "User",
+    "site_admin": true
+  },
+  "committer": {
+    "login": "jdennes",
+    "id": 65057,
+    "avatar_url": "https://avatars.githubusercontent.com/u/65057?",
+    "gravatar_id": "55fd031da91ef9af6e6ed88b101416a1",
+    "url": "https://api.github.com/users/jdennes",
+    "html_url": "https://github.com/jdennes",
+    "followers_url": "https://api.github.com/users/jdennes/followers",
+    "following_url": "https://api.github.com/users/jdennes/following{/other_user}",
+    "gists_url": "https://api.github.com/users/jdennes/gists{/gist_id}",
+    "starred_url": "https://api.github.com/users/jdennes/starred{/owner}{/repo}",
+    "subscriptions_url": "https://api.github.com/users/jdennes/subscriptions",
+    "organizations_url": "https://api.github.com/users/jdennes/orgs",
+    "repos_url": "https://api.github.com/users/jdennes/repos",
+    "events_url": "https://api.github.com/users/jdennes/events{/privacy}",
+    "received_events_url": "https://api.github.com/users/jdennes/received_events",
+    "type": "User",
+    "site_admin": true
+  },
+  "parents": [
+    {
+      "sha": "5514532ab61216d1d7d242fd624a2f215d225a31",
+      "url": "https://api.github.com/repos/jdennes/contribution-checker/commits/5514532ab61216d1d7d242fd624a2f215d225a31",
+      "html_url": "https://github.com/jdennes/contribution-checker/commit/5514532ab61216d1d7d242fd624a2f215d225a31"
+    }
+  ],
+  "stats": {
+    "total": 2,
+    "additions": 1,
+    "deletions": 1
+  },
+  "files": [
+    {
+      "sha": "d8853e79dea5d3235cb470f4ea1de0ec2d17bcb5",
+      "filename": "lib/contribution-checker/version.rb",
+      "status": "modified",
+      "additions": 1,
+      "deletions": 1,
+      "changes": 2,
+      "blob_url": "https://github.com/jdennes/contribution-checker/blob/731e83d4abf1bd67ac6ab68d18387693482e47cf/lib/contribution-checker/version.rb",
+      "raw_url": "https://github.com/jdennes/contribution-checker/raw/731e83d4abf1bd67ac6ab68d18387693482e47cf/lib/contribution-checker/version.rb",
+      "contents_url": "https://api.github.com/repos/jdennes/contribution-checker/contents/lib/contribution-checker/version.rb?ref=731e83d4abf1bd67ac6ab68d18387693482e47cf",
+      "patch": "@@ -1,3 +1,3 @@\n module ContributionChecker\n-  VERSION = \"0.0.1\"\n+  VERSION = \"0.0.2\"\n end"
+    }
+  ]
+}

data/spec/fixtures/default_compare.json

@@ -9,12 +9,12 @@
     "commit": {
       "author": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T22:47:15Z"
       },
       "committer": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T22:47:15Z"
       },
       "message": "Add ContributionChecker::InvalidAccessTokenError",
@@ -79,12 +79,12 @@
     "commit": {
       "author": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T10:25:34Z"
       },
       "committer": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T10:25:34Z"
       },
       "message": "Version 0.0.2",

data/spec/fixtures/default_compare_ahead.json

@@ -9,12 +9,12 @@
     "commit": {
       "author": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T22:47:15Z"
       },
       "committer": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T22:47:15Z"
       },
       "message": "Add ContributionChecker::InvalidAccessTokenError",
@@ -79,12 +79,12 @@
     "commit": {
       "author": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T10:25:34Z"
       },
       "committer": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T10:25:34Z"
       },
       "message": "Version 0.0.2",

data/spec/fixtures/emails.json

@@ -1,6 +1,6 @@
 [
   {
-    "email": "example@example.com",
+    "email": "me@foo.com",
     "primary": false,
     "verified": true
   },

data/spec/fixtures/gh-pages_compare.json

@@ -9,12 +9,12 @@
     "commit": {
       "author": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T22:47:15Z"
       },
       "committer": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T22:47:15Z"
       },
       "message": "Add ContributionChecker::InvalidAccessTokenError",
@@ -79,12 +79,12 @@
     "commit": {
       "author": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T10:25:34Z"
       },
       "committer": {
         "name": "James Dennes",
-        "email": "example@example.com",
+        "email": "me@foo.com",
         "date": "2014-06-08T10:25:34Z"
       },
       "message": "Version 0.0.2",

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: contribution-checker
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors:
 - James Dennes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-24 00:00:00.000000000 Z
+date: 2015-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit
@@ -128,6 +128,7 @@ files:
 - lib/contribution-checker/version.rb
 - spec/contribution-checker/checker_spec.rb
 - spec/fixtures/commit.json
+- spec/fixtures/commit_with_generic_email.json
 - spec/fixtures/default_compare.json
 - spec/fixtures/default_compare_ahead.json
 - spec/fixtures/emails.json
@@ -144,7 +145,7 @@ files:
 - spec/fixtures/user_fork_not_matching.json
 - spec/fixtures/user_repos.json
 - spec/helper.rb
-homepage: ''
+homepage: https://github.com/jdennes/contribution-checker
 licenses:
 - MIT
 metadata: {}
@@ -164,13 +165,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.2.3
 signing_key: 
 specification_version: 4
 summary: Check whether a commit is counted as a contribution.
 test_files:
 - spec/contribution-checker/checker_spec.rb
 - spec/fixtures/commit.json
+- spec/fixtures/commit_with_generic_email.json
 - spec/fixtures/default_compare.json
 - spec/fixtures/default_compare_ahead.json
 - spec/fixtures/emails.json