contribution-checker 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c2e0818376e281959857ad59fcf196dbe5a107d2
-  data.tar.gz: f822111b754aa62875a4cbfdddb108af1736929d
+  metadata.gz: f6ecd5538f10ca9621b4fa836289523aa63976ed
+  data.tar.gz: 3f8256f68c44955712b5c88941619a224ffcb9ec
 SHA512:
-  metadata.gz: 00594f72065361343a7121e7563f6908031de2685bb0f9bfa03ee0dd810320d8c70578362815ab9eb42707d063e0e21b695fd775746516577c50e3a67152a324
-  data.tar.gz: 953c874712e16d57886dfa59983d429ac8ead173850d5d1a75922f24f36b908ca728febc4f0e2be373887f16aba73e46389e60cbe8970bb8a37f8f2464e0c89f
+  metadata.gz: dc84b1ef6e9a2d17882402647b9957ee68608c76385e6c775b893b731528f4bbfe53f2610a4c68992f7a5532031f9cc2159e5c77507d36f0a39dd35b81d6d104
+  data.tar.gz: e9b884acb90e6e1c4bf6a54b3f3012fd5efe1e7809ad90662394ac7a792b725832d906fa57b69ff8d652dc2b114a32268432732d9bc91b873923b7486dc759f3

data/README.md

@@ -34,7 +34,7 @@ checker.check
 
 You might also like to try out the [Contribution Checker][app] app built on top of this library:
 
-![checker](https://cloud.githubusercontent.com/assets/65057/3352063/2a90d4b4-fa31-11e3-8733-c52d5df05bad.png)
+![checker](https://cloud.githubusercontent.com/assets/65057/6320756/b32c9328-bae6-11e4-9ba1-48ced9a5fb6e.png)
 
 The source for the app is in [jdennes/contribution-checker-app][contribution-checker-app].
 

data/contribution-checker.gemspec

@@ -18,9 +18,9 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "octokit", "~> 3.3"
+  spec.add_dependency "octokit", "~> 3.8"
 
-  spec.add_development_dependency "bundler", "~> 1.6"
+  spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
   spec.add_development_dependency "webmock"

data/lib/contribution-checker/checker.rb

@@ -171,9 +171,7 @@ module ContributionChecker
     #
     # @return [Boolean]
     def user_has_starred_repo?
-      @client.auto_paginate = true
-      starred = @client.starred @user.login
-      starred.map { |s| s.full_name }.include? @nwo
+      @client.starred? @nwo
     end
 
     # Checks whether the authenticated user is a member of the organization
@@ -232,8 +230,12 @@ module ContributionChecker
       @user_forks = @user_repos.select { |r| r[:fork] }
       @user_forks.each do |f|
         r = @client.repository f[:full_name]
-        return true if r[:parent][:full_name] == @repo[:full_name]
+        if r[:parent][:full_name] == @repo[:full_name]
+          @client.auto_paginate = false
+          return true
+        end
       end
+      @client.auto_paginate = false
       false
     end
 

data/lib/contribution-checker/version.rb

@@ -1,3 +1,3 @@
 module ContributionChecker
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/spec/contribution-checker/checker_spec.rb

@@ -80,9 +80,9 @@ describe ContributionChecker::Checker do
           to_return(json_response("default_compare.json"))
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
-        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/user/starred/jdennes/contribution-checker").
+          to_return(:status => 404)
+        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 
@@ -126,9 +126,9 @@ describe ContributionChecker::Checker do
           to_return(json_response("gh-pages_compare.json"))
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
-        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/user/starred/jdennes/contribution-checker").
+          to_return(:status => 404)
+        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 
@@ -172,9 +172,9 @@ describe ContributionChecker::Checker do
           to_return(json_response("gh-pages_compare.json"))
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
-        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/user/starred/jdennes/contribution-checker").
+          to_return(:status => 404)
+        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 
@@ -218,9 +218,9 @@ describe ContributionChecker::Checker do
           to_return(:status => 404)
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
-        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/user/starred/jdennes/contribution-checker").
+          to_return(:status => 404)
+        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 
@@ -263,11 +263,11 @@ describe ContributionChecker::Checker do
           to_return(json_response("default_compare.json"))
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
+        stub_get("/user/starred/jdennes/contribution-checker").
+          to_return(:status => 404)
         stub_get("/orgs/github/members/jdennes").
           to_return(:status => 204)
-        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 
@@ -309,11 +309,11 @@ describe ContributionChecker::Checker do
           to_return(json_response("default_compare.json"))
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
+        stub_get("/user/starred/jdennes/contribution-checker").
+          to_return(:status => 404)
         stub_get("/repos/jdennes/contribution-checker/forks?per_page=100").
           to_return(json_response("repo_forks.json"))
-        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/repos/jdennes/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 
@@ -355,11 +355,11 @@ describe ContributionChecker::Checker do
           to_return(json_response("default_compare.json"))
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
+        stub_get("/user/starred/someone/contribution-checker").
+          to_return(:status => 404)
         stub_get("/repos/jdennes/contribution-checker").
           to_return(json_response("potential_fork.json"))
-        stub_get("/repos/someone/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/repos/someone/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 
@@ -401,15 +401,15 @@ describe ContributionChecker::Checker do
           to_return(json_response("default_compare.json"))
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
+        stub_get("/user/starred/someone/contribution-checker").
+          to_return(:status => 404)
         stub_get("/repos/jdennes/contribution-checker").
           to_return(:status => 404)
         stub_get("/user/repos?per_page=100").
           to_return(json_response("user_repos.json"))
         stub_get("/repos/jdennes/myfork").
           to_return(json_response("user_fork.json"))
-        stub_get("/repos/someone/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/repos/someone/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 
@@ -451,15 +451,15 @@ describe ContributionChecker::Checker do
           to_return(json_response("default_compare.json"))
         stub_get("/user/emails").
           to_return(json_response("emails.json"))
-        stub_get("/user/starred?per_page=100").
-          to_return(json_response("starred.json"))
+        stub_get("/user/starred/someone/contribution-checker").
+          to_return(:status => 404)
         stub_get("/repos/jdennes/contribution-checker").
           to_return(:status => 404)
         stub_get("/user/repos?per_page=100").
           to_return(json_response("user_repos.json"))
         stub_get("/repos/jdennes/myfork").
           to_return(json_response("user_fork_not_matching.json"))
-        stub_get("/repos/someone/contribution-checker/issues?creator=jdennes&per_page=100&state=all").
+        stub_get("/repos/someone/contribution-checker/issues?creator=jdennes&state=all").
           to_return(json_response("issues_and_prs.json"))
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: contribution-checker
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - James Dennes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-22 00:00:00.000000000 Z
+date: 2015-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.8'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -139,7 +139,6 @@ files:
 - spec/fixtures/repo_forks.json
 - spec/fixtures/repo_with_forks.json
 - spec/fixtures/repo_with_too_many_forks.json
-- spec/fixtures/starred.json
 - spec/fixtures/user.json
 - spec/fixtures/user_fork.json
 - spec/fixtures/user_fork_not_matching.json
@@ -165,7 +164,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Check whether a commit is counted as a contribution.
@@ -183,7 +182,6 @@ test_files:
 - spec/fixtures/repo_forks.json
 - spec/fixtures/repo_with_forks.json
 - spec/fixtures/repo_with_too_many_forks.json
-- spec/fixtures/starred.json
 - spec/fixtures/user.json
 - spec/fixtures/user_fork.json
 - spec/fixtures/user_fork_not_matching.json

data/spec/fixtures/starred.json

@@ -1,186 +0,0 @@
-[
-  {
-    "id": 16283275,
-    "name": "geo_pattern",
-    "full_name": "jasonlong/geo_pattern",
-    "owner": {
-      "login": "jasonlong",
-      "id": 6104,
-      "avatar_url": "https://avatars.githubusercontent.com/u/6104?v=3",
-      "gravatar_id": "",
-      "url": "https://api.github.com/users/jasonlong",
-      "html_url": "https://github.com/jasonlong",
-      "followers_url": "https://api.github.com/users/jasonlong/followers",
-      "following_url": "https://api.github.com/users/jasonlong/following{/other_user}",
-      "gists_url": "https://api.github.com/users/jasonlong/gists{/gist_id}",
-      "starred_url": "https://api.github.com/users/jasonlong/starred{/owner}{/repo}",
-      "subscriptions_url": "https://api.github.com/users/jasonlong/subscriptions",
-      "organizations_url": "https://api.github.com/users/jasonlong/orgs",
-      "repos_url": "https://api.github.com/users/jasonlong/repos",
-      "events_url": "https://api.github.com/users/jasonlong/events{/privacy}",
-      "received_events_url": "https://api.github.com/users/jasonlong/received_events",
-      "type": "User",
-      "site_admin": true
-    },
-    "private": false,
-    "html_url": "https://github.com/jasonlong/geo_pattern",
-    "description": "Create beautiful generative geometric background images from a string.",
-    "fork": false,
-    "url": "https://api.github.com/repos/jasonlong/geo_pattern",
-    "forks_url": "https://api.github.com/repos/jasonlong/geo_pattern/forks",
-    "keys_url": "https://api.github.com/repos/jasonlong/geo_pattern/keys{/key_id}",
-    "collaborators_url": "https://api.github.com/repos/jasonlong/geo_pattern/collaborators{/collaborator}",
-    "teams_url": "https://api.github.com/repos/jasonlong/geo_pattern/teams",
-    "hooks_url": "https://api.github.com/repos/jasonlong/geo_pattern/hooks",
-    "issue_events_url": "https://api.github.com/repos/jasonlong/geo_pattern/issues/events{/number}",
-    "events_url": "https://api.github.com/repos/jasonlong/geo_pattern/events",
-    "assignees_url": "https://api.github.com/repos/jasonlong/geo_pattern/assignees{/user}",
-    "branches_url": "https://api.github.com/repos/jasonlong/geo_pattern/branches{/branch}",
-    "tags_url": "https://api.github.com/repos/jasonlong/geo_pattern/tags",
-    "blobs_url": "https://api.github.com/repos/jasonlong/geo_pattern/git/blobs{/sha}",
-    "git_tags_url": "https://api.github.com/repos/jasonlong/geo_pattern/git/tags{/sha}",
-    "git_refs_url": "https://api.github.com/repos/jasonlong/geo_pattern/git/refs{/sha}",
-    "trees_url": "https://api.github.com/repos/jasonlong/geo_pattern/git/trees{/sha}",
-    "statuses_url": "https://api.github.com/repos/jasonlong/geo_pattern/statuses/{sha}",
-    "languages_url": "https://api.github.com/repos/jasonlong/geo_pattern/languages",
-    "stargazers_url": "https://api.github.com/repos/jasonlong/geo_pattern/stargazers",
-    "contributors_url": "https://api.github.com/repos/jasonlong/geo_pattern/contributors",
-    "subscribers_url": "https://api.github.com/repos/jasonlong/geo_pattern/subscribers",
-    "subscription_url": "https://api.github.com/repos/jasonlong/geo_pattern/subscription",
-    "commits_url": "https://api.github.com/repos/jasonlong/geo_pattern/commits{/sha}",
-    "git_commits_url": "https://api.github.com/repos/jasonlong/geo_pattern/git/commits{/sha}",
-    "comments_url": "https://api.github.com/repos/jasonlong/geo_pattern/comments{/number}",
-    "issue_comment_url": "https://api.github.com/repos/jasonlong/geo_pattern/issues/comments/{number}",
-    "contents_url": "https://api.github.com/repos/jasonlong/geo_pattern/contents/{+path}",
-    "compare_url": "https://api.github.com/repos/jasonlong/geo_pattern/compare/{base}...{head}",
-    "merges_url": "https://api.github.com/repos/jasonlong/geo_pattern/merges",
-    "archive_url": "https://api.github.com/repos/jasonlong/geo_pattern/{archive_format}{/ref}",
-    "downloads_url": "https://api.github.com/repos/jasonlong/geo_pattern/downloads",
-    "issues_url": "https://api.github.com/repos/jasonlong/geo_pattern/issues{/number}",
-    "pulls_url": "https://api.github.com/repos/jasonlong/geo_pattern/pulls{/number}",
-    "milestones_url": "https://api.github.com/repos/jasonlong/geo_pattern/milestones{/number}",
-    "notifications_url": "https://api.github.com/repos/jasonlong/geo_pattern/notifications{?since,all,participating}",
-    "labels_url": "https://api.github.com/repos/jasonlong/geo_pattern/labels{/name}",
-    "releases_url": "https://api.github.com/repos/jasonlong/geo_pattern/releases{/id}",
-    "created_at": "2014-01-27T15:38:07Z",
-    "updated_at": "2015-01-09T22:05:40Z",
-    "pushed_at": "2015-01-09T22:05:40Z",
-    "git_url": "git://github.com/jasonlong/geo_pattern.git",
-    "ssh_url": "git@github.com:jasonlong/geo_pattern.git",
-    "clone_url": "https://github.com/jasonlong/geo_pattern.git",
-    "svn_url": "https://github.com/jasonlong/geo_pattern",
-    "homepage": "",
-    "size": 1885,
-    "stargazers_count": 584,
-    "watchers_count": 584,
-    "language": "Ruby",
-    "has_issues": true,
-    "has_downloads": true,
-    "has_wiki": true,
-    "has_pages": true,
-    "forks_count": 31,
-    "mirror_url": null,
-    "open_issues_count": 2,
-    "forks": 31,
-    "open_issues": 2,
-    "watchers": 584,
-    "default_branch": "master",
-    "permissions": {
-      "admin": false,
-      "push": false,
-      "pull": true
-    }
-  },
-  {
-    "id": 9639981,
-    "name": "xctool",
-    "full_name": "facebook/xctool",
-    "owner": {
-      "login": "facebook",
-      "id": 69631,
-      "avatar_url": "https://avatars.githubusercontent.com/u/69631?v=3",
-      "gravatar_id": "",
-      "url": "https://api.github.com/users/facebook",
-      "html_url": "https://github.com/facebook",
-      "followers_url": "https://api.github.com/users/facebook/followers",
-      "following_url": "https://api.github.com/users/facebook/following{/other_user}",
-      "gists_url": "https://api.github.com/users/facebook/gists{/gist_id}",
-      "starred_url": "https://api.github.com/users/facebook/starred{/owner}{/repo}",
-      "subscriptions_url": "https://api.github.com/users/facebook/subscriptions",
-      "organizations_url": "https://api.github.com/users/facebook/orgs",
-      "repos_url": "https://api.github.com/users/facebook/repos",
-      "events_url": "https://api.github.com/users/facebook/events{/privacy}",
-      "received_events_url": "https://api.github.com/users/facebook/received_events",
-      "type": "Organization",
-      "site_admin": false
-    },
-    "private": false,
-    "html_url": "https://github.com/facebook/xctool",
-    "description": "A replacement for Apple's xcodebuild that makes it easier to build and test iOS or OSX apps.",
-    "fork": false,
-    "url": "https://api.github.com/repos/facebook/xctool",
-    "forks_url": "https://api.github.com/repos/facebook/xctool/forks",
-    "keys_url": "https://api.github.com/repos/facebook/xctool/keys{/key_id}",
-    "collaborators_url": "https://api.github.com/repos/facebook/xctool/collaborators{/collaborator}",
-    "teams_url": "https://api.github.com/repos/facebook/xctool/teams",
-    "hooks_url": "https://api.github.com/repos/facebook/xctool/hooks",
-    "issue_events_url": "https://api.github.com/repos/facebook/xctool/issues/events{/number}",
-    "events_url": "https://api.github.com/repos/facebook/xctool/events",
-    "assignees_url": "https://api.github.com/repos/facebook/xctool/assignees{/user}",
-    "branches_url": "https://api.github.com/repos/facebook/xctool/branches{/branch}",
-    "tags_url": "https://api.github.com/repos/facebook/xctool/tags",
-    "blobs_url": "https://api.github.com/repos/facebook/xctool/git/blobs{/sha}",
-    "git_tags_url": "https://api.github.com/repos/facebook/xctool/git/tags{/sha}",
-    "git_refs_url": "https://api.github.com/repos/facebook/xctool/git/refs{/sha}",
-    "trees_url": "https://api.github.com/repos/facebook/xctool/git/trees{/sha}",
-    "statuses_url": "https://api.github.com/repos/facebook/xctool/statuses/{sha}",
-    "languages_url": "https://api.github.com/repos/facebook/xctool/languages",
-    "stargazers_url": "https://api.github.com/repos/facebook/xctool/stargazers",
-    "contributors_url": "https://api.github.com/repos/facebook/xctool/contributors",
-    "subscribers_url": "https://api.github.com/repos/facebook/xctool/subscribers",
-    "subscription_url": "https://api.github.com/repos/facebook/xctool/subscription",
-    "commits_url": "https://api.github.com/repos/facebook/xctool/commits{/sha}",
-    "git_commits_url": "https://api.github.com/repos/facebook/xctool/git/commits{/sha}",
-    "comments_url": "https://api.github.com/repos/facebook/xctool/comments{/number}",
-    "issue_comment_url": "https://api.github.com/repos/facebook/xctool/issues/comments/{number}",
-    "contents_url": "https://api.github.com/repos/facebook/xctool/contents/{+path}",
-    "compare_url": "https://api.github.com/repos/facebook/xctool/compare/{base}...{head}",
-    "merges_url": "https://api.github.com/repos/facebook/xctool/merges",
-    "archive_url": "https://api.github.com/repos/facebook/xctool/{archive_format}{/ref}",
-    "downloads_url": "https://api.github.com/repos/facebook/xctool/downloads",
-    "issues_url": "https://api.github.com/repos/facebook/xctool/issues{/number}",
-    "pulls_url": "https://api.github.com/repos/facebook/xctool/pulls{/number}",
-    "milestones_url": "https://api.github.com/repos/facebook/xctool/milestones{/number}",
-    "notifications_url": "https://api.github.com/repos/facebook/xctool/notifications{?since,all,participating}",
-    "labels_url": "https://api.github.com/repos/facebook/xctool/labels{/name}",
-    "releases_url": "https://api.github.com/repos/facebook/xctool/releases{/id}",
-    "created_at": "2013-04-24T05:18:44Z",
-    "updated_at": "2015-01-13T13:34:34Z",
-    "pushed_at": "2014-12-09T01:35:35Z",
-    "git_url": "git://github.com/facebook/xctool.git",
-    "ssh_url": "git@github.com:facebook/xctool.git",
-    "clone_url": "https://github.com/facebook/xctool.git",
-    "svn_url": "https://github.com/facebook/xctool",
-    "homepage": "",
-    "size": 20633,
-    "stargazers_count": 3740,
-    "watchers_count": 3740,
-    "language": "Objective-C",
-    "has_issues": true,
-    "has_downloads": true,
-    "has_wiki": true,
-    "has_pages": false,
-    "forks_count": 398,
-    "mirror_url": null,
-    "open_issues_count": 64,
-    "forks": 398,
-    "open_issues": 64,
-    "watchers": 3740,
-    "default_branch": "master",
-    "permissions": {
-      "admin": false,
-      "push": false,
-      "pull": true
-    }
-  }
-]