context_validations 0.0.3 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d11c171439aaf9f2e7e22d2dea1e148f061f0daa
-  data.tar.gz: 4d430fc4aac414999a209f76411c10962bf1bd88
+  metadata.gz: 1e5d88bf3e08d906667a9d76bc454e4fb2319c17
+  data.tar.gz: 1700bb40d4ef8f2af86e3f74ec6ac1185093940e
 SHA512:
-  metadata.gz: 6586b690a8e4e97cae04a5e8a77636245ee0b875b870daadb0c86263483e5f70500b7b3196fcbc2f0ae8fcd4d50c795f4680b6ad3767762208a0e9a6a5b507fa
-  data.tar.gz: 42563e3c5c1a493f09493e837f01a4e3ffe8aa920864c1b2a0f09a249b6ef5c538c336ec49f1328791a511f649aa57e307c26cea7e4ba08255e5a09a7bb63abf
+  metadata.gz: 8d6e73defea0447f9dfb43f269166a1886b56b2f6aaa974a9d1f3f2371000f445b340b7f61d18e76caaa43c3ace4078fe230e434351e770c824e51b90b9c2dac
+  data.tar.gz: b5b93d9d2d5d0157f69f0662b48d55cea488bc64be75ba6f158fff27dc33fc43fb4cbcd38b2c6957d410d14d166d606be9a03abe43bb63ea23c8fa0378f0aad0

data/README.md

@@ -127,6 +127,37 @@ use `ActiveRecord::Base.create` as we do not want to allow the
 validations to be set via mass-assignment. This does introduce an extra
 step in some places but it shouldn't be that big of a deal.
 
+## Testing ##
+
+Currently only `MiniTest` is supported. We are open to pull requests for supporting additional test frameworks but we only work with `MiniTest` 
+so we probably won't go out of the way to support something we're not using.
+
+We highly recommend using [ValidAttribute](https://github.com/bcardarella/valid_attribute) to test your validations. The following example is done using
+`ValidAttribute`.
+
+### MiniTest ###
+
+You are given access to a `#validations_for(:action_name)` method. You should pass the action in your
+controller that is the context of the validations and use the `#valiadtions=` setter on the model.
+
+This is a common example of how to test:
+
+```ruby
+require 'test_helper'
+
+describe UserController do
+  context 'create' do
+    subject { User.new(:password => 'password', :validations => validations_for(:create)) }
+    it { must have_valid(:name).when('Brian Cardarella') }
+    it { wont have_valid(:name).when(nil, '') }
+  end
+end
+``` 
+
+## ClientSideValidations Support ##
+
+The [ClientSideValidations](https://github.com/bcardarella/client_side_validations) gem is fully supported.
+
 ## Authors ##
 
 * [Brian Cardarella](http://twitter.com/bcardarella)

data/context_validations.gemspec

@@ -22,5 +22,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'minitest'
   spec.add_development_dependency 'm'
-  spec.add_development_dependency 'activemodel'
+  spec.add_development_dependency 'activerecord'
+  spec.add_development_dependency 'sqlite3'
 end

data/lib/context_validations.rb

@@ -1,5 +1,8 @@
 require 'context_validations/version'
 require 'active_support'
+if defined?(MiniTest::Unit::TestCase)
+  require 'context_validations/minitest'
+end
 
 module ContextValidations
   extend ActiveSupport::Autoload

data/lib/context_validations/controller.rb

@@ -51,7 +51,8 @@ module ContextValidations::Controller
       defaults[:attributes] = [attribute]
       validations.each do |key, options|
         key = "#{key.to_s.camelize}Validator"
-        klass = key.include?('::') ? key.constantize : "ActiveModel::Validations::#{key}".constantize
+        namespace = defined?(ActiveRecord) ? ActiveRecord::Base : ActiveModel::Validations
+        klass = key.include?('::') ? key.constantize : namespace.const_get(key)
         validator = klass.new(defaults.merge(_parse_validates_options(options)))
         validators << validator
       end

data/lib/context_validations/minitest.rb

@@ -0,0 +1,27 @@
+module ContextValidations
+  module ValidationsFor
+    module MiniTest
+      def validations_for(action)
+        determine_constant_from_test_name.new.validations(action)
+      end
+
+      def determine_constant_from_test_name
+        names = self.class.name.split('::')
+
+        while names.size > 0 do
+          names.last.sub!(/Test$/, '')
+          begin
+            constant = names.join('::').constantize
+            break(constant) if constant
+          rescue NameError
+            # Constant wasn't found, move on
+          ensure
+            names.pop
+          end
+        end
+      end
+    end
+  end
+end
+
+MiniTest::Unit::TestCase.send(:include, ContextValidations::ValidationsFor::MiniTest)

data/lib/context_validations/model.rb

@@ -29,8 +29,25 @@ module ContextValidations::Model
 
   def run_validations!
     Array.wrap(validations).each do |validator|
+      if validator.respond_to?(:setup)
+        validator.setup(self.class)
+      end
       validator.validate(self)
     end
     errors.empty?
   end
+
+  private
+
+  def _validators
+    validations.inject({}) do |hash, validator|
+      attribute = validator.attributes.first
+      if hash.key?(attribute)
+        hash[attribute] << validator
+      else
+        hash[attribute] = [validator]
+      end
+      hash
+    end
+  end
 end

data/lib/context_validations/version.rb

@@ -1,3 +1,3 @@
 module ContextValidations
-  VERSION = '0.0.3'
+  VERSION = '0.1.0'
 end

data/test/controller_test.rb

@@ -60,6 +60,27 @@ class PrivateController
   end
 end
 
+class CustomValidator < ActiveModel::EachValidator
+  def validate_each(record, attribute, value)
+    if value != 'awesome'
+      record.errors.add(attribute, 'Failed')
+    end
+  end
+end
+
+class CustomValidatorsController
+  include ContextValidations::Controller
+
+  def create
+    validations(:create)
+  end
+
+  private
+
+  def base_validations
+    validates :first_name, :custom => true
+  end
+end
 
 describe 'Controller' do
   context 'Public validations' do
@@ -101,4 +122,14 @@ describe 'Controller' do
       @controller.create.length.must_equal 2
     end
   end
+
+  context 'Custom validations' do
+    before do
+      @controller = CustomValidatorsController.new
+    end
+
+    it 'combines base and create validations for other create action, context is forced' do
+      @controller.create.length.must_equal 1
+    end
+  end
 end

data/test/model_test.rb

@@ -1,12 +1,11 @@
 require 'test_helper'
-require 'active_model'
 
 EmailFormat = /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/
 
-class User
-  include ActiveModel::Validations
+users_table = %{CREATE TABLE users (id INTEGER PRIMARY KEY, first_name TEXT, email TEXT);}
+ActiveRecord::Base.connection.execute(users_table)
+class User < ActiveRecord::Base
   include ContextValidations::Model
-  attr_accessor :first_name, :email
 
   validates :first_name, :presence => true
   validates :email, :format => EmailFormat
@@ -22,7 +21,7 @@ describe 'Model' do
   end
 
   it 'accepts validations set onto the instance' do
-    validations = [ActiveModel::Validations::PresenceValidator.new(:attributes => [:first_name]), ActiveModel::Validations::FormatValidator.new(:attributes => [:email], :with => EmailFormat)]
+    validations = [ActiveModel::Validations::PresenceValidator.new(:attributes => [:first_name]), ActiveModel::Validations::FormatValidator.new(:attributes => [:email], :with => EmailFormat), ActiveRecord::Validations::UniquenessValidator.new(:attributes => [:email])]
     @user.validations = validations
     @user.valid?.must_equal false
     @user.errors.count.must_equal 2

data/test/test_helper.rb

@@ -6,6 +6,7 @@ else
   require 'minitest/autorun'
 end
 
+require 'active_record'
 require 'context_validations'
 
 class MiniTest::Spec
@@ -13,3 +14,8 @@ class MiniTest::Spec
     alias :context :describe
   end
 end
+
+ActiveRecord::Base.establish_connection(
+  :adapter => defined?(JRUBY_VERSION) ? 'jdbcsqlite3' : 'sqlite3',
+  :database => ':memory:'
+)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: context_validations
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors:
 - Brian Cardarella
@@ -81,7 +81,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
@@ -110,6 +124,7 @@ files:
 - context_validations.gemspec
 - lib/context_validations.rb
 - lib/context_validations/controller.rb
+- lib/context_validations/minitest.rb
 - lib/context_validations/model.rb
 - lib/context_validations/version.rb
 - test/controller_test.rb