contentful 2.13.0 → 2.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3514e62a075ac398b0c9106f5ecb267357267c8fa607bd0d4e074204314bf5f
-  data.tar.gz: f577fdda2e5ec172ac6fc938e5964b7b5bd53dc6b0a25228f06d47b9c1225de2
+  metadata.gz: 77d1a0312ff87aa52f3b6c0764b9771b38842f1b24e18128bff86c9aefd59fde
+  data.tar.gz: bec8478bf8561cc00a782d465f80b839a49002f8d9476af88e624ed5814e5d9b
 SHA512:
-  metadata.gz: 35c4148a847481427b22de6314027815ca3f75f3a431f39cad683a654589ab7e73b987273b8bc3c5c3cecfe10624ba9418259505f4f162a19978a3012dbf281e
-  data.tar.gz: 2ec77898592a47104c5537ef9163d389fa5d62d80e9e6756be2715da3ff5778d169310a2d2b93bf77222208f544242daaa676d8a3ac9f8ee26248cae6b77cdde
+  metadata.gz: 0b1d915d4ac1a8ec6f1df4a16a6e2f90e871a93e5c6041fd0e43215fb7ccdaa997a08b7d183d77285516cc2a094be53df8511fad53cf32b24ce3b7907f481622
+  data.tar.gz: 918b2ab9bc2831814fb779cdeb124ea41c73aed753907f41f72b8aa0362e39ebdd4a2099db4cc0b2a13569a148c4cea11130c34d30af35b2a77fcfabf99d32ad

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+## 2.13.1
+### Fixed
+* Fixed detection of empty fields when `:use_camel_case` is `true`. [#203](https://github.com/contentful/contentful.rb/issues/203)
+
 ## 2.13.0
 ### Changed
 * Updated HTTP gem version limits. [#202](https://github.com/contentful/contentful.rb/pull/202)

data/lib/contentful/entry.rb

@@ -103,9 +103,11 @@ module Contentful
     protected
 
     def content_type_field?(name)
+      content_type_key = Support.snakify('contentType', @configuration[:use_camel_case])
+
       content_type = ContentTypeCache.cache_get(
         sys[:space].id,
-        sys[:content_type].id
+        sys[content_type_key.to_sym].id
       )
 
       return false if content_type.nil?

data/lib/contentful/version.rb

@@ -1,5 +1,5 @@
 # Contentful Namespace
 module Contentful
   # Gem Version
-  VERSION = '2.13.0'
+  VERSION = '2.13.1'
 end

data/spec/entry_spec.rb

@@ -541,41 +541,85 @@ describe Contentful::Entry do
   end
 
   describe 'empty fields' do
-    it 'raises an exception by default' do
-      vcr('entries/empty_fields') {
-        entry = create_client(
-          space: 'z4ssexir3p93',
-          access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
-          dynamic_entries: :auto
-        ).entry('2t1x77MgUA4SM2gMiaUcsy')
+    context 'when default configuration' do
+      it 'raises an exception by default' do
+        vcr('entries/empty_fields') {
+          entry = create_client(
+            space: 'z4ssexir3p93',
+            access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
+            dynamic_entries: :auto
+          ).entry('2t1x77MgUA4SM2gMiaUcsy')
 
-        expect { entry.title }.to raise_error Contentful::EmptyFieldError
-      }
-    end
+          expect { entry.title }.to raise_error Contentful::EmptyFieldError
+        }
+      end
 
-    it 'returns nil if raise_for_empty_fields is false' do
-      vcr('entries/empty_fields') {
-        entry = create_client(
-          space: 'z4ssexir3p93',
-          access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
-          dynamic_entries: :auto,
-          raise_for_empty_fields: false
-        ).entry('2t1x77MgUA4SM2gMiaUcsy')
+      it 'returns nil if raise_for_empty_fields is false' do
+        vcr('entries/empty_fields') {
+          entry = create_client(
+            space: 'z4ssexir3p93',
+            access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
+            dynamic_entries: :auto,
+            raise_for_empty_fields: false
+          ).entry('2t1x77MgUA4SM2gMiaUcsy')
 
-        expect(entry.title).to be_nil
-      }
+          expect(entry.title).to be_nil
+        }
+      end
+
+      it 'will properly raise NoMethodError for non-fields' do
+        vcr('entries/empty_fields') {
+          entry = create_client(
+            space: 'z4ssexir3p93',
+            access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
+            dynamic_entries: :auto
+          ).entry('2t1x77MgUA4SM2gMiaUcsy')
+
+          expect { entry.unexisting_field }.to raise_error NoMethodError
+        }
+      end
     end
 
-    it 'will properly raise NoMethodError for non-fields' do
-      vcr('entries/empty_fields') {
-        entry = create_client(
-          space: 'z4ssexir3p93',
-          access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
-          dynamic_entries: :auto
-        ).entry('2t1x77MgUA4SM2gMiaUcsy')
+    context 'when use_camel_case is true it should still work' do
+      it 'raises an exception by default' do
+        vcr('entries/empty_fields') {
+          entry = create_client(
+            space: 'z4ssexir3p93',
+            access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
+            dynamic_entries: :auto,
+            use_camel_case: true
+          ).entry('2t1x77MgUA4SM2gMiaUcsy')
 
-        expect { entry.unexisting_field }.to raise_error NoMethodError
-      }
+          expect { entry.title }.to raise_error Contentful::EmptyFieldError
+        }
+      end
+
+      it 'returns nil if raise_for_empty_fields is false' do
+        vcr('entries/empty_fields') {
+          entry = create_client(
+            space: 'z4ssexir3p93',
+            access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
+            dynamic_entries: :auto,
+            raise_for_empty_fields: false,
+            use_camel_case: true
+          ).entry('2t1x77MgUA4SM2gMiaUcsy')
+
+          expect(entry.title).to be_nil
+        }
+      end
+
+      it 'will properly raise NoMethodError for non-fields' do
+        vcr('entries/empty_fields') {
+          entry = create_client(
+            space: 'z4ssexir3p93',
+            access_token: 'e157fdaf7b325b71d07a94b7502807d4cfbbb1a34e69b7856838e25b92777bc6',
+            dynamic_entries: :auto,
+            use_camel_case: true
+          ).entry('2t1x77MgUA4SM2gMiaUcsy')
+
+          expect { entry.unexisting_field }.to raise_error NoMethodError
+        }
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: contentful
 version: !ruby/object:Gem::Version
-  version: 2.13.0
+  version: 2.13.1
 platform: ruby
 authors:
 - Contentful GmbH (Jan Lelis)
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-26 00:00:00.000000000 Z
+date: 2019-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -266,30 +266,6 @@ files:
 - coverage/.last_run.json
 - coverage/.resultset.json
 - coverage/.resultset.json.lock
-- coverage/assets/0.10.1/application.css
-- coverage/assets/0.10.1/application.js
-- coverage/assets/0.10.1/colorbox/border.png
-- coverage/assets/0.10.1/colorbox/controls.png
-- coverage/assets/0.10.1/colorbox/loading.gif
-- coverage/assets/0.10.1/colorbox/loading_background.png
-- coverage/assets/0.10.1/favicon_green.png
-- coverage/assets/0.10.1/favicon_red.png
-- coverage/assets/0.10.1/favicon_yellow.png
-- coverage/assets/0.10.1/loading.gif
-- coverage/assets/0.10.1/magnify.png
-- coverage/assets/0.10.1/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png
-- coverage/assets/0.10.1/smoothness/images/ui-bg_flat_75_ffffff_40x100.png
-- coverage/assets/0.10.1/smoothness/images/ui-bg_glass_55_fbf9ee_1x400.png
-- coverage/assets/0.10.1/smoothness/images/ui-bg_glass_65_ffffff_1x400.png
-- coverage/assets/0.10.1/smoothness/images/ui-bg_glass_75_dadada_1x400.png
-- coverage/assets/0.10.1/smoothness/images/ui-bg_glass_75_e6e6e6_1x400.png
-- coverage/assets/0.10.1/smoothness/images/ui-bg_glass_95_fef1ec_1x400.png
-- coverage/assets/0.10.1/smoothness/images/ui-bg_highlight-soft_75_cccccc_1x100.png
-- coverage/assets/0.10.1/smoothness/images/ui-icons_222222_256x240.png
-- coverage/assets/0.10.1/smoothness/images/ui-icons_2e83ff_256x240.png
-- coverage/assets/0.10.1/smoothness/images/ui-icons_454545_256x240.png
-- coverage/assets/0.10.1/smoothness/images/ui-icons_888888_256x240.png
-- coverage/assets/0.10.1/smoothness/images/ui-icons_cd0a0a_256x240.png
 - coverage/assets/0.10.2/application.css
 - coverage/assets/0.10.2/application.js
 - coverage/assets/0.10.2/colorbox/border.png
@@ -357,6 +333,7 @@ files:
 - doc/Contentful/ServiceUnavailable.html
 - doc/Contentful/Space.html
 - doc/Contentful/StringCoercion.html
+- doc/Contentful/StructuredTextCoercion.html
 - doc/Contentful/Support.html
 - doc/Contentful/SymbolCoercion.html
 - doc/Contentful/Sync.html
@@ -554,7 +531,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: contentful