RubyGems - contentful-management - Versions diffs - 2.2.0 → 2.2.1 - Mend

contentful-management 2.2.0 → 2.2.1

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (8) hide show

checksums.yaml +4 -4
data/CHANGELOG.md +4 -0
data/lib/contentful/management/entry.rb +4 -4
data/lib/contentful/management/resource_requester.rb +1 -1
data/lib/contentful/management/version.rb +1 -1
data/spec/fixtures/vcr_cassettes/entry/create_with_ct_entries_new.yml +279 -0
data/spec/lib/contentful/management/entry_spec.rb +16 -0
metadata +4 -2

checksums.yaml CHANGED

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d377237ac5fae9287e980db31e4968afa5b8ecd1628ffdc2adce1035332b57a8
-  data.tar.gz: 3a5116a7e471a60e25baa932e64efaef17a0c3b5866a8223c2d124dff4ef2b33
+  metadata.gz: b75e50ebfc4202efbbd7d47c99781cafa716bc3287ebfb4ab52f6a8bf010254f
+  data.tar.gz: 026f56b80f835f32709a190d73af227a1f2985aa763217266fc2a39065f16f1a
 SHA512:
-  metadata.gz: 91fce556a7f693dd2f8d08970eabfbc576cd40b21be13abfbb385ad42cba7fdab347b22f68dde00593753777516f6620592348b34a75b0838c76a2350f6712a0
-  data.tar.gz: cd4b54ccd6a43acecb2d021096b4dd5e1142e6fd3327d2c217b38ce3e0df7d1a796162321d6f81eeec3652485df3a989b54dc7fa80d7c0ea94b486d2a5a0f0ec
+  metadata.gz: 02c0a808c2c80a6e41912f66154c408bdfd46e82d8df9495e116bed6f09395e88b9677a35d19034ee719c5afffc490b4ab22d72f8c8a329246b6f4f845287635
+  data.tar.gz: 84ae44e1a8a0df806b1ae4e569249fdbc8e2844c45c00226db9cb246d110059c2ef7e0ce7c87347251a74834c73a038d090fc92b11a503dd2621f09a0cd55f33

data/CHANGELOG.md CHANGED

@@ -2,6 +2,10 @@
 ## Master
+## 2.2.1
+### Fixed
+* Fixed side-effect that was causing entries created using `content_type.entries.new` to fail to save.
 ## 2.2.0
 ### Added
 * Added `#save` as a shortcut for `editor_interface.update(controls: editor_interface.controls)`. [#155](https://github.com/contentful/contentful-management.rb/issues/155)

data/lib/contentful/management/entry.rb CHANGED

@@ -43,7 +43,7 @@ module Contentful
       # @private
       def self.create_attributes(client, attributes)
-        content_type = attributes[:content_type]
+        content_type = attributes.delete(:content_type)
         fields_for_create = if attributes[:fields] # create from initialized dynamic entry via save
                               tmp_entry = new
                               tmp_entry.instance_variable_set(:@fields, attributes.delete(:fields) || {})
@@ -117,11 +117,11 @@ module Contentful
         locale = attributes[:locale] || content_type.sys[:space].default_locale
         fields = content_type.properties[:fields]
         field_names = fields.map { |field| field.id.to_sym }
-        attributes.keep_if { |key| field_names.include?(key) }
+        attributes = attributes.keep_if { |key| field_names.include?(key) }
-        attributes.each do |id, value|
+        attributes.each_with_object({}) do |(id, value), result|
           field = fields.detect { |f| f.id.to_sym == id.to_sym }
-          attributes[id] = { locale => parse_attribute_with_field(value, field) }
+          result[id] = { locale => parse_attribute_with_field(value, field) }
         end
       end

data/lib/contentful/management/resource_requester.rb CHANGED

@@ -24,7 +24,7 @@ module Contentful
         request = Request.new(
           client,
           resource_class.build_endpoint(endpoint_options),
-          resource_class.create_attributes(client, attributes),
+          resource_class.create_attributes(client, attributes.clone),
           nil,
           resource_class.create_headers(client, attributes)
         )

data/lib/contentful/management/version.rb CHANGED

@@ -3,6 +3,6 @@ module Contentful
   # Management Namespace
   module Management
     # Gem Version
-    VERSION = '2.2.0'.freeze
+    VERSION = '2.2.1'.freeze
   end
 end

data/spec/fixtures/vcr_cassettes/entry/create_with_ct_entries_new.yml ADDED

@@ -0,0 +1,279 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://api.contentful.com/spaces/facgnwwgj5fe/environments/master/content_types/test
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      X-Contentful-User-Agent:
+      - sdk contentful-management.rb/2.2.0; platform ruby/2.5.1; os macOS/16;
+      Authorization:
+      - Bearer <ACCESS_TOKEN>
+      Content-Type:
+      - application/vnd.contentful.management.v1+json
+      Connection:
+      - close
+      Host:
+      - api.contentful.com
+      User-Agent:
+      - http.rb/2.2.2
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Access-Control-Allow-Headers:
+      - Accept,Accept-Language,Authorization,Cache-Control,Content-Length,Content-Range,Content-Type,DNT,Destination,Expires,If-Match,If-Modified-Since,If-None-Match,Keep-Alive,Last-Modified,Origin,Pragma,Range,User-Agent,X-Http-Method-Override,X-Mx-ReqToken,X-Requested-With,X-Contentful-Version,X-Contentful-Content-Type,X-Contentful-Organization,X-Contentful-Skip-Transformation,X-Contentful-User-Agent,X-Contentful-Enable-Alpha-Feature
+      Access-Control-Allow-Methods:
+      - DELETE,GET,HEAD,POST,PUT,OPTIONS
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Expose-Headers:
+      - Etag
+      Access-Control-Max-Age:
+      - '1728000'
+      Cf-Space-Id:
+      - facgnwwgj5fe
+      Content-Type:
+      - application/vnd.contentful.management.v1+json
+      Date:
+      - Tue, 12 Jun 2018 12:39:08 GMT
+      Etag:
+      - '"b995d565da7819ad9bbbc285771244bd"'
+      Server:
+      - Contentful
+      Strict-Transport-Security:
+      - max-age=15768000
+      X-Content-Type-Options:
+      - nosniff
+      X-Contentful-Ratelimit-Hour-Limit:
+      - '36000'
+      X-Contentful-Ratelimit-Hour-Remaining:
+      - '35942'
+      X-Contentful-Ratelimit-Reset:
+      - '0'
+      X-Contentful-Ratelimit-Second-Limit:
+      - '10'
+      X-Contentful-Ratelimit-Second-Remaining:
+      - '9'
+      X-Contentful-Request-Id:
+      - d8a435708c3e0b59ab6b1d9158be9a8c
+      Content-Length:
+      - '1292'
+      Connection:
+      - Close
+      Set-Cookie:
+      - incap_ses_467_673446=C1b/cN48GXgAV1hxkh97Buu+H1sAAAAASfcv4CC5DGzbGMuOjAoQhw==;
+        path=/; Domain=.contentful.com
+      - nlbi_673446=cB42ZHEIFFCa7U1o6lKYhQAAAAAY+2t4guO/ocI/jh56hVZK; path=/; Domain=.contentful.com
+      - visid_incap_673446=LcBv1jChSkKIvoQWmkVXGuu+H1sAAAAAQUIPAAAAAABvEGPqBWsfuhqkzEaaOOb/;
+        expires=Wed, 12 Jun 2019 12:00:33 GMT; path=/; Domain=.contentful.com
+      X-Iinfo:
+      - 2-32234290-32234303 NNNN CT(105 107 0) RT(1528807146445 60) q(0 0 2 -1) r(8
+        8) U5
+      X-Cdn:
+      - Incapsula
+    body:
+      encoding: ASCII-8BIT
+      string: |
+        {
+          "sys": {
+            "space": {
+              "sys": {
+                "type": "Link",
+                "linkType": "Space",
+                "id": "facgnwwgj5fe"
+              }
+            },
+            "id": "test",
+            "type": "ContentType",
+            "createdAt": "2017-03-02T18:32:49.570Z",
+            "updatedAt": "2017-03-02T18:32:50.586Z",
+            "environment": {
+              "sys": {
+                "id": "master",
+                "type": "Link",
+                "linkType": "Environment"
+              }
+            },
+            "createdBy": {
+              "sys": {
+                "type": "Link",
+                "linkType": "User",
+                "id": "4SejVrWT96dvL9IV4Nb7sQ"
+              }
+            },
+            "updatedBy": {
+              "sys": {
+                "type": "Link",
+                "linkType": "User",
+                "id": "4SejVrWT96dvL9IV4Nb7sQ"
+              }
+            },
+            "publishedCounter": 1,
+            "version": 2,
+            "publishedBy": {
+              "sys": {
+                "type": "Link",
+                "linkType": "User",
+                "id": "4SejVrWT96dvL9IV4Nb7sQ"
+              }
+            },
+            "publishedVersion": 1,
+            "firstPublishedAt": "2017-03-02T18:32:50.559Z",
+            "publishedAt": "2017-03-02T18:32:50.559Z"
+          },
+          "displayField": "name",
+          "name": "Test",
+          "description": "",
+          "fields": [
+            {
+              "id": "name",
+              "name": "name",
+              "type": "Symbol",
+              "localized": false,
+              "required": false,
+              "validations": [],
+              "disabled": false,
+              "omitted": false
+            }
+          ]
+        }
+    http_version:
+  recorded_at: Tue, 12 Jun 2018 12:39:08 GMT
+- request:
+    method: post
+    uri: https://api.contentful.com/spaces/facgnwwgj5fe/environments/master/entries
+    body:
+      encoding: UTF-8
+      string: '{"fields":{"name":{"en-US":"foobar"}}}'
+    headers:
+      X-Contentful-User-Agent:
+      - sdk contentful-management.rb/2.2.0; platform ruby/2.5.1; os macOS/16;
+      Authorization:
+      - Bearer <ACCESS_TOKEN>
+      Content-Type:
+      - application/vnd.contentful.management.v1+json
+      X-Contentful-Content-Type:
+      - test
+      Content-Type-Id:
+      - test
+      Connection:
+      - close
+      Host:
+      - api.contentful.com
+      User-Agent:
+      - http.rb/2.2.2
+  response:
+    status:
+      code: 201
+      message: Created
+    headers:
+      Access-Control-Allow-Headers:
+      - Accept,Accept-Language,Authorization,Cache-Control,Content-Length,Content-Range,Content-Type,DNT,Destination,Expires,If-Match,If-Modified-Since,If-None-Match,Keep-Alive,Last-Modified,Origin,Pragma,Range,User-Agent,X-Http-Method-Override,X-Mx-ReqToken,X-Requested-With,X-Contentful-Version,X-Contentful-Content-Type,X-Contentful-Organization,X-Contentful-Skip-Transformation,X-Contentful-User-Agent,X-Contentful-Enable-Alpha-Feature
+      Access-Control-Allow-Methods:
+      - DELETE,GET,HEAD,POST,PUT,OPTIONS
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Expose-Headers:
+      - Etag
+      Access-Control-Max-Age:
+      - '1728000'
+      Cf-Space-Id:
+      - facgnwwgj5fe
+      Content-Type:
+      - application/vnd.contentful.management.v1+json
+      Date:
+      - Tue, 12 Jun 2018 12:39:09 GMT
+      Etag:
+      - '"cbe73cdb8d7ece4ff67125c9cdd85cd0"'
+      Server:
+      - Contentful
+      Strict-Transport-Security:
+      - max-age=15768000
+      X-Content-Type-Options:
+      - nosniff
+      X-Contentful-Ratelimit-Hour-Limit:
+      - '36000'
+      X-Contentful-Ratelimit-Hour-Remaining:
+      - '35941'
+      X-Contentful-Ratelimit-Reset:
+      - '0'
+      X-Contentful-Ratelimit-Second-Limit:
+      - '10'
+      X-Contentful-Ratelimit-Second-Remaining:
+      - '9'
+      X-Contentful-Request-Id:
+      - 967c62f7ad9284b1b7c3c7f7648315f1
+      Content-Length:
+      - '917'
+      Connection:
+      - Close
+      Set-Cookie:
+      - incap_ses_467_673446=vFoZJEqLu1vAWlhxkh97Bu2+H1sAAAAAf9ScH7sPhALnoIORNSun3g==;
+        path=/; Domain=.contentful.com
+      - nlbi_673446=wEfNOUIdSXB0V1Pv6lKYhQAAAABeL4r3wGhe0A09T8AfE2hJ; path=/; Domain=.contentful.com
+      - visid_incap_673446=lIyDH8l2Rd6wPg0iUMfUYe2+H1sAAAAAQUIPAAAAAABPveL4akLQXa/OfV4860wc;
+        expires=Wed, 12 Jun 2019 12:00:33 GMT; path=/; Domain=.contentful.com
+      X-Iinfo:
+      - 2-32234372-32234374 NNNN CT(104 104 0) RT(1528807147413 67) q(0 0 2 -1) r(20
+        20) U5
+      X-Cdn:
+      - Incapsula
+    body:
+      encoding: ASCII-8BIT
+      string: |
+        {
+          "sys": {
+            "space": {
+              "sys": {
+                "type": "Link",
+                "linkType": "Space",
+                "id": "facgnwwgj5fe"
+              }
+            },
+            "id": "3Q8FXPXXzOs8MCYYquQgcs",
+            "type": "Entry",
+            "createdAt": "2018-06-12T12:39:09.268Z",
+            "updatedAt": "2018-06-12T12:39:09.268Z",
+            "environment": {
+              "sys": {
+                "id": "master",
+                "type": "Link",
+                "linkType": "Environment"
+              }
+            },
+            "createdBy": {
+              "sys": {
+                "type": "Link",
+                "linkType": "User",
+                "id": "4SejVrWT96dvL9IV4Nb7sQ"
+              }
+            },
+            "updatedBy": {
+              "sys": {
+                "type": "Link",
+                "linkType": "User",
+                "id": "4SejVrWT96dvL9IV4Nb7sQ"
+              }
+            },
+            "version": 1,
+            "contentType": {
+              "sys": {
+                "type": "Link",
+                "linkType": "ContentType",
+                "id": "test"
+              }
+            }
+          },
+          "fields": {
+            "name": {
+              "en-US": "foobar"
+            }
+          }
+        }
+    http_version:
+  recorded_at: Tue, 12 Jun 2018 12:39:10 GMT
+recorded_with: VCR 4.0.0

data/spec/lib/contentful/management/entry_spec.rb CHANGED

@@ -920,6 +920,22 @@ describe Contentful::Management::Entry do
       end
     end
+    describe 'it can properly create entries from a content type using #new' do
+      let(:space_id) { 'facgnwwgj5fe' }
+      let(:environment_id) { 'master' }
+      let(:content_type_id) { 'test' }
+      it 'creates an entry' do
+        vcr('entry/create_with_ct_entries_new') {
+          new_entry = client.content_types(space_id, environment_id).find(content_type_id).entries.new
+          new_entry.name_with_locales = { 'en-US' => 'foobar' }
+          expect { new_entry.save }.not_to raise_error
+          expect(new_entry.name).to eq 'foobar'
+        }
+      end
+    end
     describe 'it can properly assign, save and publish - #61' do
       describe 'on an entry created through the api' do
         describe 'before refetch' do

metadata CHANGED

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: contentful-management
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.2.1
 platform: ruby
 authors:
 - Piotr Protas
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-06-05 00:00:00.000000000 Z
+date: 2018-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: http
@@ -528,6 +528,7 @@ files:
 - spec/fixtures/vcr_cassettes/entry/create.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_asset.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_assets.yml
+- spec/fixtures/vcr_cassettes/entry/create_with_ct_entries_new.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_custom_id.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_entries.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_entry.yml
@@ -908,6 +909,7 @@ test_files:
 - spec/fixtures/vcr_cassettes/entry/create.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_asset.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_assets.yml
+- spec/fixtures/vcr_cassettes/entry/create_with_ct_entries_new.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_custom_id.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_entries.yml
 - spec/fixtures/vcr_cassettes/entry/create_with_entry.yml