contactually-api 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52c58a5aa6d6ecc6d612f0ae0366a5bce859ccf0
-  data.tar.gz: 7c71f707ba29bb435b89f90601ac38345be21d19
+  metadata.gz: 5b229529b6cd9e6c9e1194c9b8f9dfd815716f59
+  data.tar.gz: 207a10352a62b760a13060c3d02f629adb65f9d6
 SHA512:
-  metadata.gz: 879d68b4a16df5ded12212deb10abe89e79f27b11e0f1c219ff8b8625b631d064c7522ab3584c1cbf3cb95abc83f4b265a876eaffbadeb80be5c81b61689c593
-  data.tar.gz: cf5a164d0ba56c6605150e21a00c64afdeea94d116c6de467e4b4636d7fb8da8d6238833176534598d3f113ca80948ae1791de2555711f003b976da65f2f11b6
+  metadata.gz: 7ea7125518a774970476ef75ae2bf4e94592cc8bb74c44bbdb98f2b885effd0e79850c3d261da2de334a899a77346326f3f1c900832ec8c6635d35086b77610b
+  data.tar.gz: 778405c57ad558e5c634b9608a429cdab695ad7f402ed07eb770dca04a4999f594fd80458de11f03f89d2a226be787be830aa427271a9f3417db2c15196339b4

data/lib/contactually/api.rb

@@ -19,6 +19,10 @@ module Contactually
       @notes ||= Contactually::Notes.new self
     end
 
+    def tasks
+      @tasks ||= Contactually::Tasks.new self
+    end
+
     def groupings
       @groupings ||= Contactually::Groupings.new self
     end
@@ -31,10 +35,14 @@ module Contactually
       @contact_groupings ||= Contactually::ContactGroupings.new self
     end
 
+    def contents
+      @contents ||= Contactually::Contents.new self
+    end
+
     def connection
       @connection ||= Faraday.new do |faraday|
-        faraday.adapter Faraday.default_adapter
         faraday.headers['Content-Type'] = 'application/json'
+        faraday.adapter Faraday.default_adapter
         faraday.use Contactually::Middleware::ErrorDetector
       end
     end

data/lib/contactually/errors.rb

@@ -12,6 +12,9 @@ module Contactually
   class DuplicatedContactError < Error
   end
 
+  class AuthenticationError < Error
+  end
+
   class APIError < Error
   end
 

data/lib/contactually/middleware/error_detector.rb

@@ -3,7 +3,7 @@ module Contactually
     class ErrorDetector < Faraday::Middleware
 
       def call(env)
-        @app.call(env).on_complete do
+        @app.call(env).on_complete do |env|
           unless (200..299).include? env[:status]
             cast_error(env[:body])
           end
@@ -18,9 +18,13 @@ module Contactually
           raise InvalidParametersError, body
         when /^We already have/ then
           raise DuplicatedContactError, body
+        when /^You need to sign in/ then
+          raise AuthenticationError, body
         else
           raise APIError, body
         end
+      rescue JSON::ParserError
+        raise APIError, body
       end
     end
   end

data/lib/contactually/version.rb

@@ -1,3 +1,3 @@
 module Contactually
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/accounts_spec.rb

@@ -2,6 +2,9 @@ require 'spec_helper'
 
 describe Contactually::Accounts do
 
+  let(:account_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/account.json")) }
+  let(:accounts_index_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/accounts_index.json")) }
+
   before(:all) do
     Contactually.configure { |c| c.api_key = 'VALID_API_KEY' }
     @master = Contactually::API.new
@@ -26,8 +29,7 @@ describe Contactually::Accounts do
     end
 
     it 'returns accounts from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/accounts_index.json"))
-      allow(@master).to receive(:call).with('accounts.json', :get, {}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('accounts.json', :get, {}).and_return(JSON.load(accounts_index_json))
       expect(subject.index({})).to be_kind_of Array
       expect(subject.index({})[0]).to be_kind_of Contactually::Account
     end
@@ -41,8 +43,7 @@ describe Contactually::Accounts do
     end
 
     it 'returns an account' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/account.json"))
-      allow(@master).to receive(:call).with('accounts/1.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('accounts/1.json', :get, { foo: :bar }).and_return(JSON.load(account_json))
       expect(subject.show(1, { foo: :bar })).to be_kind_of Contactually::Account
     end
   end

data/spec/api_spec.rb

@@ -50,15 +50,27 @@ describe Contactually::API do
       end
     end
 
+    describe '#accounts' do
+      specify do
+        expect(subject.accounts).to be_kind_of Contactually::Accounts
+      end
+    end
+
+    describe '#contact_groupings' do
+      specify do
+        expect(subject.contact_groupings).to be_kind_of Contactually::ContactGroupings
+      end
+    end
+
     describe '#contacts' do
       specify do
         expect(subject.contacts).to be_kind_of Contactually::Contacts
       end
     end
 
-    describe '#notes' do
+    describe '#contents' do
       specify do
-        expect(subject.notes).to be_kind_of Contactually::Notes
+        expect(subject.contents).to be_kind_of Contactually::Contents
       end
     end
 
@@ -68,6 +80,24 @@ describe Contactually::API do
       end
     end
 
+    describe '#notes' do
+      specify do
+        expect(subject.notes).to be_kind_of Contactually::Notes
+      end
+    end
+
+    describe '#tasks' do
+      specify do
+        expect(subject.tasks).to be_kind_of Contactually::Tasks
+      end
+    end
+
+    describe 'endpoints' do
+      %w{ accounts contact_groupings contacts contents groupings notes tasks }.each do |endpoint|
+        specify { expect(subject.respond_to?(endpoint)).to eq true }
+      end
+    end
+
     describe '#get' do
       it 'parses from json response' do
         allow(subject.connection).to receive(:get).

data/spec/contact_groupings_spec.rb

@@ -2,6 +2,8 @@ require 'spec_helper'
 
 describe Contactually::ContactGroupings do
 
+  let(:grouping_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/grouping.json")) }
+
   before(:all) do
     Contactually.configure { |c| c.api_key = 'VALID_API_KEY' }
     @master = Contactually::API.new
@@ -27,8 +29,7 @@ describe Contactually::ContactGroupings do
     end
 
     it 'returns grouping from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/grouping.json"))
-      allow(@master).to receive(:call).with('contacts/1/groupings.json', :post, { grouping_id: 512 }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contacts/1/groupings.json', :post, { grouping_id: 512 }).and_return(JSON.load(grouping_json))
       expect(subject.create(1, { grouping_id: 512 })).to be_kind_of Contactually::Grouping
     end
   end

data/spec/contacts_spec.rb

@@ -2,6 +2,9 @@ require 'spec_helper'
 
 describe Contactually::Contacts do
 
+  let(:contact_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/contact.json")) }
+  let(:contacts_index_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/contacts_index.json")) }
+
   before(:all) do
     Contactually.configure { |c| c.api_key = 'VALID_API_KEY' }
     @master = Contactually::API.new
@@ -20,15 +23,13 @@ describe Contactually::Contacts do
 
   describe '#create' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/contact.json"))
-      allow(@master).to receive(:call).with('contacts.json', :post, { contact: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contacts.json', :post, { contact: { foo: :bar }}).and_return(JSON.load(contact_json))
       subject.create({ contact: { foo: :bar }})
       expect(@master).to have_received(:call)
     end
 
     it 'returns a contact' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/contact.json"))
-      allow(@master).to receive(:call).with('contacts.json', :post, { contact: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contacts.json', :post, { contact: { foo: :bar }}).and_return(JSON.load(contact_json))
       expect(subject.create({ contact: { foo: :bar } })).to be_kind_of Contactually::Contact
     end
   end
@@ -57,8 +58,7 @@ describe Contactually::Contacts do
     end
 
     it 'returns a contact' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/contact.json"))
-      allow(@master).to receive(:call).with('contacts/1.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contacts/1.json', :get, { foo: :bar }).and_return(JSON.load(contact_json))
       expect(subject.show(1, { foo: :bar })).to be_kind_of Contactually::Contact
     end
   end
@@ -93,8 +93,7 @@ describe Contactually::Contacts do
     end
 
     it 'returns contacts from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/contacts_index.json"))
-      allow(@master).to receive(:call).with('contacts.json', :get, {}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contacts.json', :get, {}).and_return(JSON.load(contacts_index_json))
       expect(subject.index({})).to be_kind_of Array
       expect(subject.index({})[0]).to be_kind_of Contactually::Contact
     end
@@ -108,8 +107,7 @@ describe Contactually::Contacts do
     end
 
     it 'returns contacts from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/contacts_index.json"))
-      allow(@master).to receive(:call).with('contacts/search.json', :get, { term: :foo_bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contacts/search.json', :get, { term: :foo_bar }).and_return(JSON.load(contacts_index_json))
       expect(subject.search({ term: :foo_bar })).to be_kind_of Array
       expect(subject.search({ term: :foo_bar })[0]).to be_kind_of Contactually::Contact
     end

data/spec/contents_spec.rb

@@ -2,6 +2,9 @@ require 'spec_helper'
 
 describe Contactually::Contents do
 
+  let(:content_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/content.json")) }
+  let(:contents_index_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/contents_index.json")) }
+
   before(:all) do
     Contactually.configure { |c| c.api_key = 'VALID_API_KEY' }
     @master = Contactually::API.new
@@ -20,15 +23,13 @@ describe Contactually::Contents do
 
   describe '#create' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/content.json"))
-      allow(@master).to receive(:call).with('contents.json', :post, { content: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contents.json', :post, { content: { foo: :bar }}).and_return(JSON.load(content_json))
       subject.create({ content: { foo: :bar }})
       expect(@master).to have_received(:call)
     end
 
     it 'returns a content' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/content.json"))
-      allow(@master).to receive(:call).with('contents.json', :post, { content: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contents.json', :post, { content: { foo: :bar }}).and_return(JSON.load(content_json))
       expect(subject.create({ content: { foo: :bar }})).to be_kind_of Contactually::Content
     end
   end
@@ -41,8 +42,7 @@ describe Contactually::Contents do
     end
 
     it 'returns contents from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/contents_index.json"))
-      allow(@master).to receive(:call).with('contents.json', :get, {}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contents.json', :get, {}).and_return(JSON.load(contents_index_json))
       expect(subject.index({})).to be_kind_of Array
       expect(subject.index({})[0]).to be_kind_of Contactually::Content
     end
@@ -64,8 +64,7 @@ describe Contactually::Contents do
     end
 
     it 'returns a contact' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/content.json"))
-      allow(@master).to receive(:call).with('contents/1.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('contents/1.json', :get, { foo: :bar }).and_return(JSON.load(content_json))
       expect(subject.show(1, { foo: :bar })).to be_kind_of Contactually::Content
     end
   end

data/spec/error_detector_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+describe Contactually::Middleware::ErrorDetector do
+
+  describe '#cast_error' do
+
+    it 'detects invalid parameter errors' do
+      body = { error: 'Invalid parameters' }.to_json
+      expect{ subject.send(:cast_error, body) }.to raise_error Contactually::InvalidParametersError
+    end
+
+    it 'detects duplication errors' do
+      body = { error: 'We already have' }.to_json
+      expect{ subject.send(:cast_error, body) }.to raise_error Contactually::DuplicatedContactError
+    end
+
+    it 'rescues json parse errors' do
+      body = ";foobar;"
+      expect{ subject.send(:cast_error, body) }.to raise_error Contactually::APIError
+    end 
+
+  end
+
+end

data/spec/groupings_spec.rb

@@ -2,6 +2,10 @@ require 'spec_helper'
 
 describe Contactually::Groupings do
 
+  let(:groupings_index_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/groupings_index.json")) }
+  let(:grouping_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/grouping.json")) }
+  let(:groupings_statistics_json) { File.read(File.join(File.dirname(__FILE__), "fixtures/groupings_statistics.json")) }
+
   before(:all) do
     Contactually.configure { |c| c.api_key = 'VALID_API_KEY' }
     @master = Contactually::API.new
@@ -27,8 +31,7 @@ describe Contactually::Groupings do
     end
 
     it 'returns groupings from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/groupings_index.json"))
-      allow(@master).to receive(:call).with('groupings.json', :get, {}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('groupings.json', :get, {}).and_return(JSON.load(groupings_index_json))
       expect(subject.index({})).to be_kind_of Array
       expect(subject.index({})[0]).to be_kind_of Contactually::Grouping
     end
@@ -42,8 +45,7 @@ describe Contactually::Groupings do
     end
 
     it 'returns groupings from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/grouping.json"))
-      allow(@master).to receive(:call).with('groupings.json', :post, { grouping: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('groupings.json', :post, { grouping: { foo: :bar }}).and_return(JSON.load(grouping_json))
       expect(subject.create({ grouping: { foo: :bar }})).to be_kind_of Contactually::Grouping
     end
   end
@@ -64,8 +66,7 @@ describe Contactually::Groupings do
     end
 
     it 'returns a grouping from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/grouping.json"))
-      allow(@master).to receive(:call).with('groupings/1.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('groupings/1.json', :get, { foo: :bar }).and_return(JSON.load(grouping_json))
       expect(subject.show(1, { foo: :bar })).to be_kind_of Contactually::Grouping
     end
   end
@@ -78,8 +79,7 @@ describe Contactually::Groupings do
     end
 
     it 'returns a grouping from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/grouping.json"))
-      allow(@master).to receive(:call).with('groupings/1.json', :put, { grouping: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('groupings/1.json', :put, { grouping: { foo: :bar }}).and_return(JSON.load(grouping_json))
       expect(subject.update(1, { grouping: { foo: :bar }})).to be_kind_of Contactually::Grouping
     end
   end
@@ -92,8 +92,7 @@ describe Contactually::Groupings do
     end
 
     it 'returns statistics object' do
-      json = File.read(File.join(File.dirname(__FILE__), "fixtures/groupings_statistics.json"))
-      allow(@master).to receive(:call).with('groupings/1/statistics.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('groupings/1/statistics.json', :get, { foo: :bar }).and_return(JSON.load(groupings_statistics_json))
       expect(subject.statistics(1, { foo: :bar })).to be_kind_of Contactually::GroupingStatistic
     end
   end

data/spec/notes_spec.rb

@@ -2,6 +2,9 @@ require 'spec_helper'
 
 describe Contactually::Notes do
 
+  let(:notes_index_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/notes_index.json")) }
+  let(:note_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/note.json")) }
+
   before(:all) do
     Contactually.configure { |c| c.api_key = 'VALID_API_KEY' }
     @master = Contactually::API.new
@@ -27,8 +30,7 @@ describe Contactually::Notes do
     end
 
     it 'returns notes from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/notes_index.json"))
-      allow(@master).to receive(:call).with('notes.json', :get, {}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('notes.json', :get, {}).and_return(JSON.load(notes_index_json))
       expect(subject.index({})).to be_kind_of Array
       expect(subject.index({})[0]).to be_kind_of Contactually::Note
     end
@@ -36,45 +38,39 @@ describe Contactually::Notes do
 
   describe '#show' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/note.json"))
-      allow(@master).to receive(:call).with('notes/1.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('notes/1.json', :get, { foo: :bar }).and_return(JSON.load(note_json))
       subject.show(1, { foo: :bar })
       expect(@master).to have_received(:call)
     end
 
     it 'returns a note' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/note.json"))
-      allow(@master).to receive(:call).with('notes/1.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('notes/1.json', :get, { foo: :bar }).and_return(JSON.load(note_json))
       expect(subject.show(1, { foo: :bar })).to be_kind_of Contactually::Note
     end
   end
 
   describe '#create' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/note.json"))
-      allow(@master).to receive(:call).with('notes.json', :post, { note: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('notes.json', :post, { note: { foo: :bar }}).and_return(JSON.load(note_json))
       subject.create({ note: { foo: :bar }})
       expect(@master).to have_received(:call)
     end
 
     it 'returns a note' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/note.json"))
-      allow(@master).to receive(:call).with('notes.json', :post, { note: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('notes.json', :post, { note: { foo: :bar }}).and_return(JSON.load(note_json))
       expect(subject.create({ note: { foo: :bar }})).to be_kind_of Contactually::Note
     end
   end
 
   describe '#update' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/note.json"))
-      allow(@master).to receive(:call).with('notes/1.json', :put, { note: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('notes/1.json', :put, { note: { foo: :bar }}).and_return(JSON.load(note_json))
       subject.update(1, { note: { foo: :bar }})
       expect(@master).to have_received(:call)
     end
 
     it 'returns a note' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/note.json"))
-      allow(@master).to receive(:call).with('notes/1.json', :put, { note: { foo: :bar }}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('notes/1.json', :put, { note: { foo: :bar }}).and_return(JSON.load(note_json))
       expect(subject.update(1, { note: { foo: :bar }})).to be_kind_of Contactually::Note
     end
   end

data/spec/tasks_spec.rb

@@ -2,6 +2,9 @@ require 'spec_helper'
 
 describe Contactually::Tasks do
 
+  let(:task_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/task.json")) }
+  let(:tasks_index_json) { File.read(File.join(File.dirname(__FILE__),"fixtures/tasks_index.json")) }
+
   before(:all) do
     Contactually.configure { |c| c.api_key = 'VALID_API_KEY' }
     @master = Contactually::API.new
@@ -20,60 +23,52 @@ describe Contactually::Tasks do
 
   describe '#show' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks/1.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks/1.json', :get, { foo: :bar }).and_return(JSON.load(task_json))
       subject.show(1, { foo: :bar })
       expect(@master).to have_received(:call)
     end
 
     it 'returns a task' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks/1.json', :get, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks/1.json', :get, { foo: :bar }).and_return(JSON.load(task_json))
       expect(subject.show(1, { foo: :bar })).to be_kind_of Contactually::Task
     end
   end
 
   describe '#complete' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks/1/complete.json', :post, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks/1/complete.json', :post, { foo: :bar }).and_return(JSON.load(task_json))
       subject.complete(1, { foo: :bar })
       expect(@master).to have_received(:call)
     end
 
     it 'returns a task' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks/1/complete.json', :post, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks/1/complete.json', :post, { foo: :bar }).and_return(JSON.load(task_json))
       expect(subject.complete(1, { foo: :bar })).to be_kind_of Contactually::Task
     end
   end
 
   describe '#create' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks.json', :post, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks.json', :post, { foo: :bar }).and_return(JSON.load(task_json))
       subject.create({ foo: :bar })
       expect(@master).to have_received(:call)
     end
 
     it 'returns a new task' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks.json', :post, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks.json', :post, { foo: :bar }).and_return(JSON.load(task_json))
       expect(subject.create({ foo: :bar })).to be_kind_of Contactually::Task
     end
   end
 
   describe '#update' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks/1.json', :put, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks/1.json', :put, { foo: :bar }).and_return(JSON.load(task_json))
       subject.update(1, { foo: :bar })
       expect(@master).to have_received(:call)
     end
 
     it 'returns a new task' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks/1.json', :put, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks/1.json', :put, { foo: :bar }).and_return(JSON.load(task_json))
       expect(subject.update(1, { foo: :bar })).to be_kind_of Contactually::Task
     end
   end
@@ -104,15 +99,13 @@ describe Contactually::Tasks do
 
   describe '#ignore' do
     it 'calls the api with correct params' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks/1/ignore.json', :post, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks/1/ignore.json', :post, { foo: :bar }).and_return(JSON.load(task_json))
       subject.ignore(1, { foo: :bar })
       expect(@master).to have_received(:call)
     end
 
     it 'returns a new task' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/task.json"))
-      allow(@master).to receive(:call).with('tasks/1/ignore.json', :post, { foo: :bar }).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks/1/ignore.json', :post, { foo: :bar }).and_return(JSON.load(task_json))
       expect(subject.ignore(1, { foo: :bar })).to be_kind_of Contactually::Task
     end
   end
@@ -125,8 +118,7 @@ describe Contactually::Tasks do
     end
 
     it 'returns tasks from json response' do
-      json = File.read(File.join(File.dirname(__FILE__),"fixtures/tasks_index.json"))
-      allow(@master).to receive(:call).with('tasks.json', :get, {}).and_return(JSON.load(json))
+      allow(@master).to receive(:call).with('tasks.json', :get, {}).and_return(JSON.load(tasks_index_json))
       expect(subject.index({})).to be_kind_of Array
       expect(subject.index({})[0]).to be_kind_of Contactually::Task
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: contactually-api
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Johannes Heck
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-17 00:00:00.000000000 Z
+date: 2014-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -129,6 +129,7 @@ files:
 - spec/contact_groupings_spec.rb
 - spec/contacts_spec.rb
 - spec/contents_spec.rb
+- spec/error_detector_spec.rb
 - spec/fixtures/account.json
 - spec/fixtures/accounts_index.json
 - spec/fixtures/contact.json
@@ -177,6 +178,7 @@ test_files:
 - spec/contact_groupings_spec.rb
 - spec/contacts_spec.rb
 - spec/contents_spec.rb
+- spec/error_detector_spec.rb
 - spec/fixtures/account.json
 - spec/fixtures/accounts_index.json
 - spec/fixtures/contact.json