contact_congress_parser 0.0.7 → 0.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d01ba03b717555b89223cc3068d3aecc8d01255
-  data.tar.gz: 373699f8700199e8dac8dfd5deca599e96ef8b3c
+  metadata.gz: b0f8d3f863eccc838fda533ac01475652568e7eb
+  data.tar.gz: a69134a888c381218e7edad074ee4e5a2cb428a9
 SHA512:
-  metadata.gz: a22c2c8de5d31837a794ba24b710cbc89d489f997ee41b632f31b9ed31b7c002a22631ac7b29aac73fdaeadb4dcfe2e0aaae80d11d3a76aacc80bc347ed26696
-  data.tar.gz: e43876bd5f73eb4af227ad6407765ec16765b4152d04c8e12a7783b4bf98912360997197c69592ada9df98f966b05ea5587f70182eb03498da2fe6f7619f648e
+  metadata.gz: c857664dcbe3b7c3f6cc0988812d48b02c7a21288fb431448762985cc606cb28520a2d657994443a48b560b2182d65c65543be702a5c02cabda3e8b015cf7c68
+  data.tar.gz: 7547db2184ee54fbd4025a9d11203e9341e1e62835f5366eee412a962bd8ff1e627983f177a8c9d18979544c3d4ad44705edc8aa9af942ec179f9901f1f8f051

data/lib/contact_congress_parser.rb

@@ -4,12 +4,18 @@ require 'yaml'
 require 'uri'
 
 require 'contact_congress_parser/parser'
+require 'contact_congress_parser/form'
 require 'contact_congress_parser/action'
 require 'contact_congress_parser/field'
+require 'contact_congress_parser/success_conditions'
 
 
 module ContactCongressParser
-  def self.parse(read_io, write_io)
-    Parser.parse(read_io, write_io)
+  def self.parse_form(yaml_str)
+    Parser.new(yaml_str).form
+  end
+
+  def self.parse_bioguide(yaml_str)
+    Parser.new(yaml_str).bioguide
   end
 end

data/lib/contact_congress_parser/form.rb

@@ -0,0 +1,50 @@
+module ContactCongressParser
+  class Form
+    def initialize(data)
+      @data = data
+    end
+
+    def to_s
+      create_form do
+        actions.map { |action| tab + action.to_s }.join(newline) +
+        newline +
+        success_conditions.to_s
+      end
+    end
+
+  private
+    def create_form(&block)
+      "Conformity::Form.new('#{domain}') do" +
+      yield +
+      'end'
+    end
+
+    def domain
+      @domain ||= URI.parse(steps.first['visit']).host
+    end
+
+    def actions
+      @actions ||= steps.map { |step| Action.create_from_step(step) }.flatten
+    end
+
+    def success_conditions
+      @success_conditions ||= SuccessConditions.new(success_data)
+    end
+
+    def steps
+      @steps ||= @data['contact_form']['steps']
+    end
+
+    def success_data
+      @success ||= @data['contact_form']['success']
+    end
+
+    def newline
+      "\n"
+    end
+
+    def tab
+      '  '
+    end
+  end
+end

data/lib/contact_congress_parser/parser.rb

@@ -1,42 +1,17 @@
 module ContactCongressParser
   class Parser
-    attr_reader :write_io
+    attr_reader :data
 
-    def self.parse(read_io, write_io)
-      self.new(read_io, write_io).parse
+    def initialize(yaml_str)
+      @data = YAML.load(yaml_str)
     end
 
-    def initialize(read_io, write_io)
-      @yaml = YAML.load(read_io.read)
-      @write_io = write_io
+    def bioguide
+      @data['bioguide']
     end
 
-    def actions
-      @actions ||= steps.map { |step| Action.create_from_step(step) }.flatten
-    end
-
-    def parse
-      create_form do
-        actions.each { |action| write_io.puts tab + action.to_s }
-      end
-    end
-
-    def create_form(&block)
-      write_io.puts("Conformity::Form.new('#{domain}') do")
-      yield
-      write_io.puts("end")
-    end
-
-    def domain
-      @domain ||= URI.parse(steps.first['visit']).host
-    end
-
-    def steps
-      @steps ||= @yaml['contact_form']['steps']
-    end
-
-    def tab
-      '  '
+    def form
+      Form.new(data).to_s
     end
   end
 end

data/lib/contact_congress_parser/success_conditions.rb

@@ -0,0 +1,31 @@
+module ContactCongressParser
+  class SuccessConditions
+    def initialize(data)
+      @data = data
+    end
+
+    def to_s
+      (has_content_str     ? '  ' + has_content_str + "\n" : '') +
+      (has_status_code_str ? '  ' + has_status_code_str + "\n" : '')
+    end
+
+  private
+    attr_reader :data
+
+    def has_content_str
+      "has_content? \"#{content}\"" if content
+    end
+
+    def has_status_code_str
+      "has_status_code? #{status_code}" if status_code
+    end
+
+    def content
+      data.fetch('body', {}).fetch('contains', nil)
+    end
+
+    def status_code
+      data.fetch('headers', {}).fetch('status', nil)
+    end
+  end
+end

data/lib/contact_congress_parser/version.rb

@@ -1,3 +1,3 @@
 module ContactCongressParser
-  VERSION = "0.0.7"
+  VERSION = "0.0.8"
 end

data/spec/form_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+
+clone_from = 'https://github.com/nhjk/contact-congress.git'
+clone_to = 'contact-congress'
+
+
+include ContactCongressParser
+describe Form do
+  before :context do
+    Git.clone(clone_from, clone_to)
+    @member_files = Dir.glob("#{clone_to}/members/*.yaml")
+    raise "Error retrieving member_files" if @member_files.empty?
+  end
+
+  it 'outputs forms parsable by conformity' do
+    @member_files.each do |member_file|
+      data = YAML.load(File.read(member_file))
+      form = Form.new(data)
+
+      expect { Conformity.send(:eval, form.to_s) }.to_not raise_error
+    end
+  end
+
+  after :context do
+    `rm -rf #{clone_to}`
+  end
+end

data/spec/parser_spec.rb

@@ -1,28 +1,18 @@
 require_relative 'spec_helper'
-require 'git'
 
 
-clone_from = 'https://github.com/nhjk/contact-congress.git'
-clone_to = 'contact-congress'
+describe Parser do
+  it 'parses the bioguide properly' do
+    member_yaml = <<-YAML
+      bioguide: A999999
+      contact_form:
+        method: POST
+        action: ""
+        steps: ""
+        success: ""
+    YAML
 
-describe ContactCongressParser do
-  before :context do
-    Git.clone(clone_from, clone_to)
-    @member_files = Dir.glob("#{clone_to}/members/*.yaml")
-    raise "Error retrieving member_files" if @member_files.empty?
-  end
-
-  it 'parses member yaml files into forms runnable by conformity' do
-    @member_files.each do |member_file|
-      member_io = File.open(member_file)
-      s_io = StringIO.new
-      ContactCongressParser.parse(member_io, s_io)
-      expect { Conformity.send(:eval, s_io.string) }.to_not raise_error
-    end
-  end
-
-  after :context do
-    `rm -rf #{clone_to}`
+    parser = Parser.new(member_yaml)
+    expect(parser.bioguide).to match("A999999")
   end
 end
-

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 
 require 'yaml'
+require 'git'
 require 'conformity'
 require 'contact_congress_parser'
 

data/spec/success_conditions_spec.rb

@@ -0,0 +1,18 @@
+require 'spec_helper'
+
+
+include ContactCongressParser
+describe SuccessConditions do
+  it 'parses success conditions correctly' do
+    data = {"headers"=>{"status"=>200}, "body"=>{"contains"=>"Thank You"}}
+    sc = SuccessConditions.new(data)
+    expect(sc.to_s).to match("  has_content? \"Thank You\"\n" +
+                             "  has_status_code? 200\n")
+  end
+  
+  it 'handles missing data without raising errors' do
+    data1 = {"success"=>{}}
+    data2 = {"success"=>{"headers"=>{"status"=>200}}}
+    data3 = {"success"=>{"body"=>{"contains"=>"Thank You"}}}
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: contact_congress_parser
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Nikias Kalpaxis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-07 00:00:00.000000000 Z
+date: 2014-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -54,12 +54,16 @@ files:
 - lib/contact_congress_parser.rb
 - lib/contact_congress_parser/action.rb
 - lib/contact_congress_parser/field.rb
+- lib/contact_congress_parser/form.rb
 - lib/contact_congress_parser/parser.rb
+- lib/contact_congress_parser/success_conditions.rb
 - lib/contact_congress_parser/version.rb
 - spec/action_spec.rb
 - spec/field_spec.rb
+- spec/form_spec.rb
 - spec/parser_spec.rb
 - spec/spec_helper.rb
+- spec/success_conditions_spec.rb
 homepage: https://github.com/nhjk/contact_congress_parser
 licenses:
 - MIT
@@ -87,5 +91,7 @@ summary: Parser for https://github.com/unitedstates/contact-congress member file
 test_files:
 - spec/action_spec.rb
 - spec/field_spec.rb
+- spec/form_spec.rb
 - spec/parser_spec.rb
 - spec/spec_helper.rb
+- spec/success_conditions_spec.rb