contact-data 0.0.20 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db881d9279bf05f8e29a5061727511ea7d16b562
-  data.tar.gz: f01b935abf8f2168eaa3d49a7faf9e4e510b2015
+  metadata.gz: e047c67be460d782f2b82819f4e83c9e0b4a0559
+  data.tar.gz: 27e01e968cd31a67276825899a8b60629cd9c1f6
 SHA512:
-  metadata.gz: 8cca2ca481dd431965bf8fbd2f404fbd8147dbbeb8d5f453b809abe9ec31c8edf76536d086be780191818e6fcf2462c3ba4d8483a38ef13f3a13da71efb471c6
-  data.tar.gz: 6a92b1b36a1e09bf2a28bc277a80a60209da113366795563e2b6430263e0aeec1272e6808134008c988dcbbeb07281ffb2af13dd8d7529092becd04972e04704
+  metadata.gz: a735e12d551c72399df8b724b7fd9223fbde49f61f88e05624b8102eb2bb7d449a9fd85fcd4d9c58fbbd9e2190bd087ece2a8b9f42b016bd9c651fa08fc93db7
+  data.tar.gz: ac9b74436b8e38a97a9908a54456e1c374ae8f8a397e3bfc62116d86616d8252ed2cbda49e0e876a6b7168deb54feb70da3b16d94416603442d9b0474dc74744

data/Gemfile.lock

@@ -1,7 +1,8 @@
 PATH
   remote: .
   specs:
-    contact-data (0.0.19)
+    contact-data (0.0.20)
+      addressable (~> 2.3)
       rest-client (~> 1)
 
 GEM

data/contact-data.gemspec

@@ -18,6 +18,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'rest-client', '~> 1'
+  spec.add_runtime_dependency 'addressable', '~> 2.3'
 
   spec.add_development_dependency 'bundler', '~> 1'
   spec.add_development_dependency 'rake', '~> 10'

data/lib/contact-data/deprecated.rb

@@ -3,7 +3,7 @@ module ContactData
   class Deprecated
     class << self
       def search(name)
-        Fetcher.get("name/#{CGI.escape(name)}")
+        Fetcher.get("name/#{Fetcher.encode_component name}")
       end
 
       def find_contacts_in(text)

data/lib/contact-data/fetcher.rb

@@ -19,11 +19,15 @@ module ContactData
         end
       end
 
+      def encode_component(string)
+        Addressable::URI.encode_component(string, Addressable::URI::CharacterClasses::PATH)
+      end
+
       private
 
       def get_url_from(api_method, options = {})
         if api_method.is_a?(String)
-          url = URI.escape("#{URL}/#{api_method}")
+          url = "#{URL}/#{api_method}"
         elsif options[:base]
           url = "#{URL}/#{API}/#{options[:base]}/#{api_method}"
         else

data/lib/contact-data/version.rb

@@ -1,4 +1,4 @@
 # Gem version
 module ContactData
-  VERSION = '0.0.20'
+  VERSION = '0.1.0'
 end

data/lib/contact-data.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
-require 'uri'
+require 'addressable/uri'
 require 'json'
 require 'logger'
 require 'contact-data/contact'

data/spec/contact-data_deprecated_spec.rb

@@ -11,6 +11,7 @@ describe ContactData::Deprecated do
       VCR.use_cassette('deprecated_contact_search') do
         result = ContactData::Deprecated.search(name)
         expect(result).to be_a(Hash)
+        expect(result[:count]).to eq(10)
       end
     end
 
@@ -29,6 +30,7 @@ describe ContactData::Deprecated do
       VCR.use_cassette('deprecated_contact_name_search') do
         result = ContactData::Deprecated.find_contacts_in(text)
         expect(result).to be_a(Hash)
+        expect(result[:contacts]).to eq(['lorem-ipsum', 'john-smith'])
       end
     end
   end
@@ -40,6 +42,7 @@ describe ContactData::Deprecated do
       VCR.use_cassette('deprecated_link_metadata') do
         result = ContactData::Deprecated.link_metadata(url)
         expect(result).to be_a(Hash)
+        expect(result[:title]).to eq('IANA — Number Resources')
       end
     end
   end

data/spec/support/cassettes/deprecated_contact_search.yml

@@ -78,7 +78,7 @@ http_interactions:
   recorded_at: Thu, 12 Jun 2014 10:53:38 GMT
 - request:
     method: get
-    uri: http://public.xenapto.com/name/XXXXX+%253F.json
+    uri: http://public.xenapto.com/name/XXXXXXXXXX%20%3F.json
     body:
       encoding: US-ASCII
       string: ''
@@ -95,7 +95,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Wed, 13 Aug 2014 16:33:29 GMT
+      - Thu, 14 Aug 2014 11:01:50 GMT
       Status:
       - 200 OK
       Connection:
@@ -107,108 +107,18 @@ http_interactions:
       X-Ua-Compatible:
       - IE=Edge,chrome=1
       Etag:
-      - '"50cd64a593ffbd41a6f90d88fafde183"'
+      - '"dfc3ae65d751e2a767eeafc22ea049a1"'
       Cache-Control:
       - max-age=0, private, must-revalidate
       X-Request-Id:
-      - 296e310ed791fbad627564e461951566
+      - 715767cc28016598d996a86e9dc15446
       X-Runtime:
-      - '0.032884'
+      - '0.025084'
       X-Rack-Cache:
       - miss
     body:
       encoding: UTF-8
-      string: '{"contacts":[],"name":"Not found","slug":"xxxxx-plus","count":0,"version":"v1"}'
+      string: '{"contacts":[],"name":"Not found","slug":"xxxxxxxxxx","count":0,"version":"v1"}'
     http_version: 
-  recorded_at: Wed, 13 Aug 2014 16:33:29 GMT
-- request:
-    method: get
-    uri: http://public.xenapto.com/name/XXXXXXXXXX+%253F.json
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*; q=0.5, application/xml"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Wed, 13 Aug 2014 16:35:55 GMT
-      Status:
-      - 200 OK
-      Connection:
-      - close
-      Content-Type:
-      - application/json; charset=utf-8
-      Content-Length:
-      - '84'
-      X-Ua-Compatible:
-      - IE=Edge,chrome=1
-      Etag:
-      - '"253398129d504e94f0911f40498f71b1"'
-      Cache-Control:
-      - max-age=0, private, must-revalidate
-      X-Request-Id:
-      - 7df57910c30b2c48aba43d05f6288798
-      X-Runtime:
-      - '0.044715'
-      X-Rack-Cache:
-      - miss
-    body:
-      encoding: UTF-8
-      string: '{"contacts":[],"name":"Not found","slug":"xxxxxxxxxx-plus","count":0,"version":"v1"}'
-    http_version: 
-  recorded_at: Wed, 13 Aug 2014 16:35:55 GMT
-- request:
-    method: get
-    uri: http://public.xenapto.com/name/Derek+Jones+III.json
-    body:
-      encoding: US-ASCII
-      string: ''
-    headers:
-      Accept:
-      - "*/*; q=0.5, application/xml"
-      Accept-Encoding:
-      - gzip, deflate
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Wed, 13 Aug 2014 16:35:55 GMT
-      Status:
-      - 200 OK
-      Connection:
-      - close
-      Content-Type:
-      - application/json; charset=utf-8
-      Content-Length:
-      - '94'
-      X-Ua-Compatible:
-      - IE=Edge,chrome=1
-      Etag:
-      - '"5e7d9fa614dc656a150e4fdca993850e"'
-      Cache-Control:
-      - max-age=0, private, must-revalidate
-      X-Request-Id:
-      - 4569407b925ec6da38345e3e4eac86cb
-      X-Runtime:
-      - '0.058324'
-      X-Rack-Cache:
-      - miss
-    body:
-      encoding: UTF-8
-      string: '{"contacts":[],"name":"Not found","slug":"derek-plus-jones-plus-iii","count":0,"version":"v1"}'
-    http_version: 
-  recorded_at: Wed, 13 Aug 2014 16:35:55 GMT
+  recorded_at: Thu, 14 Aug 2014 11:01:50 GMT
 recorded_with: VCR 2.9.2

data/spec/support/cassettes/deprecated_link_metadata.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://public.xenapto.com/link/http%253A%252F%252Fwww.iana.org%252Fnumbers
+    uri: http://public.xenapto.com/link/http:%2F%2Fwww.iana.org%2Fnumbers
     body:
       encoding: US-ASCII
       string: ''
@@ -19,7 +19,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Thu, 12 Jun 2014 10:59:29 GMT
+      - Thu, 14 Aug 2014 11:01:50 GMT
       Status:
       - 200 OK
       Connection:
@@ -27,23 +27,23 @@ http_interactions:
       Content-Type:
       - application/json; charset=utf-8
       Content-Length:
-      - '304'
+      - '324'
       X-Ua-Compatible:
       - IE=Edge,chrome=1
       Etag:
-      - '"1f393c600ab5ec1775f8dd15075384a5"'
+      - '"7dfe4d9eed07ad2ec06fffb55895e93b"'
       Cache-Control:
       - max-age=0, private, must-revalidate
       X-Request-Id:
-      - a40aa477aa382d214fa9e0b0ccc5c459
+      - ae3abdfd5f8349271ed68511dea34866
       X-Runtime:
-      - '0.111311'
+      - '0.493192'
       X-Rack-Cache:
       - miss
     body:
       encoding: UTF-8
-      string: '{"id":1703498,"source":"API","source_contact_id":0,"url":"http%3a%2f%2fwww.iana.org/numbers","domain":"iana.org","title":null,"news_source":"Internet
-        Assigned Numbers Authority","summary":null,"created_at":"2014-06-08T10:24:59Z","updated_at":"2014-06-08T10:24:59Z","publication_date":null,"version":"v1"}'
+      string: '{"id":2642376,"source":"API","source_contact_id":0,"url":"http://www.iana.org/numbers","domain":"iana.org","title":"IANA
+        \u2014 Number Resources","news_source":"Internet Assigned Numbers Authority","summary":null,"created_at":"2014-08-14T11:01:50Z","updated_at":"2014-08-14T11:01:50Z","publication_date":null,"version":"v1"}'
     http_version: 
-  recorded_at: Thu, 12 Jun 2014 10:59:29 GMT
+  recorded_at: Thu, 14 Aug 2014 11:01:50 GMT
 recorded_with: VCR 2.9.2

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: contact-data
 version: !ruby/object:Gem::Version
-  version: 0.0.20
+  version: 0.1.0
 platform: ruby
 authors:
 - Xenapto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-13 00:00:00.000000000 Z
+date: 2014-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1'
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement