contact-data 0.0.19 → 0.0.20

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0edff2a8629c7679596d39ae5c8518d80c89a469
-  data.tar.gz: e07f9c2a4d08b3f4b6062e0727e9bbecb4df1a3c
+  metadata.gz: db881d9279bf05f8e29a5061727511ea7d16b562
+  data.tar.gz: f01b935abf8f2168eaa3d49a7faf9e4e510b2015
 SHA512:
-  metadata.gz: ece38d134c71a6b161b61fc773177d75335e40d573d504c168c4930474d471ef3a097eed3f618c12be6a397ee3ce13b17a817d50207c5d37a22c8dd70bc50676
-  data.tar.gz: 2e476a06e15f632d37f273c405efcefb2c6366d71433286c347b6fcd995622849eff062307411887b840b1f7f6bdcecab9d895c1f191205eb7dd7e7fcb7cb20b
+  metadata.gz: 8cca2ca481dd431965bf8fbd2f404fbd8147dbbeb8d5f453b809abe9ec31c8edf76536d086be780191818e6fcf2462c3ba4d8483a38ef13f3a13da71efb471c6
+  data.tar.gz: 6a92b1b36a1e09bf2a28bc277a80a60209da113366795563e2b6430263e0aeec1272e6808134008c988dcbbeb07281ffb2af13dd8d7529092becd04972e04704

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    contact-data (0.0.18)
+    contact-data (0.0.19)
       rest-client (~> 1)
 
 GEM

data/lib/contact-data/deprecated.rb

@@ -3,7 +3,7 @@ module ContactData
   class Deprecated
     class << self
       def search(name)
-        Fetcher.get("name/#{name}")
+        Fetcher.get("name/#{CGI.escape(name)}")
       end
 
       def find_contacts_in(text)

data/lib/contact-data/version.rb

@@ -1,4 +1,4 @@
 # Gem version
 module ContactData
-  VERSION = '0.0.19'
+  VERSION = '0.0.20'
 end

data/spec/contact-data_deprecated_spec.rb

@@ -4,6 +4,7 @@ require 'contact-data'
 
 describe ContactData::Deprecated do
   let(:name) { 'Derek Jones III' }
+  let(:name_xml_bug) { 'XXXXXXXXXX ?' }
 
   context 'contact' do
     it 'searches by name' do
@@ -12,6 +13,13 @@ describe ContactData::Deprecated do
         expect(result).to be_a(Hash)
       end
     end
+
+    it 'searches successfully with name that gave XML bug' do
+      VCR.use_cassette('deprecated_contact_search') do
+        result = ContactData::Deprecated.search(name_xml_bug)
+        expect(result).to be_a(Hash)
+      end
+    end
   end
 
   context 'contact name' do

data/spec/support/cassettes/deprecated_contact_search.yml

@@ -76,4 +76,139 @@ http_interactions:
         Jones","slug":"derek-jones","count":10,"version":"v1"}'
     http_version: 
   recorded_at: Thu, 12 Jun 2014 10:53:38 GMT
+- request:
+    method: get
+    uri: http://public.xenapto.com/name/XXXXX+%253F.json
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*; q=0.5, application/xml"
+      Accept-Encoding:
+      - gzip, deflate
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Wed, 13 Aug 2014 16:33:29 GMT
+      Status:
+      - 200 OK
+      Connection:
+      - close
+      Content-Type:
+      - application/json; charset=utf-8
+      Content-Length:
+      - '79'
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Etag:
+      - '"50cd64a593ffbd41a6f90d88fafde183"'
+      Cache-Control:
+      - max-age=0, private, must-revalidate
+      X-Request-Id:
+      - 296e310ed791fbad627564e461951566
+      X-Runtime:
+      - '0.032884'
+      X-Rack-Cache:
+      - miss
+    body:
+      encoding: UTF-8
+      string: '{"contacts":[],"name":"Not found","slug":"xxxxx-plus","count":0,"version":"v1"}'
+    http_version: 
+  recorded_at: Wed, 13 Aug 2014 16:33:29 GMT
+- request:
+    method: get
+    uri: http://public.xenapto.com/name/XXXXXXXXXX+%253F.json
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*; q=0.5, application/xml"
+      Accept-Encoding:
+      - gzip, deflate
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Wed, 13 Aug 2014 16:35:55 GMT
+      Status:
+      - 200 OK
+      Connection:
+      - close
+      Content-Type:
+      - application/json; charset=utf-8
+      Content-Length:
+      - '84'
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Etag:
+      - '"253398129d504e94f0911f40498f71b1"'
+      Cache-Control:
+      - max-age=0, private, must-revalidate
+      X-Request-Id:
+      - 7df57910c30b2c48aba43d05f6288798
+      X-Runtime:
+      - '0.044715'
+      X-Rack-Cache:
+      - miss
+    body:
+      encoding: UTF-8
+      string: '{"contacts":[],"name":"Not found","slug":"xxxxxxxxxx-plus","count":0,"version":"v1"}'
+    http_version: 
+  recorded_at: Wed, 13 Aug 2014 16:35:55 GMT
+- request:
+    method: get
+    uri: http://public.xenapto.com/name/Derek+Jones+III.json
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*; q=0.5, application/xml"
+      Accept-Encoding:
+      - gzip, deflate
+      User-Agent:
+      - Ruby
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      Date:
+      - Wed, 13 Aug 2014 16:35:55 GMT
+      Status:
+      - 200 OK
+      Connection:
+      - close
+      Content-Type:
+      - application/json; charset=utf-8
+      Content-Length:
+      - '94'
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Etag:
+      - '"5e7d9fa614dc656a150e4fdca993850e"'
+      Cache-Control:
+      - max-age=0, private, must-revalidate
+      X-Request-Id:
+      - 4569407b925ec6da38345e3e4eac86cb
+      X-Runtime:
+      - '0.058324'
+      X-Rack-Cache:
+      - miss
+    body:
+      encoding: UTF-8
+      string: '{"contacts":[],"name":"Not found","slug":"derek-plus-jones-plus-iii","count":0,"version":"v1"}'
+    http_version: 
+  recorded_at: Wed, 13 Aug 2014 16:35:55 GMT
 recorded_with: VCR 2.9.2

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: contact-data
 version: !ruby/object:Gem::Version
-  version: 0.0.19
+  version: 0.0.20
 platform: ruby
 authors:
 - Xenapto
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-12 00:00:00.000000000 Z
+date: 2014-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rest-client