constructable 0.3.3 → 0.3.4

data/README.markdown

@@ -168,6 +168,7 @@ macro and still get all the validations and stuff by calling super:
 class Song
   constructable :length, accessible: true, validate_type: Integer
 
+
   def length=(length)
     if length.is_a?(String) && length =~ /(\d{,2}):(\d{,2})/
       @length = $1.to_i * 60 + $2.to_i
@@ -177,7 +178,7 @@ class Song
   end
 end
 
-song = Song.new(length: '3:10')
+song = Song.new(length: 190)
 #=> #<Song:0x000001010ea040 @length=190>
 
 song.length = '1:30'
@@ -186,27 +187,6 @@ song.length
 
 song.length = 'abc'
 # raises AttributeError, ':length must be of type Integer'
-```
-
-You can also redefine private setters/getters the constructable
-class macro set up for you:
-
-```ruby
-class Song
-  constructable :name, validate_type: String
-  attribute_reader :name_history
-
-  def initialize(opts = {})
-    @name_history = []
-  end
-
- private
-
-  def name=(name)
-    @name_histoy += name
-    super
-  end
-end
 
 song = Song.new(name: 'Aaron', length: '6:01')
 #=> #<Song:0x0x00000100941528 @length=190 @name="Aaron" @name_history=["Aaron"]>

data/VERSION

@@ -1 +1 @@
-0.3.3
+0.3.4

data/constructable.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{constructable}
-  s.version = "0.3.3"
+  s.version = "0.3.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Manuel Korfmann"]
-  s.date = %q{2011-06-18}
+  s.date = %q{2011-06-19}
   s.description = %q{Makes constructing objects through an attributes hash easier}
   s.email = %q{manu@korfmann.info}
   s.extra_rdoc_files = [

data/lib/constructable/attribute.rb

@@ -34,6 +34,10 @@ module Constructable
       ('@' + self.name.to_s).to_sym
     end
 
+    def attr_writer_symbol
+      (self.name.to_s + '=').to_sym
+    end
+
     def check_for_requirement(requirement, value)
       if self.send requirement[:name]
         unless self.instance_exec(value,&requirement[:check])

data/lib/constructable/constructor.rb

@@ -47,13 +47,11 @@ module Constructable
       attributes = @attributes
       attributes.each do |attribute|
         @module.module_eval do
-          attr_reader attribute.name
+          attr_reader attribute.name if attribute.readable
 
-          define_method(:"#{attribute.name}=") do |value|
+          define_method(attribute.attr_writer_symbol) do |value|
             instance_variable_set attribute.ivar_symbol, attribute.process(value)
-          end
-          private attribute.name unless attribute.readable
-          private :"#{attribute.name}=" unless attribute.writable
+          end if attribute.writable
         end
       end
     end
@@ -61,7 +59,7 @@ module Constructable
     def construct(constructor_hash, obj)
       constructor_hash ||= {}
       @attributes.each do |attribute|
-        obj.send :"#{attribute.name}=", constructor_hash[attribute.name]
+        obj.instance_variable_set attribute.ivar_symbol, attribute.process(constructor_hash[attribute.name])
       end
     end
 

data/test/constructable/test_attribute.rb

@@ -18,7 +18,7 @@ describe 'Attribute' do
 
   describe 'process' do
     it 'intepretes nil but not false as undefined' do
-      attribute = Attribute.new(:foo, default: true)
+      attribute = Attribute.new(:foo, default: ->{true})
       assert_equal false, attribute.process(false)
     end
 

data/test/constructable/test_constructor.rb

@@ -22,14 +22,6 @@ describe 'Constructor' do
     end
 
     describe 'redefining' do
-      describe 'constructing a class will call redefined setters' do
-        it 'calls the redefined setters' do
-          @klass.constructable :bacon, readable: true
-          @klass.class_eval { private; def bacon=(value);super(:zomg_bacon);end }
-          instance = @klass.new(bacon: :no_bacon)
-          assert_equal :zomg_bacon, instance.bacon
-        end
-      end
 
       describe 'class' do
         it 'getters ' do
@@ -96,13 +88,6 @@ describe 'Constructor' do
             instance.integer = :not_an_integer
           end
         end
-
-        it 'sets for private setters/getters' do
-          @klass.constructable :integer, validate_type: Integer, readable: true
-          @klass.class_eval { private; def integer=(value); super(value.to_i) ;end }
-          instance = @klass.new(integer: '5')
-          assert_equal 5, instance.integer
-        end
       end
     end
   end

metadata

@@ -2,7 +2,7 @@
 name: constructable
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors: 
 - Manuel Korfmann
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-06-18 00:00:00 +02:00
+date: 2011-06-19 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -100,7 +100,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 335237132407385369
+      hash: -4277054694638453062
       segments: 
       - 0
       version: "0"