const_lookup 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3eecd6ef6683b4b6cb3aaa860153047ba969b853
-  data.tar.gz: 87609285e5549e1e375a8f958118037cdae90a6a
+  metadata.gz: 6272f106053cfae63ddee05a1ee5e21636d40852
+  data.tar.gz: b8393dacdefb03921a50aa5b613d483414ad2abb
 SHA512:
-  metadata.gz: 55f4cc3995ca5af7e0b31c3d5df4124ab0b13f877111b5ea3ca6bcde58c099df17241d5c8369ad4ecd5ac4db9dd43500891aaf53a99230a20c72db4cca914b82
-  data.tar.gz: 787cac62e65e37edf237f3fbaf408a9f3e103ab1f0af3f5aba6e69d7da779c8ae57d5af576dcbc829c1a57319b5ce783e60f2d491147bfd19fa188413612234b
+  metadata.gz: f5fbc355c841826f7fe708fdc6a806c59fd49fdc637f78360ba3297cd335a64f66756a9205efaf77c287a3e415e2330ffd618acc3b14ae59ea95e41c067d68fa
+  data.tar.gz: e01ed3588c93c7ff9a3c67bd01fbc51eb1244cc5b39ec78aa5330fe5640aedda3edc45e74b8057ba76fef505b6614f88564d89651ebd70ad094efa632ac70c53

data/README.md

@@ -2,7 +2,7 @@
 
 [![Build Status](https://secure.travis-ci.org/amarshall/const_lookup.png?branch=master)](http://travis-ci.org/amarshall/const_lookup)
 [![Code Climate rating](https://codeclimate.com/github/amarshall/const_lookup.png)](https://codeclimate.com/github/amarshall/const_lookup)
-[![Gem Version](https://badge.fury.io/rb/const_lookup.png)](https://badge.fury.io/rb/const_lookup)
+[![Gem Version](https://badge.fury.io/rb/const_lookup.png)](https://rubygems.org/gems/const_lookup)
 
 Makes resolving a constant in a given namespace easy.
 
@@ -29,7 +29,7 @@ ConstLookup.lookup('E', A::C)  #=> #<NameError: Failed to find `E' in A::C>
 
 Or, if you like monkey-patching Ruby core:
 
-```
+```ruby
 module A
   module B; end
   module C; end
@@ -42,6 +42,23 @@ A::C.const_lookup('B')  #=> A::B
 A::C.const_lookup('D')  #=> D
 ```
 
+Compare this with using [`Module#const_get`](http://ruby-doc.org/core/Module.html#method-i-const_get):
+
+```ruby
+module A
+  module B; end
+  module C; end
+end
+module D; end
+
+A::C.const_get('A')  #=> A
+A::C.const_get('B')  #=> #<NameError: uninitialized constant A::C::B>
+A::C.const_get('D')  #=> D
+A::C.const_get('E')  #=> #<NameError: uninitialized constant A::C::E>
+```
+
+This is because `const_get` looks up the *ancestor tree*, not the namespace tree like `ConstLookup` does.
+
 ## Contributing
 
 Contributions are welcome. Please be sure that your pull requests are atomic so they can be considered and accepted separately.

data/lib/const_lookup.rb

@@ -1,11 +1,12 @@
 require 'const_lookup/version'
 
 class ConstLookup
-  def self.lookup name, namespace = nil
-    new(*namespace).lookup(name)
+  def self.lookup name, namespace = Object
+    new(namespace).lookup(name)
   end
 
-  def initialize namespace = Object
+  def initialize namespace
+    raise ArgumentError unless namespace.is_a? Module
     @namespace = namespace.to_s
   end
 

data/lib/const_lookup/version.rb

@@ -1,3 +1,3 @@
 class ConstLookup
-  VERSION = '0.4.0'
+  VERSION = '0.5.0'
 end

data/spec/const_lookup_spec.rb

@@ -12,16 +12,30 @@ describe ConstLookup do
       ConstLookup.lookup name, namespace
     end
 
-    it "creates the new finder with no args when no namespace given" do
+    it "creates the new finder with Object when no namespace given" do
       name = double
       finder = double
-      expect(ConstLookup).to receive(:new).with(no_args).and_return finder
+      expect(ConstLookup).to receive(:new).with(Object).and_return finder
       expect(finder).to receive(:lookup).with(name)
 
       ConstLookup.lookup name
     end
   end
 
+  describe "#initialize" do
+    it "accepts a Module as a namespace" do
+      expect { ConstLookup.new(Module.new) }.to_not raise_error
+    end
+
+    it "accepts a Class as a namespace" do
+      expect { ConstLookup.new(Class.new) }.to_not raise_error
+    end
+
+    it "raises an ArgumentError when the namespace is not a Class/Module" do
+      expect { ConstLookup.new(Object.new) }.to raise_error ArgumentError
+    end
+  end
+
   describe "#lookup" do
     it "returns the constant when it resides in the most specific namespace" do
       stub_const('Foo::Bar::Baz', Module.new)
@@ -71,11 +85,6 @@ describe ConstLookup do
   end
 
   describe "#lookup_path" do
-    it "is just Object when no namespace is given" do
-      constant_finder = ConstLookup.new
-      expect(constant_finder.lookup_path).to eq [Object]
-    end
-
     it "is a list of each constant in the namespace in ascending order" do
       stub_const('Foo::Bar::Baz', Module.new)
       constant_finder = ConstLookup.new(Foo::Bar::Baz)

data/spec/readme_spec.rb

@@ -43,4 +43,26 @@ describe "README examples" do
       expect(A::C.const_lookup('D')).to eq D
     end
   end
+
+  describe "example 3" do
+    before do
+      module A
+        module B; end
+        module C; end
+      end
+      module D; end
+    end
+
+    after do
+      Object.send :remove_const, :A
+      Object.send :remove_const, :D
+    end
+
+    it "works" do
+      expect(A::C.const_get('A')).to eq A
+      expect{A::C.const_get('B')}.to raise_error NameError, %q(uninitialized constant A::C::B)
+      expect(A::C.const_get('D')).to eq D
+      expect{A::C.const_get('E')}.to raise_error NameError, %q(uninitialized constant A::C::E)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: const_lookup
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Andrew Marshall
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-09 00:00:00.000000000 Z
+date: 2013-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler