consistency_fail 0.3.1 → 0.3.2

data/.rspec

@@ -0,0 +1 @@
+--color

data/consistency_fail.gemspec

@@ -19,6 +19,7 @@ constraint. You'll need a database-level constraint for cases like these.
 consistency_fail will find your missing unique indexes, so you can add them and
 stop ignoring the C in ACID.
 EOF
+  s.license = "MIT"
 
   s.add_development_dependency "activerecord", "~>3.0"
   s.add_development_dependency "rspec"

data/lib/consistency_fail/introspectors/has_one.rb

@@ -12,9 +12,14 @@ module ConsistencyFail
       # TODO: handle has_one :through cases (multicolumn index on the join table?)
       def desired_indexes(model)
         instances(model).map do |a|
+          if a.respond_to?(:foreign_key)
+            foreign_key = a.foreign_key
+          else
+            foreign_key = a.primary_key_name
+          end
           ConsistencyFail::Index.new(a.class_name.constantize,
                                      a.table_name.to_s,
-                                     [a.foreign_key])
+                                     [foreign_key])
         end.compact
       end
       private :desired_indexes

data/lib/consistency_fail/models.rb

@@ -12,7 +12,7 @@ module ConsistencyFail
     end
 
     def dirs
-      load_path.select { |lp| MODEL_DIRECTORY_REGEXP =~ lp }
+      load_path.select { |lp| MODEL_DIRECTORY_REGEXP =~ lp.to_s }
     end
 
     def preload_all

data/lib/consistency_fail/version.rb

@@ -1,3 +1,3 @@
 module ConsistencyFail
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/spec/introspectors/has_one_spec.rb

@@ -60,6 +60,14 @@ describe ConsistencyFail::Introspectors::HasOne do
       indexes.should == [ConsistencyFail::Index.new(fake_ar_model("Address"), "addresses", ["user_id"])]
     end
 
+    it "finds one in Rails 3.0.x (where foreign_key is not defined)" do
+      @association.stub!(:table_name => :addresses, :class_name => @address_string, :primary_key_name => "user_id")
+      @address_class.stub_chain(:connection, :indexes).with("addresses").and_return([])
+
+      indexes = subject.missing_indexes(@model)
+      indexes.should == [ConsistencyFail::Index.new(fake_ar_model("Address"), "addresses", ["user_id"])]
+    end
+
     it "finds none when they're already in place" do
       @association.stub!(:table_name => :addresses, :class_name => @address_string, :foreign_key => "user_id")
       index = ConsistencyFail::Index.new(double('model'), "addresses", ["user_id"])

data/spec/models_spec.rb

@@ -15,6 +15,12 @@ describe ConsistencyFail::Models do
     models.dirs.should == ["app/models", "some/other/models"]
   end
 
+  it "accepts and matches path names as well as strings" do
+    models = models([Pathname.new("app/models")])
+    lambda { models.dirs }.should_not raise_error(TypeError)
+    models.dirs.should == [Pathname.new("app/models")]
+  end
+
   it "preloads models by calling require_dependency" do
     models = models(["foo/bar/baz", "app/models", "some/other/models"])
     Dir.stub(:glob).

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: consistency_fail
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-18 00:00:00.000000000 Z
+date: 2013-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -66,6 +66,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rspec
 - Gemfile
 - LICENSE
 - README.md
@@ -95,7 +96,8 @@ files:
 - spec/reporter_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/trptcolin/consistency_fail
-licenses: []
+licenses:
+- MIT
 post_install_message: 
 rdoc_options: []
 require_paths: