consistency_fail 0.3.0 → 0.3.1

data/bin/consistency_fail

@@ -14,7 +14,7 @@ $:<< File.join(File.dirname(__FILE__), "..", "lib")
 require "consistency_fail"
 
 def problems(models, introspector)
-  problems = models.map do |m|
+  models.map do |m|
     [m, introspector.missing_indexes(m)]
   end.reject do |m, indexes|
     indexes.empty?
@@ -38,6 +38,11 @@ problems = problems(models.all, introspector)
 reporter.report_has_one_problems(problems)
 success &&= problems.empty?
 
+introspector = ConsistencyFail::Introspectors::Polymorphic.new
+problems = problems(models.all, introspector)
+reporter.report_polymorphic_problems(problems)
+success &&= problems.empty?
+
 if success
   exit 0
 else

data/lib/consistency_fail.rb

@@ -2,4 +2,5 @@ require 'consistency_fail/models'
 require 'consistency_fail/introspectors/table_data'
 require 'consistency_fail/introspectors/validates_uniqueness_of'
 require 'consistency_fail/introspectors/has_one'
+require 'consistency_fail/introspectors/polymorphic'
 require 'consistency_fail/reporter'

data/lib/consistency_fail/introspectors/has_one.rb

@@ -5,7 +5,7 @@ module ConsistencyFail
     class HasOne
       def instances(model)
         model.reflect_on_all_associations.select do |a|
-          a.macro == :has_one
+          a.macro == :has_one && a.options[:as].to_s.length == 0
         end
       end
 

data/lib/consistency_fail/introspectors/polymorphic.rb

@@ -0,0 +1,43 @@
+require 'consistency_fail/index'
+
+module ConsistencyFail
+  module Introspectors
+    class Polymorphic
+      def instances(model)
+        model.reflect_on_all_associations.select do |a|
+          a.macro == :has_one && a.options[:as].to_s.length > 0
+        end
+      end
+
+      def desired_indexes(model)
+        instances(model).map do |a|
+          as      = a.options[:as]
+          as_type = "#{as}_type"
+          as_id   = "#{as}_id"
+
+          ConsistencyFail::Index.new(
+            a.class_name.constantize,
+            a.table_name.to_s,
+            [as_type, as_id]
+          )
+        end.compact
+      end
+      private :desired_indexes
+
+      def missing_indexes(model)
+        desired = desired_indexes(model)
+
+        existing_indexes = desired.inject([]) do |acc, d|
+          acc += TableData.new.unique_indexes_by_table(d.model,
+                                                       d.model.connection,
+                                                       d.table_name)
+        end
+
+        desired.reject do |index|
+          existing_indexes.include?(index)
+        end
+      end
+
+    end
+  end
+end

data/lib/consistency_fail/reporter.rb

@@ -1,5 +1,6 @@
 require 'consistency_fail/reporters/validates_uniqueness_of'
 require 'consistency_fail/reporters/has_one'
+require 'consistency_fail/reporters/polymorphic'
 
 module ConsistencyFail
   class Reporter
@@ -10,5 +11,9 @@ module ConsistencyFail
     def report_has_one_problems(indexes_by_model)
       ConsistencyFail::Reporters::HasOne.new.report(indexes_by_model)
     end
+
+    def report_polymorphic_problems(indexes_by_model)
+      ConsistencyFail::Reporters::Polymorphic.new.report(indexes_by_model)
+    end
   end
 end

data/lib/consistency_fail/reporters/polymorphic.rb

@@ -0,0 +1,13 @@
+require 'consistency_fail/reporters/base'
+
+module ConsistencyFail
+  module Reporters
+    class Polymorphic < Base
+      attr_reader :macro
+
+      def initialize
+        @macro = :has_one_with_polymorphic
+      end
+    end
+  end
+end

data/lib/consistency_fail/version.rb

@@ -1,3 +1,3 @@
 module ConsistencyFail
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/spec/introspectors/has_one_spec.rb

@@ -17,7 +17,7 @@ describe ConsistencyFail::Introspectors::HasOne do
 
     it "finds one" do
       model = fake_ar_model("User")
-      association = double("association", :macro => :has_one)
+      association = double("association", :macro => :has_one, :options => {})
       model.stub!(:reflect_on_all_associations).and_return([association])
 
       subject.instances(model).should == [association]
@@ -30,11 +30,19 @@ describe ConsistencyFail::Introspectors::HasOne do
 
       subject.instances(model).should == []
     end
+
+    it "finds one, but it's a polymorphic association" do
+      model = fake_ar_model("User")
+      association = double("association", :macro => :has_one, :options => {:as => "addressable"})
+      model.stub!(:reflect_on_all_associations).and_return([association])
+
+      subject.instances(model).should == []
+    end
   end
 
   describe "finding missing indexes" do
     before do
-      @association = double("association", :macro => :has_one)
+      @association = double("association", :macro => :has_one, :options => {})
       @model = fake_ar_model("User", :table_exists? => true,
                                      :table_name => "users",
                                      :class_name => "User",

data/spec/introspectors/polymorphic_spec.rb

@@ -0,0 +1,77 @@
+require 'spec_helper'
+require 'consistency_fail/introspectors/table_data'
+require 'consistency_fail/introspectors/polymorphic'
+
+describe ConsistencyFail::Introspectors::Polymorphic do
+  def introspector(model)
+    ConsistencyFail::Introspectors::Polymorphic.new(model)
+  end
+
+  describe "instances of polymorphic" do
+    it "finds none" do
+      model = fake_ar_model("User")
+      model.stub(:reflect_on_all_associations).and_return([])
+
+      subject.instances(model).should == []
+    end
+
+    it "finds one" do
+      model = fake_ar_model("User")
+      association = double("association", :macro => :has_one, :options => {:as => "addressable"})
+      model.stub!(:reflect_on_all_associations).and_return([association])
+
+      subject.instances(model).should == [association]
+    end
+
+    it "finds other has_one associations, but not polymorphic" do
+      model = fake_ar_model("User")
+      validation = double("association", :macro => :has_one, :options => {})
+      model.stub!(:reflect_on_all_associations).and_return([validation])
+
+      subject.instances(model).should == []
+    end
+
+    it "finds other non has_one associations" do
+      model = fake_ar_model("User")
+      validation = double("association", :macro => :has_many)
+      model.stub!(:reflect_on_all_associations).and_return([validation])
+
+      subject.instances(model).should == []
+    end
+  end
+
+  describe "finding missing indexes" do
+    before do
+      @association = double("association", :macro => :has_one, :options => {:as => "addressable"})
+      @model = fake_ar_model("User", :table_exists? => true,
+                                     :table_name => "users",
+                                     :class_name => "User",
+                                     :reflect_on_all_associations => [@association])
+      @address_class = double("Address Class")
+      @address_string = "Address"
+      @address_string.stub(:constantize).and_return(@address_class)
+    end
+
+    it "finds one" do
+      @association.stub!(:table_name => :addresses, :class_name => @address_string)
+      @address_class.stub_chain(:connection, :indexes).with("addresses").and_return([])
+
+      indexes = subject.missing_indexes(@model)
+      indexes.should == [ConsistencyFail::Index.new(fake_ar_model("Address"), "addresses", ["addressable_type", "addressable_id"])]
+    end
+
+    it "finds none when they're already in place" do
+      @association.stub!(:table_name => :addresses, :class_name => @address_string)
+      index = ConsistencyFail::Index.new(double('model'), "addresses", ["addressable_type", "addressable_id"])
+
+      fake_connection = double("connection")
+      @address_class.stub_chain(:connection).and_return(fake_connection)
+
+      ConsistencyFail::Introspectors::TableData.stub_chain(:new, :unique_indexes_by_table).
+        with(@address_class, fake_connection, "addresses").
+        and_return([index])
+
+      subject.missing_indexes(@model).should == []
+    end
+  end
+end

data/spec/reporter_spec.rb

@@ -71,4 +71,20 @@ describe ConsistencyFail::Reporter do
       @fake_out.string.should =~ /Friend\s+users\s+\(email\)/m
     end
   end
+
+  context "polymorphic" do
+    it "says everything's good" do
+      subject.report_polymorphic_problems([])
+
+      @fake_out.string.should =~ /Hooray!/
+    end
+
+    it "shows a missing compound index on a single model" do
+      missing_indexes = [ConsistencyFail::Index.new(double('model'), "addresses", ["addressable_type", "addressable_id"])]
+
+      subject.report_polymorphic_problems(fake_ar_model("Address", :table_name => "addresses") => missing_indexes)
+
+      @fake_out.string.should =~ /Address\s+addresses\s+\(addressable_type, addressable_id\)/m
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: consistency_fail
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-18 00:00:00.000000000 Z
+date: 2013-07-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -76,16 +76,19 @@ files:
 - lib/consistency_fail/enforcer.rb
 - lib/consistency_fail/index.rb
 - lib/consistency_fail/introspectors/has_one.rb
+- lib/consistency_fail/introspectors/polymorphic.rb
 - lib/consistency_fail/introspectors/table_data.rb
 - lib/consistency_fail/introspectors/validates_uniqueness_of.rb
 - lib/consistency_fail/models.rb
 - lib/consistency_fail/reporter.rb
 - lib/consistency_fail/reporters/base.rb
 - lib/consistency_fail/reporters/has_one.rb
+- lib/consistency_fail/reporters/polymorphic.rb
 - lib/consistency_fail/reporters/validates_uniqueness_of.rb
 - lib/consistency_fail/version.rb
 - spec/index_spec.rb
 - spec/introspectors/has_one_spec.rb
+- spec/introspectors/polymorphic_spec.rb
 - spec/introspectors/table_data_spec.rb
 - spec/introspectors/validates_uniqueness_of_spec.rb
 - spec/models_spec.rb
@@ -118,6 +121,7 @@ summary: A tool to detect missing unique indexes
 test_files:
 - spec/index_spec.rb
 - spec/introspectors/has_one_spec.rb
+- spec/introspectors/polymorphic_spec.rb
 - spec/introspectors/table_data_spec.rb
 - spec/introspectors/validates_uniqueness_of_spec.rb
 - spec/models_spec.rb