connection_pool 0.9.3 → 1.0.0

data/Changes.md

@@ -1,3 +1,11 @@
+1.0.0
+-----
+
+- `#with_connection` is now gone in favor of `#with`.
+
+- We no longer pollute the top level namespace with our internal
+`TimedStack` class.
+
 0.9.3
 --------
 

data/lib/connection_pool.rb

@@ -1,5 +1,4 @@
 require_relative 'connection_pool/version'
-require_relative 'timed_queue'
 
 # Generic connection pool class for e.g. sharing a limited number of network connections
 # among many threads.  Note: Connections are eager created.
@@ -39,7 +38,7 @@ class ConnectionPool
     @size = options.fetch(:size)
     @timeout = options.fetch(:timeout)
 
-    @available = ::TimedQueue.new(@size, &block)
+    @available = TimedStack.new(@size, &block)
     @key = :"current-#{@available.object_id}"
   end
 
@@ -52,16 +51,11 @@ class ConnectionPool
     end
   end
 
-  def with_connection(&block)
-    warn("ConnectionPool#with_connection is deprecated and will be removed in version 1.0. Upgrade your code to use ConnectionPool#with instead. (in #{caller[0]})")
-    with(&block)
-  end
-
   def checkout
     stack = ::Thread.current[@key] ||= []
 
     if stack.empty?
-      conn = @available.timed_pop(@timeout)
+      conn = @available.pop(@timeout)
     else
       conn = stack.last
     end
@@ -92,11 +86,6 @@ class ConnectionPool
       @pool.checkin
     end
 
-    def with_connection(&block)
-      warn("ConnectionPool::Wrapper#with_connection is deprecated and will be removed in version 1.0. Upgrade your code to use ConnectionPool::Wrapper#with instead. (in #{caller[0]})")
-      with(&block)
-    end
-
     def respond_to?(id, *args)
       METHODS.include?(id) || @pool.with { |c| c.respond_to?(id, *args) }
     end
@@ -108,3 +97,5 @@ class ConnectionPool
     end
   end
 end
+
+require_relative 'connection_pool/timed_stack'

data/lib/{timed_queue.rb → connection_pool/timed_stack.rb}

@@ -1,7 +1,7 @@
 require 'thread'
 require 'timeout'
 
-class TimedQueue
+class ConnectionPool::TimedStack
   def initialize(size = 0)
     @que = Array.new(size) { yield }
     @mutex = Mutex.new
@@ -16,7 +16,7 @@ class TimedQueue
   end
   alias_method :<<, :push
 
-  def timed_pop(timeout=0.5)
+  def pop(timeout=0.5)
     deadline = Time.now + timeout
     @mutex.synchronize do
       loop do

data/lib/connection_pool/version.rb

@@ -1,3 +1,3 @@
 class ConnectionPool
-  VERSION = "0.9.3"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: connection_pool
 version: !ruby/object:Gem::Version
-  version: 0.9.3
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors:
@@ -26,8 +26,8 @@ files:
 - Rakefile
 - connection_pool.gemspec
 - lib/connection_pool.rb
+- lib/connection_pool/timed_stack.rb
 - lib/connection_pool/version.rb
-- lib/timed_queue.rb
 - test/helper.rb
 - test/test_connection_pool.rb
 homepage: https://github.com/mperham/connection_pool