configure-s3-website 1.1.1 → 1.1.2

data/.gitignore

@@ -1,2 +1,3 @@
 tmp
 pkg
+Gemfile.lock

data/README.md

@@ -79,6 +79,10 @@ API with the following JSON:
 }
 ```
 
+## Development
+
+* This project uses [Semantic Versioning](http://semver.org)
+
 ## License
 
 See the file LICENSE.

data/changelog.md

@@ -1,5 +1,11 @@
 # Changelog
 
+This project uses [Semantic Versioning](http://semver.org).
+
+## 1.1.2
+
+* Use UTC time when signing requests
+
 ## 1.1.1
 
 * Do not send the location constraint XML when using the standard region

data/lib/configure-s3-website/s3_client.rb

@@ -67,7 +67,7 @@ module ConfigureS3Website
           <CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
             <LocationConstraint>#{endpoint.location_constraint}</LocationConstraint>
           </CreateBucketConfiguration >
-        |
+         |
              end
 
       call_s3_api(
@@ -85,7 +85,7 @@ module ConfigureS3Website
 
     def self.call_s3_api(path, method, body, config_source)
       endpoint = Endpoint.new(config_source.s3_endpoint || '')
-      date = Time.now.strftime("%a, %d %b %Y %H:%M:%S %Z")
+      date = Time.now.utc.strftime("%a, %d %b %Y %H:%M:%S %Z")
       digest = create_digest(path, method, config_source, date)
       url = "https://#{endpoint.hostname}#{path}"
       uri = URI.parse(url)

data/lib/configure-s3-website/version.rb

@@ -1,3 +1,3 @@
 module ConfigureS3Website
-  VERSION = '1.1.1'
+  VERSION = '1.1.2'
 end

data/spec/s3_client_spec.rb

@@ -2,17 +2,51 @@ require 'rspec'
 require 'configure-s3-website'
 
 describe ConfigureS3Website::S3Client do
-  context '#create_bucket' do
+  context '#create_bucket with invalid s3_endpoint value' do
     let(:config_source) {
       mock = double('config_source')
       mock.stub(:s3_endpoint).and_return('invalid-location-constraint')
       mock
     }
-    it 'throws an error if the config contains an invalid S3 location constraint' do
+
+    it 'throws an error' do
       expect {
         extractor = ConfigureS3Website::S3Client.
           send(:create_bucket, config_source)
       }.to raise_error(InvalidS3LocationConstraintError)
     end
   end
+
+  context '#create_bucket with no s3_endpoint value' do
+    let(:config_source) {
+      ConfigureS3Website::FileConfigSource.new('spec/sample_files/_config_file.yml')
+    }
+
+    it 'calls the S3 api without request body' do
+      ConfigureS3Website::S3Client.should_receive(:call_s3_api).
+        with(anything(), anything(), '', anything())
+      ConfigureS3Website::S3Client.send(:create_bucket,
+                                        config_source)
+    end
+  end
+
+  context '#create_bucket with s3_endpoint value' do
+    let(:config_source) {
+      ConfigureS3Website::FileConfigSource.new(
+        'spec/sample_files/_config_file_oregon.yml'
+      )
+    }
+
+    it 'calls the S3 api with location constraint XML' do
+      ConfigureS3Website::S3Client.should_receive(:call_s3_api).
+        with(anything(), anything(),
+        %|
+          <CreateBucketConfiguration xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
+            <LocationConstraint>us-west-2</LocationConstraint>
+          </CreateBucketConfiguration >
+         |, anything())
+      ConfigureS3Website::S3Client.send(:create_bucket,
+                                        config_source)
+    end
+  end
 end

data/spec/sample_files/_config_file.yml

@@ -0,0 +1,3 @@
+s3_id: <%= 'hello world' %>
+s3_secret: <%= 'secret world' %>
+s3_bucket: my-bucket

data/spec/sample_files/_config_file_oregon.yml

@@ -0,0 +1,4 @@
+s3_id: <%= 'hello world' %>
+s3_secret: <%= 'secret world' %>
+s3_bucket: my-bucket
+s3_endpoint: us-west-2

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: configure-s3-website
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-12 00:00:00.000000000 Z
+date: 2013-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -157,6 +157,8 @@ files:
 - lib/configure-s3-website/version.rb
 - spec/config_extractor/file_config_extractor_spec.rb
 - spec/s3_client_spec.rb
+- spec/sample_files/_config_file.yml
+- spec/sample_files/_config_file_oregon.yml
 - spec/sample_files/_config_file_with_eruby.yml
 homepage: https://github.com/laurilehmijoki/configure-s3-website
 licenses: []
@@ -170,15 +172,21 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 925918613448529982
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 925918613448529982
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Configure your AWS S3 bucket to function as a web site
@@ -196,4 +204,6 @@ test_files:
 - features/support/vcr.rb
 - spec/config_extractor/file_config_extractor_spec.rb
 - spec/s3_client_spec.rb
+- spec/sample_files/_config_file.yml
+- spec/sample_files/_config_file_oregon.yml
 - spec/sample_files/_config_file_with_eruby.yml