configuration_service 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc898eb1373d71883928bb492b533ffadc0e895c
-  data.tar.gz: ec3e54e1a4768122bd1f0e14f77cfc8e6da36bed
+  metadata.gz: 4610fe57d04ebf9b414e4a1e714a4951bae72241
+  data.tar.gz: 071270662e7f96be1485bc94faa2a406ea9925b1
 SHA512:
-  metadata.gz: 978bd8e5c8bd45ff27550378d5052bdadca16c72d4787fd88c5e5aca4a691b2906074b145e7123597cf5278a1e09932c5f33915857435b7c847ea6a2f6c51f4d
-  data.tar.gz: 4cbd165b89b7f76886333c3ec414391cf8db0254e00e50e6ac67cdb77367d28324a5963b9eae22b5a49eff198c836e0fbafec10a1747df0808662c20e3e8531f
+  metadata.gz: 4e29d9cd857a188765e9253ac9f604b5f044adecaaeefacfd7c1edff7e96a0cb5199017359a4a121d8664e01926dd055b79836ec354b7418863941d33331f4de
+  data.tar.gz: bb14fb1e0df9b75616c25fce06d2ff67d5822e8f1da3b658ac975f7680653ff4d08dabc9bf51eced82671c101e668c34e8fa8b7d4b761c1634bee7b8f4d50f92

data/configuration_service.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = "configuration_service"
-  spec.version       = "1.1.1"
+  spec.version       = "1.1.2"
   spec.authors       = ["Sheldon Hearn"]
   spec.email         = ["sheldonh@starjuice.net"]
 

data/lib/configuration_service/errors.rb

@@ -15,4 +15,10 @@ module ConfigurationService
   class AuthorizationError < Error
   end
 
+  ##
+  # A configuration service provider registry lookup error
+  #
+  class ProviderNotFoundError < Error
+  end
+
 end

data/lib/configuration_service/factory/environment_context.rb

@@ -12,9 +12,25 @@ module ConfigurationService
     #   # CFGSRV_PROVIDER="vault"
     #   # CFGSRV_PROVIDER_ADDRESS="http://127.0.0.1:8200"
     #
+    #   # And the following in Gemfile:
+    #   #
+    #   # source 'https://rubygems.org'
+    #   #
+    #   # gem 'configuration_service-vault'
+    #   # gem 'acme_application'
+    #
+    #   # Now main.rb (or config.ru or whatever) is decoupled from provider
+    #   # selection and service configuration:
+    #
+    #   require 'bundler'
+    #   Bundler.require(:default) # Registers the vault provider
+    #
     #   service = ConfigurationService::Factory::EnvironmentContext.create
-    #   configuraton = service.request_configuration
-    #   AcmeApplication.new(configuration.data).run
+    #   if configuraton = service.request_configuration
+    #     AcmeApplication.new(configuration.data).run
+    #   else
+    #     raise "configuration not found"
+    #   end
     #
     class EnvironmentContext
 
@@ -75,7 +91,7 @@ module ConfigurationService
       #
       def create
         ConfigurationService.new(@env[:identifier], @env[:token], provider).tap do
-          @env.scrub! # TODO mandates that scrub not try to mutate the strings given to provider
+          @env.scrub!
         end
       end
 
@@ -96,7 +112,8 @@ module ConfigurationService
           provider_id = @env[:provider]
           provider_config = @env.subslice(:provider)
           provider_class = ConfigurationService::ProviderRegistry.instance.lookup(provider_id)
-          provider_class.new(provider_config) # TODO mandates keyword arguments or options hash
+          provider_class or raise ProviderNotFoundError, "provider not registered: #{provider_id}"
+          provider_class.new(provider_config)
         end
 
     end

data/lib/configuration_service/factory/environment_context/env_dict.rb

@@ -4,7 +4,7 @@ module ConfigurationService
 
     class EnvironmentContext
 
-      class EnvDict < Hash # :nodoc: all
+      class EnvDict < Hash # :nodoc:
 
         def initialize(env, *path)
           @env = env

data/lib/configuration_service/test/orchestrator.rb

@@ -162,6 +162,7 @@ module ConfigurationService
       # True if the last consuming operation did not return data
       #
       # TODO: distinguish #request_not_matched? to mean "found data, but filtered out by metadata filter"
+      #
       def request_not_matched?
         not @response.found?
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: configuration_service
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Sheldon Hearn