config-factory 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b31bc2f2074a9f1e66efe1d58e5e224b254e4820
-  data.tar.gz: 5afe13b48946fdcbf269d10d7a57399e354b6afe
+  metadata.gz: 85d51fce96572d3dba52936c624787dfc7318cbc
+  data.tar.gz: ee7cdc6973f8918992858021eabde2d92d272f2d
 SHA512:
-  metadata.gz: 33047cf037e5d3d3443b31839dd3ea79831bee2cf57782fd863b820c721069c47bfb01e8d026e040ab366e5df14ea2a8d652fa857b0e931b1abf31bc6fff9627
-  data.tar.gz: a41e560799880666b8de8859b481bdab1c9d520a1d24320504b42d89c178151b0c01b4ff504c89c7ed533979e1a02443566a6110c7a92c5a6f18bc97843ea921
+  metadata.gz: 74c6acb13ffe5a9892e6430b91452ca3819b149cd8d3bacb62159d2fd60ad1ea872c1043918b753279433a4e444c8d08a27c082111d2bd2963af7d4f2e8306d2
+  data.tar.gz: e7d2d643473f1de988680e736f8bbfae5e78df564259d6550d17e9409de7d5c75237e2d6d44aeae2b02858885ad6bfdd9abc71be99e631ce327c32a19e6ca3f2

data/CHANGES.md

@@ -1,3 +1,7 @@
+## 0.0.6 (16 March 2016)
+
+- Better error messages for missing keys, configs, etc.
+
 ## 0.0.5 (2 March 2016)
 
 - Add `AbstractFactory#from_file`

data/lib/config/factory/abstract_factory.rb

@@ -17,6 +17,7 @@ module Config
 
       def for_environment(env, config_name)
         arg_hash = env.args_for(config_name)
+        fail ArgumentError, "no #{self} arguments found for config #{config_name} in environment #{env}" unless arg_hash
         build_from(arg_hash)
       end
 
@@ -26,7 +27,9 @@ module Config
       end
 
       def build_from(arg_hash)
+        fail ArgumentError, "nil argument hash passed to #{self}.build_from" unless arg_hash
         args = deep_symbolize_keys(arg_hash)
+        fail ArgumentError, "product key #{product_key} not found in argument hash #{args}" unless args.key?(product_key)
         key_value = args.delete(product_key)
         product_class = products[key_value]
         fail ArgumentError, "No #{name} product class found for #{product_key}: #{key_value}" unless product_class

data/lib/config/factory/environment.rb

@@ -24,6 +24,10 @@ module Config
         Environment.new(name: Environments::DEFAULT_ENVIRONMENT, configs: hash)
       end
 
+      def to_s
+        "#{self.class}: name = #{@name}, configs = #{@configs})"
+      end
+
       private
 
       def name=(v)

data/lib/config/factory/module_info.rb

@@ -4,7 +4,7 @@ module Config
     NAME = 'config-factory'
 
     # The version of this gem
-    VERSION = '0.0.5'
+    VERSION = '0.0.6'
 
     # The copyright notice for this gem
     COPYRIGHT = 'Copyright (c) 2016 The Regents of the University of California'

data/spec/unit/config/factory/environment_spec.rb

@@ -48,6 +48,44 @@ module Config
           end
         end
       end
+
+      describe '#to_s' do
+        it 'includes the name' do
+          env = Environment.load_file('spec/data/single-environment.yml')
+          expect(env.to_s).to include(Environments::DEFAULT_ENVIRONMENT.to_s)
+        end
+
+        it 'includes the hash' do
+          h = {
+            'db' =>
+            {
+              'adapter' => 'mysql2',
+              'encoding' => 'utf8',
+              'pool' => 5,
+              'database' => 'example_pord',
+              'host' => 'mysql-dev.example.org',
+              'port' => 3306
+            },
+            'source' => {
+              'protocol' => 'OAI',
+              'oai_base_url' => 'http://oai.example.org/oai',
+              'metadata_prefix' => 'some_prefix',
+              'set' => 'some_set',
+              'seconds_granularity' => true
+            },
+            'index' => {
+              'adapter' => 'solr',
+              'url' => 'http://solr.example.org/',
+              'proxy' => 'http://foo:bar@proxy.example.com/',
+              'open_timeout' => 120,
+              'read_timeout' => 300
+            }
+          }
+          env = Environment.load_hash(h)
+          expect(env.to_s).to include(h.to_s)
+        end
+      end
+
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: config-factory
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - David Moles
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-02 00:00:00.000000000 Z
+date: 2016-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler